| *** mhen_ is now known as mhen | 02:12 | |
| *** tosky_ is now known as tosky | 08:53 | |
| hberaud[m] | damani: tkajinam : Please can you recheck https://review.opendev.org/c/openstack/futurist/+/939361 and https://review.opendev.org/c/openstack/oslo.utils/+/939233 when you have 2 min. Thanks in advance | 10:05 |
|---|---|---|
| opendevreview | Stephen Finucane proposed openstack/pbr master: Add openstack-tox-py313 job https://review.opendev.org/c/openstack/pbr/+/940117 | 10:30 |
| damani[m] | hberaud, done | 12:39 |
| hberaud[m] | thx | 12:39 |
| *** tosky is now known as Guest6863 | 13:19 | |
| *** tosky_ is now known as tosky | 13:19 | |
| damani[m] | can we get some new code review here please https://review.opendev.org/c/openstack/oslo.service/+/935783 | 15:38 |
| opendevreview | Jeremy Stanley proposed openstack/pbr master: Add openstack-tox-py313 job https://review.opendev.org/c/openstack/pbr/+/940117 | 17:07 |
| opendevreview | Ghanshyam proposed openstack/whereto master: DNM: Testing ubuntu noble https://review.opendev.org/c/openstack/whereto/+/935408 | 18:37 |
| gmann | fungi: clarkb: any plan to release pbr soon? for the py312 setuptool things needed by the doc noble jobs | 19:00 |
| clarkb | gmann: so again I want to stress that you don't need a pbr update to solve that problem | 19:03 |
| clarkb | but yes we're releasing bindep today so that we can update bindep to use the latest pbr pyproject.toml support next, thne we'll update that to use a beta release of pbr and ifthat works we can release pbr for real | 19:03 |
| gmann | ack | 19:04 |
| clarkb | the updates to pbr make this stuff easier but they aer not required | 19:04 |
| clarkb | fungi: where did we end up with the beta release of pbr. That can happen concurrently right? | 19:05 |
| clarkb | I don't think we need to wait for the docs updates for that (would be good to have docs in place before the actual release but not a strong requirement for the beta release) | 19:05 |
| gmann | yeah, that will help to do things in easy way. I am trying to finish noble migration with min we can. | 19:05 |
| fungi | gmann: i've had a pbr pre-release request pending for weeks, waiting on the oslo ptl to +1: | 19:08 |
| fungi | https://review.opendev.org/938505 | 19:08 |
| fungi | we just wanted to make sure we tested it out as a pyproject build backend before tagging a full release | 19:09 |
| fungi | i should probably just get more persistent about pinging people on stuff like that | 19:10 |
| gmann | fungi: ah thanks. Daniel is on PTO maybe but let's see if we can get +1 damani[m] ^^ or I will ping Takashi on monday | 19:11 |
| fungi | but as clarkb says that's not going to change the missing setuptools on python 3.12, just makes it possible for projects to declare they need setuptools for building if they use a pyproject.toml file | 19:12 |
| fungi | er, and even that was already possible anyway, this just makes pbr do the same for itself too | 19:12 |
| fungi | in order to provide a demonstration that it works | 19:12 |
| clarkb | fungi: I think it will pull in setuptools on python3.12 due to the requirements.txt addition | 19:12 |
| clarkb | whcih will noop on python 3.11 and older and might work for 3.12 and newer | 19:13 |
| fungi | oh, right i guess that will work around the issue | 19:13 |
| gmann | true but use of pyproject.toml can take time and having setuptools from pbr requirement file will help but agree to have project start using pyproject.toml | 19:13 |
| fungi | the experimental bindep change series ending at https://review.opendev.org/938570 also demonstrates doing it | 19:15 |
| fungi | (i could have squashed them all, but this was good for untangling the different aspects and making it clearer to review the first time around) | 19:16 |
| fungi | clarkb: with pbr declaring setuptools as a requirement, what do you think about dropping setuptools from the build-system.requires list since pbr will pull it in now? | 19:18 |
| clarkb | fungi: you need it in both places I think? | 21:59 |
| clarkb | fungi: one determines what goes into isolated build environments to build pbr and the other specifies what packages to install alongside pbr for runtime needs? | 22:00 |
| clarkb | or maybe you only need it in both places for pbr itself but requirements is sufficient for everyone else? | 22:00 |
| fungi | clarkb: sorry, i meant in examples for projects using pbr, but in theory it would likely work that way for pbr itself too | 22:21 |
| clarkb | fungi: it isn't clear to me of `build` and similar tools will bundle setuptools for python<3.12 | 22:23 |
| clarkb | so I think having it in the example is good belts and suspenders | 22:23 |
| fungi | it will install pbr, which declares that it depends on setuptools, so will install setuptools | 22:24 |
| clarkb | right but only for python3.12 or newer | 22:24 |
| fungi | but now that you mention it, we made the dependency on setuptools limited to newer python only | 22:24 |
| fungi | sorry, tiny blackberry-type keyboard at the moment | 22:25 |
| clarkb | we could drop that rule from requierments.txt but I did it that way to avoid unexpected interactiosn with older python. By limiting it to 3.12 and newer we're makign the problem space smaller and in a place where people are most likely to be willing to debug the problems because it is forward looking | 22:25 |
| clarkb | but if we don't think that is a major risk we could drop the rule and do it globally | 22:25 |
| clarkb | it should still noop I think? | 22:25 |
| clarkb | er I mean on python <3.12 it would see setuptools is already prsent and move along | 22:26 |
| fungi | yeah, it didn't seem necessary to me to limit it, if pbr gets installed somewhere that lacks setuptools it won't work anyway | 22:26 |
| clarkb | ya I think the main concern was that we'd accidentally try to install something that would make things worse than if we just used what was already there | 22:28 |
| clarkb | I'd be happy to drop the limitation from requirements.txt and then use a beta release to do our best to try and catch any cases like that | 22:29 |
| fungi | well, we can do a second beta too | 22:37 |
| clarkb | good point | 22:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!