| *** ralonsoh_ is now known as ralonsoh | 07:40 | |
| artem_vasilyev | Hey folks, can you take a look at the oslo.metrics fix, please https://review.opendev.org/c/openstack/oslo.metrics/+/940526 | 08:42 |
|---|---|---|
| opendevreview | Merged openstack/oslo.versionedobjects master: Replace distutils https://review.opendev.org/c/openstack/oslo.versionedobjects/+/936068 | 10:53 |
| opendevreview | Merged openstack/oslo.log master: Fix outdated envlist https://review.opendev.org/c/openstack/oslo.log/+/939016 | 10:58 |
| opendevreview | Merged openstack/oslo.metrics master: Restore group permissions to unix socket file https://review.opendev.org/c/openstack/oslo.metrics/+/940526 | 11:39 |
| opendevreview | Merged openstack/oslo.cache master: Detect service ports from pifpaf environments https://review.opendev.org/c/openstack/oslo.cache/+/938993 | 11:50 |
| opendevreview | Merged openstack/oslo.upgradecheck master: pre-commit: Bump versions https://review.opendev.org/c/openstack/oslo.upgradecheck/+/939012 | 14:11 |
| opendevreview | Merged openstack/oslotest master: pre-commit: Bump versions https://review.opendev.org/c/openstack/oslotest/+/939009 | 14:12 |
| hberaud[m] | Hey folks there is a couple of remaining deprecation patches yet not merged, please can you review them, thanks in advance. https://review.opendev.org/q/prefixtopic:%22eventlet-removal%22+deprecate+status:open+author:hberaud@redhat.com | 14:42 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.rootwrap master: Adjust warning message for eventlet support deprecation https://review.opendev.org/c/openstack/oslo.rootwrap/+/940881 | 14:59 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.rootwrap master: Adjust warning message for eventlet support deprecation https://review.opendev.org/c/openstack/oslo.rootwrap/+/940881 | 15:02 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Adjust warning message for eventlet support deprecation https://review.opendev.org/c/openstack/oslo.cache/+/940882 | 15:02 |
| tkajinam | ^^^ giving it another thought I wonder if we put too much information in logs now ... I wonder how these update look to you, hberaud[m] | 15:04 |
| hberaud[m] | I prefered the initial version of https://review.opendev.org/c/openstack/oslo.rootwrap/+/940881 but I've no problem with the second one | 15:05 |
| hberaud[m] | you are right, the removal of eventlet is now a mainstream things, and people will be able to check the release notes | 15:06 |
| tkajinam | I'm afraid that operators are flooded by multiple "please migrate your code" warning which they can't do anything | 15:06 |
| tkajinam | about | 15:07 |
| tkajinam | I'll made similar changes to your changes and will +2 | 15:07 |
| opendevreview | Takashi Kajinami proposed openstack/tooz master: deprecate the eventlet handler from the zookeeper driver https://review.opendev.org/c/openstack/tooz/+/940374 | 15:07 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.concurrency master: deprecate eventlet monkey patch within lockutils https://review.opendev.org/c/openstack/oslo.concurrency/+/940430 | 15:08 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.privsep master: deprecate eventlet monkey patching within oslo.privsep.daemon https://review.opendev.org/c/openstack/oslo.privsep/+/940370 | 15:08 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.log master: deprecate eventlet monkey patch within oslo.log https://review.opendev.org/c/openstack/oslo.log/+/940432 | 15:10 |
| hberaud[m] | tkajinam: Thanks | 15:12 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: Adjust warning message for eventlet support deprecation https://review.opendev.org/c/openstack/oslo.utils/+/940883 | 15:12 |
| tkajinam | I'm pretty sure with the shortened version we get "too much" logs | 15:13 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Deprecate utility for eventlet https://review.opendev.org/c/openstack/taskflow/+/940884 | 15:20 |
| tkajinam | we probably have to check if there are anything left... | 15:20 |
| tkajinam | hberaud[m], dansmith do you mind reviewing this series ? https://review.opendev.org/c/openstack/taskflow/+/938998 | 15:22 |
| hberaud[m] | sure | 15:22 |
| dansmith | tkajinam: did you mean damani[m] ? | 15:23 |
| opendevreview | Merged openstack/oslo.db master: pre-commit: Bump versions https://review.opendev.org/c/openstack/oslo.db/+/939007 | 15:23 |
| tkajinam | dansmith, yes. sorry !! | 15:24 |
| tkajinam | autocomplate-- | 15:24 |
| dansmith | np :D | 15:24 |
| tkajinam | hberaud[m], if you can review ones in its relation chain that would be nice, because these resolves some unmaintained items kept these for some time... | 15:25 |
| hberaud[m] | I'm on it | 15:26 |
| tkajinam | thx ! | 15:26 |
| opendevreview | Merged openstack/oslo.db master: Run pyupgrade to clean up Python 2 syntaxes https://review.opendev.org/c/openstack/oslo.db/+/939008 | 15:33 |
| -opendevstatus- NOTICE: nominations for the OpenStack PTL and TC positions are now open, for details see https://governance.openstack.org/election/ | 16:08 | |
| opendevreview | Merged openstack/oslo.concurrency master: Remove support for running unit tests in Windows https://review.opendev.org/c/openstack/oslo.concurrency/+/939573 | 17:12 |
| opendevreview | Merged openstack/oslo.serialization master: Ignore iteritems() and use items() solely https://review.opendev.org/c/openstack/oslo.serialization/+/936315 | 17:29 |
| opendevreview | Merged openstack/tooz master: deprecate the eventlet handler from the zookeeper driver https://review.opendev.org/c/openstack/tooz/+/940374 | 18:16 |
| opendevreview | Merged openstack/oslo.cache master: Adjust warning message for eventlet support deprecation https://review.opendev.org/c/openstack/oslo.cache/+/940882 | 18:16 |
| opendevreview | Merged openstack/oslo.utils master: Adjust warning message for eventlet support deprecation https://review.opendev.org/c/openstack/oslo.utils/+/940883 | 18:18 |
| opendevreview | Merged openstack/oslo.concurrency master: deprecate eventlet monkey patch within lockutils https://review.opendev.org/c/openstack/oslo.concurrency/+/940430 | 18:19 |
| opendevreview | Merged openstack/oslo.log master: deprecate eventlet monkey patch within oslo.log https://review.opendev.org/c/openstack/oslo.log/+/940432 | 18:22 |
| opendevreview | Merged openstack/oslo.privsep master: deprecate eventlet monkey patching within oslo.privsep.daemon https://review.opendev.org/c/openstack/oslo.privsep/+/940370 | 18:32 |
| opendevreview | Merged openstack/oslo.rootwrap master: Adjust warning message for eventlet support deprecation https://review.opendev.org/c/openstack/oslo.rootwrap/+/940881 | 18:32 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily while we upgrade for a new jeepyb feature and switch our database container image source repository | 18:52 | |
| opendevreview | Merged openstack/oslo.privsep master: Remove guard for non-windows operating systems https://review.opendev.org/c/openstack/oslo.privsep/+/939575 | 19:22 |
| damani[m] | dansmith, what is your issue with f-string? | 19:40 |
| dansmith | damani[m]: are you asking why I don't like them, or what well-reasoned technical objections I have? | 19:40 |
| * JayF likes f-string, but just wants to build a shed without having to repaint it in an undocumented shade of chartreuse ;) | 19:40 | |
| damani[m] | dansmith, yes why you don't like it | 19:41 |
| damani[m] | f-strings are the recommended approach in modern python and that works well | 19:41 |
| damani[m] | better readability, performance, and maintainability | 19:41 |
| dansmith | modern python also recommends that we break our code and syntax every year to chase the new thing they find cool | 19:42 |
| dansmith | I find them to be much less readable, especially when people embed expressions in them.. if they only ever use {varname} it's not so bad | 19:42 |
| dansmith | but I think they end up being much longer than %-formatted strings, which means more likely to need line breaks, which makes them less readable to me | 19:43 |
| JayF | I know the rule of thumb we use in Ironic, which I wish was used here, is for things like this where we prefer a specific way of doing things, we try to add it to a linter instead of reviewing for it. | 19:43 |
| dansmith | in general I agree, as long as my preferences get encoded by the linter, | 19:44 |
| JayF | lol | 19:44 |
| dansmith | but I also think there's some judgment here, like {varname} is okay but {wholechunkofpythonwithnosyntaxhighlightingthatloopsandstuff} is not | 19:44 |
| JayF | it does give a nice place to express those preferences in review :D | 19:44 |
| dansmith | but like I said, if oslo is requiring f-strings, I want a pointer to where that's written down, which could be linter config or policy docs, but asking to revise the patch for something like that based on some nebulous suggestion is just meh | 19:46 |
| JayF | the trick is, that's the second comment not associated with a -1 giving a preference | 19:47 |
| JayF | but given the limited core group on oslo, that puts it in a non-mergable state implicitly | 19:47 |
| JayF | I'm extremely close to just abandoning the patch and taking this into consideration next time I try to add a small cli operator helper | 19:48 |
| damani[m] | merged | 19:48 |
| JayF | I really appreciate it \o/ | 19:49 |
| opendevreview | Merged openstack/oslo.utils master: Add image checker to imageutils https://review.opendev.org/c/openstack/oslo.utils/+/930379 | 20:56 |
| opendevreview | Merged openstack/oslo.messaging master: Added Docs for Simulator https://review.opendev.org/c/openstack/oslo.messaging/+/940495 | 21:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!