| *** mhen_ is now known as mhen | 01:43 | |
| stephenfin | hberaud[m]: There are some relatively easy typing changes for oslo.i18n there ^ if you have the time/inclination today | 09:28 |
|---|---|---|
| opendevreview | Merged openstack/oslo.db master: Add MariaDB error 1020 handling as DBConsistencyError subclass of DBDeadlock https://review.opendev.org/c/openstack/oslo.db/+/955189 | 15:07 |
| stephenfin | dansmith: I'm playing around with the image inspection stuff again. Is there any expection that SafetyCheck would ever be subclassed itself, rather than defined with a target function? | 16:35 |
| stephenfin | I ask because the docstring for __call__ says that said thing should return a boolean https://github.com/openstack/oslo.utils/blob/1a85259acb7dd/oslo_utils/imageutils/format_inspector.py#L142-L155 | 16:35 |
| stephenfin | while users of same check for non-null return values https://github.com/openstack/oslo.utils/blob/1a85259acb7dd/oslo_utils/imageutils/format_inspector.py#L421-L423 | 16:36 |
| stephenfin | both seem redundant when our error path is an exception, right? | 16:36 |
| dansmith | stephenfin: I think that's leftover from review.. I had it initially returning a boolean and then we moved to an exception IIRC | 16:36 |
| stephenfin | ack | 16:43 |
| opendevreview | Clark Boylan proposed openstack/pbr master: Update setup.cfg usage docs to explain pbr vs setuptools better https://review.opendev.org/c/openstack/pbr/+/956388 | 16:58 |
| opendevreview | Clark Boylan proposed openstack/pbr master: Remove duplicate line in test_generates_c_extensions https://review.opendev.org/c/openstack/pbr/+/956389 | 16:58 |
| opendevreview | Merged openstack/pbr master: Move distutils commands to _compat https://review.opendev.org/c/openstack/pbr/+/954048 | 17:18 |
| opendevreview | Merged openstack/pbr master: Move functional tests to their own directory https://review.opendev.org/c/openstack/pbr/+/954049 | 22:32 |
| -opendevstatus- NOTICE: All OpenDev IRC and Matrix bots will be offline briefly (including channel logging and meeting management) in order to move them to a newer server | 23:50 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!