| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Extract shared logic between eventlet and threading backends https://review.opendev.org/c/openstack/oslo.service/+/956843 | 00:14 |
|---|---|---|
| opendevreview | Merged openstack/oslo.service master: Merge common files in one service file. https://review.opendev.org/c/openstack/oslo.service/+/955062 | 00:22 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Extract shared logic between eventlet and threading backends https://review.opendev.org/c/openstack/oslo.service/+/956843 | 01:31 |
| damani[m] | tkajinam, can you please take a look https://review.opendev.org/c/openstack/oslo.service/+/956739 | 01:34 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Extract shared logic between eventlet and threading backends https://review.opendev.org/c/openstack/oslo.service/+/956843 | 01:36 |
| *** mhen_ is now known as mhen | 01:37 | |
| *** mtreinish_ is now known as mtreinish | 11:00 | |
| opendevreview | Dmitriy Rabotyagov proposed openstack/osprofiler master: Cleanup jaeger backend from devstack and examples https://review.opendev.org/c/openstack/osprofiler/+/956878 | 11:44 |
| *** mtreinish_ is now known as mtreinish | 12:02 | |
| cardoe | tkajinam: So https://review.opendev.org/c/openstack/oslo.privsep/+/939575 breaks my local testing.... any chance I can tweak that behavior a little bit? | 15:12 |
| cardoe | Basically a few things like cinder just import the capabilities.py just by running their test suite. So if I'm not on a Linux box I can no longer run their unit tests or basic things locally. | 15:13 |
| cardoe | Keeping the change in that one file is enough to let me run tests. Cause nothing actually executes those functions. | 15:14 |
| tkajinam | maybe we can revert the changes partially, to restore logic not specific to windows | 15:15 |
| tkajinam | I'm not big fun of keeping compatibility code for real logic for something not really used in production but I know that some people prefer keeping these compatible with non linux such as mac os to save their life. | 15:16 |
| tkajinam | a big fan of * | 15:16 |
| tkajinam | cardoe, If you can propose a change then I'll review it | 15:17 |
| cardoe | It would be to just add that one snippet back. | 15:17 |
| cardoe | It would let folks run unit tests on Windows and macOS for example. | 15:17 |
| cardoe | Its just right now as soon as you "from oslo.privsep import capabilities" in any file on a non-Linux platform it blows up. | 15:18 |
| tkajinam | I doubt allowing users to run these unit tests is useful really and just adds useless burden on us | 15:35 |
| tkajinam | if these is real developers using specific non-linux platforms and we know the compat code actually helps them then I agree we can maintain it. | 15:36 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.privsep master: Restore compatibility with non-linux operating systems https://review.opendev.org/c/openstack/oslo.privsep/+/956932 | 15:45 |
| tkajinam | cardoe, this is what I expected ^^^ | 15:45 |
| tkajinam | (I wrote it because showing the code might be much easier, I'm happy to abandon it if you have your version | 15:46 |
| cardoe | No that works. I hadn't written it yet. I was just wanting to start the convo. | 15:48 |
| cardoe | Not looking to have you guys support functionality in the library. | 15:48 |
| cardoe | The other option was that I start slinging patches at a bunch of projects making the import of capabilities conditional | 15:48 |
| tkajinam | ok | 16:18 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!