| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Add Broadcaster for RPC Fanout https://review.opendev.org/c/openstack/oslo.messaging/+/938536 | 04:31 |
|---|---|---|
| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Replace eventlet with cheroot in HTTP driver https://review.opendev.org/c/openstack/oslo.messaging/+/961583 | 04:31 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Extract shared logic between eventlet and threading backends https://review.opendev.org/c/openstack/oslo.service/+/956843 | 07:16 |
| damani[m] | hi | 07:18 |
| damani[m] | can i get review on that patch please https://review.opendev.org/c/openstack/oslo.service/+/956843 | 07:18 |
| damani[m] | and that one too please https://review.opendev.org/c/openstack/oslo.service/+/956739 | 07:19 |
| damani[m] | and that one also please https://review.opendev.org/c/openstack/oslo.service/+/957302 | 07:20 |
| *** mrunge_ is now known as mrunge | 07:38 | |
| hberaud[m] | damani: o/ concerning https://review.opendev.org/c/openstack/oslo.service/+/956843/14..15 you said that you will fix s/service.ServiceLauncher/service.ProcessLauncher/ into a separated patch https://review.opendev.org/c/openstack/oslo.service/+/956843/comment/7b30c4c8_13f144fd/ but I still see the fix into the original patch. Have you created a separated patch? | 07:41 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Extract shared logic between eventlet and threading backends https://review.opendev.org/c/openstack/oslo.service/+/956843 | 08:22 |
| damani[m] | hberaud, i think you watch an old patchset | 08:24 |
| damani[m] | because i can see the modification | 08:25 |
| damani[m] | it's not anymore on that patch | 08:25 |
| hberaud[m] | I compared PS 14 and 15 and even 14 and 16 and 15 and 16 | 08:25 |
| hberaud[m] | ok then I will recheck | 08:26 |
| damani[m] | 16 have not the mapping modification | 08:26 |
| hberaud[m] | have you submitted the patch with the mapping modification? | 08:27 |
| damani[m] | and i prepare a patch with that modification | 08:27 |
| hberaud[m] | ack | 08:27 |
| hberaud[m] | thanks | 08:27 |
| damani[m] | but i don't think that block the currrent patch :) | 08:27 |
| damani[m] | you're welcome | 08:28 |
| hberaud[m] | normally no | 08:28 |
| hberaud[m] | :) | 08:29 |
| hberaud[m] | damani: and that? => https://review.opendev.org/c/openstack/oslo.service/+/956843/14/oslo_service/backend/_threading/service.py#93 | 08:33 |
| hberaud[m] | this code is still present in the current patch set | 08:34 |
| *** mtreinish_ is now known as mtreinish | 11:49 | |
| *** mtreinish_ is now known as mtreinish | 14:26 | |
| *** johnsom_ is now known as johnsom | 14:26 | |
| *** TheJulia_ is now known as TheJulia | 14:26 | |
| *** mtreinish_ is now known as mtreinish | 14:39 | |
| *** johnsom_ is now known as johnsom | 14:39 | |
| *** mnaser_ is now known as mnaser | 14:39 | |
| *** haleyb_ is now known as haleyb | 14:39 | |
| *** haleyb_ is now known as haleyb | 14:42 | |
| *** haleyb_ is now known as haleyb | 15:05 | |
| *** cardoe_ is now known as cardoe | 15:32 | |
| *** iurygregory_ is now known as iurygregory | 23:41 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!