| *** mhen_ is now known as mhen | 02:58 | |
| *** mrunge_ is now known as mrunge | 06:39 | |
| opendevreview | Takashi Kajinami proposed openstack/etcd3gw master: tox: Fix outdated functional test env https://review.opendev.org/c/openstack/etcd3gw/+/965076 | 09:50 |
|---|---|---|
| opendevreview | Merged openstack/etcd3gw master: tox: Fix outdated functional test env https://review.opendev.org/c/openstack/etcd3gw/+/965076 | 14:23 |
| tkajinam | stephenfin, hi. I see mypy check fails in CI https://review.opendev.org/c/openstack/oslo.cache/+/938639 but these are not reproduced in my local run (using Python 3.12). I wonder if you have any idea about it ? | 14:31 |
| tkajinam | I can check these failures and fix these but I'm wondering if I can fix something so that the same errors can appear in my local run... | 14:31 |
| tkajinam | (this is not urgent but appreciate your thoughts when you have time | 14:32 |
| stephenfin | tkajinam: I've seen that happen when the pre-commit environment is old and hasn't pulled in the newest version of a dependency. Can you try running `pre-commit gc`, and if that fails `pre-commit clean` | 14:35 |
| stephenfin | ...and I see it's now broken on master. Not on you. | 14:36 |
| tkajinam | stephenfin, `pre-commit clean` did the job! :-D | 14:38 |
| tkajinam | and yeah the same failures are seen in master :-( | 14:38 |
| stephenfin | Indeed. This is on me https://github.com/sqlalchemy/dogpile.cache/pull/278/commits/67a5a8d0dfae4a8e393c8996eecd2aff580db699 | 14:39 |
| tkajinam | (I guess these are ones caused by any recent change in godpile.cache but I'm not too sure | 14:39 |
| tkajinam | ok my guess was correct :-) | 14:39 |
| opendevreview | Stephen Finucane proposed openstack/oslo.cache master: Update hints for latest dogpile.cache https://review.opendev.org/c/openstack/oslo.cache/+/965122 | 14:42 |
| stephenfin | tkajinam: ^ | 14:43 |
| tkajinam | stephenfin, thanks ! checking it now | 14:43 |
| tkajinam | will vote my +A once CI passes | 14:45 |
| opendevreview | Stephen Finucane proposed openstack/pbr master: WIP: Add initial pyproject.toml hook https://review.opendev.org/c/openstack/pbr/+/964716 | 15:49 |
| opendevreview | Stephen Finucane proposed openstack/pbr master: WIP: Alternative approach https://review.opendev.org/c/openstack/pbr/+/965146 | 15:49 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Deprecate redundant utility methods https://review.opendev.org/c/openstack/oslo.cache/+/965147 | 15:50 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Deprecate redundant utility methods https://review.opendev.org/c/openstack/oslo.cache/+/965147 | 15:53 |
| opendevreview | Stephen Finucane proposed openstack/pbr master: Remove use of pkg_resources from tests https://review.opendev.org/c/openstack/pbr/+/964803 | 15:55 |
| opendevreview | Stephen Finucane proposed openstack/pbr master: WIP: Add initial pyproject.toml hook https://review.opendev.org/c/openstack/pbr/+/964716 | 15:55 |
| opendevreview | Stephen Finucane proposed openstack/pbr master: WIP: Alternative approach https://review.opendev.org/c/openstack/pbr/+/965146 | 15:55 |
| tkajinam | it's nice to see that requirements check now supports deps in pyproject.toml but I'm unsure how tox.ini should look like if *requirements.txt files are gone | 16:01 |
| tkajinam | especially we may want to install only extra deps | 16:01 |
| tkajinam | for docs, for example | 16:01 |
| stephenfin | what's your concern? | 17:01 |
| stephenfin | tkajinam: I think https://github.com/tox-dev/tox/pull/3556 might be relevant | 17:04 |
| tkajinam | ah, that constraints option is cool | 17:05 |
| tkajinam | stephenfin, I was wondering how we keep constraints with only extras set. The easiest way is to replace -r requirements.txt by something like .[docs] but it makes the actual software being installed too | 17:05 |
| tkajinam | now I see we can use constraints = upper-constraints.txt along with extras = docs | 17:06 |
| stephenfin | yup | 17:06 |
| opendevreview | Takashi Kajinami proposed openstack/stevedore master: Maintain dependencies in pyproject.toml https://review.opendev.org/c/openstack/stevedore/+/965164 | 17:12 |
| * tkajinam is just playing | 17:13 | |
| stephenfin | tkajinam: Way ahead of you :) https://review.opendev.org/c/openstack/openstacksdk/+/953484 | 17:14 |
| tkajinam | tbvh I first look at patches you proposed and found none and decided to create one in an easy project :-P | 17:15 |
| tkajinam | glad to see that we use the sane names for optional dependencies (test, not tests, doc, not docs) | 17:15 |
| opendevreview | Takashi Kajinami proposed openstack/stevedore master: Maintain dependencies in pyproject.toml https://review.opendev.org/c/openstack/stevedore/+/965164 | 17:16 |
| stephenfin | tkajinam: fungi informed me that long term, we want to use dependency groups instead of a test extra, but there are some issues with that currently https://packaging.python.org/en/latest/specifications/dependency-groups/ | 17:16 |
| tkajinam | your comment there reminds me that I was not able to get rid of doc requirements due to the same reason ( I attempted it in puppet repos) | 17:16 |
| * stephenfin doesn't recall the issue currently | 17:17 | |
| tkajinam | ah, ok | 17:17 |
| tkajinam | I don't intend to spread it now but was willing to have a few samples so that we can discuss and probably do some experiment in light libraries | 17:17 |
| stephenfin | yeah, this isn't urgent. Just good to get a handle on it and be prepared in case pbr becomes too difficult to maintain or something | 17:18 |
| opendevreview | Takashi Kajinami proposed openstack/stevedore master: Maintain dependencies in pyproject.toml https://review.opendev.org/c/openstack/stevedore/+/965164 | 17:18 |
| tkajinam | yeah | 17:18 |
| opendevreview | Merged openstack/pbr master: Fix functional test for pip 25.3 https://review.opendev.org/c/openstack/pbr/+/965031 | 17:21 |
| fungi | tkajinam: stephenfin: see https://review.opendev.org/945403 for a working example | 17:23 |
| fungi | bindep's using nox instead of tox, but it's trivial to translate | 17:24 |
| opendevreview | Merged openstack/oslo.cache master: Update hints for latest dogpile.cache https://review.opendev.org/c/openstack/oslo.cache/+/965122 | 17:25 |
| tkajinam | fungi, thanks ! | 17:26 |
| fungi | my review comments as well as the commit message are relevant to decision-making for when this is sensible to implement | 17:27 |
| tkajinam | ah, ok. these todo comments | 17:29 |
| tkajinam | so it indicats that now we should be fine as python 3.8 support is gone (as long as we set the correct lower cap for pip and setuptools) | 17:29 |
| fungi | yeah | 17:31 |
| fungi | doing this for openstack 2026.1 should be fine, but please try it and see what happens, i don't have great data yet because i've been trying to implement it in projects with a much longer deprecation period for user platforms | 17:32 |
| fungi | keep in mind that, e.g. ubuntu 24.04 lts doesn't have a new enough pip so users would need to install newer third-party packages | 17:33 |
| fungi | (which we do in our test jobs) | 17:34 |
| tkajinam | yeah. at least my change is just for experiment and mass switch is not intended atm | 17:35 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Add valkey support https://review.opendev.org/c/openstack/oslo.cache/+/938639 | 17:50 |
| fungi | tkajinam: follow-up data point, i rechecked the bindep example and it's working now except for the py38 unit testing, which is expected since that's too old to support the necessary tools | 20:52 |
| opendevreview | Merged openstack/pbr master: Remove dead code https://review.opendev.org/c/openstack/pbr/+/964712 | 22:11 |
| opendevreview | Merged openstack/pbr master: Remove unused code https://review.opendev.org/c/openstack/pbr/+/964713 | 22:12 |
| opendevreview | Merged openstack/pbr master: Inline LocalInstallScripts._make_wsgi_scripts_only https://review.opendev.org/c/openstack/pbr/+/960028 | 22:12 |
| opendevreview | Merged openstack/pbr master: Remove use of easy_install https://review.opendev.org/c/openstack/pbr/+/960029 | 22:12 |
| opendevreview | Merged openstack/pbr master: Duplicate methods between ScriptWriter, WindowsScriptWriter https://review.opendev.org/c/openstack/pbr/+/964759 | 22:12 |
| opendevreview | Merged openstack/pbr master: Inline overridden script writer https://review.opendev.org/c/openstack/pbr/+/960030 | 22:13 |
| opendevreview | Merged openstack/pbr master: Remove remaining uses of pkg_resources https://review.opendev.org/c/openstack/pbr/+/960031 | 22:13 |
| opendevreview | Merged openstack/pbr master: Rename setup.cfg parsing utilities https://review.opendev.org/c/openstack/pbr/+/964714 | 22:44 |
| opendevreview | Merged openstack/pbr master: Merge pbr.core, pbr.utils into pbr.setupcfg https://review.opendev.org/c/openstack/pbr/+/964715 | 22:44 |
| opendevreview | Merged openstack/pbr master: Remove use of pkg_resources from tests https://review.opendev.org/c/openstack/pbr/+/964803 | 22:44 |
| opendevreview | Merged openstack/oslo.cache master: Drop redundant _key_generate_to_str https://review.opendev.org/c/openstack/oslo.cache/+/963565 | 23:17 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!