| *** mhen_ is now known as mhen | 02:54 | |
| opendevreview | Stephen Finucane proposed openstack/pbr master: Add classifiers for latest Python https://review.opendev.org/c/openstack/pbr/+/965916 | 12:16 |
|---|---|---|
| stephenfin | hberaud: Are you here? | 12:21 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Simplify process group fallback expression https://review.opendev.org/c/openstack/oslo.messaging/+/965938 | 14:59 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Simplify process group fallback expression https://review.opendev.org/c/openstack/oslo.messaging/+/965938 | 15:19 |
| opendevreview | Merged openstack/oslo.messaging stable/2024.2: Fix Queue Manager in podman containerised env https://review.opendev.org/c/openstack/oslo.messaging/+/958849 | 16:23 |
| cardoe | stephenfin: you might be the best person to answer if https://review.opendev.org/c/openstack/oslo.db/+/965879 makes sense | 16:32 |
| stephenfin | cardoe: I was under the impression pbr already created a 'test' or 'testing' extra if a test-requirements.txt file was present | 16:32 |
| cardoe | I'm looking to make that available and change all the downstream users to depend on it with oslo.db[test] | 16:32 |
| cardoe | So this is for nova itself that uses that for its own testing when its using oslo.db | 16:33 |
| cardoe | So maybe I call it something else like oslo.db[test-fixtures] ? | 16:33 |
| stephenfin | Ah, wait, so these are used for fixtures that can be used by other projects? | 16:34 |
| stephenfin | In that case, yes, I think a 'fixtures' extra makes sense | 16:34 |
| cardoe | okay I can rename it. | 16:34 |
| stephenfin | ditto for other projects that provide custom fixtures | 16:34 |
| cardoe | Today it's pulled into the dependency list always | 16:34 |
| cardoe | I'll update the patch and call it oslo.db[fixtures] | 16:35 |
| cardoe | I just wish Python had a way to NOT install something when an extra was NOT supplied. | 16:35 |
| stephenfin | wdym? | 16:36 |
| cardoe | Well like if oslo.db[fixtures] isn't the dependency don't install oslo_db.test_fixtures.blah | 16:37 |
| stephenfin | Ah, yes, gotcha | 16:37 |
| cardoe | Cause technically you always need to install it, just when you import oslo_db.test_fixtures.blah it'll fail cause the dep is missing. | 16:37 |
| cardoe | But I guess that's what stevedore is for | 16:38 |
| stephenfin | though nothing should import that module from oslo.db itself, so unless you import it manually... | 16:38 |
| stephenfin | yeah | 16:38 |
| cardoe | Anyway thanks for the feedback. I'll update the patch. | 16:38 |
| stephenfin | nw | 16:38 |
| cardoe | Also good work on k-orc.cloud Looking forward to using and contributing to it. | 16:38 |
| stephenfin | I can't take much credit, since that was mainly mandre and pprinetti (who aren't on IRC), but thanks :) | 16:39 |
| opendevreview | Merged openstack/pbr master: Add classifiers for latest Python https://review.opendev.org/c/openstack/pbr/+/965916 | 16:53 |
| opendevreview | Stephen Finucane proposed openstack/oslotest master: Remove cross-testing functionality https://review.opendev.org/c/openstack/oslotest/+/965828 | 17:39 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Simplify process group fallback expression https://review.opendev.org/c/openstack/oslo.messaging/+/965938 | 22:09 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!