| *** mhen_ is now known as mhen | 02:44 | |
| gibi | can I get a second oslo core to review https://review.opendev.org/c/openstack/oslo.service/+/966458 ? | 13:51 |
|---|---|---|
| *** haleyb is now known as haleyb|out | 15:12 | |
| opendevreview | Elod Illes proposed openstack/openstack-doc-tools master: Add 2025.2 to sitemap generator script https://review.opendev.org/c/openstack/openstack-doc-tools/+/962791 | 15:46 |
| opendevreview | Elod Illes proposed openstack/openstack-doc-tools master: Add 2025.2 to sitemap generator script https://review.opendev.org/c/openstack/openstack-doc-tools/+/962791 | 15:46 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: trivial: Remove references to importlib_metadata https://review.opendev.org/c/openstack/stevedore/+/966592 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Remove use of mutable default param https://review.opendev.org/c/openstack/stevedore/+/966593 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Deprecate verify_requirements flag https://review.opendev.org/c/openstack/stevedore/+/966594 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: typing: Add initial type hints https://review.opendev.org/c/openstack/stevedore/+/966595 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: typing: Make better use of ParamSpec https://review.opendev.org/c/openstack/stevedore/+/966596 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: typing: Add hints to tests https://review.opendev.org/c/openstack/stevedore/+/966597 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: tests: Trivial fixups https://review.opendev.org/c/openstack/stevedore/+/966598 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: docs: Update to use pyproject.toml https://review.opendev.org/c/openstack/stevedore/+/966620 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Remove unnecessary type docstring field lists https://review.opendev.org/c/openstack/stevedore/+/966691 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: typing: Remove unnecessary method subclass https://review.opendev.org/c/openstack/stevedore/+/966692 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: typing: Remove use of _init_attributes (1/2) https://review.opendev.org/c/openstack/stevedore/+/966693 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: typing: Remove use of _init_attributes (2/2) https://review.opendev.org/c/openstack/stevedore/+/966694 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Make better use of super https://review.opendev.org/c/openstack/stevedore/+/966695 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Add conflict resolution support https://review.opendev.org/c/openstack/stevedore/+/966696 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Unskip test https://review.opendev.org/c/openstack/stevedore/+/966697 | 16:15 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Deprecate warn_on_missing_entrypoint parameter https://review.opendev.org/c/openstack/stevedore/+/966698 | 16:15 |
| stephenfin | tkajinam: hberaud[m]: Any chance you could review those stevedore patches when you've time? Just want a sanity check. They start here https://review.opendev.org/c/openstack/stevedore/+/966590/ (I self-approved the two trivial ones at the bottom) | 16:21 |
| opendevreview | Stephen Finucane proposed openstack/oslo.service master: trivial: Avoid use of kwargs https://review.opendev.org/c/openstack/oslo.service/+/966702 | 16:25 |
| stephenfin | tkajinam: Also, follow-up for your comment on gibi's patch there ^ | 16:26 |
| tkajinam | stephenfin, I think I reviewed most of these. Just left a comment in https://review.opendev.org/c/openstack/stevedore/+/966591 regarding the value in select option | 16:29 |
| * stephenfin looks | 16:29 | |
| * tkajinam is looking at https://docs.astral.sh/ruff/rules/#pyupgrade-up | 16:31 | |
| tkajinam | I see some pyproject.toml contains U while the others have UP. | 16:32 |
| stephenfin | tkajinam: It accepts partial matches. That's how we e.g. enable E4, E5, E7 and E9 but not (a theoretical?) E3 | 16:32 |
| stephenfin | So there'll only be an issue if they introduce e.g. US errors | 16:33 |
| stephenfin | ❯ ruff check . | 16:33 |
| stephenfin | ruff failed | 16:33 |
| stephenfin | Cause: Failed to parse /home/stephenfin/code/stevedore/pyproject.toml | 16:33 |
| stephenfin | Cause: TOML parse error at line 53, column 51 | 16:33 |
| stephenfin | | | 16:33 |
| stephenfin | 53 | select = ["C4", "E4", "E5", "E7", "E9", "F", "S", "V"] | 16:33 |
| stephenfin | | ^^^ | 16:33 |
| stephenfin | Unknown rule selector: `V` | 16:33 |
| tkajinam | ok | 16:33 |
| stephenfin | that's what happens if you pass an invalid selector | 16:33 |
| tkajinam | I readded my +2. | 16:35 |
| tkajinam | I'll update it later to use UP because I prefer more specific usage to avoid future problems but I can take care of it with my own approval | 16:35 |
| stephenfin | ack | 16:35 |
| stephenfin | there may be a few others littered around the place, but I think you already know that | 16:36 |
| tkajinam | yup | 16:36 |
| tkajinam | thanks to grep :-) | 16:36 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.middleware master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/oslo.middleware/+/966703 | 16:39 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/oslo.cache/+/966704 | 16:39 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.context master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/oslo.context/+/966705 | 16:40 |
| opendevreview | Takashi Kajinami proposed openstack/pycadf master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/pycadf/+/966706 | 16:41 |
| opendevreview | Takashi Kajinami proposed openstack/microversion-parse master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/microversion-parse/+/966707 | 16:41 |
| opendevreview | Merged openstack/oslo.service master: Synch Service.launch() signature https://review.opendev.org/c/openstack/oslo.service/+/966458 | 16:45 |
| tkajinam | oh wait I have to click (more) button to view the full series about that stevedore series | 16:50 |
| stephenfin | Yeah, it's quite big 😅 | 16:51 |
| stephenfin | I wanted the conflict resolution thing for OSC and, err, got carried away | 16:51 |
| tkajinam | ok I see https://review.opendev.org/c/openstack/stevedore/+/966696 | 16:52 |
| tkajinam | ok I'll try to go through that typing changes tomorrow with my fresh eyes hopefully | 16:53 |
| stephenfin | ty | 16:53 |
| tkajinam | stephenfin, thanks for these great work by the way | 16:53 |
| opendevreview | Merged openstack/microversion-parse master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/microversion-parse/+/966707 | 17:15 |
| opendevreview | Merged openstack/oslo.cache master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/oslo.cache/+/966704 | 19:48 |
| opendevreview | Merged openstack/oslo.service master: trivial: Avoid use of kwargs https://review.opendev.org/c/openstack/oslo.service/+/966702 | 20:07 |
| opendevreview | Merged openstack/oslo.context master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/oslo.context/+/966705 | 20:25 |
| opendevreview | Merged openstack/oslo.middleware master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/oslo.middleware/+/966703 | 20:32 |
| opendevreview | Merged openstack/pycadf master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/pycadf/+/966706 | 20:46 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!