| hberaud[m] | tkajinam, stephenfin o/ please, do you mind having another look at https://review.opendev.org/c/openstack/oslo.messaging/+/960377. thanks in advance | 08:54 |
|---|---|---|
| *** elodilles is now known as elodilles_pto | 09:18 | |
| tkajinam | hberaud[m], hmm... I'm struggling to understand the benefit of detecting that specific exchange limit error there. what is the benefit of adding dedicated retry logic to that specific error, rather than just adding retry logic for generic MessageDeliveryFailure ? | 09:28 |
| hberaud[m] | I think you are right, there is no specific benefits | 09:29 |
| hberaud[m] | That's just that having a specific type help to be aware of that specific case, but the same could be done with a MessageDeliveryFailure | 09:30 |
| hberaud[m] | Would you me to drop the specific type and to follow the classic MessageDeliveryFailure scenario? | 09:31 |
| hberaud[m] | s/Would you prefer that I drop the specific type and to follow the classic MessageDeliveryFailure scenario?/ | 09:32 |
| tkajinam | give me a few more minutes | 09:35 |
| hberaud[m] | sure | 09:35 |
| tkajinam | I wonder if the problem is caused by the logic swallowing PrecinditionFailed regardless of the actual error | 09:35 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Restore ThreadGroup.max_threads for backward compatibility https://review.opendev.org/c/openstack/oslo.service/+/967218 | 09:39 |
| hberaud[m] | if I correctly understand your message, and if I follow your reasoning, I think we only need the first "PRECONDITION_FAILED - inequivalent arg 'durable'" to ensure to properly declare an exchange properly, and my new proposal is not anymore needed and would be considered as a classic MessageDeliveryFailure. | 09:43 |
| hberaud[m] | exact? | 09:43 |
| hberaud[m] | in short, my patch is not really needed as this new PRECONDITION_FAILED would be automatically managed by the classic workflow | 09:44 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.messaging master: rabbit: Fix ignored PreconditionFailed error https://review.opendev.org/c/openstack/oslo.messaging/+/967305 | 09:44 |
| tkajinam | hberaud[m], yup and that's what I'm trying to show by this one ^^^^ | 09:45 |
| tkajinam | maybe we need a bug for this so that we can backport it | 09:45 |
| hberaud[m] | looking | 09:45 |
| hberaud[m] | let me check your patch | 09:46 |
| hberaud[m] | Indeed it looks a more better approach | 09:48 |
| hberaud[m] | I propose that we 1) abandon my patch 2) continue with yours 3) we backport 967305 to stable branches | 09:50 |
| hberaud[m] | I abandoned my patch | 09:56 |
| tkajinam | hberaud[m], agree with all these points | 10:06 |
| tkajinam | I'll create a bug and associate my patch with it. If you have additional context then feel free to add it to the bug | 10:06 |
| * tkajinam is writing a bug | 10:06 | |
| hberaud[m] | Thanks, no I've no additional context, I found this problem of exchange limit simply by checking rabbitmq release notes, but I've no real use cases | 10:07 |
| tkajinam | ah ok | 10:10 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.messaging master: rabbit: Fix ignored PreconditionFailed error https://review.opendev.org/c/openstack/oslo.messaging/+/967305 | 10:25 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.messaging master: rabbit: Fix ignored PreconditionFailed error https://review.opendev.org/c/openstack/oslo.messaging/+/967305 | 10:27 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.messaging master: rabbit: Fix ignored PreconditionFailed error https://review.opendev.org/c/openstack/oslo.messaging/+/967305 | 10:27 |
| damani[m] | hi | 12:08 |
| damani[m] | tkajinam, hberaud, gibi, can you please take a look on that patch https://review.opendev.org/c/openstack/oslo.service/+/967218 | 12:09 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.service master: [threading]Dump config when no_fork https://review.opendev.org/c/openstack/oslo.service/+/967354 | 12:31 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.service master: [threading]Dump config when no_fork https://review.opendev.org/c/openstack/oslo.service/+/967354 | 13:11 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.service master: [threading]Dump config when no_fork https://review.opendev.org/c/openstack/oslo.service/+/967354 | 13:33 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.service master: [threading]Dump config when no_fork https://review.opendev.org/c/openstack/oslo.service/+/967354 | 13:35 |
| gibi | damani[m]: thanks looks good to me | 13:41 |
| gibi | damani[m]: I also pushed https://review.opendev.org/c/openstack/oslo.service/+/967354 to recover on more functionality when no_fork is used. I'm wondering what else will not work with no_fork mode | 13:42 |
| gibi | s/on more/one more/ | 13:42 |
| gibi | is it even advised to use no_fork? | 13:43 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: Add typing https://review.opendev.org/c/openstack/oslo.limit/+/967072 | 14:10 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: Add typing https://review.opendev.org/c/openstack/oslo.limit/+/967072 | 14:12 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: ruff: Enable more rules https://review.opendev.org/c/openstack/oslo.limit/+/967379 | 14:13 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.service master: [threading]Dump config when no_fork https://review.opendev.org/c/openstack/oslo.service/+/967354 | 14:14 |
| opendevreview | Merged openstack/oslo.messaging master: rabbit: Fix ignored PreconditionFailed error https://review.opendev.org/c/openstack/oslo.messaging/+/967305 | 14:20 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.messaging stable/2025.2: rabbit: Fix ignored PreconditionFailed error https://review.opendev.org/c/openstack/oslo.messaging/+/967384 | 14:24 |
| *** haleyb|out is now known as haleyb | 14:32 | |
| opendevreview | Stephen Finucane proposed openstack/oslo.cache master: Add missing py.typed file https://review.opendev.org/c/openstack/oslo.cache/+/967385 | 14:33 |
| opendevreview | Merged openstack/castellan master: Validate [key_manager] auth_type at loading https://review.opendev.org/c/openstack/castellan/+/963971 | 14:47 |
| opendevreview | Merged openstack/castellan master: Make sure [key_manager] auth_url is a valid URL https://review.opendev.org/c/openstack/castellan/+/963972 | 14:48 |
| opendevreview | Merged openstack/castellan master: Drop redundant exception handling https://review.opendev.org/c/openstack/castellan/+/954873 | 14:55 |
| opendevreview | Merged openstack/oslo.limit master: Apply ruff https://review.opendev.org/c/openstack/oslo.limit/+/967071 | 14:58 |
| opendevreview | Merged openstack/castellan master: Fix missing argument https://review.opendev.org/c/openstack/castellan/+/954874 | 15:07 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.limit master: Accept previously accepted format for endpoint_service_type https://review.opendev.org/c/openstack/oslo.limit/+/961478 | 15:17 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: ruff: Enable more rules https://review.opendev.org/c/openstack/oslo.limit/+/967379 | 15:24 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: Add typing https://review.opendev.org/c/openstack/oslo.limit/+/967072 | 15:24 |
| opendevreview | Merged openstack/stevedore master: Deprecate warn_on_missing_entrypoint parameter https://review.opendev.org/c/openstack/stevedore/+/966698 | 16:00 |
| opendevreview | Merged openstack/taskflow master: Replace PackException/UnpackException https://review.opendev.org/c/openstack/taskflow/+/952419 | 16:13 |
| opendevreview | Merged openstack/oslo.service master: Restore ThreadGroup.max_threads for backward compatibility https://review.opendev.org/c/openstack/oslo.service/+/967218 | 17:20 |
| opendevreview | Stephen Finucane proposed openstack/oslo.concurrency master: Add missing raise https://review.opendev.org/c/openstack/oslo.concurrency/+/967406 | 17:48 |
| opendevreview | Stephen Finucane proposed openstack/oslo.concurrency master: Apply ruff https://review.opendev.org/c/openstack/oslo.concurrency/+/967407 | 17:48 |
| opendevreview | Stephen Finucane proposed openstack/oslo.concurrency master: trivial: Remove use of kwargs https://review.opendev.org/c/openstack/oslo.concurrency/+/967408 | 17:48 |
| opendevreview | Stephen Finucane proposed openstack/oslo.concurrency master: Add typing https://review.opendev.org/c/openstack/oslo.concurrency/+/967409 | 17:48 |
| stephenfin | damani[m]: Could you hit these release patches when you get a chance? https://review.opendev.org/c/openstack/releases/+/967383 https://review.opendev.org/c/openstack/releases/+/967382 https://review.opendev.org/c/openstack/releases/+/967381 https://review.opendev.org/c/openstack/releases/+/967380 | 17:50 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.vmware master: Use oslo.service loopingcall https://review.opendev.org/c/openstack/oslo.vmware/+/967416 | 18:45 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.vmware master: [test]Mock time.sleep instead of greenthread.sleep https://review.opendev.org/c/openstack/oslo.vmware/+/967417 | 18:45 |
| opendevreview | Balazs Gibizer proposed openstack/oslo.vmware master: Remove eventlet timeout from image_transfer https://review.opendev.org/c/openstack/oslo.vmware/+/967418 | 18:45 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!