| opendevreview | Eunkyung Kim proposed openstack/osprofiler master: Fix KeyError in notifying db errors https://review.opendev.org/c/openstack/osprofiler/+/968274 | 01:34 |
|---|---|---|
| *** mhen_ is now known as mhen | 02:27 | |
| opendevreview | LeeChunghwan proposed openstack/osprofiler master: Create root span in the otlp driver https://review.opendev.org/c/openstack/osprofiler/+/968428 | 05:59 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: fixture: Mock out services, regions https://review.opendev.org/c/openstack/oslo.limit/+/968463 | 13:02 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: Handle missing endpoint, region, service https://review.opendev.org/c/openstack/oslo.limit/+/968464 | 13:02 |
| stephenfin | tkajinam: ^ | 13:02 |
| tkajinam | stephenfin, thx. checking | 13:08 |
| tkajinam | I wonder if just explicitly passing endpoint_id can resolve the issue. let me check it. | 13:08 |
| stephenfin | tkajinam: the failing nova tests in question are intentionally testing discovery | 13:09 |
| stephenfin | nova.tests.functional.test_unified_limits.EndpointDiscoveryTest | 13:10 |
| tkajinam | ahh ok | 13:11 |
| tkajinam | OK I found that intentional endpoint_id=None in nova though idk if the behavior should be really tested in nova in that detail | 13:13 |
| tkajinam | (but that does not block your fix. thanks ! | 13:14 |
| stephenfin | I don't believe it should, no | 13:14 |
| tkajinam | yeah | 13:14 |
| stephenfin | but if not, we should still do _something_ beyond what we're doing, like make it a non-callable mock | 13:14 |
| stephenfin | it == the sdk's 'services' method | 13:14 |
| tkajinam | anyway we can merge your changes to unblock the CI (still waiting for CI result | 13:15 |
| tkajinam | yeah | 13:15 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: WIP: fixture: Autospec the identity proxy API mock https://review.opendev.org/c/openstack/oslo.limit/+/968473 | 13:24 |
| opendevreview | Merged openstack/oslo.service master: Add multiprocessing utilities with spawn start method https://review.opendev.org/c/openstack/oslo.service/+/963742 | 16:36 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!