| *** mhen_ is now known as mhen | 02:17 | |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Add spawn-safe ServiceManager (temporary backport of Cotyledon PR#84) https://review.opendev.org/c/openstack/oslo.service/+/969586 | 10:40 |
|---|---|---|
| opendevreview | Daniel Bengtsson proposed openstack/oslo.config master: Add skip_if_exists parameter to register_opts() https://review.opendev.org/c/openstack/oslo.config/+/967828 | 11:14 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.config master: Add skip_if_exists parameter to register_opts() https://review.opendev.org/c/openstack/oslo.config/+/967828 | 11:21 |
| opendevreview | Abhishek Bongale proposed openstack/etcd3gw master: Allow session parameter for custom configuration https://review.opendev.org/c/openstack/etcd3gw/+/969384 | 11:52 |
| opendevreview | Abhishek Bongale proposed openstack/etcd3gw master: Allow session parameter for custom configuration https://review.opendev.org/c/openstack/etcd3gw/+/969384 | 14:13 |
| opendevreview | Stephen Finucane proposed openstack/oslo.serialization master: Add ruff https://review.opendev.org/c/openstack/oslo.serialization/+/969140 | 14:16 |
| opendevreview | Stephen Finucane proposed openstack/oslo.serialization master: Add typing https://review.opendev.org/c/openstack/oslo.serialization/+/969141 | 14:16 |
| opendevreview | Stephen Finucane proposed openstack/oslo.metrics master: Add ruff https://review.opendev.org/c/openstack/oslo.metrics/+/969239 | 14:27 |
| opendevreview | Stephen Finucane proposed openstack/oslo.metrics master: Add typing https://review.opendev.org/c/openstack/oslo.metrics/+/969240 | 14:27 |
| opendevreview | Stephen Finucane proposed openstack/oslo.serialization master: Add typing https://review.opendev.org/c/openstack/oslo.serialization/+/969141 | 14:31 |
| opendevreview | Stephen Finucane proposed openstack/oslo.metrics master: Add ruff https://review.opendev.org/c/openstack/oslo.metrics/+/969239 | 14:31 |
| opendevreview | Stephen Finucane proposed openstack/oslo.metrics master: Add typing https://review.opendev.org/c/openstack/oslo.metrics/+/969240 | 14:31 |
| opendevreview | Stephen Finucane proposed openstack/oslo.upgradecheck master: Add typing https://review.opendev.org/c/openstack/oslo.upgradecheck/+/969097 | 14:33 |
| stephenfin | tkajinam: hberaud[m]: I should have addressed your comments on those patches | 14:33 |
| hberaud[m] | ack, thanks | 14:34 |
| stephenfin | regarding the tox -> pre-commit -> tox thing, it's not an ideal solution but it's the best one I could come up with | 14:34 |
| hberaud[m] | will review them ASAP | 14:34 |
| stephenfin | As noted in the dependency resolver, I wanted to use tox's dependency resolver to ensure we always get the latest version of packages allowed by upper-constraints | 14:34 |
| stephenfin | and I also wanted to avoid duplicating our dependency list in .pre-commit-config.yaml | 14:35 |
| hberaud[m] | ack | 14:35 |
| stephenfin | If we integrate mypy into the pep8 target then we will need to drop the skip_install option and start installing all dependencies + pre-commit + mypy. That will make that target much slower | 14:36 |
| stephenfin | actually, nvm, it's already slower because we are calling the mypy testenv via this dance... 😅 | 14:36 |
| stephenfin | so if we don't like the approach either I do that ^ | 14:37 |
| stephenfin | or I stop doing type checks in pre-commit (and by extension the pep8 testevnv) and insist users call `tox -e mypy` explicitly. This would also require adding a new zuul job to all repos to check this. | 14:38 |
| stephenfin | I'm okay with either. Let me know if you have strong preferences | 14:38 |
| stephenfin | ...and thanks for the reviews :) | 14:38 |
| tkajinam | stephenfin, regarding the target I prefer the single one given how updating zuul jobs commonly is complicated (well each change might be simple but you know how many repos we should update. and if we start doing it then we should probably ask the others for consistency which extends the scope | 14:59 |
| tkajinam | so I prefer running mypy from pep8 target | 15:00 |
| tkajinam | and honestly with the current execution steps I feel like having separate tox env is redundant. It could be beneficial if tox still allowed using shared env but you know its current state | 15:01 |
| tkajinam | if installing the deps into the tox venv and run pre-commit there can work then I think removing skip_install (and add additional typing packages there) and run mypy from pre-commit is most simple and my preference | 15:02 |
| tkajinam | stephenfin, ^^^ | 15:02 |
| stephenfin | ack, I'll do that instead so | 15:03 |
| tkajinam | stephenfin, thx ! | 15:03 |
| tkajinam | I have to review the other remaining ones | 15:07 |
| tkajinam | stephenfin, hberaud[m] by the way I proposed the changes to enable H904 (for delay string interpolation in logging) https://review.opendev.org/q/topic:%22H904%22 I wonder if you mind if I fast approve these (especially ones which only touch tox.ini) ? | 15:08 |
| tkajinam | I'm aware some of these may conflict with the ruff patches so I'll keep these open (or wll update the ruff change once these are merged by myside) | 15:09 |
| hberaud[m] | tkajinam: I voted, I let you merge them once the ruff patches wave is passed | 16:08 |
| opendevreview | Merged openstack/oslo.metrics master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.metrics/+/969420 | 16:16 |
| opendevreview | Merged openstack/oslo.upgradecheck master: Add ruff https://review.opendev.org/c/openstack/oslo.upgradecheck/+/969096 | 16:29 |
| tkajinam | hberaud[m], thx ! | 16:54 |
| tkajinam | I'll merge ones without merge conflict | 16:54 |
| tkajinam | (I mean the repos without ruff change proposed | 16:54 |
| opendevreview | Merged openstack/oslo.serialization master: Add ruff https://review.opendev.org/c/openstack/oslo.serialization/+/969140 | 17:13 |
| opendevreview | Merged openstack/castellan master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/castellan/+/969469 | 17:29 |
| opendevreview | Merged openstack/taskflow master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/taskflow/+/969462 | 17:50 |
| opendevreview | Stephen Finucane proposed openstack/oslo.serialization master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.serialization/+/969453 | 18:01 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.limit/+/969057 | 18:08 |
| opendevreview | Stephen Finucane proposed openstack/oslo.log master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.log/+/969063 | 18:10 |
| opendevreview | Stephen Finucane proposed openstack/oslo.context master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.context/+/969048 | 18:12 |
| opendevreview | Stephen Finucane proposed openstack/oslo.i18n master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.i18n/+/969054 | 18:13 |
| opendevreview | Stephen Finucane proposed openstack/oslo.cache master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.cache/+/969045 | 18:14 |
| opendevreview | Stephen Finucane proposed openstack/stevedore master: Run mypy from tox https://review.opendev.org/c/openstack/stevedore/+/969055 | 18:15 |
| opendevreview | Stephen Finucane proposed openstack/oslo.middleware master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.middleware/+/969264 | 18:16 |
| opendevreview | Stephen Finucane proposed openstack/oslo.concurrency master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.concurrency/+/969047 | 18:17 |
| opendevreview | Stephen Finucane proposed openstack/oslo.utils master: Run mypy from tox https://review.opendev.org/c/openstack/oslo.utils/+/969082 | 18:18 |
| opendevreview | Stephen Finucane proposed openstack/oslo.upgradecheck master: Add typing https://review.opendev.org/c/openstack/oslo.upgradecheck/+/969097 | 18:19 |
| opendevreview | Stephen Finucane proposed openstack/oslo.serialization master: Add typing https://review.opendev.org/c/openstack/oslo.serialization/+/969141 | 18:20 |
| opendevreview | Stephen Finucane proposed openstack/oslo.serialization master: Add typing https://review.opendev.org/c/openstack/oslo.serialization/+/969141 | 18:22 |
| opendevreview | Stephen Finucane proposed openstack/oslo.metrics master: Add typing https://review.opendev.org/c/openstack/oslo.metrics/+/969240 | 18:23 |
| stephenfin | tkajinam: hberaud[m]: Updated everything to remove mypy from pre-commit and instead embed it in the pep8 tox target | 18:24 |
| stephenfin | where it will be picked up by the existing openstack-tox-pep8 job | 18:25 |
| opendevreview | Merged openstack/tooz master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/tooz/+/969460 | 18:26 |
| opendevreview | Merged openstack/oslo.log master: Add ruff https://review.opendev.org/c/openstack/oslo.log/+/969061 | 18:57 |
| opendevreview | Merged openstack/oslo.i18n master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.i18n/+/969468 | 19:11 |
| opendevreview | Merged openstack/oslo.rootwrap master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.rootwrap/+/969451 | 19:22 |
| opendevreview | Merged openstack/stevedore master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/stevedore/+/969463 | 19:36 |
| opendevreview | Merged openstack/oslo.cache master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.cache/+/969424 | 19:36 |
| opendevreview | Merged openstack/oslo.service master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.service/+/969457 | 19:38 |
| opendevreview | Merged openstack/etcd3gw master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/etcd3gw/+/969461 | 19:42 |
| opendevreview | Merged openstack/oslo.limit master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.limit/+/969442 | 19:45 |
| opendevreview | Merged openstack/oslo.versionedobjects master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.versionedobjects/+/969459 | 19:46 |
| opendevreview | Merged openstack/oslo.concurrency master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.concurrency/+/969425 | 19:49 |
| opendevreview | Merged openstack/oslo.privsep master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.privsep/+/969449 | 19:53 |
| opendevreview | Merged openstack/oslo.reports master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.reports/+/969450 | 19:54 |
| opendevreview | Merged openstack/futurist master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/futurist/+/969464 | 19:54 |
| opendevreview | Merged openstack/oslo.config master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.config/+/969429 | 19:55 |
| opendevreview | Merged openstack/oslo.policy master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.policy/+/969448 | 19:58 |
| opendevreview | Merged openstack/oslo.context master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.context/+/969440 | 19:59 |
| opendevreview | Merged openstack/oslo.middleware master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.middleware/+/969447 | 20:03 |
| opendevreview | Merged openstack/oslo.messaging master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.messaging/+/969446 | 20:04 |
| opendevreview | Merged openstack/oslo.serialization master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.serialization/+/969453 | 20:37 |
| opendevreview | Merged openstack/oslo.utils master: Add types to oslo_utils.fixture https://review.opendev.org/c/openstack/oslo.utils/+/969080 | 21:23 |
| opendevreview | Merged openstack/oslo.db master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.db/+/969439 | 21:44 |
| opendevreview | Merged openstack/oslo.utils master: tests: Remove unnecessary base class https://review.opendev.org/c/openstack/oslo.utils/+/969081 | 21:46 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.upgradecheck master: Delay string interpolations at logging calls https://review.opendev.org/c/openstack/oslo.upgradecheck/+/969458 | 23:47 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!