| *** mhen_ is now known as mhen | 02:13 | |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: typing: Accept None project ID https://review.opendev.org/c/openstack/oslo.limit/+/970247 | 11:06 |
|---|---|---|
| opendevreview | Stephen Finucane proposed openstack/oslo.limit master: typing: Be looser in what we accept https://review.opendev.org/c/openstack/oslo.limit/+/970248 | 11:06 |
| opendevreview | Merged openstack/pycadf master: ruff: Enable missing E5 check https://review.opendev.org/c/openstack/pycadf/+/970255 | 11:50 |
| opendevreview | Merged openstack/oslo.utils master: ruff: Enable missing E5 check https://review.opendev.org/c/openstack/oslo.utils/+/970254 | 11:54 |
| opendevreview | Merged openstack/oslo.context master: ruff: Enable missing E5 check https://review.opendev.org/c/openstack/oslo.context/+/970252 | 11:58 |
| opendevreview | Merged openstack/oslo.utils master: strutils: Improve hint for string_to_bytes https://review.opendev.org/c/openstack/oslo.utils/+/970243 | 12:16 |
| opendevreview | Merged openstack/oslo.middleware master: ruff: Enable missing E5 check https://review.opendev.org/c/openstack/oslo.middleware/+/970253 | 12:33 |
| opendevreview | Merged openstack/oslo.i18n master: ruff: Enable missing E5 check https://review.opendev.org/c/openstack/oslo.i18n/+/970256 | 12:43 |
| opendevreview | Merged openstack/oslo.limit master: Fix region query https://review.opendev.org/c/openstack/oslo.limit/+/969413 | 12:46 |
| opendevreview | Merged openstack/oslo.context master: typing: Simplify return type of RequestContext.to_policy_values https://review.opendev.org/c/openstack/oslo.context/+/970172 | 12:52 |
| opendevreview | Merged openstack/oslo.cache master: ruff: Enable missing E5 check https://review.opendev.org/c/openstack/oslo.cache/+/970251 | 12:53 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Enable logging related ruff checks https://review.opendev.org/c/openstack/oslo.cache/+/970008 | 14:27 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.middleware master: Enable logging related ruff checks https://review.opendev.org/c/openstack/oslo.middleware/+/970010 | 14:29 |
| stephenfin | tkajinam: An oversight, yeah. That list was taken from the ruff defaults and E5 isn't present there. I see not reason not to enable it though https://docs.astral.sh/ruff/settings/#lint_select | 16:11 |
| opendevreview | Stephen Finucane proposed openstack/oslo.limit stable/2025.2: Fix region query https://review.opendev.org/c/openstack/oslo.limit/+/970419 | 16:15 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.context master: Enable logging related ruff checks https://review.opendev.org/c/openstack/oslo.context/+/970434 | 16:56 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.limit master: Enable logging related ruff checks https://review.opendev.org/c/openstack/oslo.limit/+/970435 | 16:57 |
| tkajinam | stephenfin, ok, thanks. I'm roughly guessing that they expect the formatter should enforce it though I see it does not treat the limit as hard one and leaves some lines > 79 chars. | 17:00 |
| stephenfin | in my experience it doesn't wrap comments, string literals, or assignments of very long things. I'm okay with the latter, but we should obviously avoid the other two | 17:01 |
| stephenfin | if you spot any other places I've missed, send them my way and I'll happily ack them | 17:02 |
| tkajinam | https://docs.astral.sh/ruff/settings/#line-length | 17:03 |
| tkajinam | yeah | 17:03 |
| tkajinam | stephenfin, I think I covered all except for openstackclient which has some lines which can't be easily wrapped. I'll check it again tomorrow but I guess we might end up with disabling E501 in test code only | 17:17 |
| stephenfin | ack | 17:17 |
| opendevreview | Merged openstack/oslo.cache master: Enable logging related ruff checks https://review.opendev.org/c/openstack/oslo.cache/+/970008 | 17:59 |
| opendevreview | Merged openstack/oslo.middleware master: Enable logging related ruff checks https://review.opendev.org/c/openstack/oslo.middleware/+/970010 | 18:02 |
| opendevreview | Merged openstack/oslo.concurrency master: Enable logging related ruff checks https://review.opendev.org/c/openstack/oslo.concurrency/+/970009 | 18:15 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!