| opendevreview | Takashi Kajinami proposed openstack/oslo.context master: Add interface to override is_admin check https://review.opendev.org/c/openstack/oslo.context/+/974617 | 02:25 |
|---|---|---|
| *** mhen_ is now known as mhen | 02:41 | |
| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Implement ConsulOperator as a service broker to support HTTP Driver https://review.opendev.org/c/openstack/oslo.messaging/+/912499 | 08:24 |
| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Add HTTP driver to oslo.messaging.drivers https://review.opendev.org/c/openstack/oslo.messaging/+/914840 | 08:24 |
| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Implement HTTPListener and HTTPClient https://review.opendev.org/c/openstack/oslo.messaging/+/915056 | 08:24 |
| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Add flask app for http-driver https://review.opendev.org/c/openstack/oslo.messaging/+/938283 | 08:24 |
| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Add Broadcaster for RPC Fanout https://review.opendev.org/c/openstack/oslo.messaging/+/938536 | 08:24 |
| opendevreview | Xiang Wang proposed openstack/oslo.messaging master: Add HTTP Driver documentation https://review.opendev.org/c/openstack/oslo.messaging/+/973843 | 08:24 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: redis: Use native interfaces to configure socket keepalive https://review.opendev.org/c/openstack/oslo.cache/+/974723 | 13:16 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.context master: Add interface to override is_admin check https://review.opendev.org/c/openstack/oslo.context/+/974617 | 13:33 |
| opendevreview | Merged openstack/oslo.config master: Adapt subcommand test for Python 3.14 https://review.opendev.org/c/openstack/oslo.config/+/974557 | 13:46 |
| opendevreview | Takashi Kajinami proposed openstack/tooz master: debian: Use compatibility package for mysql-server https://review.opendev.org/c/openstack/tooz/+/974726 | 13:46 |
| opendevreview | Merged openstack/taskflow master: pre-commit: Bump versions https://review.opendev.org/c/openstack/taskflow/+/974623 | 13:50 |
| opendevreview | Takashi Kajinami proposed openstack/tooz master: Pin tooz-tox-py313-mysql to Ubuntu Noble https://review.opendev.org/c/openstack/tooz/+/974731 | 14:16 |
| tkajinam | ^^^ stephenfin this is probably a "short path" to fix that broken job | 14:16 |
| tkajinam | technically we can add mariadb support for pifpaf but the annoying blocker atm is that pifpaf uses a single docker image for all tests and we can't install both mariadb and mysql into a single image ... | 14:16 |
| stephenfin | tkajinam: Ack, I'll look shortly | 14:38 |
| stephenfin | tkajinam: regarding https://review.opendev.org/c/openstack/oslo.context/+/974617/7/oslo_context/context.py, my question was not about overriding is_admin but rather the need for the property | 14:38 |
| stephenfin | (i.e. @property) | 14:38 |
| stephenfin | I was already aware of what nova was doing and it was on my list to address https://review.opendev.org/c/openstack/nova/+/705658/31/nova/context.py#117 | 14:39 |
| stephenfin | but they (and others?) simply set `is_admin` once in __init__ and don't seem to touch it again, so a property + setter seems like overkill? | 14:40 |
| *** haleyb_ is now known as haleyb | 15:10 | |
| tkajinam | stephenfin, maybe, though I don't really like the idea of using self to set is_admin within __init__. | 15:14 |
| tkajinam | stephenfin, it may work as lon as is_admin is evaluated at the last step but I can easily imagine that people can mess up that by adding new things | 15:15 |
| tkajinam | the benefit of having that dedicated interface is that we can ensure that the instance (=self) is fully set up... though I'm aware that this may not be fully guaranteed if is_admin is somehow called within __init__ | 15:16 |
| opendevreview | Takashi Kajinami proposed openstack/tooz master: Pin tooz-tox-py313-mysql to Ubuntu Noble https://review.opendev.org/c/openstack/tooz/+/974731 | 15:19 |
| stephenfin | tkajinam: Fair enough, and I guess it is harmless. I approved it | 15:34 |
| tkajinam | stephenfin, thanks ! | 15:37 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.context master: Add interface to override is_admin check https://review.opendev.org/c/openstack/oslo.context/+/974617 | 15:55 |
| opendevreview | Takashi Kajinami proposed openstack/tooz master: Pin tooz-tox-py313-mysql to Ubuntu Noble https://review.opendev.org/c/openstack/tooz/+/974731 | 17:08 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!