| *** mhen_ is now known as mhen | 02:26 | |
| opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Skip functional tests for .gitignore update https://review.opendev.org/c/openstack/oslo.policy/+/976076 | 03:46 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Skip functional tests for .gitignore update https://review.opendev.org/c/openstack/taskflow/+/976077 | 03:47 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Skip functional tests for .gitignore update https://review.opendev.org/c/openstack/oslo.policy/+/976076 | 06:08 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.service master: Reduce code duplication between two LoopingCall implementations https://review.opendev.org/c/openstack/oslo.service/+/975917 | 10:45 |
| ralonsoh | damani[m], hello! I think we have an issue with oslo.service | 12:24 |
| ralonsoh | https://bugs.launchpad.net/neutron/+bug/2141304 | 12:24 |
| ralonsoh | it seems to be related to some recent changes in this project | 12:24 |
| ralonsoh | In particular https://review.opendev.org/c/openstack/oslo.service/+/965208 | 12:25 |
| ralonsoh | hberaud[m], | 12:25 |
| stephenfin | PavloKostianov[m]: I was out last week but it seems you got your pep8 issues resolved | 12:39 |
| stephenfin | PavloKostianov[m]: also, commit 2eb7a9fe620005045d0d28282a3dbdce4091758a didn't remove the flake8 plugin: it migrated to the native hacking hook. We *have* removed that hook since though in favour of ruff. I personally install pre-commit and let it run, but you can also run it manually before commit with `pre-commit run -a` or `tox -e pep8`. | 12:44 |
| stephenfin | `tox -e pep8` will also run mypy which was likely the source of many of your lint failures | 12:45 |
| hberaud[m] | ralonsoh: ack, thanks for the heads up | 14:17 |
| *** haleyb|out is now known as haleyb | 14:24 | |
| ralonsoh | yw | 14:35 |
| PavloKostianov[m] | stephenfin: Thanks for the reply! I did resolved the pep8 issues running `tox -e pep8` manually. to make sure I did it. But the problem is that even though I have run `pre-commit --install` before committing the issues were only discovered after the CI failed. That's why I was thinking flake8 hook was removed, but as I understand for you it works (not letting you commit before you fix linting issues), right? Is there a step I | 14:53 |
| PavloKostianov[m] | am missing to make it work? | 14:53 |
| stephenfin | PavloKostianov[m]: pre-commit won't catch mypy issues, so that's likely what was missed | 14:54 |
| stephenfin | we used to use pre-commit for mypy also but that provded sub-optimal for a number of reason (speed, inconsistent dependency management, etc.) | 14:55 |
| PavloKostianov[m] | I see, now I know, thanks! | 15:14 |
| opendevreview | Takashi Kajinami proposed openstack/tooz master: Remove zake driver https://review.opendev.org/c/openstack/tooz/+/976150 | 17:04 |
| tkajinam | so it turned out zake relies on pkg_resources... and the library was abandoned | 17:08 |
| tkajinam | removing it from tooz is easy, but we also have to remove it from taskflow which is tricky due to the heavy usage to fake zookeeper backend ... | 17:08 |
| opendevreview | Liron Kuchlani proposed openstack/osprofiler master: Fix SQLAlchemy 2.0 compatibility in handle_error https://review.opendev.org/c/openstack/osprofiler/+/976184 | 20:36 |
| opendevreview | Ghanshyam proposed openstack/oslo.service master: Fix service multiple workers launching different service instance https://review.opendev.org/c/openstack/oslo.service/+/976188 | 22:05 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!