| *** mhen_ is now known as mhen | 02:21 | |
| *** mhen_ is now known as mhen | 03:45 | |
| opendevreview | Merged openstack/oslo.service master: Add register and set method to override the default value for service opts https://review.opendev.org/c/openstack/oslo.service/+/975574 | 07:07 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Remove zake https://review.opendev.org/c/openstack/taskflow/+/976331 | 14:20 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Use pifpaf env vars to detect backend services https://review.opendev.org/c/openstack/taskflow/+/976504 | 14:20 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Fix wrong environment variable to detect redis port https://review.opendev.org/c/openstack/taskflow/+/976505 | 14:20 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Remove zake https://review.opendev.org/c/openstack/taskflow/+/976331 | 14:29 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Use pifpaf env vars to detect backend services https://review.opendev.org/c/openstack/taskflow/+/976504 | 14:29 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Fix wrong environment variable to detect redis port https://review.opendev.org/c/openstack/taskflow/+/976505 | 14:29 |
| amoralej_ | Hi, I'm adding osprofiler support in watcher and while testing it I'm hitting an issue with the cmd client part. In my case it fails to connect to the notifications rabbitmq topics because I need to use non-default values for specific oslo_messaging_rabbit | 14:55 |
| amoralej_ | unless I'm missing something, i can not pass those options, (amqp_durable_queues i.e.) | 14:55 |
| amoralej_ | would be ok to make osprofile cmd to load os_messaging_rabbit and potentially oslo_messaging_notifications from a ini-type config file? or for cli, all options should come from cli args ? | 14:56 |
| *** amoralej_ is now known as amoralej | 15:01 | |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Remove zake https://review.opendev.org/c/openstack/taskflow/+/976331 | 15:02 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Use pifpaf env vars to detect backend services https://review.opendev.org/c/openstack/taskflow/+/976504 | 15:02 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Fix wrong environment variable to detect redis port https://review.opendev.org/c/openstack/taskflow/+/976505 | 15:02 |
| stephenfin | amoralej: propose a change with motivation inline and we'll happily review it | 15:22 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Remove zake https://review.opendev.org/c/openstack/taskflow/+/976331 | 15:34 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Use pifpaf env vars to detect backend services https://review.opendev.org/c/openstack/taskflow/+/976504 | 15:34 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Fix wrong environment variable to detect redis port https://review.opendev.org/c/openstack/taskflow/+/976505 | 15:34 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Support passing posargs for functional tests https://review.opendev.org/c/openstack/taskflow/+/976644 | 15:34 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Remove zake https://review.opendev.org/c/openstack/taskflow/+/976331 | 15:49 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Use pifpaf env vars to detect backend services https://review.opendev.org/c/openstack/taskflow/+/976504 | 15:49 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Fix wrong environment variable to detect redis port https://review.opendev.org/c/openstack/taskflow/+/976505 | 15:49 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Support passing posargs for functional tests https://review.opendev.org/c/openstack/taskflow/+/976644 | 15:49 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Remove zake https://review.opendev.org/c/openstack/taskflow/+/976331 | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Use pifpaf env vars to detect backend services https://review.opendev.org/c/openstack/taskflow/+/976504 | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Fix wrong environment variable to detect redis port https://review.opendev.org/c/openstack/taskflow/+/976505 | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Support passing posargs for functional tests https://review.opendev.org/c/openstack/taskflow/+/976644 | 16:03 |
| tkajinam | I think I finally managed to get these tests passing without zake | 16:03 |
| tkajinam | (though I still had to keep one test skipped now... | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Remove zake https://review.opendev.org/c/openstack/taskflow/+/976331 | 16:47 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Use pifpaf env vars to detect backend services https://review.opendev.org/c/openstack/taskflow/+/976504 | 16:47 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Fix wrong environment variable to detect redis port https://review.opendev.org/c/openstack/taskflow/+/976505 | 16:47 |
| opendevreview | Takashi Kajinami proposed openstack/taskflow master: Support passing posargs for functional tests https://review.opendev.org/c/openstack/taskflow/+/976644 | 16:47 |
| amoralej | stephenfin, thanks, I will but i was wondering if making cli read from config files is considered a bad practice before sending the patch | 17:35 |
| stephenfin | amoralej: aha, gotcha. I believe os-profiler already uses oslo.config, so it should already support config files | 17:52 |
| * stephenfin looks | 17:52 | |
| amoralej | yes, it does | 17:52 |
| amoralej | i just need to add some logic to load the config from files to the cmd and pass it to the driver, i think | 17:53 |
| amoralej | i expect it to not be hard | 17:53 |
| stephenfin | amoralej: https://docs.openstack.org/oslo.config/latest/reference/command-line | 17:56 |
| stephenfin | you probably knew about that already but just in case you didn't | 17:56 |
| amoralej | I appreciate it, thanks! | 17:57 |
| stephenfin | tl;dr though: I see no issues with making it configurable. It's pretty common for tools like nova-manage etc. | 17:57 |
| amoralej | right, that's a good point | 17:57 |
| gmaan | tkajinam: hberaud[m] damani[m] thanks for review, gate is green now, can either of you +W this https://review.opendev.org/c/openstack/oslo.service/+/976188/1 | 18:08 |
| gmaan | tkajinam: hberaud[m] and this too, gate is green now but waiting for +w https://review.opendev.org/c/openstack/oslo.service/+/976207 | 18:09 |
| stephenfin | gmaan: I +W'd (but didn't review) both of those | 18:11 |
| gmaan | stephenfin: thanks | 18:13 |
| opendevreview | Merged openstack/oslo.service master: Fix service multiple workers launching different service instance https://review.opendev.org/c/openstack/oslo.service/+/976188 | 20:01 |
| opendevreview | Merged openstack/oslo.service master: Run neutron-ovs-tempest-with-oslo-master job in check pipeline https://review.opendev.org/c/openstack/oslo.service/+/976207 | 20:15 |
| gmaan | damani[m]: tkajinam: I proposed a new release for oslo.service which includes all these fixes/spawn-way, can either of you check this https://review.opendev.org/c/openstack/releases/+/975702 | 21:09 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!