| tkajinam | stephenfin, hi. it'd be nice if you have time to review https://review.opendev.org/c/openstack/oslo.privsep/+/977534 . I'm honestly not very confident about the change in oslo_privsep/tests/unit/test_daemon.py and am wondering if you have a better idea ? | 10:34 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/oslo.metrics master: Fix broken log format https://review.opendev.org/c/openstack/oslo.metrics/+/977610 | 10:44 |
| PavloKostianov[m] | Hi everyone! I want to share I have recently built and released to allow developers patch multiple repositories with the same change at the same time. If you need to apply same change on all or even just more than 1 oslo repo it will help. | 11:35 |
| PavloKostianov[m] | Here is the PyPI page: https://pypi.org/project/changes-roller/ | 11:35 |
| PavloKostianov[m] | Feel free to open new issues with bugs/issue requests on the GH repo: https://github.com/k-pavlo/changes-roller | 11:35 |
| PavloKostianov[m] | *a tool | 11:35 |
| opendevreview | Merged openstack/oslo.metrics master: Fix broken log format https://review.opendev.org/c/openstack/oslo.metrics/+/977610 | 13:11 |
| opendevreview | Merged openstack/oslo.privsep master: Fix mypy errors https://review.opendev.org/c/openstack/oslo.privsep/+/977534 | 13:33 |
| opendevreview | Merged openstack/oslo.privsep master: Replace usage of undocumented logging.WARN https://review.opendev.org/c/openstack/oslo.privsep/+/977535 | 13:33 |
| tkajinam | AttributeError: Can't pickle local object '_ConfigFileOpt.__init__.<locals>.<lambda>' | 14:18 |
| tkajinam | hm | 14:18 |
| tkajinam | damani[m] hberaud[m] I'm a bit confused now seeing the above error in heat. I don't think this is quite specific to heat and we expect any conf instance, loaded by oslo.config may encounter the same | 14:21 |
| tkajinam | I mean, I guess https://review.opendev.org/c/openstack/oslo.service/+/965208 may never work actually and 'fork' context may be always used... Is that what you expected ? | 14:24 |
| tkajinam | gmaan, you might be interested in ^^^ , too | 14:26 |
| opendevreview | Takashi Kajinami proposed openstack/castellan master: tox: Fix missing functional-vault-py310 env https://review.opendev.org/c/openstack/castellan/+/977678 | 14:36 |
| opendevreview | Takashi Kajinami proposed openstack/castellan master: Move vault functional tests to noble https://review.opendev.org/c/openstack/castellan/+/977681 | 14:38 |
| tkajinam | idk why this has not been caught ... https://review.opendev.org/c/openstack/castellan/+/977678 | 14:42 |
| tkajinam | probably recent tox release revealed it | 14:42 |
| opendevreview | Takashi Kajinami proposed openstack/castellan master: Bump vault used in tests https://review.opendev.org/c/openstack/castellan/+/975135 | 14:59 |
| opendevreview | Takashi Kajinami proposed openstack/castellan master: Use more explicit import https://review.opendev.org/c/openstack/castellan/+/975399 | 14:59 |
| opendevreview | Takashi Kajinami proposed openstack/castellan master: barbican: Drop redundant full url composition https://review.opendev.org/c/openstack/castellan/+/975497 | 14:59 |
| opendevreview | Takashi Kajinami proposed openstack/castellan master: Check context instance type directly https://review.opendev.org/c/openstack/castellan/+/975375 | 14:59 |
| opendevreview | Takashi Kajinami proposed openstack/castellan master: barbican: Pass down domain/system scope https://review.opendev.org/c/openstack/castellan/+/975376 | 14:59 |
| frickler | tkajinam: isn't that what https://review.opendev.org/c/openstack/oslo.service/+/977241 is supposed to fix? | 15:01 |
| tkajinam | frickler, yes it "fixed" but eventually all services use fork context | 15:01 |
| tkajinam | that _select_service_manager_context was added to use spawn context where it can be used, but spawn context may be never used due to conf instance not picklable | 15:03 |
| opendevreview | Merged openstack/castellan master: tox: Fix missing functional-vault-py310 env https://review.opendev.org/c/openstack/castellan/+/977678 | 15:44 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Fix remaining access to [cache] memcache_username/password https://review.opendev.org/c/openstack/oslo.cache/+/977687 | 15:46 |
| opendevreview | Takashi Kajinami proposed openstack/castellan stable/2025.2: tox: Fix missing functional-vault-py310 env https://review.opendev.org/c/openstack/castellan/+/977688 | 15:52 |
| opendevreview | Merged openstack/castellan master: Move vault functional tests to noble https://review.opendev.org/c/openstack/castellan/+/977681 | 15:56 |
| cardoe | tkajinam: https://review.opendev.org/c/openstack/oslo.utils/+/977568 you mind looking at that since I know you're really good at looking at technical Python-y things? | 15:57 |
| opendevreview | Merged openstack/castellan master: Use more explicit import https://review.opendev.org/c/openstack/castellan/+/975399 | 16:08 |
| opendevreview | Merged openstack/castellan master: Bump vault used in tests https://review.opendev.org/c/openstack/castellan/+/975135 | 16:10 |
| gmaan | tkajinam: yes that change fixed it and release 4.5.1 will be ok. and yes until oslo.cofig is not picklable, services will be using 'fork' method which is same as before. to start using spawn, oslo.config as well services must be picklable | 16:11 |
| opendevreview | Merged openstack/futurist master: Remove MANIFEST.in https://review.opendev.org/c/openstack/futurist/+/975980 | 16:12 |
| gmaan | ralonsoh: you mentioned about nova cpu also in this, is there any failureI missed to check https://review.opendev.org/c/openstack/requirements/+/977691 | 16:17 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: Refactor force_reraise https://review.opendev.org/c/openstack/oslo.utils/+/977692 | 16:26 |
| tkajinam | cardoe, I'll recheck it once CI post results but it looks good to me... though I'm wondering if we can refactor the method a bit ^^^ to avoid duplicating same error message | 16:27 |
| tkajinam | gmaan, ok so that's what needs to be addressed during next cycle, right ? | 16:29 |
| tkajinam | I just want to make sure that won't be abandoned in the current incomplete status with that noisy warning always appearing. | 16:29 |
| gmaan | tkajinam: I am not sure as someone should be working on that. as you know 'fork' is deprecated one and might be removed in future. spawn is not going to be default so it will not break us at least in near future | 16:31 |
| gmaan | but if spawn can work then this is the end goal for threading mdoe | 16:31 |
| gmaan | tkajinam: I think damani[m] idea was to provide the interface to use spawn and projects start fixing and using it. I do not think it was 100% workable in current implementation of services and oslo.config | 16:32 |
| opendevreview | Merged openstack/castellan master: Check context instance type directly https://review.opendev.org/c/openstack/castellan/+/975375 | 16:32 |
| opendevreview | Merged openstack/castellan master: barbican: Pass down domain/system scope https://review.opendev.org/c/openstack/castellan/+/975376 | 16:32 |
| opendevreview | Merged openstack/castellan master: barbican: Drop redundant full url composition https://review.opendev.org/c/openstack/castellan/+/975497 | 16:32 |
| tkajinam | ok | 16:33 |
| gmaan | we just need to make sure oslo.service does not use the spawn if servies are not yet ready | 16:33 |
| gmaan | and that was the bug where oslo.service was selecting spawn even service instance and oslo.config used in that service instance was not ready | 16:33 |
| tkajinam | I probably have to talk with damani[m] about his next plan. | 16:35 |
| tkajinam | honestly speaking I feel like we've been doing too many break-and-fix-partially stuff regarding threading for some time and I'm a bit lost about the goal | 16:36 |
| tkajinam | that fallback, effectively voiding the context selection, is one of these | 16:37 |
| opendevreview | Merged openstack/oslo.cache master: Fix remaining access to [cache] memcache_username/password https://review.opendev.org/c/openstack/oslo.cache/+/977687 | 20:24 |
| *** Callum0270 is now known as Callum027 | 20:42 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!