| opendevreview | Merged openstack/oslo.utils master: Refactor force_reraise https://review.opendev.org/c/openstack/oslo.utils/+/977692 | 00:08 |
|---|---|---|
| opendevreview | Merged openstack/oslo.db master: Fix unit test failure with SQLAlchemy 2.1 https://review.opendev.org/c/openstack/oslo.db/+/977543 | 00:11 |
| opendevreview | Merged openstack/oslo.cache master: Replace remaining usage of deprecated options https://review.opendev.org/c/openstack/oslo.cache/+/977492 | 00:25 |
| opendevreview | Merged openstack/oslo.cache stable/2025.2: Fix type mismatch https://review.opendev.org/c/openstack/oslo.cache/+/975045 | 00:25 |
| opendevreview | Merged openstack/oslo.db master: Replace usage of undocumented logging.WARN https://review.opendev.org/c/openstack/oslo.db/+/977532 | 00:37 |
| opendevreview | Merged openstack/oslo.context master: Parse domain_name header https://review.opendev.org/c/openstack/oslo.context/+/975377 | 00:44 |
| opendevreview | Merged openstack/oslo.policy master: Replace usage of undocumented logging.WARN https://review.opendev.org/c/openstack/oslo.policy/+/977533 | 00:52 |
| opendevreview | Merged openstack/taskflow master: Add Gelera specific error code for connection retries https://review.opendev.org/c/openstack/taskflow/+/977549 | 00:55 |
| opendevreview | Merged openstack/oslo.config master: Replace usage of undocumented logging.WARN https://review.opendev.org/c/openstack/oslo.config/+/977531 | 00:57 |
| opendevreview | Merged openstack/oslo.messaging master: Replace deprecated datetime.datetime.utcnow https://review.opendev.org/c/openstack/oslo.messaging/+/977422 | 01:01 |
| opendevreview | Merged openstack/taskflow master: Create separate dependency group per database backend https://review.opendev.org/c/openstack/taskflow/+/977550 | 01:03 |
| opendevreview | Merged openstack/osprofiler master: Replace deprecated datetime.datetime.utcnow https://review.opendev.org/c/openstack/osprofiler/+/977423 | 01:08 |
| tkajinam | os_api_ref/tests/base.py:129:9: error: Value of type variable "UseFixtureT" of "useFixture" of "TestCase" cannot be "Timeout" [type-var] | 13:57 |
| tkajinam | os_api_ref/tests/base.py:130:9: error: Value of type variable "UseFixtureT" of "useFixture" of "TestCase" cannot be "OutputStreamCapture" [type-var] | 13:57 |
| tkajinam | hmm | 13:57 |
| dansmith | stephenfin: on the ContainerFileInspector patch, are you opposed to that being a patch on its own before anything uses it in the later patches (re: your "nothing is setting _inner_format" comment)? | 15:31 |
| stephenfin | dansmith: nope, I just missed the _inner_format usage in the next patch (I did look) | 20:15 |
| dansmith | stephenfin: okay cool, and .. is the *args complaint because it messes up the typing or something? I think it's a fairly common pattern for hooking | 20:16 |
| dansmith | I can make it explicit (and then change it again in the next patch), I'm just wondering if that's preference or some actual reason | 20:18 |
| stephenfin | yeah, type checking. if you change it to `*args, **kwargs` you lose the ability to have mypy/ty/pyre/... catch invalid stuff | 20:20 |
| dansmith | okay | 20:21 |
| stephenfin | before you ask, I'm fine with `data` in the next patch too. I was hoping it was a limited list but if that's not going to be the case, we're going to need something fairly free form | 20:21 |
| dansmith | ack :) | 20:21 |
| stephenfin | we could do a mapping of formats to parameters for same (rather than a flat list and format prefixes) but I guess that won't work if the same param works for multiple formats | 20:22 |
| stephenfin | (as in dict[str, dict[str, str]]) | 20:22 |
| stephenfin | tkajinam: looks like my patch to bump testtools merged....and some of their hints are wrong | 20:23 |
| dansmith | yeah, I'd really like it if I didn't have to do the data thing at all, but we need to decrypt the key as soon as we have it so we can know what block of data to grab (and potentially later blocks for the inner format) we kinda need to have it upfront | 20:24 |
| dansmith | s/we have it/we have the LUKS header | 20:24 |
| dansmith | stephenfin: while I have you, completely unrelated... | 20:25 |
| dansmith | I've been manually hacking tox.ini to run coverage on functional tests .. is there some reason we can't/don't just change that globally to run on all the tests? | 20:26 |
| dansmith | (I assume you're the (or a) primary opinion-holder here) | 20:26 |
| stephenfin | no reason: melwitt actually has a patch up to do that for nova you might want to hit https://review.opendev.org/c/openstack/nova/+/975346 | 20:27 |
| dansmith | aha, nice.. I have been heckling her for a few missed coverage things by doing said local hack, so I'd have assumed that was why she was proposing it, if not for the other justification | 20:28 |
| melwitt | haha yeah I found the same thing lately a lot of code coverage is coming from func tests only so I was thinking we should include them in coverage. I am concerned that I didn't pick a high enough job timeout on that though | 20:28 |
| dansmith | melwitt: yeah, a couple times recently I've pecked out a gerrit comment of "you're not testing this" and then realized "well, maybe she is" and ran locally | 20:29 |
| melwitt | it actually came out biggest for me recently on a unified limits fix I was working on, showed really low code coverage bc almost all unified limits tests are func tests | 20:29 |
| dansmith | melwitt: so that runs unit and then functional and then generates the report? | 20:30 |
| melwitt | yeah. it's pretty slow though and I wasn't sure if someone like stephenfin might know some trick to make it faster | 20:30 |
| dansmith | I shall do the same in glance | 20:31 |
| melwitt | the .stestr.conf has a default to run unit tests, that's how that has been done | 20:31 |
| dansmith | right | 20:32 |
| melwitt | so I just left that alone and added a line to run func tests to the testenv:cover itself | 20:32 |
| dansmith | yeah I didn't see a good way to do that otherwise, which is why I didn't propose a change, but I guess I didn't think about two separate runs adding to the same report | 20:33 |
| stephenfin | melwitt: Not yet. I know the test I have to verify the schema coverage is slow (sean-k-mooney has complained about it more than once), but I think tacking on coverage just makes _everything_ slower | 20:33 |
| stephenfin | that's the one I've been seeing timeout but I _think_ it's just an artifact of being the longest-running test and most likely to get caught by the closing door | 20:34 |
| stephenfin | *unit test | 20:34 |
| melwitt | yeah, that's kinda what I found in googling is just, coverage adds a lot of overhead period | 20:34 |
| stephenfin | dansmith: you should also be able to just pass `--test-path ./glance/tests` to stestr | 20:34 |
| sean-k-mooney | stephenfin: i have forgoten if i have | 20:34 |
| dansmith | stephenfin: yeah that's the local hack I was doing | 20:35 |
| sean-k-mooney | maybe i rased it once or twice a while ago | 20:35 |
| stephenfin | once there's an __init__.py in the tests dir, stestr will do discovery just fine | 20:35 |
| stephenfin | ack | 20:35 |
| melwitt | I'm gonna apply your suggested edit stephenfin | 20:38 |
| stephenfin | melwitt: maybe do it in a follow-up? idk if that exclude regex needs updating if we also include unit tests | 20:39 |
| dansmith | yeah, seems better in the nova case to re-use the commands from the other env | 20:40 |
| melwitt | oh. oops | 20:40 |
| dansmith | glance doesn't have any to skip that I know of, so it's simpler | 20:40 |
| stephenfin | doing it in one run would definitely be faster since stestr doesn't need to collect tests a second time (and python startup time is slow) | 20:41 |
| stephenfin | but like I said, it's probably minimal compared to general run time | 20:41 |
| stephenfin | *as a proportion of total run time | 20:41 |
| melwitt | it might be better to include the functional db tests though. api and notification samples are safer to exclude I think i.e. probably don't bring much coverage value | 20:44 |
| stephenfin | melwitt: definitely one to debate in a follow-up | 20:47 |
| stephenfin | :) | 20:47 |
| stephenfin | tkajinam: https://github.com/testing-cabal/testtools/pull/574 | 20:49 |
| melwitt | stephenfin: hm, it looks like there might be something bad about running unit and func concurrently, lots of weird errors https://review.opendev.org/c/openstack/nova/+/975346 so I'm gonna revert back to PS1 | 23:34 |
| melwitt | *PS2 | 23:35 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!