| opendevreview | Takashi Kajinami proposed openstack/oslo.messaging master: Declare Python 3.15 support https://review.opendev.org/c/openstack/oslo.messaging/+/1007382 | 00:53 |
|---|---|---|
| tkajinam | stephenfin, do you have any idea about the magic to fix the misc error seen in https://zuul.opendev.org/t/openstack/build/d29f2c35bf95488c91a5847b00d55f27 ? | 01:06 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: DevStack plugin, CI and docs https://review.opendev.org/c/openstack/oslo.messaging/+/1007624 | 02:18 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: interop with the original driver https://review.opendev.org/c/openstack/oslo.messaging/+/1007625 | 02:18 |
| opendevreview | Merged openstack/oslo.messaging stable/2026.1: Fix rabbit consumer reconnection loop https://review.opendev.org/c/openstack/oslo.messaging/+/1006763 | 02:50 |
| opendevreview | Merged openstack/oslo.messaging master: Make python 3.15 jov non-voting https://review.opendev.org/c/openstack/oslo.messaging/+/1007498 | 02:50 |
| opendevreview | Merged openstack/oslo.messaging master: Declare Python 3.15 support https://review.opendev.org/c/openstack/oslo.messaging/+/1007382 | 04:02 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: wire protocol and client https://review.opendev.org/c/openstack/oslo.messaging/+/1007621 | 06:47 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: server side and entry point https://review.opendev.org/c/openstack/oslo.messaging/+/1007622 | 06:47 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: fanout broadcaster https://review.opendev.org/c/openstack/oslo.messaging/+/1007623 | 06:47 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: DevStack plugin, CI and docs https://review.opendev.org/c/openstack/oslo.messaging/+/1007624 | 06:47 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: interop with the original driver https://review.opendev.org/c/openstack/oslo.messaging/+/1007625 | 06:47 |
| stephenfin | tkajinam: Looks like you figured it out 💪 | 08:59 |
| tkajinam | yeah but I don't fully understand why we get that type error, even after reading your typing update in testscenarios ... | 09:38 |
| opendevreview | Stephen Finucane proposed openstack/oslo.privsep master: pre-commit: Bump versions https://review.opendev.org/c/openstack/oslo.privsep/+/1008030 | 09:47 |
| opendevreview | Stephen Finucane proposed openstack/oslo.privsep master: typing: Propagate return types through decorators https://review.opendev.org/c/openstack/oslo.privsep/+/1008031 | 09:47 |
| opendevreview | Stephen Finucane proposed openstack/oslo.privsep master: typing: Propagate parameter types through entrypoint decorator https://review.opendev.org/c/openstack/oslo.privsep/+/1008032 | 09:47 |
| opendevreview | Stephen Finucane proposed openstack/oslo.privsep master: typing: Tighten type annotations in priv_context https://review.opendev.org/c/openstack/oslo.privsep/+/1008033 | 09:47 |
| stephenfin | tkajinam: It would have been triggered by the addition of py.typed file. Without that, the base class would have been typed to Any so attribute access wouldn't have been checked | 10:50 |
| tkajinam | ok | 10:53 |
| tkajinam | even with that in my mind it's not clear what's the difference mypy is complaining, though | 10:54 |
| tkajinam | anyway we can ignore that completely once your patch to get rid of testscenarios is merged | 10:54 |
| tkajinam | maybe we can replace it fully by ddt nowadays | 10:54 |
| stephenfin | Well I also don't like ddt 😅 and it's not typed so you'll end up with functions being typed as Any. I've been using self.subTest lately | 11:03 |
| stephenfin | tkajinam: Note the difference in the type of `result` and the return type between these two signatures | 11:04 |
| stephenfin | https://github.com/testing-cabal/testtools/blob/088c98e24961ecf6d94ea5204457f2dcffe2f1c6/testtools/testcase.py#L896 | 11:04 |
| stephenfin | https://github.com/testing-cabal/testscenarios/blob/5eeab1702eaaeaecd05346ae098b37ccc9d25dba/testscenarios/testcase.py#L70-L72 | 11:05 |
| stephenfin | The closest we could get is to make `WithScenarios` generic (meaning you'd use it like `WithScenarios[testtools.TestResult]`) but that still wouldn't have fixed the potential nullability of the return type, which would never happen with the testtools.TestCase.run implementation | 11:07 |
| stephenfin | Oh, interesting: I think the type of testtools.TestCase is wrong | 11:09 |
| stephenfin | https://github.com/python/typeshed/blob/c981c922a32f74c0f4717b038d4dbb1ac11170ad/stdlib/unittest/case.pyi#L91 | 11:09 |
| tkajinam | oh I didn't check testtools | 12:52 |
| tkajinam | so the typing information from core python indicates that allowing None is correct though the doc says run should return an return object always since python 3.3 | 12:53 |
| tkajinam | s/an return object/a result object/ | 12:53 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Document multiprocessing spawn strategy https://review.opendev.org/c/openstack/oslo.service/+/1006180 | 13:49 |
| opendevreview | Elod Illes proposed openstack/openstack-doc-tools master: Add 2026.2 Hibiscus to maintained series https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008075 | 14:47 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Install libzstd https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008080 | 15:17 |
| tkajinam | hopefully this fixes py314 job in doc-tools... | 15:17 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Bump test tools https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008083 | 15:30 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Bump test tools https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008083 | 15:31 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Enable testing with Python 3.15. https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008084 | 15:33 |
| stephenfin | tkajinam: yes, exactly. I proposed a fix for testtools earlier https://github.com/testing-cabal/testtools/pull/636 | 15:39 |
| stephenfin | though you will still have a type conflict since testtools use a different type of TestResult to unittest | 15:39 |
| tkajinam | stephenfin, thanks, and ok. that's a bit annoying :-( | 15:40 |
| stephenfin | As I noted above, we would need to make `WithScenarios` generic to properly fix this. `WithScenarios[testtools.TestResult]` is a bit heavy though 😅 | 15:41 |
| stephenfin | easier to just get rid of it, if you ask me :) | 15:41 |
| tkajinam | that's not urgent but we may eventually do it if we keep seeing the same type errors | 15:43 |
| tkajinam | (and I'm afraid we do soon... | 15:43 |
| opendevreview | Elod Illes proposed openstack/openstack-doc-tools master: Add 2026.2 Hibiscus to maintained series https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008075 | 15:46 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Install libzstd https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008080 | 15:47 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Bump test tools https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008083 | 15:47 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Enable testing with Python 3.15. https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008084 | 15:47 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Install libzstd https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008080 | 16:02 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Bump test tools https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008083 | 16:09 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Enable testing with Python 3.15. https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008084 | 16:09 |
| opendevreview | Merged openstack/openstack-doc-tools master: Install libzstd https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008080 | 16:15 |
| opendevreview | Merged openstack/openstack-doc-tools master: Bump test tools https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008083 | 16:24 |
| opendevreview | Merged openstack/openstack-doc-tools master: Enable testing with Python 3.15. https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008084 | 16:35 |
| opendevreview | Takashi Kajinami proposed openstack/openstack-doc-tools master: Adapt to recent scrapy https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008100 | 17:15 |
| tkajinam | elodilles, https://review.opendev.org/c/openstack/openstack-doc-tools/+/1008100 worked in my env but it'd be nice if you can try that in your env, too, when you have time. | 17:59 |
| tkajinam | (I don't yet fully understand the expected output from the tool, tbh | 18:00 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!