| rm_work | amorin: Was this to me or someone else, I can’t tell heh | 01:19 |
|---|---|---|
| rm_work | ah prolly to Stephen | 01:33 |
| rm_work | Speaking of stephenfin, you might be the one to give a second look at https://review.opendev.org/c/openstack/tooz/+/1007408 ? | 01:34 |
| rm_work | Huge performance gains / avoids some stalls, in my benchmarking | 01:35 |
| rm_work | We’re using it internally because now we use Redis as our backend for oslo RPC with HTTP-RPC so we really tax it a bit 😅 | 01:36 |
| rm_work | I think https://review.opendev.org/c/openstack/oslo.service/+/1012821 is close too, tkajinam hopefully you’re good with it now? | 01:44 |
| opendevreview | Merged openstack/oslo.service master: Threading backend: fix more no_fork exit hangs https://review.opendev.org/c/openstack/oslo.service/+/1012821 | 02:57 |
| *** mhen_ is now known as mhen | 02:59 | |
| opendevreview | Adam Harwell proposed openstack/oslo.service stable/2026.2: Threading backend: reload on SIGHUP with no_fork https://review.opendev.org/c/openstack/oslo.service/+/1015531 | 06:08 |
| opendevreview | Adam Harwell proposed openstack/oslo.service stable/2026.2: Threading backend: fix more no_fork exit hangs https://review.opendev.org/c/openstack/oslo.service/+/1015532 | 06:08 |
| rm_work | ^^ so there’s the backports… I’m not sure if both of those are going to be acceptable as backports tho so I made them WIP and we can discuss? | 06:09 |
| rm_work | It would be nice for me because I run 2026.2 in my deployment so I could drop the two manual patches, but also my CI is already handling it so it isn’t too bad | 06:10 |
| rm_work | Both are on top of https://review.opendev.org/c/openstack/oslo.service/+/1013546 which I guess still needs a +2/+W as well | 06:14 |
| rm_work | Claude seems to think 1015531 might be at risk of being considered “change in behavior” even though the behavior it changes was a bug 🫠 | 06:24 |
| amorin | rm_work , yes I was answering to stephenfin :) About your work on http driver, I tested long time ago, that a huge work as well, I wish I can find time to check this again soon! | 07:13 |
| *** ralonsoh_ooo is now known as ralonsoh | 07:39 | |
| opendevreview | Luca Miccini proposed openstack/oslo.cache master: Honor socket_timeout and dead_retry in the bmemcached pool https://review.opendev.org/c/openstack/oslo.cache/+/1015543 | 09:29 |
| opendevreview | Adam Harwell proposed openstack/oslo.service stable/2026.2: Ensure spawn pool workers have logging configured https://review.opendev.org/c/openstack/oslo.service/+/1015545 | 09:40 |
| opendevreview | Adam Harwell proposed openstack/oslo.service stable/2026.2: Threading backend: reload on SIGHUP with no_fork https://review.opendev.org/c/openstack/oslo.service/+/1015531 | 09:40 |
| opendevreview | Adam Harwell proposed openstack/oslo.service stable/2026.2: Threading backend: fix more no_fork exit hangs https://review.opendev.org/c/openstack/oslo.service/+/1015532 | 09:40 |
| rm_work | ^^ needed that first one for tests to work… idk hopefully it is backportable too | 09:41 |
| opendevreview | Luca Miccini proposed openstack/oslo.cache master: Honor socket_timeout and dead_retry in the bmemcached pool https://review.opendev.org/c/openstack/oslo.cache/+/1015543 | 10:24 |
| stephenfin | gmaan: I was coming here to suggest we talk about this synchronously (timezones, eh?) 😂 | 10:54 |
| stephenfin | gmaan: They don't need to go together, no. I'm happy to try just removing the dependencies for now (assuming hberaud and damani are too). | 10:55 |
| stephenfin | gmaan: Okay, left a comment on the change. I'm happy to merge (and release) the rest of the stack. We can continue to discuss the change in backend and either merge or abandon that later | 11:11 |
| rm_work | Wheeeee | 11:25 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: tooz service discovery https://review.opendev.org/c/openstack/oslo.messaging/+/1007620 | 11:25 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: wire protocol and client https://review.opendev.org/c/openstack/oslo.messaging/+/1007621 | 11:25 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: server side and entry point https://review.opendev.org/c/openstack/oslo.messaging/+/1007622 | 11:25 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: fanout broadcaster https://review.opendev.org/c/openstack/oslo.messaging/+/1007623 | 11:25 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: DevStack plugin, CI and docs https://review.opendev.org/c/openstack/oslo.messaging/+/1007624 | 11:25 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: oslo.metrics counters https://review.opendev.org/c/openstack/oslo.messaging/+/1011115 | 11:25 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: HTTP-RPC driver: interop with the original driver https://review.opendev.org/c/openstack/oslo.messaging/+/1007625 | 11:25 |
| rm_work | Had to rebase everything just to add a metrics job in patch 6 lol | 11:26 |
| stephenfin | rm_work: some follow-up requests on https://review.opendev.org/c/openstack/tooz/+/1007408 | 11:27 |
| rm_work | Will look thanks! 🙏 | 11:28 |
| rm_work | Ugh yeah I need to make a note that I should do a better job of humanizing some of those release notes. That particular one I read and understood so I mostly left it, but maybe I only understand it because I spent the time working on the fix, lol | 11:32 |
| rm_work | I’ll word up a better follow up (your text also looks right to me pretty much, but let me poke at it) | 11:33 |
| rm_work | The type annotation thing I kind of threw up my hands on but maybe it’s possible to make it a bit better… have you poked the project folks about your patch in a while? I find you pretty much have to stay on top of people or they assume you don’t actually care and move on 🥲 | 11:35 |
| stephenfin | rm_work: larger request on https://review.opendev.org/c/openstack/tooz/+/1007940 too | 11:45 |
| stephenfin | on the redis-py type annotation thing: I haven't pushed. Redis (i.e. the company, formerly Redis Labs) make enough money that they should be able to push on this stuff themselves 😅 | 11:47 |
| stephenfin | (I have a much larger stack of changes locally too, but not point pushing that if I can get the existing smaller stack in. Anyway...) | 11:48 |
| rm_work | On the casts, should I fix just the ones I added, or just fix all of them in this file | 12:26 |
| rm_work | I think I’ll just fix them all | 12:26 |
| opendevreview | Adam Harwell proposed openstack/tooz master: redis: Follow-ups to group reads without WATCH https://review.opendev.org/c/openstack/tooz/+/1015573 | 12:32 |
| opendevreview | Adam Harwell proposed openstack/tooz master: redis: Follow-ups to group reads without WATCH https://review.opendev.org/c/openstack/tooz/+/1015573 | 12:42 |
| opendevreview | Adam Harwell proposed openstack/tooz master: redis: Follow-ups to group reads without WATCH https://review.opendev.org/c/openstack/tooz/+/1015573 | 12:49 |
| rm_work | Ok I think it’s good now | 12:49 |
| rm_work | Oh lol I should have looked at the other CR first, forgot it removed a bunch of these | 12:52 |
| rm_work | I’ll move it to the end | 12:55 |
| opendevreview | Merged openstack/tooz master: redis: Read groups without WATCH https://review.opendev.org/c/openstack/tooz/+/1007408 | 13:08 |
| opendevreview | Adam Harwell proposed openstack/tooz master: redis: Retry operations in one bounded layer https://review.opendev.org/c/openstack/tooz/+/1007940 | 13:16 |
| opendevreview | Adam Harwell proposed openstack/tooz master: redis: Follow-ups to group reads without WATCH https://review.opendev.org/c/openstack/tooz/+/1015573 | 13:16 |
| rm_work | OK here we go | 13:16 |
| opendevreview | Adam Harwell proposed openstack/tooz master: redis: Recover after primary role changes https://review.opendev.org/c/openstack/tooz/+/1003880 | 13:16 |
| rm_work | Moved them around a bit and did the decorator thing, though it hilariously immediately changes | 13:17 |
| rm_work | Will need a re-review from you on… we’ll all of them, but one of them lost a +2 because I had to move and tweak it | 13:19 |
| rm_work | *well, all of them | 13:19 |
| gmaan | stephenfin: works for me, checking the reviews. give me some time | 15:55 |
| opendevreview | Takashi Kajinami proposed openstack/tooz master: Use FileNotFoundError to detect missing file https://review.opendev.org/c/openstack/tooz/+/1015375 | 15:59 |
| gmaan | stephenfin: done, I will wait for Daniel response otherwise will workflow next week | 16:04 |
| gmaan | and we can continue discussion on default backend independently. removing default installation first can be good and we might get projects input if it is ok for them and keeping eventlet as default at least till it is removed. we can proceed accordingly | 16:06 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly while we reboot for system updates, but should return within a few minutes. | 17:42 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!