| *** mhen_ is now known as mhen | 02:53 | |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: backend: Clarify dependency errors and Eventlet migration https://review.opendev.org/c/openstack/oslo.service/+/1016449 | 10:37 |
|---|---|---|
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: backend: Clarify extras and warn on Eventlet use https://review.opendev.org/c/openstack/oslo.service/+/1016449 | 10:39 |
| elodilles | hi Oslo team o/ it seems that oslo.db breaks a couple of projects' cross job: https://review.opendev.org/c/openstack/requirements/+/1016323 | 12:25 |
| elodilles | it seems that the patch that introduced the breaking change is: https://review.opendev.org/c/openstack/oslo.db/+/1012550 | 12:26 |
| elodilles | at least that is the only change that touches something related to timestamps o:) | 12:28 |
| elodilles | any idea for the way forward? | 12:28 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: kafka: Start a new pool's group at the latest notification https://review.opendev.org/c/openstack/oslo.messaging/+/1016466 | 12:29 |
| rm_work | ^^ ran into this after the change to the kafka join mode, still testing in my cloud, so WIP for now | 12:30 |
| elodilles | furthermore, oslo.service also causing some cross jobs to fail. https://review.opendev.org/c/openstack/requirements/+/1016352 cross jobs try to initialize eventlet, but eventlet isn't installed | 12:32 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: kafka: Start a new pool's group at the latest notification https://review.opendev.org/c/openstack/oslo.messaging/+/1016466 | 12:34 |
| opendevreview | Adam Harwell proposed openstack/oslo.messaging master: kafka: Start a new pool's group at the latest notification https://review.opendev.org/c/openstack/oslo.messaging/+/1016466 | 12:50 |
| tkajinam | elodilles, hmm so these three follows the same patter in the way how they mock timeutils and assert updated_at and we probably have to fix their patching method | 14:16 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.db master: Revert "Replace unnecessary lambda expression" https://review.opendev.org/c/openstack/oslo.db/+/1016484 | 14:41 |
| tkajinam | I really don't like the fact we end up with using lambda there but probably just reverting the change is the fastest path without undesired effort... | 14:41 |
| tkajinam | alternatively we could use time fixture but that was deprecated :-( | 14:42 |
| tkajinam | (idk why the deprecation was desired, though | 14:42 |
| elodilles | tkajinam: i don't know whether revert is necessary, haven't checked, but if the projets are using oslo.db library in the wrong way, then maybe fixing the usage in projects is better. we are early in the cycle, so probably no need to rush like if we would discover this at final release day o:) | 15:07 |
| tkajinam | elodilles, it's a bit tricky. these projects are using oslo.db in a correct way. the problem is related to their tests which attempts to patch and assert timestamp update which is actually implemented in oslo.db. | 15:15 |
| tkajinam | replacing a lambda is not needed for its functionality but its just a known best practice and it may not important enough to require "fixing" 20+ unit tests ... | 15:20 |
| tkajinam | and I don't want requirement bump stuck for such thing | 15:21 |
| tkajinam | I'll merge that revert and create a new release | 15:21 |
| tkajinam | stephenfin gmaan, it seems making eventlet optional broke oslo.messaging in services without eventlet ... https://zuul.opendev.org/t/openstack/build/66f58d3e4b334880af2bc9e10e8e86a6 | 15:31 |
| tkajinam | oh wait this is probably what we just need https://review.opendev.org/c/openstack/oslo.messaging/+/1013535 | 15:34 |
| elodilles | tkajinam: ACK, thanks for working on it o/ | 16:05 |
| rm_work | When events is finally and fully dead we can have a nice party 🥹 | 16:15 |
| rm_work | *eventlet | 16:15 |
| gmaan | elodilles: tkajinam yeah, we already had fix on oslo.messaging merged before we merged eventlet options things | 16:27 |
| gmaan | I think we just need to release it | 16:28 |
| gmaan | elodilles: confirmed that oslo.messasging 18.4.0 already has that fix, we just need to get the 18.4.0 in uc. | 16:42 |
| elodilles | gmaan: ah, good to know. thanks o/ as i see it got stuck at the release pipeline :S https://zuul.opendev.org/t/openstack/status?pipeline=release | 17:01 |
| gmaan | elodilles: k | 17:02 |
| elodilles | zuul is a bit overloaded i guess. jobs are waiting in the queues waiting for nodes | 17:02 |
| elodilles | it's in the queue 4,5 hrs already O.o | 17:02 |
| elodilles | oh, nice, it just got worker nodes \o/ | 17:03 |
| gmaan | cool | 17:03 |
| elodilles | i'll take a look for the update-constraints patch later on today (or early morning if i won't forget :X) and approve it if the cross jobs are passing | 17:04 |
| gmaan | thanks, I will keep monitoring it as my day just started and will rebase oslo.policy uc one on top of it to see the result of btho | 17:06 |
| elodilles | +1 | 17:06 |
| rm_work | so this fix: https://review.opendev.org/c/openstack/oslo.messaging/+/1016466 would be nice to get I think in 18.4.1 | 17:26 |
| rm_work | I think the issue SHOULDN'T be noticeable for anyone besides me (HTTP-RPC), and possibly networking-baremetal and Watcher very minorly (though I think it's not really breaking for them, just non-ideal) | 17:26 |
| rm_work | missed that case | 17:27 |
| opendevreview | Merged openstack/oslo.service master: backend: Clarify extras and warn on Eventlet use https://review.opendev.org/c/openstack/oslo.service/+/1016449 | 18:18 |
| opendevreview | Merged openstack/oslo.messaging master: Add functools.wraps to expected_exceptions https://review.opendev.org/c/openstack/oslo.messaging/+/1016389 | 18:20 |
| stephenfin | elodilles: tkajinam: I missed the discussion on oslo.db earlier. I had started working on fixes for services, but a revert might make sense too | 18:25 |
| stephenfin | example: https://review.opendev.org/c/openstack/ironic/+/1016538 | 18:25 |
| opendevreview | Merged openstack/oslo.messaging master: Add types for server decorators https://review.opendev.org/c/openstack/oslo.messaging/+/1016390 | 18:43 |
| opendevreview | Stephen Finucane proposed openstack/pbr master: Restore Git-backed package data in pyproject-only builds https://review.opendev.org/c/openstack/pbr/+/1016551 | 18:51 |
| *** haleyb is now known as haleyb|out | 23:27 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!