| archanaserver | Hi @vkmc, good morning o/ | 06:26 |
|---|---|---|
| archanaserver | my blog post update: | 07:40 |
| archanaserver | introduction blog: https://archanaserver.in/2021-06-05-outreachy-introduce-yourself/ | 07:40 |
| archanaserver | week 2 blog: https://archanaserver.in/2021-06-07-week-02-outreachy-internship-with-openstack/ | 07:40 |
| vkmc | archanaserver, o/ | 11:26 |
| vkmc | just reviewed your patch | 11:26 |
| vkmc | https://review.opendev.org/c/openstack/python-manilaclient/+/789018 | 11:26 |
| vkmc | you are getting closer | 11:26 |
| archanaserver | followed your review and added the @ddt decorator, when i do so i'm getting this error again http://paste.openstack.org/show/806370/ even though i fixed the string issue that i face on friday | 13:28 |
| vkmc | ok | 13:35 |
| vkmc | let's see what's wrong | 13:35 |
| archanaserver | yes sure | 13:40 |
| vkmc | ok so, a quick view shows you are not creating the fake share group | 13:50 |
| vkmc | share_group_to_delete is a string | 13:51 |
| vkmc | you need to create the fake share group and pass that string as the name | 13:51 |
| vkmc | you have two ways to do so | 13:58 |
| vkmc | for example, for the share_types test | 13:58 |
| vkmc | https://github.com/openstack/python-manilaclient/blob/master/manilaclient/tests/unit/v2/test_shell.py#L3453-L3471 | 13:58 |
| vkmc | fake_share_types = [ | 13:58 |
| vkmc | share_types.ShareType('fake', {'id': type_id}, True) | 13:58 |
| vkmc | for type_id in type_ids | 13:58 |
| vkmc | ] | 13:58 |
| vkmc | that for loop is calling share_types | 13:58 |
| vkmc | which is the class being imported in https://github.com/openstack/python-manilaclient/blob/master/manilaclient/tests/unit/v2/test_shell.py#L43 | 13:59 |
| vkmc | and creating the fake using the type_id provided as param | 13:59 |
| vkmc | one option, is that you import the share_groups class and create the fakes in that fashion | 13:59 |
| vkmc | the other option | 14:00 |
| vkmc | is that you create a single object, as we were doing originally | 14:00 |
| vkmc | https://github.com/openstack/python-manilaclient/blob/master/manilaclient/tests/unit/v2/test_shell.py#L953 | 14:01 |
| vkmc | like this | 14:01 |
| vkmc | you can do either of those | 14:01 |
| *** kafilat has joined #openstack-outreachy | 14:29 | |
| kafilat | Hi vkmc, I've reviewed Ashley's patch | 14:29 |
| kafilat | I have a question about Manila cli | 14:29 |
| vkmc | hi kafilat! | 14:29 |
| vkmc | nicely done | 14:30 |
| vkmc | sure, what's up? | 14:30 |
| kafilat | What is "tenant-name" "tenant-id" etc | 14:30 |
| vkmc | project-name, project-id | 14:31 |
| vkmc | is the legacy name | 14:31 |
| kafilat | http://paste.openstack.org/show/806423/ | 14:33 |
| kafilat | Oh okay | 14:33 |
| kafilat | Do I need to specify it each time to use the cli? | 14:35 |
| vkmc | you can define the environment variables with that information | 14:35 |
| vkmc | if you are using devstack | 14:35 |
| vkmc | you can source the openrc file and that should be enough | 14:36 |
| vkmc | (in other words, execute "source openrc admin admin" in your devstack folder | 14:36 |
| vkmc | ) | 14:36 |
| vkmc | let me know if that works | 14:36 |
| kafilat | Okay. I'm going to try that | 14:36 |
| kafilat | Thanks! | 14:36 |
| vkmc | cool! | 14:38 |
| vkmc | anytime | 14:38 |
| archanaserver | Hi Vicky, thank you. Will work on the fix after the bug squash meeting :) and will let you know the result | 14:49 |
| vkmc | cool! | 14:57 |
| vkmc | archanaserver, thanks for joining the bug squash and thanks for accepting to work on that bug! | 16:09 |
| archanaserver | it's my pleasure to take part in bug squash :) | 16:12 |
| archanaserver | am i going to work on that bug parallelly with the fix i'm working on right now? | 16:14 |
| archanaserver | also thank you for mentioning me there | 16:16 |
| archanaserver | :) | 16:16 |
| kafilat | Thanks vkmc, it worked! | 17:07 |
| archanaserver | what is this line mean here https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L5521-L5524 | 18:52 |
| archanaserver | what this is doing? | 18:52 |
| *** kafilat has quit IRC | 19:47 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!