| archanaserver | hi vkmc | 10:15 |
|---|---|---|
| archanaserver | i'm getting this error in 21 case http://paste.openstack.org/show/806622/ | 10:17 |
| archanaserver | after removing this function def assertDictEqual(self, d1, d2, approx_equal=False, tolerance=0.001): | 10:17 |
| archanaserver | i'm not getting what this error wants to say | 10:18 |
| vkmc | archanaserver, hi! | 10:18 |
| vkmc | only a test? | 10:18 |
| vkmc | or several tests? | 10:18 |
| archanaserver | yes there are several, Failed: 21 | 10:20 |
| vkmc | hmm submit it for review, probably there are tests we need to fix | 10:21 |
| archanaserver | previously I was getting this error | 10:30 |
| archanaserver | TypeError: assertDictEqual() got an unexpected keyword argument 'approx_equal' | 10:30 |
| archanaserver | and then | 10:30 |
| archanaserver | TypeError: assertDictEqual() got an unexpected keyword argument 'tolerance' | 10:30 |
| archanaserver | so I fixed this from here -> https://github.com/openstack/manila/blob/master/manila/test.py#L326-L327 | 10:30 |
| archanaserver | by removing that two params, because it doesn't contain now (after removing the func) | 10:30 |
| archanaserver | then getting this error which i just showed you -> http://paste.openstack.org/show/806622/ | 10:30 |
| archanaserver | well okay, I'm submitting it for review | 10:31 |
| vkmc | yeah, that way we can compare code :) | 10:32 |
| vkmc | worst case we can get back to a previous verison | 10:33 |
| vkmc | version* | 10:33 |
| archanaserver | oh okay | 10:33 |
| archanaserver | submitted! | 10:34 |
| vkmc | cool! | 10:35 |
| archanaserver | so what now we can start? | 10:36 |
| archanaserver | also, when we can start working on manila UI? | 10:36 |
| vkmc | of course, you are free to start looking into things | 11:06 |
| vkmc | being proactive on taking tasks, learning things or working on different stuff is always encouraged | 11:06 |
| archanaserver | that's awesome | 11:38 |
| archanaserver | i'll start with looking into Manila UI and Horizon code | 11:38 |
| archanaserver | just to get familiar | 11:39 |
| archanaserver | and then i can start contribute to some small fixes :) | 11:40 |
| vkmc | that sounds very good | 11:41 |
| vkmc | in our one on one this week can start looking into the main internship task so you can start focusing in that area | 11:42 |
| archanaserver | yeah sure | 11:43 |
| vkmc | kafilat, archanaserver, joining in a bit, running over with a different meeting | 15:00 |
| archanaserver | okie sure | 15:01 |
| gouthamr | archanaserver, just mentioned this to kafilat | 18:43 |
| gouthamr | i'd like you to watch this presentation: https://www.youtube.com/watch?v=eBcmHMKZG9A | 18:43 |
| gouthamr | and read this to complement that knowledge: https://docs.openstack.org/manila/latest/admin/shared-file-systems-share-types.html | 18:43 |
| gouthamr | both of these should give you a fair idea about manila, and "capabilities"-driven provisioning via share types | 18:44 |
| archanaserver | gouthamr: sure, thanks! | 18:48 |
| kafilat | Thanks, will do! | 18:49 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!