| francie | Good morning all | 07:47 |
|---|---|---|
| francie | Hello maaritanm | 07:47 |
| francie | I just sent the patchset containing the unit tests but I have got some questions | 07:48 |
| francie | Let me know when you have a moment | 07:48 |
| francie | Hello maaritanm, | 09:19 |
| francie | Hello vkmc | 11:14 |
| francie | When you have a moment could you take a look at the patch? | 11:15 |
| vkmc | francie, hey | 11:21 |
| vkmc | francie, yes | 11:21 |
| francie | Thanks | 11:21 |
| francie | I received some zuul failure | 11:22 |
| francie | https://review.opendev.org/c/openstack/python-manilaclient/+/815157 | 11:22 |
| francie | TypeError: test_allow_access_wait() missing 2 required positional arguments: 'share' and 'access_to' | 11:22 |
| maaritamm | Looks like francie misspelled my nickname, I didn't get the notifications, thanks for jumping in vkmc! :) | 15:36 |
| vkmc | maaritamm, anytime | 15:36 |
| vkmc | code looks good good | 15:37 |
| vkmc | unit tests are tricky | 15:37 |
| maaritamm | yeah | 15:37 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!