| rose_kimondo_ | gouthamr, I have succesfully pushed it. The error was because I mistakenly had an apostrophe in the branch's name. | 04:27 |
|---|---|---|
| rose_kimondo_ | gouthamr, carloss, Hi. In the final application, there is a section titled "(Optional) Community-specific Questions" where we can answer additional questions after checking with our mentors where there is need to. Is there any additional information that we should provide specific to this community? Thanks. | 13:34 |
| carloss | rose_kimondo_: not that I can think of right now | 13:35 |
| rose_kimondo_ | carloss: Cool, thanks. Also, another patch has also failed the jobs :( but it is up for review: https://review.opendev.org/c/openstack/manila/+/965341 | 13:46 |
| carloss | rose_kimondo_: our CI is currently broken because of the grenade job failures | 13:58 |
| premlata | Hi @carloss, as per my understanding, I should implement the API so it returns something like: | 19:28 |
| premlata | the view should be: | 19:28 |
| premlata | { | 19:28 |
| premlata | project_id_1:{ | 19:28 |
| premlata | user_id_1:{ | 19:28 |
| premlata | shares: xxx, | 19:28 |
| premlata | gigabytes: xxx, | 19:28 |
| premlata | snapshots: xxx, | 19:29 |
| premlata | }, | 19:29 |
| premlata | user_id_2:{ | 19:29 |
| premlata | shares: xxx, | 19:29 |
| premlata | gigabytes: xxx, | 19:29 |
| premlata | } | 19:29 |
| premlata | }, | 19:29 |
| premlata | project_id_2:{ | 19:29 |
| premlata | user_id_1:{ | 19:29 |
| premlata | shares: xxx, | 19:29 |
| premlata | gigabytes: xxx, | 19:29 |
| premlata | }, | 19:29 |
| premlata | user_id_2:{ | 19:29 |
| premlata | shares: xxx, | 19:29 |
| premlata | gigabytes: xxx, | 19:29 |
| premlata | } | 19:29 |
| premlata | } | 19:29 |
| premlata | } according to @haixin comment and update the tests, and add release note for this https://review.opendev.org/c/openstack/manila/+/807780? Am I following it correct? | 19:29 |
| carloss | premlata: yep, you're correct | 19:30 |
| carloss | one suggestion: for good formatting of jsons and stuff like that | 19:30 |
| carloss | I recommend to use https://paste.opendev.org/ | 19:30 |
| carloss | when sharing outputs/pastes with us | 19:30 |
| carloss | :) | 19:30 |
| premlata | Sure, thank you very much for the suggestion :) . Also, one thing - Do I create a new patch or begin the work on the same branch after rebasing? | 19:31 |
| carloss | premlata: same branch and same patch would be preferable | 20:23 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!