| nathan_akin[m] | hello carloss gouthamr i pushed new patches, please feel free to look at them when you are less busy :) | 22:37 |
|---|---|---|
| nathan_akin[m] | i really should sleep now, my eyes are tweaking Gn :) | 22:37 |
| nathan_akin[m] | oh also gouthamr thank you for the clarification on my PR , just pushed patchset 4 on 982050 , i addressed all three comments. removed the duplicate Change-Id, replaced the brittle tuple unpacking with just checking the check name string, and switched the call_args index access to use .args[0] and .kwargs to make it more readable. thanks for the detailed feedback, really helpful, | 23:11 |
| nathan_akin[m] | https://review.opendev.org/c/openstack/manila/+/982050 | 23:11 |
| nathan_akin[m] | hey gouthamr carloss been reading through the scheduler code and noticed something in the affinity filter. when a user passes an invalid share UUID as a scheduler hint, the filter catches the exception and returns None (which stops scheduling), but there's no call to message_api.create() before that happens. so from the user's side they just get NoValidHost, last filter AffinityFilter with no explanation. other scheduler | 23:25 |
| nathan_akin[m] | paths like missing share type already use the message API to give user facing feedback. would it be worth filing a bug and adding that here too? | 23:25 |
| nathan_akin[m] | * | 23:30 |
| nathan_akin[m] | * Oh.. also 😅 [carloss](https://matrix.to/#/@_oftc_carloss:matrix.org) been reading through the scheduler code and noticed something in the affinity filter. when a user passes an invalid share UUID as a scheduler hint, the filter catches the exception and returns None (which stops scheduling), but there's no call to message_api.create() before that happens. so from the user's side they just get NoValidHost, last filter | 23:31 |
| nathan_akin[m] | AffinityFilter with no explanation. other scheduler paths like missing share type already use the message API to give user facing feedback. would it be worth filing a bug and adding that here too? [gouthamr](https://matrix.to/#/@_oftc_gouthamr:matrix.org) | 23:31 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!