| *** tetsuro has joined #openstack-placement | 00:30 | |
| openstackgerrit | Steve Kowalik proposed openstack/nova master: Switch to oslo_messaging.ConfFixture.transport_url https://review.openstack.org/573046 | 00:53 |
|---|---|---|
| *** edmondsw has joined #openstack-placement | 01:42 | |
| *** edmondsw has quit IRC | 01:47 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update admin/flavors document https://review.openstack.org/573063 | 01:52 |
| openstackgerrit | Merged openstack/nova master: Re-base placement object unit tests on NoDBTestCase https://review.openstack.org/572279 | 01:55 |
| openstackgerrit | Tsuyoshi Nagata proposed openstack/nova master: Fix nova can handle device name length more widly for universally. https://review.openstack.org/573066 | 01:58 |
| openstackgerrit | Tsuyoshi Nagata proposed openstack/nova master: Fix nova can handle device name length more widly for universally. https://review.openstack.org/573066 | 02:02 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 02:10 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 02:10 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 02:10 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 02:10 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 02:11 |
| openstackgerrit | Tsuyoshi Nagata proposed openstack/nova master: Define nova's max number of devices by each bus-type. https://review.openstack.org/567472 | 02:15 |
| openstackgerrit | Merged openstack/nova master: Fix nits in nested provider allocation candidates https://review.openstack.org/572673 | 02:24 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Fix a logic error in network_request https://review.openstack.org/573073 | 02:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.openstack.org/572790 | 02:42 |
| *** mriedem has quit IRC | 02:52 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 03:08 |
| openstackgerrit | Merged openstack/nova stable/ocata: libvirt: Skip fetching the virtual size of block devices https://review.openstack.org/571433 | 03:21 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 03:29 |
| *** edmondsw has joined #openstack-placement | 03:30 | |
| *** edmondsw has quit IRC | 03:35 | |
| openstackgerrit | Chen proposed openstack/nova master: Fix issues in nova-show-usage-statistics-for-hosts-instances.rst https://review.openstack.org/573077 | 03:37 |
| openstackgerrit | Chen proposed openstack/nova master: Fix issues in nova-show-usage-statistics-for-hosts-instances.rst https://review.openstack.org/573077 | 03:48 |
| *** takashin has quit IRC | 04:32 | |
| *** edmondsw has joined #openstack-placement | 05:19 | |
| openstackgerrit | Merged openstack/nova master: Change consecutive build failure limit to a weigher https://review.openstack.org/572195 | 05:22 |
| *** e0ne has joined #openstack-placement | 05:23 | |
| *** edmondsw has quit IRC | 05:23 | |
| *** e0ne has quit IRC | 05:25 | |
| openstackgerrit | jichenjc proposed openstack/nova-specs master: Add additional information for z/VM spec. https://review.openstack.org/562154 | 05:26 |
| openstackgerrit | Merged openstack/nova master: Add granular policy rules for allocation candidates https://review.openstack.org/570656 | 05:29 |
| openstackgerrit | Tsuyoshi Nagata proposed openstack/nova master: Fix nova can handle device name length more widely for universally. https://review.openstack.org/573066 | 05:36 |
| *** takashin has joined #openstack-placement | 06:03 | |
| openstackgerrit | jichenjc proposed openstack/nova master: doc follow https://review.openstack.org/#/c/572195 https://review.openstack.org/573091 | 06:10 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the file name of development-environment.rst https://review.openstack.org/573096 | 06:26 |
| openstackgerrit | jichenjc proposed openstack/nova master: doc follow https://review.openstack.org/#/c/572195 https://review.openstack.org/573091 | 06:31 |
| *** e0ne has joined #openstack-placement | 06:31 | |
| *** e0ne has quit IRC | 06:41 | |
| *** tssurya has joined #openstack-placement | 06:47 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | 06:53 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | 06:59 |
| *** edmondsw has joined #openstack-placement | 07:07 | |
| *** e0ne has joined #openstack-placement | 07:10 | |
| *** e0ne has quit IRC | 07:11 | |
| *** edmondsw has quit IRC | 07:11 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: placement: Use INNER JOIN for requied traits https://review.openstack.org/573113 | 07:27 |
| *** ttsiouts has joined #openstack-placement | 07:30 | |
| *** tssurya_ has joined #openstack-placement | 07:32 | |
| *** ttsiouts has quit IRC | 07:35 | |
| *** tssurya_ has quit IRC | 07:37 | |
| *** ttsiouts has joined #openstack-placement | 07:54 | |
| *** ttsiouts has quit IRC | 07:55 | |
| *** ttsiouts has joined #openstack-placement | 07:56 | |
| *** ttsiouts has quit IRC | 08:00 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Update nova network info when doing rebuild for evacuate operation https://review.openstack.org/382853 | 08:36 |
| *** ttsiouts has joined #openstack-placement | 08:41 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.63 https://review.openstack.org/573136 | 08:53 |
| *** edmondsw has joined #openstack-placement | 08:55 | |
| *** edmondsw has quit IRC | 09:00 | |
| *** takashin has left #openstack-placement | 09:01 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: sync_guest_time: use the proper errno https://review.openstack.org/572346 | 09:09 |
| openstackgerrit | tianhui proposed openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | 09:16 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fix tox python3 overrides https://review.openstack.org/572974 | 09:35 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fix tox python3 overrides https://review.openstack.org/572974 | 09:37 |
| *** tetsuro has quit IRC | 09:44 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | 09:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Speed things up and document them https://review.openstack.org/534382 | 09:45 |
| *** e0ne has joined #openstack-placement | 09:56 | |
| *** ttsiouts has quit IRC | 10:08 | |
| openstackgerrit | tianhui proposed openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | 10:09 |
| openstackgerrit | Merged openstack/osc-placement master: fix tox python3 overrides https://review.openstack.org/572917 | 10:12 |
| openstackgerrit | tianhui proposed openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | 10:16 |
| openstackgerrit | tianhui proposed openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | 10:18 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: placement: Use INNER JOIN for requied traits https://review.openstack.org/573113 | 10:30 |
| *** edmondsw has joined #openstack-placement | 10:43 | |
| *** edmondsw has quit IRC | 10:47 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support nested alloc cands with sharing providers https://review.openstack.org/567508 | 10:52 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Use list instead of set for duplicate check https://review.openstack.org/569720 | 10:52 |
| openstackgerrit | tianhui proposed openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | 10:59 |
| *** ttsiouts has joined #openstack-placement | 11:01 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries https://review.openstack.org/558045 | 11:02 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480 | 11:02 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add microversion for nested allocation candidate https://review.openstack.org/565487 | 11:02 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Delete duplicate functions in placement test https://review.openstack.org/573193 | 11:16 |
| *** edmondsw has joined #openstack-placement | 11:22 | |
| *** ttsiouts has quit IRC | 11:26 | |
| openstackgerrit | tianhui proposed openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | 11:37 |
| *** ttsiouts has joined #openstack-placement | 11:44 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: WIP: Optimize member_of check for nested providers https://review.openstack.org/573203 | 11:54 |
| *** nicolasbock has joined #openstack-placement | 12:11 | |
| *** cdent has joined #openstack-placement | 12:21 | |
| *** mriedem has joined #openstack-placement | 12:38 | |
| openstackgerrit | MultipleCrashes proposed openstack/nova master: Retry decorator fix for autoscale delete https://review.openstack.org/563418 | 12:39 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262 | 12:49 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 12:49 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269 | 12:49 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 12:49 |
| openstackgerrit | Jan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads https://review.openstack.org/567148 | 12:58 |
| openstackgerrit | Jan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads https://review.openstack.org/567148 | 13:05 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 13:23 |
| cdent | can we talk about what it will take to get optional placement db merged before it is two years old: https://review.openstack.org/#/c/362766/ ? | 13:29 |
| *** ttsiouts has quit IRC | 13:32 | |
| *** openstackgerrit has quit IRC | 13:34 | |
| *** ttsiouts has joined #openstack-placement | 13:37 | |
| *** tssurya has quit IRC | 13:40 | |
| efried | cdent: I came across that again last night, but was too zonked. I'll try to look at it today. | 13:52 |
| *** openstackgerrit has joined #openstack-placement | 13:56 | |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Change consecutive build failure limit to a weigher https://review.openstack.org/573239 | 13:56 |
| efried | cdent: also, in case you didn't see, the reshape-provider-tree spec is up. | 13:59 |
| efried | cdent: ...and needing content from you. | 13:59 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/pike: Change consecutive build failure limit to a weigher https://review.openstack.org/573248 | 14:06 |
| mriedem | cdent: you should have that series in the runways etherpad for one | 14:07 |
| mriedem | i'm kind of surprised at how much bp code is ready to go but isn't in the runways queue | 14:07 |
| mriedem | melwitt: ^ | 14:07 |
| mriedem | we essentially have 1 thing in the queue (libvirt file backed memory) | 14:08 |
| cdent | efried: I did see, but I'm not really home yet (currently on a train) | 14:14 |
| efried | ack | 14:14 |
| cdent | mriedem: I hadn't put it in the runway queue yet because it hadn't had much review from either eric or jay and I figured it warranted some of that before it was declared adequate | 14:15 |
| cdent | as in: if the subteam hasn't said groovy yet, runway-ing seemed weird. but maybe I'm overthinking it | 14:16 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Change consecutive build failure limit to a weigher https://review.openstack.org/573239 | 14:18 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Fix interpretation of max_attempts for scheduling alternates https://review.openstack.org/573254 | 14:18 |
| mriedem | cdent: you're overthinking it | 14:20 |
| mriedem | if it's ready for review, throw it in the queue | 14:20 |
| cdent | roger that | 14:21 |
| openstackgerrit | Dan Smith proposed openstack/nova stable/pike: Change consecutive build failure limit to a weigher https://review.openstack.org/573248 | 14:21 |
| jaypipes | cdent: mostly just lack of priority from me, not lack of support for the idea. | 14:29 |
| *** ttsiouts has quit IRC | 14:30 | |
| efried | cdent: Reviewed, +2, a few questions and non-blockers inline. | 14:31 |
| cdent | thanks | 14:31 |
| *** ttsiouts has joined #openstack-placement | 14:33 | |
| efried | jaypipes: Bottom three nrp-in-alloc-cands (starting https://review.openstack.org/#/c/567508/ ) ready for you - on your radar for soon? | 14:37 |
| jaypipes | efried: it's my top non-spec review today. | 14:39 |
| efried | coo | 14:39 |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212 | 14:52 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459 | 15:00 |
| *** tssurya has joined #openstack-placement | 15:07 | |
| bauzas | efried: jaypipes: cdent: I think we're still missing in the https://review.openstack.org/#/c/565487/ series some change for the scheduler verifying the compute versions and don't ask for that microversion if some of them are still Queens | 15:08 |
| bauzas | efried: too ^ | 15:09 |
| bauzas | like I said previously, I think I can't review this series because it's a lot of SQL modifications where I'm not an expert | 15:09 |
| jaypipes | bauzas: it's actually not SQL modifications :( it's mostly for loops iterating over a bunch of sets, now :( | 15:10 |
| bauzas | jaypipes: well, ... https://review.openstack.org/#/c/567508/18/nova/api/openstack/placement/objects/resource_provider.py | 15:10 |
| jaypipes | bauzas: that's REMOVING all the SQL, man. :) | 15:10 |
| jaypipes | bauzas: and replacing with lots of set iterations and filters. | 15:11 |
| bauzas | okay, I'll try to understand it | 15:11 |
| jaypipes | bauzas: don't get me wrong... it's still touch to get to grips with, trust me. I'm sitting here going over it with a fine-toothed comb trying to keep it all in my reviewer head. :( | 15:12 |
| jaypipes | tough to get to grips with... | 15:12 |
| *** tssurya has quit IRC | 15:12 | |
| bauzas | jaypipes: heh, no worries, I'm just trying to explain that while I'd really like to help the series, I'd still want to be honest with my current situation | 15:13 |
| melwitt | mriedem: yeah, I've been wondering about the relatively empty queue too. been trying to constantly remind about runways but I'm worried people are forgetting about them | 15:13 |
| bauzas | jaypipes: the fact that placement is now a bit shipped from my mind :) | 15:14 |
| bauzas | but that's cool because I see other folks be good with it | 15:14 |
| mriedem | melwitt: when people ask for reviews on bps i just tell them to get in the runway queue first | 15:15 |
| mriedem | b/c that's where i'm going to go to look for random bp reviews | 15:15 |
| * melwitt nods | 15:15 | |
| *** tssurya has joined #openstack-placement | 15:21 | |
| *** tssurya has quit IRC | 15:24 | |
| *** ttsiouts has quit IRC | 15:29 | |
| -openstackstatus- NOTICE: Zuul update for Ansible 2.5 in progress. Scheduler crashed as unexpected side effect of pip upgrade. Will be back and running shortly. | 15:31 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Change consecutive build failure limit to a weigher https://review.openstack.org/573248 | 15:34 |
| openstackgerrit | Curt Moore proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.openstack.org/572805 | 15:45 |
| *** cdent has quit IRC | 15:51 | |
| *** cdent has joined #openstack-placement | 15:58 | |
| *** cdent has quit IRC | 16:03 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.openstack.org/554218 | 16:03 |
| *** cdent has joined #openstack-placement | 16:03 | |
| -openstackstatus- NOTICE: The zuul upgrade to ansible 2.5 is complete and zuul is running again. Changes uploaded or approved between 15:25 and 15:45 will need to be rechecked. Please report any problems in #openstack-infra | 16:10 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459 | 16:20 |
| openstackgerrit | Merged openstack/nova master: Fix the file name of development-environment.rst https://review.openstack.org/573096 | 16:26 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: always create consumer records https://review.openstack.org/567678 | 16:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: add consumers generation field https://review.openstack.org/557958 | 16:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: Allocation.consumer field https://review.openstack.org/565405 | 16:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407 | 16:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604 | 16:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 16:35 |
| openstackgerrit | Merged openstack/nova-specs master: Add additional information for z/VM spec. https://review.openstack.org/562154 | 16:40 |
| openstackgerrit | Merged openstack/nova-specs master: Amend allow abort live migrations in queued status spec https://review.openstack.org/560872 | 16:40 |
| jaypipes | efried: I'm afraid I'm really not thrilled with the nested allocation candidates series. | 16:51 |
| jaypipes | efried: but I feel everyone is just gung-ho on pressing forward no matter the consequences (with code readability or modularity) just to get this stuff into the API. | 16:53 |
| jaypipes | efried: at this point, we're so far divergent from most of my original ideas for the server side of the placement service. | 16:53 |
| jaypipes | efried: and I'm really frustrated because I just predict that all the refactoring stuff that is now needed (badly) is just going to continue getting pushed further back. | 16:54 |
| jaypipes | efried: and since I've already been bitten by pushing refactoring series, I'm basically feeling like I'm just forced to accept all of this at this point for the sake of expediency. | 16:55 |
| *** e0ne has quit IRC | 16:55 | |
| *** cdent has quit IRC | 16:58 | |
| efried | jaypipes: Okay, talk to me. | 17:10 |
| efried | jaypipes: Seems to me like refactoring has been happening along the way. Sure, more is needed - but refactoring was badly needed before even if we were going to keep the API functionally static. | 17:12 |
| efried | jaypipes: As far as readability goes, my opinion (which you may not like) is that these massive SQL statements are more of a detriment than a help. And so far we haven't shown a need for whatever improved efficiency they impart. | 17:14 |
| jaypipes | efried: it's not about the "massive SQL statements". it's about the original design of the placement service being that simple requests would follow the simple path, and only when requests were complex would the code path diverge into more complicated routines. | 17:15 |
| efried | I feel like we went too far in that direction, and the move back is the right direction. Are we going too far back? Maybe. But in so doing, we're writing a lot of really good tests which we can then use to prove unreadable-massive-but-efficient SQL blocks if we want to move back that way later on. | 17:16 |
| jaypipes | efried: that's no longer possible. everything is now the most complicated case and there's no reading the code for the simple case. | 17:16 |
| openstackgerrit | Merged openstack/nova-specs master: Spec for volume multiattach enhancements https://review.openstack.org/552078 | 17:16 |
| efried | jaypipes: Totally agree with you that we have complicated operations to support now. But what alternative? | 17:16 |
| jaypipes | efried: the alternative was not to complicate the simple path but to add separate routines that handles the complicated requests. | 17:17 |
| efried | jaypipes: Mm, I think I understand your point. | 17:17 |
| efried | jaypipes: To me, because the simple paths are a proper subset of the overall algorithm, separating them out just makes for more code, duplication we have to keep track of, etc. | 17:18 |
| jaypipes | the original design of the placement service was supposed to be a hierarchical router-like service which would analyze the request up front and send the request to the part of the router that handled that level of complexity of request. | 17:18 |
| efried | jaypipes: Benefit of being able to read through the simple path if that's what you're doing, but harder to read/maintain holistically. | 17:18 |
| jaypipes | efried: the design we currently have is "assume the worst case complexity for all requests and boil the ocean for each request" | 17:18 |
| efried | jaypipes: Hyperbolic metaphor aside, I get that that's not how it was originally in your head or even perhaps what was more broadly agreed upon architecturally, but I'm not convinced it's the wrong thing. | 17:20 |
| efried | jaypipes: Specifically I assume what you're having the most acid about is the removal of the optimized paths for "no sharing" and "no nested". | 17:21 |
| jaypipes | efried: well, yes, that and the fact that everything needs to be run through the merge_candidates() stuff now, even if we know ahead of time there's no reason to do it. | 17:22 |
| jaypipes | efried: my attachment is definitely not "for huge SQL statements". | 17:23 |
| jaypipes | efried: I don't mind splitting the large SQL statements up, especially for readability. what I mind is the unreadability of this that we now have. | 17:24 |
| jaypipes | for some judgment of "now". | 17:24 |
| efried | jaypipes: Again, my opinion, but having the extra code to figure out which route we're taking, plus having the extra code for the optimized paths themselves, and especially from a serviceability standpoint having to figure out which route we took when something blows up -- the single path, complex though it may be, is the lesser evil. | 17:24 |
| jaypipes | efried: router design would disagree with you, but ok. | 17:25 |
| efried | jaypipes: What's a router? | 17:25 |
| jaypipes | never mind, I'll try to stay on point here. | 17:25 |
| efried | happy to be educated, like I was with the operation-based JSON PATCH thing :) | 17:25 |
| efried | ...which I would have been vehemently opposed to without having seen that there were people out there who thought it was a good enough idea to make a whole RFC out of it. | 17:27 |
| efried | cause it sure seems like a RESTless hack to me. | 17:27 |
| efried | jaypipes: How many optimized paths are we interested in having, btw? When the only factor was 'sharing or no sharing', I get it - that's two paths. But now the possibilities are a dot product of [sharing x nested x traits x aggregates] with more on the way. Which combinations are candidates for optimization? | 17:32 |
| efried | Clearly non-nested non-aggregates (which implies no-sharing) is one. Does that have common code for dealing with traits, or do we have a no-traits optimized branch as well? | 17:34 |
| jaypipes | efried: I'd be fine handling the sharing providers mess with separate smaller queries (instead of the mega-join-chain thing) and then just having the nested and non-nested routes. | 17:34 |
| jaypipes | (I'm trying to finish reviews on tetsuro's series, btw..) | 17:34 |
| *** openstackgerrit has quit IRC | 17:34 | |
| jaypipes | efried: sorry, that really should have been "the granular and non-granular routes" | 17:39 |
| efried | okay, that makes more sense. | 17:40 |
| jaypipes | efried: consumer generation series could use your reviews. | 17:47 |
| efried | I would be supportive of an effort to optimize the non-granular path to the extent of short-circuiting out of all the merge_candidates etc stuff. Still not won over to the camp of switching up front and taking a totally different route, but maybe if I see it... | 17:48 |
| efried | jaypipes: Okay, that's ready for me now? Will look after food. | 17:48 |
| jaypipes | efried: yes, thx in advance. tetsuro and I are racing for 1.27 | 17:49 |
| *** tssurya has joined #openstack-placement | 17:50 | |
| jaypipes | efried: bottom 4 patches of tetsuro's series are on their way to the test pits. | 17:53 |
| *** tssurya has quit IRC | 17:53 | |
| *** tssurya has joined #openstack-placement | 17:57 | |
| *** openstackgerrit has joined #openstack-placement | 17:57 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.openstack.org/572805 | 17:57 |
| *** e0ne has joined #openstack-placement | 17:57 | |
| *** tssurya has quit IRC | 18:00 | |
| *** mriedem has quit IRC | 18:20 | |
| efried | jaypipes: bottom 4? Looking... | 18:38 |
| efried | jaypipes: That 4th didn't have another core review yet. | 18:41 |
| jaypipes | efried: oh? sorry, I thought you'd already +2'd. | 18:42 |
| jaypipes | efried: must have confused it with a differnt one. | 18:42 |
| efried | jaypipes: I'll review it right now and pull it if necessary, but if you're good with it, chances are I will be. | 18:43 |
| *** e0ne has quit IRC | 18:43 | |
| jaypipes | efried: I've un-W'd but not sure if that will remove it from the queue... | 18:43 |
| efried | jaypipes: It doesn't. Has to be rebased, I think. I would have thought a -2 should do it, but not sure about that. | 18:44 |
| efried | Chances of all four passing the gate first time around seem slim anyway :) | 18:44 |
| *** e0ne has joined #openstack-placement | 18:45 | |
| jaypipes | efried: ya | 18:45 |
| efried | jaypipes: Looked at the reshape-provider-tree spec yet? | 18:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing https://review.openstack.org/560459 | 19:01 |
| jaypipes | efried: ^ rebased and removed the FakeLibvirtDriver thing. | 19:01 |
| efried | jaypipes: Cool man. We're gonna run out of cores tho :) | 19:01 |
| efried | I can't +2 that guy. | 19:01 |
| jaypipes | efried: there's a +2 from me. I barely touched it other than adding those mocks. | 19:03 |
| efried | k | 19:03 |
| jaypipes | efried: bauzas can be core #2 | 19:03 |
| efried | jaypipes: Roger that. You didn't have to change the base class either, right? Since you still specified that variable | 19:04 |
| jaypipes | efried: yeah. | 19:04 |
| jaypipes | efried: I'm +2 on https://review.openstack.org/#/c/573113/ as well, BTW | 19:05 |
| jaypipes | efried: ok, now on to reshaper. | 19:06 |
| efried | jaypipes: Okay; not sure I'm competent to review that guy, but I'll try. | 19:06 |
| jaypipes | efried: reshaper and Jan's vRouter spec will be my last 2 reviews of the day. then I have a date with Deadpool 2. | 19:12 |
| efried | jaypipes: I hear it's disappointing. A watered-down version of the first, without much to add. So... lower your expectations. | 19:13 |
| jaypipes | efried: heh, ok :) | 19:13 |
| openstackgerrit | Simon Dodsley proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 19:16 |
| openstackgerrit | Simon Dodsley proposed openstack/nova master: Add enhanced KVM storage QoS quotas https://review.openstack.org/558530 | 19:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.openstack.org/572790 | 19:23 |
| jaypipes | efried: nice seqdiag in the spec, btw. | 19:29 |
| efried | thanks mon | 19:30 |
| efried | despite bauzas' hatin? | 19:30 |
| efried | jaypipes: Found a bug in that 4th patch. | 19:37 |
| efried | jaypipes: I'm going to post a rev that breaks it. | 19:37 |
| efried | jaypipes: I know how to fix it, but only by doing a nested SELECT. I'm sure you can come up with a JOINy way. | 19:37 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Return all nested providers in tree https://review.openstack.org/559480 | 19:42 |
| efried | jaypipes: ^ (And that'll keep it out of the gate too) | 19:42 |
| openstackgerrit | Simon Dodsley proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 19:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 20:08 |
| openstackgerrit | Merged openstack/nova master: Follow up changes to granular placement policy reviews https://review.openstack.org/570588 | 20:14 |
| openstackgerrit | Merged openstack/nova master: Support nested alloc cands with sharing providers https://review.openstack.org/567508 | 20:15 |
| openstackgerrit | Merged openstack/nova master: Use list instead of set for duplicate check https://review.openstack.org/569720 | 20:15 |
| *** e0ne has quit IRC | 20:32 | |
| *** e0ne has joined #openstack-placement | 20:33 | |
| *** e0ne has quit IRC | 20:44 | |
| *** e0ne has joined #openstack-placement | 20:45 | |
| *** mriedem1 has joined #openstack-placement | 20:47 | |
| *** e0ne has quit IRC | 20:49 | |
| *** takashin has joined #openstack-placement | 20:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 20:57 |
| *** mriedem1 is now known as mriedem | 20:58 | |
| *** nicolasbock has quit IRC | 21:22 | |
| openstackgerrit | Merged openstack/nova master: Fix issues in nova-show-usage-statistics-for-hosts-instances.rst https://review.openstack.org/573077 | 21:26 |
| openstackgerrit | Merged openstack/nova master: Fix bug to doc:nova-status https://review.openstack.org/573149 | 21:26 |
| openstackgerrit | Merged openstack/nova master: Delete duplicate functions in placement test https://review.openstack.org/573193 | 21:26 |
| openstackgerrit | Merged openstack/nova master: Enhance api-guide general info some updates https://review.openstack.org/561773 | 21:26 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (3) https://review.openstack.org/568184 | 21:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (4) https://review.openstack.org/568462 | 21:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (4) https://review.openstack.org/570750 | 21:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (5) https://review.openstack.org/570842 | 21:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6) https://review.openstack.org/571330 | 21:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992 | 21:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993 | 21:38 |
| *** edmondsw has quit IRC | 21:38 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in nova/tests/unit/virt/xenapi/stubs.py https://review.openstack.org/568412 | 21:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | 21:39 |
| openstackgerrit | Merged openstack/nova-specs master: Proposes Multiple GPU types https://review.openstack.org/557065 | 21:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (1) https://review.openstack.org/564658 | 21:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (2) https://review.openstack.org/564659 | 21:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 21:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 21:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (1) https://review.openstack.org/572018 | 21:41 |
| efried | jaypipes: +2 on bottom two consumer gen patches. Second one is +W, first one needs dansmith's nod. | 22:03 |
| efried | dansmith: https://review.openstack.org/#/c/567678/ for your convenience | 22:03 |
| openstackgerrit | Merged openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 22:16 |
| *** edmondsw has joined #openstack-placement | 22:36 | |
| *** edmondsw has quit IRC | 22:41 | |
| *** mriedem is now known as mriedem_afk | 22:52 | |
| openstackgerrit | Tsuyoshi Nagata proposed openstack/nova master: [nova] increasing the number of allowed volumes attached per instance > 26 https://review.openstack.org/567472 | 23:20 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!