| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (2) https://review.openstack.org/573481 | 00:00 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104 | 00:26 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106 | 00:49 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 01:15 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 01:46 |
| *** edmondsw has quit IRC | 01:47 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 01:55 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 01:56 |
| openstackgerrit | jiang wei proposed openstack/nova master: Add action initiator attribute to the instance info https://review.openstack.org/536243 | 02:07 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 02:11 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628 | 02:42 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375 | 02:42 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 02:42 |
| *** edmondsw has joined #openstack-placement | 02:54 | |
| *** edmondsw has quit IRC | 02:59 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP https://review.openstack.org/564092 | 03:43 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy https://review.openstack.org/571166 | 03:57 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 03:57 |
| openstackgerrit | Merged openstack/nova master: Remove support for /os-virtual-interfaces REST API https://review.openstack.org/569923 | 04:19 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 04:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 04:36 |
| *** e0ne has joined #openstack-placement | 05:28 | |
| *** tetsuro has joined #openstack-placement | 05:29 | |
| *** e0ne has quit IRC | 05:33 | |
| openstackgerrit | Merged openstack/nova master: Remove unused _disk_qcow2_to_raw https://review.openstack.org/572025 | 06:08 |
| *** ttsiouts has joined #openstack-placement | 06:23 | |
| *** belmoreira has joined #openstack-placement | 06:27 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.63 - Use new format policy in server group https://review.openstack.org/567534 | 07:05 |
| openstackgerrit | jichenjc proposed openstack/nova master: doc follow https://review.openstack.org/#/c/572195 https://review.openstack.org/573091 | 07:08 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP Add full traceback to ExceptionPayload in versioned notifications https://review.openstack.org/564092 | 07:14 |
| *** ttsiouts has quit IRC | 07:15 | |
| *** rubasov has joined #openstack-placement | 07:18 | |
| *** ttsiouts has joined #openstack-placement | 07:25 | |
| *** ttsiouts has quit IRC | 07:27 | |
| *** ttsiouts has joined #openstack-placement | 07:28 | |
| openstackgerrit | huanhongda proposed openstack/nova stable/ocata: Remove soft-deleted instances from quota_usages https://review.openstack.org/570653 | 07:30 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove network info stubbing in functional test https://review.openstack.org/570018 | 07:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840 | 07:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267 | 07:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847 | 07:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | 07:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459 | 07:31 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 07:31 |
| *** ttsiouts has quit IRC | 07:32 | |
| openstackgerrit | jiang wei proposed openstack/nova master: Add action initiator attribute to the instance info https://review.openstack.org/536243 | 07:33 |
| *** belmoreira has quit IRC | 07:36 | |
| *** bauzas has joined #openstack-placement | 07:39 | |
| *** belmoreira has joined #openstack-placement | 07:48 | |
| *** belmoreira has quit IRC | 07:53 | |
| *** ttsiouts has joined #openstack-placement | 07:53 | |
| openstackgerrit | Merged openstack/nova master: Pushing image traits to ironic node https://review.openstack.org/565620 | 08:05 |
| openstackgerrit | huanhongda proposed openstack/nova master: Return "deleted" time of instance when vm_state is DELETED or SOFT-DELETED https://review.openstack.org/574159 | 08:10 |
| *** belmoreira has joined #openstack-placement | 08:33 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | 08:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: Fix the file name of development-environment.rst https://review.openstack.org/574175 | 09:00 |
| *** ttsiouts has quit IRC | 09:12 | |
| *** e0ne has joined #openstack-placement | 09:12 | |
| *** ttsiouts has joined #openstack-placement | 09:13 | |
| *** giblet is now known as gibi | 09:31 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP Add full traceback to ExceptionPayload in versioned notifications https://review.openstack.org/564092 | 09:33 |
| *** takashin has left #openstack-placement | 09:37 | |
| *** ttsiouts has quit IRC | 09:38 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: remove unused get_ovs_interfaceid() https://review.openstack.org/572699 | 09:39 |
| *** ttsiouts has joined #openstack-placement | 09:40 | |
| *** finucannot is now known as stephenfin | 09:45 | |
| *** nicolasbock has joined #openstack-placement | 10:39 | |
| *** ttsiouts has quit IRC | 10:43 | |
| *** jrollen is now known as jroll | 10:44 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 10:55 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 10:55 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 10:55 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 10:55 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 10:55 |
| *** cdent has joined #openstack-placement | 11:00 | |
| *** ttsiouts has joined #openstack-placement | 11:06 | |
| *** ttsiouts has quit IRC | 11:07 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Rename parameters in call() of nova/image/glance.py https://review.openstack.org/508533 | 11:09 |
| *** tetsuro has quit IRC | 11:12 | |
| *** ttsiouts has joined #openstack-placement | 11:13 | |
| *** jroll has quit IRC | 11:18 | |
| *** jroll has joined #openstack-placement | 11:18 | |
| *** e0ne has quit IRC | 11:38 | |
| gibi | cdent, efried bhagyashris_: I think I found the reason why the test in https://review.openstack.org/#/c/560459 fails sometimes | 11:44 |
| gibi | cdent, efried bhagyashris_: left some comment within | 11:45 |
| cdent | gibi: presumably some other test may create that path first, and that's why sometimes it passes? | 11:45 |
| gibi | cdent: exactly | 11:46 |
| gibi | cdent: I found such tests | 11:46 |
| openstackgerrit | Alexandre arents proposed openstack/nova master: Preserve images_type of instance during live migration https://review.openstack.org/570528 | 11:46 |
| *** e0ne has joined #openstack-placement | 11:48 | |
| cdent | gibi: nice sleuthing | 11:56 |
| gibi | cdent: thanks, it was fun to do the investigation | 12:02 |
| cdent | Last night, after saying it was too late to do the investigation I lay in bed trying to sleep for about 5 hours (jetlag). Maybe I should have stayed up. | 12:03 |
| gibi | cdent: you did not know beforehand that it will take 5 hours to fall asleep | 12:07 |
| cdent | indeed | 12:08 |
| gibi | so I think you made a good decision to try to sleep | 12:08 |
| *** ttsiouts has quit IRC | 12:09 | |
| *** edmondsw has joined #openstack-placement | 12:12 | |
| *** ttsiouts has joined #openstack-placement | 12:14 | |
| bhagyashris_ | gibi: Hi, I gone through the comment on https://review.openstack.org/#/c/560459 but i am not totally clear about it | 12:16 |
| gibi | bhagyashris_: what part is unclear for your? | 12:21 |
| bhagyashris_ | gibi: In that code path there is an ensure_tree call [2]that (I assume) creates the necessary directories recursively [2] https://github.com/openstack/nova/blob/3693caa54132ef3ec278d846dc50943a8d52509b/nova/virt/libvirt/imagebackend.py#L371 | 12:23 |
| gibi | bhagyashris_: some of the functional tests ends up executing that code path and therefore creating the directory tree | 12:23 |
| gibi | bhagyashris_: the new functional test case in https://review.openstack.org/#/c/560459 also needs that directory tree to exists | 12:24 |
| gibi | bhagyashris_: but it does not create it. | 12:24 |
| gibi | bhagyashris_: so the new functional test only passes if one of the other tests that hit the directory creation code path runs before the new funtional test | 12:25 |
| *** takashin has joined #openstack-placement | 12:26 | |
| bhagyashris_ | gibi: ok | 12:32 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240 | 12:33 |
| *** e0ne has quit IRC | 12:42 | |
| *** e0ne has joined #openstack-placement | 12:47 | |
| efried | gibi: Thanks for that. Is there something we can mock to simply bypass that issue? | 13:18 |
| gibi | efried: I'm not sure that mocking the os.statvfs(path) call but I don't know what else will need the directory structure later | 13:19 |
| efried | gibi: We're already mocking spawn, aren't we? | 13:20 |
| gibi | efried: we already have 10(ish) test cases that creates the path | 13:20 |
| efried | yeah, I guess if it's like that, might as well do what the other tests do... | 13:20 |
| gibi | efried: some test case doesn't mock spawn | 13:20 |
| gibi | efried: doing exactly what other tests do is not that simple. Other tests passes because our image backend implementation creates the dir structure if it does not exists | 13:21 |
| gibi | efried: the cleanest would be to have a fixture that created the dir for both the new test and the old test depending on this dir to exists | 13:22 |
| gibi | OR mock out all the file system usage in the test | 13:22 |
| efried | Yup. | 13:22 |
| *** ttsiouts has quit IRC | 13:22 | |
| gibi | efried, bhagyashris_: I'm pretty busy with other thing right now so I haven't started fixing this test issue yet. Feel free to give it a try | 13:26 |
| *** ttsiouts has joined #openstack-placement | 13:28 | |
| openstackgerrit | ymadhavi@in.ibm.com proposed openstack/nova stable/queens: mock utils.execute() in qemu-img unit test https://review.openstack.org/574255 | 13:31 |
| *** belmorei_ has joined #openstack-placement | 13:32 | |
| *** belmoreira has quit IRC | 13:34 | |
| efried | cdent: https://review.openstack.org/#/c/362766/102..103/nova/conf/database.py@136 | 13:41 |
| efried | I still think that `deprecated_name` shouldn't be there. | 13:41 |
| cdent | Oh, I ignored that commet originally because I had no idea what you mean. | 13:42 |
| cdent | t | 13:42 |
| cdent | efried: also it's at line 59 too | 13:42 |
| efried | cdent: But on L59 it's replacing a deprecated opt that previously existed in that conf group. | 13:44 |
| cdent | and it's also listed as deprecated on the originating oslo_db settings | 13:44 |
| efried | This is a new conf group. There has never been a [placement]idle_timeout to replace. | 13:44 |
| *** mriedem has joined #openstack-placement | 13:44 | |
| efried | sorry, [placement_database]idle_timeout | 13:44 |
| mriedem | leakypipes: efried: dansmith: correct me if i'm wrong about the result of the online data migration method in https://review.openstack.org/#/c/567678/ | 13:45 |
| mriedem | otherwise i'm +2 on that change | 13:45 |
| efried | cdent: If it's deprecated in [database], then the deprecation in [api_database] is either because the copyover happened before the deprecation, or it's also wrong. | 13:46 |
| efried | cdent: But this copyover is definitely happening after the deprecation. There has never been a [placement_database]idle_timeout. So there's nothing to deprecate there. | 13:46 |
| dansmith | mriedem: if the code does what you say then it's wrong | 13:46 |
| cdent | efried: yeah, that's a good point. I'm not sure why either line is the way it is, but roman wrote that bit of the code, and he was active in oslo_db, so I just took it for granted, but I think you're right so I'll remove it (just the second one) | 13:46 |
| dansmith | mriedem: otherwise we'll never signal success to the CLI user | 13:46 |
| mriedem | right there is no indication of what's lft | 13:46 |
| mriedem | *left | 13:46 |
| efried | cdent: I could be wrong about how that stuff works; may be worth verifying with someone who knows conf better. | 13:47 |
| dansmith | mriedem: although, it will be big,big first and then 0,0 after right? | 13:47 |
| mriedem | the way this is written, it will be by default at most 50 | 13:48 |
| mriedem | but i could do: nova-manage db online_data_migration --max-count 1 | 13:48 |
| mriedem | and if there are 20 of these, i'd expect to see 1 was migrated and 9 are left | 13:48 |
| mriedem | https://github.com/openstack/nova/blob/ef6b4f43f467dfad2fd0fe99d9dec3fc93a9ffed/nova/cmd/manage.py#L655 | 13:48 |
| cdent | efried: if you haven't done so already please leave (another) comment and I'll get to it later today | 13:48 |
| efried | ack | 13:49 |
| dansmith | mriedem: it's legit to return limit, limit if it costs a lot to count the higher one I think | 13:49 |
| dansmith | mriedem: we have others that have that, AFAIK | 13:49 |
| dansmith | mriedem: it just has to be nonzero until it's zero and then be stably zero | 13:49 |
| dansmith | I thought your comment was asserting that it's always nonzero return, which won't work | 13:50 |
| mriedem | no, my comment was that it's supposed to return (total number of unmigrated records left, total migrated) | 13:50 |
| mriedem | if that's not true, ok, but we should really have a comment in the online data migration code since i always have to look this up | 13:50 |
| dansmith | well, it's technically found,done | 13:50 |
| mriedem | ok, but i assume that the limit isn't applied to "found" | 13:51 |
| mriedem | in this case, it is | 13:51 |
| dansmith | found may not be all of them, but some subset if it's expensive to find them all.. | 13:51 |
| dansmith | we could do two queries, one to count them all and one to fix the limit amount, but I'm not sure it's worth it | 13:51 |
| mriedem | we've done that in other places i'm sure | 13:51 |
| dansmith | I'm quite sure I've written one where we process through batches without counting the whole first, but I can go look if you want to knwo | 13:52 |
| efried | cdent: What about the comments in https://review.openstack.org/#/c/362766/101/nova/tests/unit/cmd/test_status.py@366 ? | 13:52 |
| mriedem | anyway, this is why it's inconsistent and confusing and we should at least have a code comment | 13:52 |
| efried | cdent: Reasoning on L831 (the test cases don't hit placement, and doesn't make sense to future-proof)? | 13:52 |
| dansmith | mriedem: yeah, even the flavor one doesn't count them all, only up to limit | 13:53 |
| cdent | looks like there's an undelivered draft response to that that I never sent. sending now | 13:53 |
| mriedem | migrate_keypairs_to_api_db is the way i'm describing | 13:53 |
| cdent | also, you could help me a lot if you were less terse when commenting | 13:53 |
| dansmith | mriedem: https://github.com/openstack/nova/blob/stable/ocata/nova/objects/flavor.py#L734 | 13:54 |
| efried | cdent: Okay. I was trying a new thing there. Guess it failed :) | 13:54 |
| dansmith | mriedem: yeah, keypairs counts them all first | 13:54 |
| cdent | efried: what was the goal of the new thing? agree it failed. I had to struggle to decode you and it didn't make me...receptive | 13:55 |
| efried | cdent: I sometimes feel like I say way too much, explaining stuff that is obvious to the reader once I've brought attention to the piece in question. | 13:55 |
| dansmith | mriedem: actually it counts unmigrated instances and bails if nonzero, it then only gets limit main_keypairs and processes those, so it'll never be more than limit right? | 13:55 |
| efried | cdent: Composing the full explanation takes time and effort, so if it's not needed, it'd be a savings to omit it. But clearly I went too far in this case. | 13:55 |
| cdent | efried I think that's useful, especially for other reviews who are trying to learn by reviewing | 13:55 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/objects/keypair.py#L265 | 13:55 |
| dansmith | mriedem: passes count to get_main_keypairs ^ | 13:56 |
| efried | cdent: ack. Thanks for the feedback | 13:56 |
| cdent | efried: for those other people (especially) it is not at all waste time and effort. I think it is the main job of a core reviewer. | 13:56 |
| efried | noted | 13:56 |
| mriedem | dansmith: but _count_unmigrated_instances could return 1000 right? | 13:56 |
| mriedem | and then _get_main_keypairs could return 50 (default max count) | 13:56 |
| dansmith | mriedem: yes but that's not part of what is returned there | 13:57 |
| dansmith | mriedem: we return main_keypairs,done not bad_instances,done | 13:57 |
| mriedem | yes true | 13:57 |
| mriedem | ok, anyway, i've +2ed jay's change, | 13:57 |
| dansmith | bad_instances is just used to determine if we can do anything | 13:57 |
| mriedem | i still think we should have some clarification in the online data migrations code to explain what's ok here | 13:57 |
| mriedem | but it's not something that goes in jay's change obviously | 13:57 |
| dansmith | ack, I' | 13:57 |
| dansmith | ll write one | 13:58 |
| mriedem | thanks | 13:58 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Document the internal online_migrations function behaviors https://review.openstack.org/574268 | 14:05 |
| openstackgerrit | Merged openstack/nova stable/queens: Ensure resource class cache when listing usages https://review.openstack.org/573811 | 14:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove network info stubbing in functional test https://review.openstack.org/570018 | 14:27 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840 | 14:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267 | 14:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847 | 14:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | 14:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding https://review.openstack.org/569459 | 14:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 14:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add NUMANetworkInfo object https://review.openstack.org/564439 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_info field https://review.openstack.org/564441 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add InstanceNUMANetworkInfo object https://review.openstack.org/564442 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Unchain _get_phynet_info from _get_port_vnic_info https://review.openstack.org/564443 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Add 'create_resource_requests' to network API https://review.openstack.org/564444 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Retrieve tunneled status in '_get_network_info' https://review.openstack.org/564445 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Start accounting for network requests https://review.openstack.org/564448 | 14:30 |
| openstackgerrit | Chris Dent proposed openstack/nova stable/ocata: Ensure resource class cache when listing usages https://review.openstack.org/574279 | 14:31 |
| *** tssurya has joined #openstack-placement | 14:43 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 14:53 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 14:53 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | 14:53 |
| cdent | efried: fixed the conf setting on that stack ^ | 14:53 |
| efried | cdent: ack | 14:54 |
| efried | cdent: +2 | 14:55 |
| cdent | thanks | 14:56 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Document the internal online_migrations function behaviors https://review.openstack.org/574268 | 14:59 |
| *** takashin has left #openstack-placement | 14:59 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Document the internal online_migrations function behaviors https://review.openstack.org/574268 | 15:12 |
| openstackgerrit | Curt Moore proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.openstack.org/574301 | 15:20 |
| *** belmorei_ has quit IRC | 15:42 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Document the internal online_migrations function behaviors https://review.openstack.org/574268 | 15:50 |
| openstackgerrit | Zack Cornelius proposed openstack/nova master: Refactor libvirt get_memory_used_mb() https://review.openstack.org/571030 | 15:56 |
| openstackgerrit | Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876 | 15:56 |
| *** ttsiouts has quit IRC | 15:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475 | 16:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: XenAPI: update the document related to vdi streaming https://review.openstack.org/568444 | 16:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: default [xenserver]/image_handler to vdi_remote_stream https://review.openstack.org/574318 | 16:01 |
| *** e0ne has quit IRC | 16:09 | |
| openstackgerrit | Curt Moore proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.openstack.org/574301 | 16:14 |
| cdent | mriedem: in case it didn't otherwise cross your radar, I sent that resource class cache and Usage patch back to ocata: https://review.openstack.org/#/c/574279/ . needed some tweaks. | 16:15 |
| openstackgerrit | Curt Moore proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.openstack.org/574301 | 16:15 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix nits from change Id609789ef6b4a4c745550cde80dd49cabe03869a https://review.openstack.org/574324 | 16:17 |
| mriedem | ocata | 16:17 |
| mriedem | hells bells | 16:17 |
| mriedem | you forgot pike? | 16:17 |
| cdent | ooops, yeah. It turns out the reason I can't spell is because I don't know the alphabet. Will redo | 16:18 |
| openstackgerrit | Chris Dent proposed openstack/nova stable/pike: Ensure resource class cache when listing usages https://review.openstack.org/574327 | 16:20 |
| mriedem | dansmith: efried: why is the server_default=text("0") needed here? https://review.openstack.org/#/c/557958/27 | 16:28 |
| mriedem | i remember this coming up some other time | 16:28 |
| cdent | there was discussion about it very early in the process of consumer generations, so perhaps in on of ed's abandoned reviews? | 16:30 |
| efried | cdent, mriedem: No, it's on this one. See zzzeek's comments on PS4 and 4 | 16:31 |
| efried | 5 | 16:31 |
| efried | not sure why it wouldn't still apply. | 16:31 |
| efried | I didn't really understand it to begin with. | 16:31 |
| mriedem | well, that sounds like server_default="0" is wrong and server_default=text("0") is right, but (1) why is server_default needed to begin with and (2) why isn't text() used in the model definition also? | 16:33 |
| mriedem | the "default" value is a Python-interpreted value, so we use the integer zero. It's applied to the insert() construct in Python before it is sent to the driver. The "server_default" OTOH is a SQL expression that needs to be rendered in a CREATE TABLE or ALTER TABLE statement just once on the server, then the server uses that value from then on. This value is emitted directly to the server at DDL time. Backg | 16:33 |
| mriedem | d on defaults is at http://docs.sqlalchemy.org/en/latest/core/defaults.html | 16:33 |
| mriedem | from PS5 | 16:33 |
| mriedem | so it sounds like it should at least be mirroring server_default=text("0") in the model definition | 16:34 |
| mriedem | it also doesn't explain why we didn't need server_default on the resource_providers CREATE TABLE in migration 016 | 16:35 |
| efried | cdent: Reviewed https://review.openstack.org/#/c/572576/ | 16:35 |
| cdent | thanks | 16:36 |
| jroll | mriedem: this is adding a column to an existing table, so the server_default bit will make existing rows 0 for that column | 16:36 |
| jroll | rather than NULL | 16:36 |
| efried | mriedem: I think to get satisfaction on this you're going to need to involve Jay and Mike. | 16:36 |
| efried | or, apparently, jroll knows about this stuff :) | 16:37 |
| jroll | only because I hate the difference between default and server_default :) | 16:37 |
| mriedem | jroll: ok i figured maybe that was it, | 16:38 |
| jroll | also just kinda making assumptions about it based on the nullable=False | 16:38 |
| mriedem | but then why not mirror the server_default=text("0") usage in the model definition - is it even needed in the model definition? | 16:38 |
| mriedem | note that text() is used in the script but not the model def | 16:38 |
| mriedem | and apparently that was a problem: https://review.openstack.org/#/c/557958/4/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/059_add_consumer_generation.py@26 | 16:38 |
| mriedem | to not use text() | 16:38 |
| * jroll doesn't know that but would also make it the same in both | 16:38 | |
| mriedem | ok, now i need to decide if i rebase the entire series, which needs a mv bump, or just this one patch...or the 4 that don't have a merge conflict... | 16:40 |
| efried | mriedem: How long is Jay out? | 16:42 |
| mriedem | no idea, but i'm assuming he's busy | 16:42 |
| mriedem | so i'll just rebase this | 16:42 |
| mriedem | wanna keep the train rolling | 16:43 |
| cdent | twitter suggests that jay is in $some_other_city today for $job orientation, but it is only 4 hours long, but requires lots of transit time | 16:56 |
| *** tssurya has quit IRC | 17:11 | |
| *** e0ne has joined #openstack-placement | 17:21 | |
| *** e0ne has quit IRC | 17:25 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add InstanceNUMATopology to LibvirtLiveMigrateData https://review.openstack.org/566398 | 17:29 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: LM: re-fit topology and claim resources on dest https://review.openstack.org/567242 | 17:29 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration https://review.openstack.org/566723 | 17:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: placement: always create consumer records https://review.openstack.org/567678 | 17:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: add consumers generation field https://review.openstack.org/557958 | 17:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: placement: Allocation.consumer field https://review.openstack.org/565405 | 17:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407 | 17:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604 | 17:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix nits from change Id609789ef6b4a4c745550cde80dd49cabe03869a https://review.openstack.org/574324 | 17:38 |
| *** e0ne has joined #openstack-placement | 17:43 | |
| openstackgerrit | Dan Smith proposed openstack/nova stable/pike: Change consecutive build failure limit to a weigher https://review.openstack.org/573248 | 18:10 |
| openstackgerrit | Curt Moore proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.openstack.org/574301 | 18:12 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 18:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262 | 18:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 18:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269 | 18:14 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 18:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: xenapi: drop deprecated vif_driver config option https://review.openstack.org/567877 | 18:30 |
| *** e0ne has quit IRC | 18:33 | |
| openstackgerrit | Curt Moore proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.openstack.org/574301 | 18:35 |
| openstackgerrit | Merged openstack/nova stable/queens: Fix interpretation of max_attempts for scheduling alternates https://review.openstack.org/573254 | 18:49 |
| efried | cdent: I'm going to download the PlacementDirect patch and play around with it to see if I can "explain" the Adapter thing via code, k? | 19:05 |
| cdent | roger that, wfm, thanks | 19:05 |
| efried | I can post my findings in a subsequent change so as not to muddy the waters, and if you (and others) likey, we can squash. Or whatever. | 19:05 |
| efried | cdent: If, once I've twiddled things around, I can successfully run the test files that patch touches, will that be sufficient evidence that it "works"? | 19:06 |
| *** e0ne has joined #openstack-placement | 19:07 | |
| cdent | i should think so, yes | 19:07 |
| cdent | if you're sufficiently happy with the changes, just commit them back, add yourself as a co-author and we'll move things along yeah? | 19:07 |
| efried | cdent: Except only you and I have weighed in on that as being a desired direction. | 19:08 |
| efried | cdent: Was thinking having separate changes could give folks the ability to compare/contrast and "vote". | 19:08 |
| efried | and it's easy to squash later. | 19:08 |
| efried | But horse<-cart, lemme see if I can even do it first. | 19:08 |
| cdent | if you like but it's also just as easy to resumit older versios of the same gerrit review. whatever works best for you | 19:09 |
| efried | ack | 19:10 |
| *** e0ne has quit IRC | 19:11 | |
| *** mriedem1 has joined #openstack-placement | 19:26 | |
| *** mriedem has quit IRC | 19:28 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_util https://review.openstack.org/574403 | 19:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.handlers.test_aggregate https://review.openstack.org/574404 | 19:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_requestlog https://review.openstack.org/574405 | 19:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_fault_wrap https://review.openstack.org/574406 | 19:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_handler https://review.openstack.org/574407 | 19:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_microversion https://review.openstack.org/574408 | 19:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_deploy https://review.openstack.org/574409 | 19:31 |
| openstackgerrit | Zack Cornelius proposed openstack/nova master: Refactor libvirt get_memory_used_mb() https://review.openstack.org/571030 | 19:33 |
| openstackgerrit | Zack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876 | 19:33 |
| mriedem1 | edleafe: i assume https://review.openstack.org/#/c/564641/ and https://review.openstack.org/#/c/562000/ are superseded and can be abandoned now? | 19:37 |
| *** mriedem1 is now known as mriedem | 19:37 | |
| mriedem | i've added the consumer generation bp to the runways queue for completeness | 19:38 |
| edleafe | mriedem: yeah, that ship sailed a long time ago. | 19:40 |
| mriedem | ack, thanks | 19:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Keep attach_mode as top-level field in _translate_attachment_ref https://review.openstack.org/574413 | 19:45 |
| *** e0ne has joined #openstack-placement | 19:49 | |
| -openstackstatus- NOTICE: Zuul was restarted for a software upgrade; changes uploaded or approved between 19:30 and 19:50 will need to be rechecked | 19:57 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Use oslo.messaging per-call monitoring https://review.openstack.org/566696 | 20:17 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Use oslo.messaging per-call monitoring https://review.openstack.org/566696 | 21:09 |
| openstackgerrit | Julia Kreger proposed openstack/nova master: ironic: bugfix: ensure a host is set for volume connectors https://review.openstack.org/571982 | 21:16 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Direct Placement API: ksa Adapter https://review.openstack.org/574470 | 21:27 |
| efried | cdent: ^ ! | 21:27 |
| * cdent looks | 21:28 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Direct Placement API: ksa Adapter https://review.openstack.org/574470 | 21:31 |
| efried | cdent: Sorry, forgot to commit the last leetle delta, which removed a TODO of yours :) | 21:31 |
| cdent | you really can't resist nested methods and classes, can you? :) | 21:32 |
| * cdent sees why | 21:33 | |
| openstackgerrit | Merged openstack/nova master: Document the internal online_migrations function behaviors https://review.openstack.org/574268 | 21:35 |
| efried | cdent: You mean the ReportClientInterceptor? | 21:36 |
| cdent | yes | 21:37 |
| efried | cdent: Yeah, I had it outside at first, but then I had to pass the TestCase (i.e. `self`) from the _interceptor method in order to invoke _set_client, which was icky. | 21:37 |
| efried | This isn't non-icky, but I find it *less* icky. | 21:37 |
| efried | And it only needs to be done once, in this place. | 21:38 |
| cdent | yeah, seems good | 21:39 |
| cdent | and overall it seems good | 21:39 |
| efried | Of course, I could avoid it altogether by doing | 21:39 |
| efried | with self._interceptor() as client: | 21:39 |
| efried | self.rt.report_client = client | 21:39 |
| efried | etc. | 21:39 |
| efried | everywhere. Or refactoring the world to avoid repeating. | 21:39 |
| * cdent nods | 21:39 | |
| efried | cdent: I figured the biggest selling point for you would be the hard line between placement and nova. The placement parts of this can live totally in placement post-extract. | 21:40 |
| cdent | yeah, totes | 21:40 |
| cdent | for reasons unclear the diff is chunked up in a weird ass way | 21:40 |
| efried | example? | 21:40 |
| cdent | https://review.openstack.org/#/c/574470/2/nova/api/openstack/placement/direct.py | 21:41 |
| cdent | init is split in half | 21:42 |
| cdent | i can read it just fine, is just annoying | 21:43 |
| cdent | nice work, in any case | 21:43 |
| cdent | col lab or a tion | 21:43 |
| efried | cdent: Yeah, it's because previously you were doing the Adapter setup in NoAuthReportClient and the mocking in PlacementDirect; now they're both done in that one init | 21:44 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Use oslo.messaging per-call monitoring https://review.openstack.org/566696 | 21:44 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Direct Placement API: ksa Adapter https://review.openstack.org/574470 | 21:44 |
| efried | cdent: Removed that mock, and another one I missed ^ | 21:44 |
| efried | cdent: If you feel squashing is appropriate and are willing to do that legwork (which I guess is mainly merging the commit messages), I'd be on board. | 21:46 |
| efried | cdent: I prefer the Adapter-based way, but of course I'm biased. | 21:46 |
| efried | perhaps it would be prudent to let tests finish up first. I only ran those three suites. | 21:47 |
| efried | cdent: btw, I didn't look at all yet, but would it be possible to swap the guts of the gabbi fixture for this? | 21:47 |
| cdent | I'm done for today and will be otherwise engaged into your morning tomorrow so you might be able to beat me to it, but if you don't, I can | 21:47 |
| efried | ack | 21:48 |
| cdent | no, the intercept part of the gabbi fixture is effectively built into gabbi (you give it a wsgi app and that's fine). The meat of those fixtures are setting up database and conf (stuff the nova test bases do, but those fixtures are not based on them) and then doing all the object creation | 21:49 |
| cdent | those fixtures are also special in that they are per test file, not per test | 21:49 |
| efried | okay | 21:49 |
| efried | cdent: btw, I fixed that set_override you noted in the preceding. | 21:49 |
| efried | seems to work fine | 21:49 |
| cdent | yeah, saw that, good | 21:50 |
| efried | cdent: I assume that means that, if you want keystone, you can provide a real [api] setup? | 21:50 |
| efried | oh, nm | 21:50 |
| efried | set_override, not set_default | 21:50 |
| cdent | efried: simple set of test cleanups, if you're feeling it: https://review.openstack.org/#/c/574403/ | 21:55 |
| efried | cdent: saw those go by, will have a swing at 'em. | 21:55 |
| cdent | thank | 21:57 |
| cdent | s | 21:57 |
| efried | cdent: wanna fix the bp name in the commit messages before I go any further? | 21:57 |
| efried | cdent: The clickythrough still works to find your blueprint, but I'm sure there's some other accounting that's broken. | 21:58 |
| efried | Like probably it's not putting these on your whiteboard. | 21:58 |
| cdent | oh noes. yeah. one mo. sigh | 21:58 |
| *** e0ne has quit IRC | 21:59 | |
| efried | cdent: You can squash all but the last one together too if you like. I'm gonna fast-approve them. | 22:00 |
| cdent | Did you see my comment (on the first one) for why I didn't squash. There are a lot of conflicting messages on whether to go big or small. | 22:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_util https://review.openstack.org/574403 | 22:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.handlers.test_aggregate https://review.openstack.org/574404 | 22:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_requestlog https://review.openstack.org/574405 | 22:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_fault_wrap https://review.openstack.org/574406 | 22:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_handler https://review.openstack.org/574407 | 22:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_microversion https://review.openstack.org/574408 | 22:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not use nova.test in placement.test_deploy https://review.openstack.org/574409 | 22:01 |
| efried | cdent: I did see that, but they're all the same except that last one. | 22:03 |
| efried | cdent: You noted uuidsentinel, but didn't change it. | 22:03 |
| cdent | that's not true they are more different than that | 22:03 |
| cdent | there are at least three different styles | 22:04 |
| efried | well eff me, maybe I should take another look. | 22:05 |
| *** nicolasbock has quit IRC | 22:05 | |
| efried | cdent: Guess I'm not seeing it. | 22:06 |
| cdent | deploy mentions self.flags | 22:07 |
| efried | Right, I said except the last one. | 22:07 |
| cdent | test_fault_wrap mentions stderr capture and logging | 22:07 |
| cdent | and then the two other styles are "those that mention uuidsentinel" and "those that don't" | 22:08 |
| efried | Roger that. | 22:10 |
| efried | If anyone's super pissed about the stderr fixture, we can always revert. I don't think it's worth haggling about rn. | 22:10 |
| cdent | this has died in test after +W (with real failures) but it's too late for me: https://review.openstack.org/#/c/557958/ | 22:17 |
| cdent | goodight efried, thanks for doing that adapter stuff. onward we go. | 22:18 |
| efried | cdent: g'night | 22:18 |
| *** cdent has quit IRC | 22:19 | |
| *** mriedem has quit IRC | 22:21 | |
| *** edmondsw has quit IRC | 22:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Time how long pre_live_migration() takes https://review.openstack.org/574481 | 23:15 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test heartbeat code in pre_live_migration https://review.openstack.org/574482 | 23:15 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583 | 23:19 |
| *** mriedem has joined #openstack-placement | 23:31 | |
| mriedem | so, GET /placement/allocations/8fb32554-5bdf-4f3b-979e-8221447f0678" status: 200 len: 19 microversion: 1.12 - if that returns something, it should always include project_id/user_id keys, even if the values are None, right? | 23:32 |
| mriedem | aha | 23:39 |
| mriedem | KeyError: "Missing project_id/user_id in: {u'allocations': {}}" | 23:39 |
| mriedem | When listing allocations for a consumer uuid that has no allocations a dict with an empty value is returned {"allocations": {}}." | 23:39 |
| mriedem | ^ is confusing | 23:45 |
| mriedem | i.e. if i don't have allocatoins, just return {}? | 23:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Heal allocations with missing/incomplete consumer information https://review.openstack.org/574488 | 23:48 |
| openstackgerrit | Merged openstack/nova master: placement: always create consumer records https://review.openstack.org/567678 | 23:49 |
| *** mriedem has quit IRC | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!