*** edmondsw has joined #openstack-placement | 00:07 | |
*** edmondsw has quit IRC | 00:12 | |
openstackgerrit | Merged openstack/nova master: Use valid UUID in the placement gabbits https://review.openstack.org/580357 | 00:55 |
---|---|---|
openstackgerrit | Merged openstack/nova master: cover migration cases with functional tests https://review.openstack.org/493865 | 00:55 |
*** ttsiouts has quit IRC | 00:55 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110 | 00:56 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113 | 00:57 |
openstackgerrit | Merged openstack/nova master: VMware: save VC reads for information that is static https://review.openstack.org/574552 | 01:17 |
*** edmondsw has joined #openstack-placement | 01:55 | |
*** edmondsw has quit IRC | 02:00 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP Support Relative URL for version API https://review.openstack.org/580544 | 02:35 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP Support Relative URL for version API https://review.openstack.org/580544 | 02:36 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974 | 02:42 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 02:43 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: WIP: Stop redirect of '' to '/' for version API https://review.openstack.org/580544 | 02:47 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 03:40 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 03:40 |
*** edmondsw has joined #openstack-placement | 03:43 | |
*** edmondsw has quit IRC | 03:48 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Update root providers in same tree https://review.openstack.org/580246 | 04:20 |
openstackgerrit | Shilpa Devharakar proposed openstack/nova master: WIP: Consistency_Groups assignment" https://review.openstack.org/580557 | 04:51 |
*** edmondsw has joined #openstack-placement | 05:31 | |
*** edmondsw has quit IRC | 05:36 | |
*** nicolasbock has joined #openstack-placement | 06:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019 | 06:44 |
*** tssurya has joined #openstack-placement | 06:47 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 06:49 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 06:50 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 06:50 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform metrics.update notification https://review.openstack.org/580567 | 07:05 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform metrics.update notification https://review.openstack.org/580567 | 07:08 |
*** edmondsw has joined #openstack-placement | 07:20 | |
*** gibi is now known as gibilet | 07:22 | |
*** edmondsw has quit IRC | 07:24 | |
*** gibilet is now known as giblet | 07:33 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 07:35 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 07:35 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 07:35 |
*** ttsiouts has joined #openstack-placement | 07:53 | |
*** ttsiouts has quit IRC | 07:54 | |
*** ttsiouts has joined #openstack-placement | 07:54 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 08:03 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 08:04 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 08:04 |
*** takashin has left #openstack-placement | 08:04 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628 | 08:10 |
*** nicolasbock has quit IRC | 08:15 | |
*** nicolasbock has joined #openstack-placement | 08:15 | |
*** nicolasbock_ has joined #openstack-placement | 08:23 | |
*** nicolasbock has quit IRC | 08:25 | |
*** nicolasbock_ has quit IRC | 08:36 | |
*** nicolasbock_ has joined #openstack-placement | 08:43 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628 | 08:48 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Refactor policies to policy in InstanceGroup DB model https://review.openstack.org/579113 | 08:48 |
*** edmondsw has joined #openstack-placement | 09:08 | |
*** edmondsw has quit IRC | 09:12 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 09:28 |
*** cdent has joined #openstack-placement | 09:28 | |
deepak_mourya | cdent: Hi | 09:29 |
cdent | hi deepak_mourya | 09:30 |
deepak_mourya | cdent: As discussed yesterday with the jaypipe i have to create placement_resource_provider_inuse | 09:32 |
deepak_mourya | but i am encountered some error | 09:32 |
* cdent nods | 09:32 | |
cdent | can you point me at the code? | 09:33 |
deepak_mourya | i am showing you the pseudo code | 09:33 |
deepak_mourya | - name: put an allocation | 09:33 |
deepak_mourya | PUT: /allocations/599ffd2d-526a-4b2e-8683-f13ad25f9958 | 09:33 |
deepak_mourya | request_headers: | 09:33 |
deepak_mourya | content-type: application/json | 09:33 |
deepak_mourya | data: | 09:33 |
deepak_mourya | allocations: | 09:33 |
deepak_mourya | - resource_provider: | 09:33 |
deepak_mourya | uuid: $ENVIRON['RP_UUID'] | 09:33 |
deepak_mourya | resources: | 09:33 |
deepak_mourya | DISK_GB: 10 | 09:33 |
deepak_mourya | status: 204 | 09:33 |
deepak_mourya | - name: Delete inuse resource provider | 09:33 |
deepak_mourya | DELETE: /resource_providers/$ENVIRON['RP_UUID'] | 09:33 |
deepak_mourya | request_headers: | 09:33 |
deepak_mourya | I did this here https://github.com/openstack/nova/blob/master/nova/tests/functional/api/openstack/placement/gabbits/allocations.yaml#L135 | 09:34 |
* cdent nods | 09:34 | |
cdent | and the error? | 09:35 |
deepak_mourya | encountered error is : | 09:35 |
deepak_mourya | AssertionError: json path $.errors[0].code cannot match {u'errors': [{u'status': 409, u'title': u'Conflict', u'detail': u'There was a conflict when trying to complete your request.\n\n Unable to delete resource provider fa7aad4d-e18e-4381-877c-5c4c2a86dbca: Resource provider has allocations. ', u'request_id': u'req-91e40592-b476-4849-9e3e-2bd3b83879cf'}]} | 09:35 |
deepak_mourya | In my understanding here is already one conflict test https://github.com/openstack/nova/blob/master/nova/tests/functional/api/openstack/placement/gabbits/with-allocations.yaml#L32 | 09:36 |
cdent | that error will be because the comment=errors.THE_CODE is not in place for the exception that is causing the HTTPConflict reponse | 09:37 |
cdent | the error response body has no 'code' attribute | 09:37 |
deepak_mourya | - name: Delete inuse resource provider | 09:38 |
deepak_mourya | DELETE: /resource_providers/$ENVIRON['RP_UUID'] | 09:38 |
deepak_mourya | request_headers: | 09:38 |
deepak_mourya | content-type: application/json | 09:38 |
deepak_mourya | status: 409 | 09:38 |
deepak_mourya | response_strings: | 09:38 |
deepak_mourya | - "Unable to delete resource provider $ENVIRON['RP_UUID']" | 09:38 |
deepak_mourya | response_json_paths: | 09:38 |
deepak_mourya | errors[0].code: placement.resource_provider.inuse | 09:38 |
deepak_mourya | yes but i have got the same when i use error code , after removing error code test will be successfull | 09:38 |
cdent | deepak_mourya: I'm struggling to understand what is going on. Can you push the code you have now up to gerrit so I can look at it there and try how it is failing myself? | 09:40 |
deepak_mourya | ok wait | 09:40 |
deepak_mourya | https://review.openstack.org/#/c/579423/ | 09:40 |
cdent | thanks, let me take a look | 09:41 |
deepak_mourya | ok sure | 09:41 |
cdent | oh, I mean the code that you currently have in progress that is not working as you expect, can you push it up to that review | 09:42 |
deepak_mourya | actually i could not understand the flow of my code and the actual error | 09:43 |
cdent | let me try something, one moment | 09:44 |
deepak_mourya | ok , Thanks | 09:44 |
cdent | deepak_mourya: I figured it out. The error codes only show up with microversion 1.23 and beyond, and that file was defaulting to an earlier one. This works: http://paste.openstack.org/show/725222/ | 09:55 |
deepak_mourya | cdent: oh i couldn't have that idea of using microversion here | 09:57 |
cdent | deepak_mourya: yeah, it's not particularly obvious is it? but if you look at the json_error_formatter code you'll see that it controls when codes are presented based on microversion | 10:07 |
openstackgerrit | Deepak Mourya proposed openstack/nova master: Resource_provider API handler does not return specific error codes https://review.openstack.org/579423 | 10:09 |
deepak_mourya | cdent: ok thanks for explaining all these things and your help :) | 10:10 |
cdent | no problem, thank you for helping out | 10:10 |
deepak_mourya | cdent: I am also curious to work these kinds of patches if you encounter in the future :) | 10:12 |
cdent | I'll try to remember to point things out when they come up | 10:13 |
deepak_mourya | sure :) | 10:13 |
*** edmondsw has joined #openstack-placement | 10:56 | |
*** edmondsw has quit IRC | 11:00 | |
*** cdent has quit IRC | 11:34 | |
*** cdent has joined #openstack-placement | 11:38 | |
*** edmondsw has joined #openstack-placement | 11:44 | |
*** cdent has quit IRC | 11:48 | |
*** rubasov has quit IRC | 11:51 | |
*** cdent has joined #openstack-placement | 11:52 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628 | 12:28 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Refactor policies to policy in InstanceGroup DB model https://review.openstack.org/579113 | 12:28 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 12:28 |
giblet | cdent, jaypipes: does anybody started (or planning to start) bumping the placement version in the scheduler report clinet used for allocation_candidates query to support nested RPs? | 12:33 |
jaypipes | giblet: I think we need to complete the reshaper stuff before that is plausible, right? | 12:34 |
cdent | giblet: i'm not aware of anyone doing that yet. efried_off and I were discussing earlier this week that things like migration handling is not prepared to deal with the allocations with more than one provider (either shared or nested) | 12:34 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 12:34 |
giblet | jaypipes: do you mean reshaper is needed as we have GPU RPs we need to move to nested? | 12:42 |
giblet | cdent: thanks. | 12:42 |
jaypipes | giblet: not just GPU RPs, but the NUMA stuff that bauzas is doing relies on the reshaper being in place so that we can safely migrate the modeling of single-compute-node providers to nested providers. | 12:56 |
cdent | giblet: that thing you just wrote about nested working by chance before 1.29 was likey the result of the incremental way in which the functionality was added. There's a bit of discussion on https://review.openstack.org/#/c/565487/ and related patches | 12:57 |
giblet | jaypipes: ahh yes, NUMA as ell | 12:59 |
giblet | well | 12:59 |
*** edleafe is now known as figleaf | 12:59 | |
bauzas | giblet: jaypipes: sorry if you see me a bit off, but I'll need to have a surgery next week for 2 weeks | 13:00 |
giblet | cdent: I guessed that this was the case | 13:00 |
figleaf | bauzas: wow, that's a long operation! | 13:02 |
jaypipes | bauzas: no worries, hope all goes well with that! | 13:03 |
* figleaf couldn't resist | 13:03 | |
giblet | bauzas: take care for your health | 13:03 |
bauzas | figleaf: no, sorry, I will be on the hospital for one day, but then I'll need to take 2 weeks off | 13:03 |
figleaf | bauzas: heh, I figured that. Just wanted to lighten your spirits | 13:04 |
figleaf | bauzas: take good care of yourself | 13:04 |
bauzas | thnaks | 13:04 |
stephenfin | whoops | 13:10 |
*** stephenfin is now known as finucannot | 13:10 | |
finucannot | How rude of me | 13:10 |
*** mriedem has joined #openstack-placement | 13:18 | |
openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 13:21 |
openstackgerrit | sahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 13:21 |
giblet | cdent: I'm wondering how can I help you and efried_off with the fixing the migration allocations with nested RPs | 13:39 |
cdent | giblet: I suppose one useful thing is that thing you often do: write some failing functional tests? | 13:40 |
giblet | cdent: I could write functional tests where the flavor asks for ... | 13:40 |
giblet | :) | 13:40 |
cdent | :) | 13:40 |
cdent | \o/ | 13:41 |
giblet | I talked with the author of https://review.openstack.org/#/c/527728/ before he left for vacation so I think I will take over that patch | 13:42 |
cdent | one thing I'm not clear on is how much stuff is half enabled. That is: how much functionality is exposed on the nova side that is currently broken, and how much is not exposed at all, and thus not broken | 13:42 |
cdent | that patch looks like a great place to start | 13:42 |
giblet | cdent: I think after 1.29 merged in placement, the allocation_candidates query response will be empty for nested requests | 13:43 |
giblet | cdent: that is not broken per se as 1.29 is not used in the schedule report client yet | 13:43 |
cdent | I was more thinking in terms of flavor to query string translation | 13:43 |
giblet | cdent: I can verify that! | 13:44 |
giblet | cdent: and I feel that most of it is OK based on my trials in the bandwidth series | 13:45 |
cdent | if it is already okay, that means we have half-exposed the functionality | 13:45 |
giblet | cdent: you can ask for resources in the flavor that might or might not coming from a nested RP | 13:46 |
giblet | cdent: if it is coming from the compute RP it works today, but if it coming from a nested then it will fail with no valid host | 13:46 |
giblet | cdent: at least this is my current expectation | 13:46 |
* cdent nods | 13:47 | |
*** edmondsw has quit IRC | 14:23 | |
*** edmondsw has joined #openstack-placement | 14:24 | |
*** edmondsw has quit IRC | 14:27 | |
*** edmondsw has joined #openstack-placement | 14:32 | |
*** purplerbot has quit IRC | 14:49 | |
*** purplerbot has joined #openstack-placement | 14:49 | |
cdent | mriedem: you happy if I or you mark https://bugs.launchpad.net/nova/+bug/1765376 as wontfix (was reviewing old bugs and that one is kind of stale) | 14:52 |
openstack | Launchpad bug 1765376 in OpenStack Compute (nova) "nova scheduler log contains html" [Low,Confirmed] | 14:52 |
cdent | (i'm asking you because you confirmed it) | 14:52 |
mriedem | cdent: sure, sounds like it's no longer a problem since https://review.openstack.org/#/c/518223/ | 14:54 |
cdent | thanks | 14:55 |
cdent | done | 14:56 |
efried_off | cdent, jaypipes: We should close https://bugs.launchpad.net/nova/+bug/1731072 as it mentioned half a dozen related-but-separate buggish things. Some of them have been fixed for sure, but not positive whether all of them have. So we should kill it and then open individual issues as/if we see them. | 14:57 |
openstack | Launchpad bug 1731072 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with multiple aggregates" [Medium,Confirmed] | 14:57 |
cdent | efried_off: roger that. if you are really off, please be off | 14:58 |
efried_off | cdent: Wife went to the store for an hour, so I'm sneaking in some time :) | 14:58 |
cdent | you have an illness | 14:59 |
efried_off | You know how it is. For one thing I don't want to come back on Monday and have like 900 emails to paw through. Rather keep it trimmed. | 15:00 |
*** deepak_mourya has quit IRC | 15:03 | |
openstackgerrit | Chen proposed openstack/nova master: Fix server_group_members quota check https://review.openstack.org/580684 | 15:07 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 15:10 |
openstackgerrit | Merged openstack/nova master: Fix whitespace damage https://review.openstack.org/580370 | 15:10 |
*** openstackgerrit has quit IRC | 15:19 | |
*** ttsiouts has quit IRC | 15:19 | |
*** tssurya has quit IRC | 15:22 | |
*** openstackgerrit has joined #openstack-placement | 15:25 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add NUMATopologyLimits.networks https://review.openstack.org/575486 | 15:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Start accounting for networks in NUMA fitting https://review.openstack.org/564448 | 15:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add RequestSpec.network_metadata https://review.openstack.org/564442 | 15:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata https://review.openstack.org/564452 | 15:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440 | 15:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field https://review.openstack.org/564441 | 15:25 |
*** mriedem is now known as mriedem_away | 15:45 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle compare in test_pre_live_migration_volume_backed* directly https://review.openstack.org/580702 | 15:46 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional test for booting with nested resources https://review.openstack.org/527728 | 16:04 |
giblet | cdent, efried_off: ^^ my first stab for using nested RPs from nova | 16:05 |
cdent | cool, will look soon | 16:05 |
giblet | cdent: nothing fancy but the logs at least shows (if you for self.fail() the test) that the allocation_candidates query generation is OK | 16:07 |
giblet | s/for self.fail()/force self.fail()/ | 16:07 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional test for booting with nested resources https://review.openstack.org/527728 | 16:13 |
*** ttsiouts has joined #openstack-placement | 16:45 | |
*** ttsiouts has quit IRC | 16:47 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Avoid requesting DISK_GB allocation for root_gb on BFV instances https://review.openstack.org/580720 | 16:54 |
*** smcginnis is now known as smcginnis_afk | 17:08 | |
*** mriedem_away is now known as mriedem | 17:10 | |
*** e0ne has joined #openstack-placement | 17:44 | |
*** cdent has quit IRC | 17:51 | |
*** e0ne has quit IRC | 17:56 | |
*** e0ne has joined #openstack-placement | 18:04 | |
*** tssurya has joined #openstack-placement | 18:20 | |
*** e0ne has quit IRC | 18:24 | |
openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata https://review.openstack.org/580742 | 19:20 |
openstackgerrit | Dan Smith proposed openstack/nova master: Avoid requesting DISK_GB allocation for root_gb on BFV instances https://review.openstack.org/580720 | 19:43 |
*** edmondsw_ has joined #openstack-placement | 20:09 | |
*** edmondsw has quit IRC | 20:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix server_group_members quota check https://review.openstack.org/580684 | 20:36 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regressions tests for server_group_members OverQuota https://review.openstack.org/580755 | 20:36 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regressions tests for server_group_members OverQuota https://review.openstack.org/580755 | 20:57 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix server_group_members quota check https://review.openstack.org/580684 | 20:57 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid joins in _server_group_count_members_by_user https://review.openstack.org/580764 | 21:06 |
*** nicolasbock_ has quit IRC | 21:15 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: cleanup mapping/reqspec after archive instance https://review.openstack.org/580775 | 21:52 |
*** edmondsw_ has quit IRC | 21:53 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Tighten up ReportClient use of generation https://review.openstack.org/556669 | 21:54 |
*** mriedem has quit IRC | 22:12 | |
*** tssurya has quit IRC | 22:27 | |
openstackgerrit | Rick Bartra proposed openstack/nova master: Add granularity to os-services API https://review.openstack.org/578553 | 22:40 |
*** figleaf is now known as edleafe | 22:46 | |
*** edmondsw has joined #openstack-placement | 22:49 | |
*** edmondsw has quit IRC | 22:54 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove unnecessary TODO on ubuntu installation https://review.openstack.org/580779 | 23:14 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!