| efried | jaypipes: FYI, added you to a nova-powervm spec that's basically going to be a proving ground / first pass for Generic Device Management. It includes a proposed yaml passthrough config format, as well as an overview of how a virt driver (PowerVM in this case) would make use of the setup to do generic passthrough. | 00:50 |
|---|---|---|
| jaypipes | efried: danke :) | 00:51 |
| efried | Aaand I'm out. Bis morgen ō/ | 00:52 |
| *** takashin has joined #openstack-placement | 01:01 | |
| openstackgerrit | Mike Lowe proposed openstack/nova master: Option needed for ceph rbd erasure coding support https://review.openstack.org/581055 | 01:04 |
| openstackgerrit | huanhongda proposed openstack/nova stable/queens: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/579093 | 02:08 |
| *** mriedem has quit IRC | 02:54 | |
| *** tetsuro has joined #openstack-placement | 04:03 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 04:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 04:17 |
| openstackgerrit | Merged openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832 | 04:28 |
| openstackgerrit | huanhongda proposed openstack/nova master: Remove duplicate parameter in API sample documents https://review.openstack.org/581203 | 05:47 |
| openstackgerrit | Merged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (2) https://review.openstack.org/573481 | 06:10 |
| openstackgerrit | Merged openstack/nova master: Allow templated cell_mapping URLs https://review.openstack.org/578163 | 06:10 |
| openstackgerrit | Merged openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 06:10 |
| openstackgerrit | Merged openstack/nova master: placement: delete auto-created consumers on fail https://review.openstack.org/579921 | 06:10 |
| openstackgerrit | Merged openstack/nova master: delete consumers which no longer have allocations https://review.openstack.org/581086 | 06:10 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Complete the api-ref of security group rule https://review.openstack.org/580109 | 06:41 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019 | 06:48 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | 06:59 |
| *** tssurya has joined #openstack-placement | 06:59 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | 07:01 |
| *** peereb has joined #openstack-placement | 07:19 | |
| openstackgerrit | karim proposed openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | 07:35 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Fix nits in the handling down cell spec https://review.openstack.org/581243 | 08:01 |
| openstackgerrit | huanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response https://review.openstack.org/574159 | 08:02 |
| *** takashin has left #openstack-placement | 08:02 | |
| *** ttsiouts has joined #openstack-placement | 08:05 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 08:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 08:17 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 08:36 |
| *** e0ne has joined #openstack-placement | 08:49 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/os-traits master: Switch to stestr https://review.openstack.org/581265 | 08:49 |
| *** cdent has joined #openstack-placement | 08:56 | |
| cdent | efried: re uxsuccess: old bug: https://bugs.launchpad.net/testrepository/+bug/1429196 | 09:12 |
| openstack | Launchpad bug 1429196 in Testrepository "testr is inconsistent with testtools over unexpected successes" [High,Triaged] | 09:12 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add queued for delete to instance_mappings table. https://review.openstack.org/566788 | 09:18 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add queued_for_delete field to InstanceMapping object https://review.openstack.org/566795 | 09:18 |
| openstackgerrit | Vu Cong Tuan proposed openstack/os-traits master: Switch to stestr https://review.openstack.org/581265 | 09:24 |
| *** deepak_mourya has quit IRC | 09:26 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/nova-specs master: Switch to stestr https://review.openstack.org/581284 | 09:29 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference https://review.openstack.org/581288 | 09:35 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference https://review.openstack.org/581288 | 09:36 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 09:56 |
| openstackgerrit | huanhongda proposed openstack/nova master: Microversion 2.64 - Add "deleted" time in GET server response https://review.openstack.org/574159 | 10:02 |
| openstackgerrit | Merged openstack/nova master: Regression test for bug 1779818 https://review.openstack.org/580011 | 10:03 |
| openstack | bug 1779818 in OpenStack Compute (nova) "child's root provider is not updated." [Medium,In progress] https://launchpad.net/bugs/1779818 - Assigned to Tetsuro Nakamura (tetsuro0907) | 10:03 |
| *** ttsiouts has quit IRC | 10:07 | |
| *** tetsuro has quit IRC | 11:00 | |
| *** ttsiouts has joined #openstack-placement | 11:02 | |
| cdent | yay, latest consumer gen fixes have fixed placecat: https://github.com/cdent/placecat | 11:07 |
| cdent | now to find something else to break | 11:07 |
| *** edmondsw has joined #openstack-placement | 11:25 | |
| efried | Thanks cdent. I guess since it's reported already, and we've removed the (only) xfail from nova, I'll just let it ride again :) | 11:36 |
| cdent | efried: I expect treinish will be on the case now that he's aware and has some history on the issue | 11:37 |
| efried | sweet | 11:37 |
| *** rubasov has joined #openstack-placement | 11:41 | |
| *** ttsiouts_ has joined #openstack-placement | 11:45 | |
| *** ttsiouts has quit IRC | 11:47 | |
| *** ttsiouts_ has quit IRC | 11:48 | |
| *** ttsiouts has joined #openstack-placement | 11:51 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240 | 11:55 |
| openstackgerrit | Merged openstack/nova master: Handle compare in test_pre_live_migration_volume_backed* directly https://review.openstack.org/580702 | 12:07 |
| efried | cdent: What should the error code be for GET /allocations/{thing that isn't a UUID} ? | 12:15 |
| cdent | efried: presumably you're curious if there should be some kind of symmetry? I'm unsure. I think 404, still | 12:16 |
| cdent | it's just the PUT that's the weird one. edleafe may have a different opinion or additional thoughts | 12:16 |
| cdent | the thing we don't want to do is mess with the semantics of URIs and response codes just because it is convenient | 12:16 |
| efried | No, I agree PUT /allocations/{malformed} should be 400. | 12:16 |
| efried | oh | 12:16 |
| efried | I see | 12:16 |
| efried | Because if it was PUT /alocatoinz/{real UUID} it would be 404. | 12:17 |
| efried | hm, yeah, that's a weird one. | 12:17 |
| jaypipes | efried: cdent's https://review.openstack.org/#/c/543262/ is ready for your +Wallaby if you have a moment. | 12:19 |
| jaypipes | efried: it looks like a big patch but is all really just import moves. | 12:20 |
| jaypipes | efried: and gets rid of the use of dunderinit-scoped variables. so big ++ from me on that. | 12:20 |
| cdent | efried: "weird one" indeed | 12:20 |
| efried | jaypipes: looking... | 12:20 |
| efried | jaypipes: I'll go through it, but do you want to ask Garbutt to restore his approval from PS27? | 12:23 |
| cdent | blargh. I'm having a can't seem to get out of my pj's kind of day | 12:23 |
| jaypipes | cdent: completely understand. | 12:26 |
| jaypipes | efried: sure, I can do that. | 12:26 |
| cdent | saying it out loud was shaming enough to get me to change. progress. | 12:37 |
| edleafe | efried: if the API is defined saying that that part of the URI must be a valid UUID, then 400. Otherwise, 404. | 12:38 |
| jaypipes | cdent: heh :) the life of a remotee... | 12:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP/POC] Updating queued_for_delete from instance_destroy() https://review.openstack.org/566813 | 12:53 |
| *** mriedem has joined #openstack-placement | 12:59 | |
| openstackgerrit | Merged openstack/nova master: Remove duplicate parameter in API sample documents https://review.openstack.org/581203 | 13:20 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302 | 13:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Restore connection_info after live migration rollback https://review.openstack.org/551349 | 13:24 |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | 13:26 |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver https://review.openstack.org/554195 | 13:31 |
| *** tssurya_ has joined #openstack-placement | 13:34 | |
| efried | stephenfin: What do you think of the suggestion here https://review.openstack.org/#/c/554195/14/nova/privsep/libvirt.py@276 to make the unpriv method take a use_systemd kwarg so the priv method can just be a one-line wrapper like e.g. the nova.privsep.fs methods? | 13:40 |
| stephenfin | efried: Fine by me, but let's do it as a follow-up perhaps? He's been put through the ringer on that one, heh | 13:43 |
| stephenfin | ...assuming the current patch is good as-is, which it looks to be at first glance | 13:43 |
| efried | stephenfin: I actually don't know, which is why I haven't voted. I've really just been commenting on style. | 13:44 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 13:44 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 13:44 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: remove duplicate memory check https://review.openstack.org/581365 | 13:44 |
| efried | As in, I don't know the arcana of mounting with/without root/systemd and how that plays in the context of the libvirt driver. | 13:44 |
| *** ttsiouts has quit IRC | 13:46 | |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 13:48 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: remove duplicate memory check https://review.openstack.org/581365 | 13:48 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 13:48 |
| stephenfin | efried: I understood it as "this sometimes fails without root so just use root" | 13:50 |
| stephenfin | Also, this should probably be being discussed on #openstack-nova. Whoops | 13:50 |
| cdent | demerits for both of you! | 13:53 |
| *** ttsiouts has joined #openstack-placement | 13:54 | |
| *** ttsiouts has quit IRC | 14:00 | |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 14:02 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: remove duplicate memory check https://review.openstack.org/581365 | 14:02 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168 | 14:02 |
| *** yikun has quit IRC | 14:06 | |
| *** ttsiouts has joined #openstack-placement | 14:09 | |
| *** tssurya_ has quit IRC | 14:18 | |
| openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Hide hypervisor id on windows guests https://review.openstack.org/579897 | 14:25 |
| openstackgerrit | Merged openstack/osc-placement master: Fix the 1.6 release note format https://review.openstack.org/579042 | 14:38 |
| openstackgerrit | Merged openstack/nova master: make incomplete_consumer_project_id a valid UUID https://review.openstack.org/580358 | 14:39 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Update root providers in same tree https://review.openstack.org/580246 | 14:39 |
| openstackgerrit | Merged openstack/osc-placement master: Remove doc/build during tox -e docs https://review.openstack.org/579041 | 14:40 |
| openstackgerrit | Merged openstack/osc-placement master: Fix docstring for delete allocation method https://review.openstack.org/577075 | 14:40 |
| *** peereb has quit IRC | 14:45 | |
| *** tssurya_ has joined #openstack-placement | 14:51 | |
| *** tssurya_ has quit IRC | 14:53 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 14:56 |
| *** ttsiouts has quit IRC | 15:20 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/queens: Refactor _build_device_metadata https://review.openstack.org/581398 | 15:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/queens: Consider hostdev devices when building metadata https://review.openstack.org/581399 | 15:21 |
| *** ttsiouts has joined #openstack-placement | 15:27 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Remove irrelevant comment https://review.openstack.org/578821 | 15:30 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Move static _get_power_off_values to compute_utils https://review.openstack.org/578822 | 15:30 |
| openstackgerrit | Chen proposed openstack/nova master: WIP https://review.openstack.org/581403 | 15:31 |
| *** ttsiouts has quit IRC | 15:32 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: update project/user for consumer in allocation https://review.openstack.org/581139 | 15:47 |
| jaypipes | efried: addressed your review comments on ^^ | 15:47 |
| *** ttsiouts has joined #openstack-placement | 15:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Document differences and similaries between extra specs and hints https://review.openstack.org/581410 | 15:55 |
| efried | jaypipes: ack, looking... | 15:57 |
| efried | jaypipes: So we're basically just going to accept the race as a known-possible bug for now? | 15:59 |
| efried | jaypipes: Can/should we maybe open up a lp bug for it so we don't forget to investigate? | 15:59 |
| efried | jaypipes: https://bugs.launchpad.net/nova/+bug/1781008 | 16:05 |
| openstack | Launchpad bug 1781008 in OpenStack Compute (nova) "Possible race updating consumer's proj/user" [Undecided,New] - Assigned to Jay Pipes (jaypipes) | 16:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: update project/user for consumer in allocation https://review.openstack.org/581139 | 16:05 |
| openstackgerrit | karim proposed openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | 16:06 |
| efried | jaypipes: Added the bug to the commit message, and +2 | 16:06 |
| jaypipes | efried: thx | 16:10 |
| *** ttsiouts has quit IRC | 16:16 | |
| *** tssurya has quit IRC | 16:41 | |
| *** e0ne has quit IRC | 16:51 | |
| mriedem | jaypipes: efried: couple of comments in https://review.openstack.org/#/c/581139/4/nova/api/openstack/placement/objects/consumer.py | 16:52 |
| mriedem | otherwise i'm also +2 on that one | 16:52 |
| mriedem | given i hedged on the TODO comment scenario | 16:52 |
| mriedem | if you agree with renaming that to _update() then i can make that change when i need to rebase my changes on top and then i'll fast approve | 16:54 |
| efried | I defer to jaypipes; I've got no skin in that one. | 16:55 |
| jaypipes | mriedem: responded. | 16:59 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 17:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 17:20 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488 | 17:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor _heal_instances_in_cell https://review.openstack.org/577896 | 17:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance https://review.openstack.org/577905 | 17:28 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 17:42 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | 17:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | 17:53 |
| *** mriedem has quit IRC | 17:53 | |
| *** mriedem1 has joined #openstack-placement | 17:57 | |
| *** mriedem1 is now known as mriedem | 18:00 | |
| melwitt | mriedem: from what I understand of the last scheduler meeting log, we have 4 consumer-related bug patches to review, then the first reshaper patch will be uploaded after that? | 18:17 |
| melwitt | I was wondering if we could link the reviews somewhere, either https://etherpad.openstack.org/p/nova-rocky-blueprint-status or https://etherpad.openstack.org/p/rocky-nova-priorities-tracking ? | 18:17 |
| mriedem | melwitt: i think i suggested the latter | 18:18 |
| mriedem | there are changes up (i think) from cdent and efried for their parts of reshaper | 18:18 |
| mriedem | but those depend on the sql fu from jaypipes which yes he was going to do after the multiple consumer bug fixes - a couple of which have merged now | 18:19 |
| cdent | there are, yes, but they are WIPs | 18:19 |
| efried | ^ | 18:19 |
| melwitt | yeah, I saw the WIPs. should we review them anyway or? | 18:19 |
| efried | mine not yet prolly. I'm hoping to get back to it later today and beef it up some. | 18:20 |
| mriedem | these are the 3 consumer fixes i'm aware of: https://review.openstack.org/#/c/581086/ https://review.openstack.org/#/c/581139/ https://review.openstack.org/#/c/579921/ | 18:20 |
| mriedem | i don't know what the other one is | 18:20 |
| mriedem | might be https://review.openstack.org/#/c/579654/ but that requires a microversion | 18:20 |
| melwitt | cool, thank you | 18:20 |
| mriedem | cdent: efried: are you aware of a 4th not yet fixed consumers bug? | 18:21 |
| efried | I haven't been keeping a tight handle on the consumer bugs, just reviewing patches as they're flung in my direction. cdent and/or jaypipes would know better. | 18:22 |
| mriedem | same | 18:22 |
| cdent | I think we had four and they got collapsed to three. but lemme check | 18:22 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1778763 is likely a duplicate now | 18:22 |
| openstack | Launchpad bug 1778763 in OpenStack Compute (nova) "Consumers never get deleted" [Undecided,New] | 18:22 |
| melwitt | mriedem: I just noticed the last one you linked is abandoned | 18:22 |
| mriedem | oh maybe this https://review.openstack.org/#/c/579163/ ? | 18:23 |
| cdent | yes, that one need to come to life | 18:23 |
| mriedem | i would think that https://review.openstack.org/#/c/579921/ and https://review.openstack.org/#/c/581086/ resolve | 18:25 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1778763 | 18:25 |
| openstack | Launchpad bug 1778763 in OpenStack Compute (nova) "Consumers never get deleted" [Undecided,New] | 18:25 |
| melwitt | okay cool, so we have that one. and then coming soon will be jaypipes's sql-fu for reshaper, then when the WIP reshaper patches are ready, those are next. so reshaper will be just the 3 patches or will more be expected? | 18:26 |
| cdent | there's a 4th for the fast forward upgrade tool | 18:27 |
| melwitt | k | 18:27 |
| efried | I... suppose the rt side can be done in one patch? | 18:30 |
| melwitt | made a note on https://etherpad.openstack.org/p/nova-rocky-blueprint-status in the reshaper section | 18:31 |
| *** e0ne has joined #openstack-placement | 18:31 | |
| melwitt | then linked the return 404 when no consumer found patch on https://etherpad.openstack.org/p/rocky-nova-priorities-tracking for subteam review | 18:31 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Tighten up ReportClient use of generation https://review.openstack.org/556669 | 18:31 |
| efried | jaypipes, mriedem, cdent, dansmith: This one should be ready to go finally ^ | 18:32 |
| efried | melwitt: The 404 patch isn't ready for review. jaypipes and I talked about it yesterday and concluded it's lower priority than the reshaper work, so back burner. | 18:34 |
| jaypipes | efried: I was halfway through a review on that... | 18:34 |
| efried | jaypipes: PS15 just added moar tests. Carry on. Thanks :) | 18:34 |
| melwitt | efried: oh, k. so not something we need to clear out before reshaper. got it | 18:35 |
| efried | melwitt: I *think* that's the case, yeah. | 18:35 |
| *** tssurya has joined #openstack-placement | 18:36 | |
| melwitt | jaypipes: are all of the consumer bugs you were tackling squared away now? (approved or merged) is the road clear for sql-fu for reshaper or is there anything else that needs to be done first? | 18:37 |
| jaypipes | melwitt: the last one was approved and waiting to merge. so I *think* so, yes. | 18:40 |
| melwitt | cool, thanks. wanted to make sure I'm on the right page :) | 18:40 |
| melwitt | nice work y'all | 18:41 |
| cdent | jaypipes: since I know you've got absolutely nothing better to do with your copious free time, I have a hopefully quick sql question for you. In https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/044_placement_add_projects_users.py#L69 there's a special alter statement for postgresql | 18:44 |
| cdent | i'm playing with that code with cockroachdb, and despite assertions that cockroach talks postgres, neither those lines, not the default alter work | 18:45 |
| cdent | is there a more generic way to accomplish the cast-like thing that's happening there? | 18:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/581444 | 18:46 |
| jaypipes | cdent: lemme wrap up efried's review and I'll take a looksie. | 18:47 |
| *** e0ne has quit IRC | 18:47 | |
| cdent | jaypipes: thanks. no rush. This is play for the sake of education | 18:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/581445 | 18:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: unquiesce instance after quiesce failure https://review.openstack.org/581451 | 18:56 |
| jaypipes | cdent: hmm, looks like not going to work until https://github.com/cockroachdb/cockroach/issues/9851 is done... | 19:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Delete orphan nodes before updating resources https://review.openstack.org/579922 | 19:04 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Avoid BadRequest error log on volume attachment https://review.openstack.org/581453 | 19:04 |
| jaypipes | cdent: you would need to do a fairly invasive create-new-table-select-into-that-table-with-using-clause-rename-table thing | 19:04 |
| jaypipes | cdent: not impossible, but certainly not as easy as ALTER TABLE .. USING | 19:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Address nits from consumer generation https://review.openstack.org/577227 | 19:09 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: unquiesce instance after quiesce failure https://review.openstack.org/581454 | 19:09 |
| cdent | jaypipes: hmm. yeah. meh. | 19:10 |
| * cdent considers some other options | 19:10 | |
| cdent | jaypipes: thanks for that quick response. | 19:13 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Nova objects for Libvirt NUMA config https://review.openstack.org/581456 | 19:40 |
| *** e0ne has joined #openstack-placement | 20:04 | |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Add destination MSP IP address to PowerVM migrate data https://review.openstack.org/581463 | 20:32 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Remove unused variable in migration https://review.openstack.org/581464 | 20:34 |
| openstackgerrit | Matt Rabe proposed openstack/nova master: Add destination MSP IP address to PowerVM migrate data https://review.openstack.org/579676 | 20:35 |
| *** e0ne has quit IRC | 20:53 | |
| *** e0ne has joined #openstack-placement | 20:53 | |
| openstackgerrit | Rick Bartra proposed openstack/nova master: Add granularity to os-services API https://review.openstack.org/578553 | 20:58 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Tighten up ReportClient use of generation https://review.openstack.org/556669 | 21:01 |
| efried | jaypipes: ^ | 21:01 |
| cdent | also jaypipes : further digging reveals yet more differences between how mysql, postgresql, and cockroachdb each want to deal with ordering various alters so I've given up. It can be made to work, but not currently worth the effort | 21:03 |
| cdent | efried: imma look at that in the morning | 21:03 |
| efried | thx | 21:04 |
| cdent | are there any other biggies that should be looked at sooner than later? | 21:05 |
| efried | cdent: Nothing super important. | 21:08 |
| efried | cdent: A few I've refreshed today, but they're pretty minor other than ---^ | 21:08 |
| cdent | k | 21:09 |
| cdent | I'll be around all tomorrow, but only half of thursday and none of friday | 21:09 |
| cdent | but now I retire | 21:10 |
| cdent | good night | 21:10 |
| *** cdent has quit IRC | 21:10 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Check provider generation and retry on conflict https://review.openstack.org/556669 | 21:11 |
| efried | dammit, had the commit message edit open but forgot to save it. | 21:11 |
| *** e0ne has quit IRC | 21:22 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Avoid BadRequest error log on volume attachment https://review.openstack.org/581453 | 21:37 |
| *** tssurya has quit IRC | 21:58 | |
| *** edmondsw has quit IRC | 22:01 | |
| openstackgerrit | Merged openstack/nova master: hardware: fix hugepages memory usage per intances https://review.openstack.org/580657 | 22:41 |
| openstackgerrit | Merged openstack/nova master: Update root providers in same tree https://review.openstack.org/580246 | 22:59 |
| openstackgerrit | Merged openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 22:59 |
| openstackgerrit | Merged openstack/nova master: Refactor policies to policy in InstanceGroup DB model https://review.openstack.org/579113 | 22:59 |
| *** edmondsw has joined #openstack-placement | 23:16 | |
| *** edmondsw has quit IRC | 23:21 | |
| *** bhagyashri_s has quit IRC | 23:27 | |
| *** bhagyashri_s has joined #openstack-placement | 23:28 | |
| *** takashin has joined #openstack-placement | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!