*** cdent has quit IRC | 00:02 | |
*** yikun has joined #openstack-placement | 03:24 | |
*** Nel1x has quit IRC | 03:34 | |
*** yikun has quit IRC | 06:11 | |
openstackgerrit | Chen proposed openstack/nova stable/rocky: Update ssh configuration doc https://review.openstack.org/594041 | 06:31 |
---|---|---|
openstackgerrit | Chen proposed openstack/nova stable/rocky: Revisons on notifications doc https://review.openstack.org/594042 | 06:37 |
*** tssurya has joined #openstack-placement | 06:52 | |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Ignore deleted instances when populating with availability zones https://review.openstack.org/594050 | 07:13 |
*** tetsuro has quit IRC | 07:36 | |
*** tetsuro has joined #openstack-placement | 08:08 | |
*** e0ne has joined #openstack-placement | 08:10 | |
*** cdent has joined #openstack-placement | 08:33 | |
*** mriedem has joined #openstack-placement | 09:42 | |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Set default AZ explicitely for instances without host. Ignore deleted instances when populating with availability zones https://review.openstack.org/594050 | 10:26 |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Set default AZ explicitely for instances without host. https://review.openstack.org/594050 | 10:27 |
* cdent tries to break some stuff | 10:43 | |
*** e0ne has quit IRC | 11:36 | |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | 11:44 |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Filter out instances without a host when populating AZ https://review.openstack.org/594050 | 11:47 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Re-activate source host port bindings on live migration rollback https://review.openstack.org/594139 | 11:53 |
*** yikun_ has joined #openstack-placement | 11:57 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [placement] Use oslotest uuidsentinel https://review.openstack.org/594144 | 12:05 |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | 12:07 |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | 12:23 |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Filter out instances without a host when populating AZ https://review.openstack.org/594050 | 12:26 |
cdent | mriedem: care to speculate why on one host (ubuntu bionic) I get varying numbers (~50 - ~150) of failures like this on current master: http://paste.openstack.org/show/728513/ in clean virtualenvs, both python 2.7 and 3.6, but not on another host (osx) | 12:33 |
cdent | ^ that is only a problem on a host with a lot of cpus and when only running the placement tests, so it basically comes down to conf not being initialized properly. will fix. | 13:02 |
*** efried is now known as efried_goatin | 13:03 | |
* cdent is glad he knows about efried_goatin's nanny | 13:05 | |
mriedem | cdent: so you figured it out? | 13:08 |
*** s10 has joined #openstack-placement | 13:08 | |
cdent | mriedem: yeah, I think so. it's basically global conf being tricksy | 13:09 |
mriedem | i remember having to muck with that b/c oslo_policy in nova.conf is different (and only for nova) so the placement group thing is a bit different | 13:09 |
mriedem | i.e. [placement]/policy_file i think | 13:09 |
cdent | so yeah, registering the policy opts in the gabbi fixture makes the problem go away | 13:10 |
cdent | which is a good enough fix for now, but it means we got some leakage, but from what I've been able to discern that's always been the case with the functional tests and conf | 13:11 |
cdent | and I'm not clear how, or even if, to fix it | 13:11 |
openstackgerrit | Chris Dent proposed openstack/nova master: Set policy_opt defaults in placement gabbi fixture https://review.openstack.org/594172 | 13:28 |
cdent | mriedem that ought to fix it | 13:29 |
mriedem | cdent: so the gabbi tests dont' go through this right? https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/wsgi.py#L71 | 13:32 |
cdent | correct, but they do go through deploy, and it is in deploy where the option is used | 13:32 |
mriedem | +2 | 13:34 |
cdent | :slack thumb of upness: | 13:35 |
*** efried_goatin is now known as efried | 13:37 | |
mriedem | you stick your slacks in a sack mister | 13:38 |
mriedem | say what you will about irc, at least we don't have animated gifs | 13:39 |
*** e0ne has joined #openstack-placement | 13:40 | |
efried | dude, my client was translating emojis to images and it was making me freakin crazy. | 13:42 |
cdent | :) :( | 13:42 |
efried | There was no actual option to turn it off - I had to go hacking into internal configs. | 13:42 |
efried | oh, I took care of it. Because e.g. ^^ (which I use all the time to mean, "look at the above - no, really, look at the above") was showing up as an emoji. | 13:42 |
mriedem | ;P | 13:44 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter out instances without a host when populating AZ https://review.openstack.org/594050 | 13:44 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Filter out instances without a host when populating AZ https://review.openstack.org/594178 | 13:50 |
edleafe | ah, now we know how to mess with efried | 13:54 |
efried | Like I said, it's no longer an issue. I had to hack the client, but it was that or pick a new client. | 13:55 |
edleafe | doh! | 13:56 |
openstackgerrit | Jiri Suchomel proposed openstack/nova stable/pike: Filter out instances without a host when populating AZ https://review.openstack.org/594184 | 13:58 |
openstackgerrit | Surya Seetharaman proposed openstack/nova stable/queens: Filter out instances without a host when populating AZ https://review.openstack.org/594185 | 14:00 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Filter out instances without a host when populating AZ https://review.openstack.org/594185 | 14:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Filter out instances without a host when populating AZ https://review.openstack.org/594184 | 14:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge config drive extension response into server controller https://review.openstack.org/584223 | 14:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | 14:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge keypair extension response into server view builder https://review.openstack.org/584748 | 14:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge server usage extension response into server view builder https://review.openstack.org/585262 | 14:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge security groups extension response into server view builder https://review.openstack.org/585475 | 14:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge extended_status extension response into server view builder https://review.openstack.org/592092 | 14:53 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Record cell success/failure/timeout in CrossCellLister https://review.openstack.org/594265 | 14:56 |
openstackgerrit | Jose Castro Leon proposed openstack/nova master: Add extend in-use volumes support for RBD https://review.openstack.org/594273 | 15:04 |
cdent | edleafe: you still away? | 15:15 |
cdent | was wondering about the state of your filtering experiments | 15:16 |
*** s10 has quit IRC | 15:18 | |
*** alex_xu has quit IRC | 15:23 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Explicitly fail if trying to attach SR-IOV port https://review.openstack.org/591898 | 15:42 |
*** e0ne has quit IRC | 15:44 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Set policy_opt defaults in placement deploy unit test https://review.openstack.org/594334 | 15:57 |
cdent | mriedem, efried followup on the unit test side | 15:58 |
mriedem | +2 | 16:01 |
openstackgerrit | Dan Smith proposed openstack/nova master: Batch results per cell when doing cross-cell listing https://review.openstack.org/592698 | 16:16 |
openstackgerrit | Dan Smith proposed openstack/nova master: List instances from all cells explicitly https://review.openstack.org/593717 | 16:16 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make instance_list perform per-cell batching https://review.openstack.org/593131 | 16:16 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 16:16 |
openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | 16:17 |
efried | rebase only ^ | 16:17 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | 16:19 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 16:20 |
openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 16:20 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 16:20 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 16:20 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 16:20 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 16:20 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 16:20 |
openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 16:20 |
efried | Shuffle to put schema consts on bottom (cdent FYI) ^ | 16:20 |
cdent | roger | 16:21 |
cdent | efried: gonna stroll but when I come back will run through that stack | 16:35 |
efried | cdent: I'm still doing things | 16:35 |
efried | addressing the -1 from jay and fixing nits along the way | 16:35 |
efried | but the deltas there should be small, so feel free to review, just knowing that you'll have to come back and do the delta after. | 16:36 |
* cdent is curious about efried's development patterns and tooling | 16:36 | |
cdent | but i'll worry about that later | 16:36 |
* cdent strolls | 16:36 | |
efried | cdent: Happy to splain | 16:36 |
cdent | laterz | 16:36 |
*** s10 has joined #openstack-placement | 16:39 | |
*** s10 has quit IRC | 16:46 | |
*** nicolasbock has joined #openstack-placement | 16:59 | |
*** sean-k-mooney has quit IRC | 17:00 | |
edleafe | cdent: back | 17:04 |
edleafe | cdent: I ran it once with coarse results. Now I'm going through each file to see if we want to keep it or not. | 17:04 |
edleafe | e.g., most of the release notes are nova-specific, but there are a few placement release notes | 17:05 |
openstackgerrit | Merged openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024 | 17:36 |
openstackgerrit | Merged openstack/nova master: Set policy_opt defaults in placement gabbi fixture https://review.openstack.org/594172 | 17:36 |
openstackgerrit | Merged openstack/nova master: Set policy_opt defaults in placement deploy unit test https://review.openstack.org/594334 | 17:39 |
*** e0ne has joined #openstack-placement | 17:42 | |
cdent | edleafe: so you're saying, basically, that it worked for some form of "worked"? | 17:46 |
cdent | efried: the thing I was interested in was basically: you pushed twice to gerrit twice when you did the rebase and then the reordering, why? | 17:47 |
efried | cdent: Yeah, I figured that was what you were interested in. | 17:48 |
edleafe | Oh, it worked. I just ran it with the major directories. Now it's running with this: http://paste.openstack.org/show/728546/ | 17:48 |
efried | As a reviewer, I like to be able to diff patch sets without rebases in the way. | 17:48 |
efried | So as a courtesy to others who might feel the same way, I like to do rebases separately from actual fixes. | 17:48 |
efried | because patch sets are cheap. | 17:48 |
efried | way cheaper than the time and effort it takes me to visually differentiate between rebase-delta and actual-change-delta. | 17:49 |
* cdent nods at efried | 17:50 | |
*** tssurya has quit IRC | 17:50 | |
cdent | I guess have a form of "don't overstimulate the gate" ptsd. A form that is not particularly logical. I agree that the clean diffing is goodness | 17:53 |
cdent | efried: anyway, are you still "doing things" on that set | 17:55 |
efried | cdent: Yes, still working my way up. Posting answers when done locally. | 17:56 |
cdent | cool. when we finally get this stack merged it will feel nicde | 17:57 |
cdent | or even nice | 17:57 |
efried | aaaaaand I fucked it up. Gods damn it to the seven hells. | 18:01 |
cdent | oh noes | 18:02 |
openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Fix cancel_all_events event name parsing https://review.openstack.org/592086 | 18:04 |
openstackgerrit | Dan Smith proposed openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735 | 18:04 |
openstackgerrit | Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | 18:04 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events https://review.openstack.org/594508 | 18:30 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events https://review.openstack.org/594508 | 18:33 |
*** e0ne has quit IRC | 18:57 | |
cdent | 'night all | 19:16 |
*** cdent has quit IRC | 19:16 | |
mriedem | (12:48:29 PM) efried: As a reviewer, I like to be able to diff patch sets without rebases in the way. | 19:31 |
mriedem | +1000 | 19:31 |
mriedem | unnecessary rebase on master in a long, big series is death | 19:31 |
efried | I'm sure people have tools for looking at such diffs cleanly... | 19:32 |
*** melwitt has quit IRC | 19:33 | |
*** melwitt has joined #openstack-placement | 19:34 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event https://review.openstack.org/594527 | 19:36 |
mriedem | if i have to diff a rebase in between, | 19:36 |
mriedem | i just put up 2 side by side browser tabs of the 2 patch sets | 19:36 |
mriedem | and eyeball it | 19:36 |
mriedem | sort of like comparing a backport | 19:36 |
*** rubasov has quit IRC | 19:39 | |
*** mriedem is now known as mriedem_afk | 19:39 | |
efried | mriedem_afk: Okay, that's what I do as well. So - no better tooling at least that you know of. (I think dansmith says he downloads the deltas and does a fancy diff-of-diffs or something.) | 19:44 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 19:54 |
openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 19:54 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider raise https://review.openstack.org/584598 | 19:54 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 19:54 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 19:55 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 19:55 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 19:55 |
openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 19:55 |
efried | cdent, jaypipes: ^ ready except the top one, which is going to need a new rebase & test fixup since https://review.openstack.org/#/c/520024/ merged. | 19:55 |
*** mriedem_afk is now known as mriedem | 21:04 | |
openstackgerrit | Dmitry Sutyagin proposed openstack/nova-specs master: Allow disabling KSM / mem-merge via extra spec https://review.openstack.org/593197 | 21:40 |
*** mriedem is now known as mriedem_away | 22:22 | |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider raise https://review.openstack.org/584598 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 23:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 23:05 |
efried | cdent, jaypipes: ^ rebased and fixed up to resolve merge conflict and tweak (hopefully all the right) tests for the _update call reduction. Should be ready for full review now. | 23:05 |
efried | mriedem_away, dansmith, melwitt, gibi_off: ^ | 23:06 |
melwitt | ack | 23:06 |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | 23:42 |
openstackgerrit | Dan Smith proposed openstack/nova master: Batch results per cell when doing cross-cell listing https://review.openstack.org/592698 | 23:48 |
openstackgerrit | Dan Smith proposed openstack/nova master: List instances from all cells explicitly https://review.openstack.org/593717 | 23:48 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make instance_list perform per-cell batching https://review.openstack.org/593131 | 23:48 |
openstackgerrit | Dan Smith proposed openstack/nova master: Record cell success/failure/timeout in CrossCellLister https://review.openstack.org/594265 | 23:48 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make CELL_TIMEOUT a constant https://review.openstack.org/594570 | 23:48 |
openstackgerrit | Dan Smith proposed openstack/nova master: Stash the cell uuid on the context when targeting https://review.openstack.org/594571 | 23:48 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make RecordWrapper record RequestContext and expose cell_uuid https://review.openstack.org/594572 | 23:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!