| *** takashin has joined #openstack-placement | 00:54 | |
| *** tetsuro has joined #openstack-placement | 01:41 | |
| *** tetsuro has quit IRC | 04:05 | |
| openstackgerrit | Takashi NATSUME proposed openstack/placement master: Fix a bug tag for placement doc https://review.openstack.org/619438 | 05:40 |
|---|---|---|
| *** tetsuro has joined #openstack-placement | 07:27 | |
| *** takashin has left #openstack-placement | 08:00 | |
| *** helenafm has joined #openstack-placement | 08:25 | |
| *** e0ne has joined #openstack-placement | 09:17 | |
| *** tssurya has joined #openstack-placement | 09:23 | |
| *** dtantsur|afk is now known as dtantsur | 09:54 | |
| *** cdent has joined #openstack-placement | 09:58 | |
| * cdent waves | 09:58 | |
| *** dims has quit IRC | 11:45 | |
| *** e0ne has quit IRC | 11:46 | |
| *** e0ne has joined #openstack-placement | 11:59 | |
| lyarwood | cdent: https://bugs.launchpad.net/oslo.config/+bug/1804420 - would you mind taking a look at this as it's blocking RDO builds of placement at the moment, I'm not sure if there's anything we can do to workaround what I believe is an oslo.config bug but any ideas would be appreciated! | 12:08 |
| openstack | Launchpad bug 1804420 in oslo.config "placement unit test placement.tests.unit.cmd.test_manage.TestCommandParsers.test_commands_associated fails on CentOS 7" [Undecided,New] | 12:08 |
| cdent | lyarwood: yeah, thanks for the heads up | 12:09 |
| cdent | weird | 12:10 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add integrated-gate-py35 template to .zuul.yaml https://review.openstack.org/617565 | 12:12 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Remove keystoneauth1 opts from placement config group https://review.openstack.org/619299 | 12:12 |
| cdent | lyarwood: I suspect there is some kind of clue in the way the help handling is different between python2 and 3, but I'm not really figuring it out yet | 12:23 |
| *** tetsuro has quit IRC | 12:58 | |
| *** diga has joined #openstack-placement | 13:21 | |
| lyarwood | cdent: https://github.com/python/cpython/commit/af26c15110b76195e62a06d17e39176d42c0511c found it finally | 13:21 |
| lyarwood | cdent: that makes sense given the reproducer | 13:21 |
| * cdent nods | 13:22 | |
| cdent | What does that mean for Centos? | 13:22 |
| lyarwood | I can asked to get this backported but it's going to take an age to land | 13:23 |
| lyarwood | or we can work around this in placement itself | 13:23 |
| cdent | did you see my comment on the bug about installing argparse from pypi? | 13:23 |
| cdent | if that fixes it, is that sufficient? | 13:24 |
| lyarwood | no unfortunatley, RDO doesn't use pypi and I don't think that would override the version of argparse in stdlib anyway right? | 13:25 |
| cdent | I thought it did? And I guess I was assuming that if there's an argparse on pypi, there would be an rpm for it. If that's not the case, then I guess working around it in placement would be fine. | 13:26 |
| cdent | I know that when I created that big of code I did slightly differently from what nova does because doing a direct copy of nova made the help output be misleading about needing to say 'placement-manage command' | 13:27 |
| cdent | and there is no command command | 13:27 |
| lyarwood | yeah there's no package for argparse AFAIK, I'll double check quickly | 13:28 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Start a contributor goals document https://review.openstack.org/618811 | 13:28 |
| lyarwood | yeah there's not, okay so I'll take a look at how Nova is doing this and post something this afternoon | 13:29 |
| lyarwood | thanks again | 13:29 |
| cdent | no, thank you, I did very little. You and yours found (and are fixing) a bug. You people get the gold star. | 13:29 |
| openstackgerrit | Chris Dent proposed openstack/placement master: Remove keystoneauth1 opts from placement config group https://review.openstack.org/619299 | 13:34 |
| *** cdent_ has joined #openstack-placement | 13:39 | |
| *** cdent has quit IRC | 13:39 | |
| *** cdent_ is now known as cdent | 13:39 | |
| cdent | lyarwood: despite the test failing, does the command itself mostly work? | 13:46 |
| lyarwood | cdent: I've not really tested it yet, I assumed it wouldn't because of this failure tbh | 13:52 |
| openstackgerrit | Lee Yarwood proposed openstack/placement master: manage: Do not use set_defaults on parent parser https://review.openstack.org/619574 | 13:52 |
| cdent | lyarwood: that somewhat fixes it but is a change for python3 | 14:04 |
| cdent | so we might some version conditionals | 14:04 |
| lyarwood | cdent: ah, I did run the py36 tests and it appeared happy | 14:05 |
| * lyarwood respins | 14:06 | |
| cdent | the tests probably don't evaluate the output sufficiently tight | 14:06 |
| cdent | that is: they don't check the output to confirm the expected subcommands, it should | 14:06 |
| cdent | <- sloppy | 14:06 |
| cdent | or perhaps | 14:06 |
| cdent | <- rushed | 14:07 |
| cdent | if you're happy to add that test, please do, otherwise I'll do it in a followup | 14:07 |
| lyarwood | cdent: ah no issues, I can add these now | 14:09 |
| cdent | thanks | 14:10 |
| *** dims has joined #openstack-placement | 14:14 | |
| * cdent waves at dims | 14:17 | |
| openstackgerrit | Lee Yarwood proposed openstack/placement master: manage: Do not use set_defaults on parent parsers with py2 https://review.openstack.org/619574 | 14:56 |
| lyarwood | cdent: ^ sorry just getting dragged into something else, I'm going to leave the output checks to a follow up, tbh I'm not sure how useful they are anyway if I'm honest. | 14:57 |
| cdent | no problem. I'll look into it if I have a chance. now wrestling with grenade weirdness. it's always something | 14:58 |
| *** diga has quit IRC | 15:46 | |
| *** e0ne has quit IRC | 16:28 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add assertions to verify placement-manage error output https://review.openstack.org/619619 | 16:38 |
| *** helenafm has quit IRC | 16:59 | |
| *** e0ne has joined #openstack-placement | 17:25 | |
| *** dtantsur is now known as dtantsur|afk | 17:35 | |
| * cdent glares at grenade | 17:37 | |
| openstackgerrit | Merged openstack/placement master: Fix a bug tag for placement doc https://review.openstack.org/619438 | 17:48 |
| *** e0ne has quit IRC | 17:49 | |
| *** e0ne has joined #openstack-placement | 18:07 | |
| *** e0ne has quit IRC | 18:15 | |
| *** tssurya has quit IRC | 18:39 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!