tetsuro | good morning | 00:30 |
---|---|---|
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Spec: Support filtering by forbidden aggregates 1 https://review.openstack.org/647704 | 01:11 |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Spec: Support filtering by forbidden aggregates 2 https://review.openstack.org/647705 | 01:11 |
*** jaypipes has quit IRC | 05:09 | |
*** jaypipes has joined #openstack-placement | 05:09 | |
*** tetsuro has quit IRC | 05:35 | |
*** e0ne has joined #openstack-placement | 07:17 | |
*** e0ne has quit IRC | 07:19 | |
*** tetsuro has joined #openstack-placement | 07:46 | |
*** ttsiouts has joined #openstack-placement | 07:50 | |
*** gryf has quit IRC | 07:59 | |
*** tssurya has joined #openstack-placement | 08:03 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Negative member_of query with microversion 1.32 https://review.openstack.org/641393 | 08:09 |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Refactor ResourceProviderListTestCase https://review.openstack.org/648339 | 08:09 |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Refactor ResourceProviderListTestCase https://review.openstack.org/648339 | 08:15 |
*** ttsiouts has quit IRC | 08:26 | |
*** ttsiouts has joined #openstack-placement | 08:26 | |
*** helenafm has joined #openstack-placement | 08:28 | |
*** takashin has left #openstack-placement | 08:30 | |
*** ttsiouts has quit IRC | 08:30 | |
*** ttsiouts has joined #openstack-placement | 09:01 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Negative member_of query with microversion 1.32 https://review.openstack.org/641393 | 09:35 |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Refactor ResourceProviderListTestCase https://review.openstack.org/648339 | 09:35 |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Fix debug log getting allocation_candidates https://review.openstack.org/648357 | 09:43 |
*** e0ne has joined #openstack-placement | 09:47 | |
*** cdent has joined #openstack-placement | 10:01 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/placement master: Refactor aggregate _get_trees_matching_all() https://review.openstack.org/648363 | 10:01 |
cdent | tetsuro, gibi, stephenfin: If you get a chance today to look at the stack of "how to placement" starting https://review.openstack.org/#/c/647788/ that would be good. I'd prefer that we have all had a look and decided it is okay before we merge it. | 10:03 |
* cdent coffees | 10:03 | |
tetsuro | sure, I will have a look. | 10:05 |
*** tetsuro has quit IRC | 10:11 | |
gibi | cdent: would it be possible to add a untriaged bug query link to the doc here? https://review.openstack.org/#/c/647789/2/doc/source/contributor/contributing.rst@57 | 10:21 |
*** melwitt has quit IRC | 10:26 | |
*** e0ne has quit IRC | 10:31 | |
*** melwitt has joined #openstack-placement | 10:32 | |
*** e0ne has joined #openstack-placement | 10:36 | |
gibi | cdent: went though the contributor doc patch series. Nice doc. I left suggestion here and there | 10:40 |
*** ttsiouts has quit IRC | 10:57 | |
*** ttsiouts has joined #openstack-placement | 10:57 | |
*** e0ne has quit IRC | 10:58 | |
*** ttsiouts has quit IRC | 11:02 | |
*** e0ne has joined #openstack-placement | 11:05 | |
*** cdent has quit IRC | 11:21 | |
jaypipes | efried, edleafe, dansmith: morning. responded on https://review.openstack.org/#/c/648147/. please forgive me, I wasn't aware of this new approach before yesterday. let me know if I summarized the two approaches appropriately in my comment on the patch, please. I'm fine either way, I guess. was just surprised by the approach due to being out for a couple weeks and remembering a different decision being made at the PTGs. | 11:27 |
*** cdent has joined #openstack-placement | 11:27 | |
*** ttsiouts has joined #openstack-placement | 12:08 | |
openstackgerrit | Chris Dent proposed openstack/placement master: Fill in the bugs section of contributing.rst https://review.openstack.org/647789 | 12:23 |
openstackgerrit | Chris Dent proposed openstack/placement master: Fill in reviewing section of contributing.rst https://review.openstack.org/647790 | 12:23 |
openstackgerrit | Chris Dent proposed openstack/placement master: Fill in the New Features section of contributing.rst https://review.openstack.org/648113 | 12:23 |
openstackgerrit | Chris Dent proposed openstack/placement master: Fill in the Writing Code section of contributing.rst https://review.openstack.org/648176 | 12:23 |
*** e0ne has quit IRC | 12:41 | |
*** e0ne has joined #openstack-placement | 12:43 | |
sean-k-mooney | jaypipes: to avoid addtional surprise and invite input im propose a similar approch here https://review.openstack.org/#/c/647578/ | 12:52 |
openstackgerrit | Chris Dent proposed openstack/osc-placement master: Update home-page https://review.openstack.org/630053 | 13:12 |
*** ttsiouts has quit IRC | 13:13 | |
*** ttsiouts has joined #openstack-placement | 13:13 | |
*** ttsiouts has quit IRC | 13:18 | |
*** e0ne has quit IRC | 13:20 | |
efried | jaypipes: Responded. Good discussion. | 13:34 |
*** ttsiouts has joined #openstack-placement | 13:40 | |
efried | gibi: got time to relook at https://review.openstack.org/#/c/647789/ series? Easy updates, should be quick +A all the way up. | 13:46 |
efried | oh, you're on it. | 13:46 |
gibi | efried: on it, an on a meeting in parallel :) | 13:47 |
openstackgerrit | Merged openstack/placement master: Add initial framing for a contributing doc https://review.openstack.org/647788 | 13:48 |
efried | cdent: fungi raises an interesting point: I assume we're not doing anything to make placement specs publish to specs.o.o rather than docs.o.o | 13:48 |
cdent | efried: correct we are not publishing to specs.o.o. That's an acknowledged situation that may or may or may not be a limitation | 13:49 |
cdent | given our predilection for using specs and aux docs, I think it's fine | 13:49 |
cdent | I don't see the branching issue as an issue (for us) | 13:50 |
*** ttsiouts has quit IRC | 13:50 | |
*** ttsiouts has joined #openstack-placement | 13:51 | |
efried | agree updates to a spec implemented in $release should wind up in $release, even if that means backporting the spec update itself. But that's fine. | 13:51 |
efried | becomes like any doc update really. | 13:52 |
jaypipes | sean-k-mooney: ack, thanks for the heads up. will review. | 13:54 |
cdent | I don't see a strong need for nova to change. Nothing is broken by leaving things as they are, is it? | 13:54 |
efried | not really | 13:54 |
efried | more work than benefit | 13:54 |
efried | if you mean the part about moving specs into the main repo | 13:54 |
openstackgerrit | Abhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance https://review.openstack.org/641210 | 13:55 |
efried | better tracking of future/backlog and rejected/dead blueprints is still something I want to do. | 13:55 |
*** ttsiouts has quit IRC | 13:55 | |
cdent | yeah, agree that having a place to save ideas make sense | 13:57 |
sean-k-mooney | cdent: efried i just replied on the mailing list by the way in the context of the future of nova specs/blueprits | 13:57 |
efried | yup, I'm caught up. | 14:00 |
efried | sean-k-mooney: I don't disagree that it would be workable to consolidate specs into the nova repo, but I don't think we would gain anything significant from it to make it worth the legwork of doing it. | 14:01 |
*** ttsiouts has joined #openstack-placement | 14:01 | |
sean-k-mooney | efried: well the main benifit i see is discoverablity and in the case where we have work item list in the spec you can mark those items as done as you proceed | 14:02 |
sean-k-mooney | but in the hopefully rare event where we need to update the spec after approval it also allows that update to be linked with the patch that cause teh change. | 14:05 |
sean-k-mooney | cdent: and no there isnt a stong need for nova to change. stephenfin and i wanted to propose the change before the nova-core group was added to nova-spec-core | 14:11 |
* cdent has limited skin in this game | 14:11 | |
cdent | I made statement in the spirit of "there's a lot to do, why add more?" | 14:12 |
sean-k-mooney | ah well most of my reaon for doing it went away with the addtion of nova-core to nova-specs-core | 14:12 |
stephenfin | efried, sean-k-mooney: I tried doing it. It's a lot of work, especially if we want to keep history | 14:13 |
stephenfin | for rather limited ROI | 14:13 |
sean-k-mooney | stephenfin: you can use the old oslo incubator script to help but ya | 14:13 |
efried | stephenfin: Mm, I hadn't considered history. I thought about moving the existing specs wholesale from the specs repo, but yeah, we would lose the git chain that way. | 14:13 |
efried | yeah, unless we do the magic that edleafe and cdent did to seed the placement repo | 14:14 |
stephenfin | you could do git magic but it's awkward | 14:14 |
stephenfin | on account of nova being an existing repo | 14:14 |
stephenfin | and the two repos not sharing a common commit | 14:14 |
efried | So yeah, unless there's more benefit than what we've discussed so far, IMO we should leave it. | 14:14 |
sean-k-mooney | you can do it relitivly simplely but yuou end up with 2 git roots and you either need a force push or need to revew each pathc | 14:14 |
sean-k-mooney | so is somewhat painful | 14:14 |
sean-k-mooney | stephenfin: care to remove it form the PTG agenda so | 14:15 |
sean-k-mooney | most of my desire for it was to encourcage more cores and non cores to read and review specs | 14:16 |
stephenfin | sean-k-mooney: Aye, I was trying to find this article https://www.destroyallsoftware.com/blog/2017/the-biggest-and-weirdest-commits-in-linux-kernel-git-history | 14:16 |
sean-k-mooney | stephenfin: you should look at some of the history of networking-ovs-dpdk we ported some neutron code into it with the history a few time and then decided it was too much hassel to continue so stopped | 14:17 |
stephenfin | sean-k-mooney: Sure, done | 14:17 |
*** ttsiouts has quit IRC | 14:17 | |
*** ttsiouts has joined #openstack-placement | 14:18 | |
*** ttsiouts has quit IRC | 14:22 | |
*** ttsiouts has joined #openstack-placement | 14:29 | |
*** e0ne has joined #openstack-placement | 14:38 | |
openstackgerrit | Merged openstack/osc-placement master: Update home-page https://review.openstack.org/630053 | 14:41 |
openstackgerrit | Merged openstack/placement master: Add link to case studies in alloc_cands api-ref https://review.openstack.org/647716 | 14:42 |
*** edleafe_ has joined #openstack-placement | 15:00 | |
*** e0ne has quit IRC | 15:14 | |
*** edleafe_ has quit IRC | 15:17 | |
*** e0ne has joined #openstack-placement | 15:20 | |
dansmith | jaypipes: ack; details in the nova spec may help clear things up if you haven't read it | 15:24 |
dansmith | cdent: it sounds like you're leaning towards nixing the SUPPORT_ stem right? | 15:26 |
cdent | dansmith: not quite. It's more like I want someone who has a stronger opinion to express one so that I don't have decide because my native inclination is to just go with whatever but I fear that as soon as that happens someone will surface and be all "omg, how could you?" | 15:28 |
dansmith | okay I dgaf either.. so hopefully someone with gaf or we can not dwell on indecision :) | 15:28 |
dansmith | *will | 15:29 |
cdent | i figure if nothing happens tomorrow, the people's have spoken by not speaking and we just go with it | 15:30 |
dansmith | aight | 15:30 |
jaypipes | dansmith, cdent: I'm not bothered by the SUPPORT_ thing, but I do think COMPUTE_IMAGE_TYPE_AMI is fine as well. | 15:31 |
dansmith | heh okay | 15:31 |
cdent | good thing we're not working an emergency room | 15:32 |
jaypipes | lol | 15:32 |
jaypipes | placemergency. | 15:32 |
* cdent adds to lexicon | 15:33 | |
cdent | edleafe: do you have an opinion? You think about names sometimes... | 15:34 |
* edleafe is typing on the review right now... | 15:35 | |
cdent | huzzah | 15:37 |
edleafe | You might want to hold the huzzah... | 15:37 |
dansmith | btw, on the aggregate vs traits question, | 15:39 |
dansmith | we really can't make it "just work" if we go the aggregate route because compute nodes can't and shouldn't be changing their own aggregate membership nor attributes of those | 15:40 |
*** e0ne has quit IRC | 15:40 | |
dansmith | so either we do this to enforce a "it never makes sense to send an unsupportable image to a compute", or we do the same in a terribly inefficient scheduler filter which won't work for people like cern, or we make admins do this all manually | 15:41 |
edleafe | dansmith: that's a good analysis perspective. My only point is that from a placement/os-traits POV, either approach should be fine. | 15:42 |
dansmith | yeah, I know, I'm just saying why I think this does need to be traits-based, not that anyone is really arguing | 15:43 |
cdent | cdent: I'm a pluralist, I'll huzzah opinion giving, even I don't agree with the opinion | 15:43 |
edleafe | So it should be up to the nova/glance/cinder teams to determine which would work best | 15:43 |
dansmith | cdent: I think his point was he wasn't helping push it either direction | 15:43 |
edleafe | dansmith: bingo | 15:43 |
cdent | Ugh, I'm tired, I jusg pinged myself instead of ed | 15:43 |
edleafe | cdent: as long as you don't start private messaging yourself... | 15:44 |
cdent | I should consider that | 15:44 |
cdent | dansmith: I'm ready to make a judgement, based on the total lack of opinions from anyone: | 15:45 |
cdent | nobody is saying SUPPORT needs to be there, so take it out | 15:45 |
cdent | How's that? | 15:45 |
dansmith | I keep trying to justify why it should be there, but I can't really | 15:46 |
dansmith | my reasoning was around the multiple-ness of it | 15:46 |
cdent | then we can merge this thing, make a release and what ed says about it being not os-traits problem anymore can be true | 15:46 |
dansmith | but traits are kinda that way anyway | 15:46 |
cdent | yeah | 15:46 |
openstackgerrit | Merged openstack/placement master: Fix debug log getting allocation_candidates https://review.openstack.org/648357 | 15:49 |
openstackgerrit | Merged openstack/placement master: Document alloc-candidates-in-tree https://review.openstack.org/647309 | 15:49 |
openstackgerrit | Dan Smith proposed openstack/os-traits master: Add COMPUTE_IMAGE_TYPE_* traits https://review.openstack.org/648147 | 15:54 |
dansmith | cdent: ^ | 15:54 |
cdent | word | 15:54 |
cdent | yeah, that looks much less dumb, somehow | 15:56 |
edleafe | Wow, what a compliment! | 15:56 |
edleafe | :) | 15:56 |
cdent | so, the way I'm checking that this are kosher is import os_traits and the doing a dir() on the module | 15:57 |
cdent | which lists all the traits, and with SUPPORT stacked up in there it looked, well, dumb | 15:58 |
cdent | in both the sense of "stupid" as well "as unable to express" | 15:58 |
openstackgerrit | Merged openstack/placement master: Fill in the bugs section of contributing.rst https://review.openstack.org/647789 | 15:59 |
openstackgerrit | Merged openstack/placement master: Fill in reviewing section of contributing.rst https://review.openstack.org/647790 | 15:59 |
* dansmith is greatly offended | 15:59 | |
cdent | i bet | 16:01 |
openstackgerrit | Merged openstack/os-traits master: Add COMPUTE_IMAGE_TYPE_* traits https://review.openstack.org/648147 | 16:22 |
*** ttsiouts has quit IRC | 16:24 | |
dansmith | actual huzzah | 16:25 |
*** tssurya has quit IRC | 16:27 | |
*** e0ne has joined #openstack-placement | 16:27 | |
efried | dansmith: https://review.openstack.org/#/c/648147/4/os_traits/compute/image.py@14 if you agree, I can propose that if you like. | 16:39 |
*** helenafm has quit IRC | 16:40 | |
dansmith | and if I don't? :) | 16:40 |
efried | what would the objection be? | 16:42 |
efried | I guess I can propose it and you can shoot it down in gerrit. | 16:42 |
dansmith | efried: oh I have no objection, you just gave me a choice so I'm exploring options :) | 16:46 |
openstackgerrit | Eric Fried proposed openstack/os-traits master: Add contextual comment about image type traits https://review.openstack.org/648466 | 16:46 |
efried | alright punk ^ | 16:46 |
* dansmith gasps at the language | 16:47 | |
efried | That was the edited-for-TV version. You should see all the responses I typed and then deleted. | 16:48 |
dansmith | I noticed your lips were mouthing a different word than your fingers.. I hate that. | 16:48 |
cdent | this is the description of "idependent" when it comes to release types: https://releases.openstack.org/reference/release_models.html#independent I think it is probably better for os-traits and os-resource-classes. If you disagree, shout. (I'll ask on the pupdate too) | 16:51 |
cdent | and I'll try to spell independent correctly | 16:51 |
dansmith | obvi | 16:52 |
edleafe | efried: can I assume that that list of disk formats will only grow, and never remove any? | 16:55 |
dansmith | cdent: I assume this will be os-traits 0.9.0 right? | 16:56 |
cdent | 0.12.0 (0.11.0 is the version on the pypi right now) | 16:56 |
dansmith | edleafe: I suppose if glance were to stop supporting one it would shrink, but I kinda doubt that would happen | 16:56 |
efried | edleafe: I would think so. | 16:56 |
dansmith | oh okay | 16:56 |
efried | edleafe: I suspect you're saying that comment could be extended to say, "but don't ever remove any, even if glance does" | 16:57 |
dansmith | edleafe: efried I would expect the trait list to never shrink | 16:57 |
dansmith | yeah | 16:57 |
efried | agree with that | 16:57 |
cdent | dansmith: it would not surprise me if some requirements.txt file somewhere didn't get updated | 16:57 |
dansmith | cdent: yeah current nova is 0.8.0 | 16:57 |
cdent | removing traits is not allowed | 16:57 |
edleafe | efried: yeah, I wasn't sure if some formats were deigned to be "archaic" and no longer listed. | 16:58 |
cdent | so saying in the comment would be somewhat redundant | 16:58 |
efried | cdent: Not sure I agree about os-* being independent. | 16:58 |
cdent | why? | 16:58 |
cdent | the reason is so we can release every time we update it | 16:58 |
efried | so we never have to tag stable e.g.? | 16:59 |
dansmith | there would never be a reason to have a stable os-traits, that I can think of | 16:59 |
efried | Meh, I guess I could be convinced. What does #openstack-release have to say about it? | 16:59 |
cdent | they suggested it | 16:59 |
efried | oh, well then. | 16:59 |
efried | ++ | 16:59 |
dansmith | lol | 16:59 |
cdent | efried: I remain curious/confused why you were concerned? | 17:00 |
dansmith | you gave him the choice and he's exploring options? :D | 17:01 |
* cdent reevaluated pluralism | 17:01 | |
efried | cdent: because I was thinking about who consumes those and how they're going to care about "stability" as release cutoffs approach. | 17:02 |
efried | os-* should be fairly stable | 17:02 |
efried | but there was a recent snafu in os-brick that has me a bit paranoid on that front. | 17:02 |
dansmith | os-brick is an actual library | 17:02 |
efried | anyway, it's not a big deal; releasing with every change makes sense. | 17:02 |
cdent | os-brick actually does things, yeah? | 17:02 |
dansmith | this is a public add-only enum | 17:02 |
efried | in this case it was a very similar change in os-brick, just aliasing some consts | 17:03 |
efried | does 'independent' still get bot proposals to u-c? | 17:04 |
* cdent doesn't know how that process works for any style of release | 17:05 | |
*** e0ne has quit IRC | 17:07 | |
*** e0ne has joined #openstack-placement | 17:08 | |
openstackgerrit | Merged openstack/placement master: Fill in the New Features section of contributing.rst https://review.openstack.org/648113 | 17:08 |
openstackgerrit | Merged openstack/placement master: Fill in the Writing Code section of contributing.rst https://review.openstack.org/648176 | 17:09 |
openstackgerrit | Merged openstack/placement master: Spec: Support filtering by forbidden aggregates 1 https://review.openstack.org/647704 | 17:09 |
openstackgerrit | Merged openstack/placement master: Spec: Support filtering by forbidden aggregates 2 https://review.openstack.org/647705 | 17:09 |
*** e0ne has quit IRC | 17:17 | |
openstackgerrit | Merged openstack/os-traits master: Add contextual comment about image type traits https://review.openstack.org/648466 | 17:18 |
openstackgerrit | Merged openstack/placement master: Prepare for negative member_of queryparam https://review.openstack.org/641391 | 17:18 |
*** e0ne has joined #openstack-placement | 17:21 | |
*** e0ne has quit IRC | 17:45 | |
*** Sundar has joined #openstack-placement | 17:57 | |
*** e0ne has joined #openstack-placement | 19:33 | |
*** jaypipes_ has joined #openstack-placement | 19:54 | |
*** jaypipes has quit IRC | 19:54 | |
*** e0ne has quit IRC | 20:00 | |
*** efried has quit IRC | 20:22 | |
*** efried has joined #openstack-placement | 20:26 | |
*** cdent has quit IRC | 20:27 | |
*** efried has quit IRC | 20:44 | |
*** takashin has joined #openstack-placement | 20:54 | |
*** efried has joined #openstack-placement | 20:58 | |
*** openstackgerrit has quit IRC | 21:07 | |
*** efried has quit IRC | 21:09 | |
*** openstackgerrit has joined #openstack-placement | 21:20 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API policy updates https://review.openstack.org/547850 | 21:20 |
*** efried has joined #openstack-placement | 21:23 | |
*** Sundar has quit IRC | 23:15 | |
*** takashin has quit IRC | 23:20 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!