| *** artom has quit IRC | 03:56 | |
| *** takashin has quit IRC | 04:16 | |
| *** takashin has joined #openstack-placement | 04:47 | |
| *** e0ne has joined #openstack-placement | 07:04 | |
| *** e0ne has quit IRC | 07:09 | |
| *** takashin has left #openstack-placement | 08:30 | |
| *** stephenfin has quit IRC | 08:44 | |
| *** stephenfin has joined #openstack-placement | 08:45 | |
| *** tetsuro has joined #openstack-placement | 09:02 | |
| *** cdent has joined #openstack-placement | 09:37 | |
| *** ttsiouts has joined #openstack-placement | 09:39 | |
| *** e0ne has joined #openstack-placement | 09:54 | |
| *** e0ne has quit IRC | 09:55 | |
| *** e0ne has joined #openstack-placement | 09:55 | |
| *** openstackstatus has quit IRC | 10:12 | |
| *** openstack has joined #openstack-placement | 10:17 | |
| *** ChanServ sets mode: +o openstack | 10:17 | |
| *** ttsiouts has quit IRC | 10:28 | |
| *** ttsiouts has joined #openstack-placement | 10:28 | |
| cdent | gibi, efried : this is an osc-placement gate blocker fix: https://review.opendev.org/#/c/683941/ | 10:31 |
|---|---|---|
| *** ttsiouts has quit IRC | 10:33 | |
| cdent | stephenfin: left some queries for you on https://review.opendev.org/#/c/683783/ with regards to when/release cycle/etc | 10:46 |
| stephenfin | replied | 10:49 |
| tetsuro | okay, I'll fix that placemeent-api- prefix thing and address other things in a follow up | 10:56 |
| tetsuro | cdent: stephenfin: Does it makes sense? | 10:56 |
| cdent | tetsuro, stephenfin : I don't have strong feelings on it. If we think we can do the cleanups in the next 48 hours or so, and accurately, may as well, but if we don't is no big deal | 10:58 |
| tetsuro | But, I realized having the fix separately over the release needs two redirects for the microversion history... which I'd like to avoid. | 11:00 |
| gibi | cdent: what do you think? Should I push the gate fix through or we can wait for efried to wake up? | 11:01 |
| cdent | gibi: I think it's fine to push. | 11:01 |
| gibi | cdent: done | 11:02 |
| tetsuro | So now I rather prefer doing all the fixes that stephen suggests in the same patch. | 11:02 |
| cdent | tetsuro: works for me | 11:02 |
| cdent | gibi: thanks | 11:02 |
| cdent | tetsuro: once you've done that I'll do the upgrade notes, based on it | 11:03 |
| cdent | in the meantime I'll cook up the reno prelude | 11:03 |
| *** ttsiouts has joined #openstack-placement | 11:07 | |
| openstackgerrit | Merged openstack/osc-placement master: Use os-endpoint instead of os-url for functional tests https://review.opendev.org/683941 | 11:12 |
| *** artom has joined #openstack-placement | 11:17 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add train-prelude release note https://review.opendev.org/684285 | 11:29 |
| cdent | gibi, stephenfin : this would be nice to get in, so it doesn't have to wait another six months: https://review.opendev.org/681047 | 11:49 |
| cdent | tetsuro: you too if you're still around | 11:50 |
| gibi | cdent: I will try to read that patch today | 11:58 |
| cdent | thanks | 11:58 |
| openstackgerrit | Chris Dent proposed openstack/osc-placement stable/train: Use os-endpoint instead of os-url for functional tests https://review.opendev.org/684292 | 12:07 |
| cdent | gibi: that ^ is a backport to train of the fix you pushed through. based on suggestion from ttx | 12:11 |
| gibi | cdent: I'm +1 on it | 12:12 |
| cdent | thanks | 12:13 |
| *** belmoreira has joined #openstack-placement | 12:27 | |
| gibi | stephenfin: thanks for reviewing https://review.opendev.org/#/c/681047 so I don't have to get back to it :) | 12:37 |
| gibi | cdent: ^^ | 12:37 |
| stephenfin | yw :) | 12:37 |
| cdent | thanks! | 12:38 |
| efried | cdent: what do you need from me rn? | 13:08 |
| cdent | efried: nada | 13:08 |
| efried | cool! | 13:09 |
| cdent | tetsuro has some docs changs in progress on which I will put the upgrade notes | 13:09 |
| cdent | and then things are basically done | 13:09 |
| *** mriedem has joined #openstack-placement | 13:24 | |
| efried | cdent: Is the prelude ready for review? | 13:24 |
| cdent | efried: it's here: https://review.opendev.org/684285 | 13:25 |
| cdent | definitions of "ready" may vary | 13:25 |
| efried | I know, I'm ready to vote, just need to know whether to +1 or +2. | 13:25 |
| cdent | any of the changes that are pending won't impact the contents, so if you're inclined to +2, go for it | 13:26 |
| cdent | s/changes/other changes/ | 13:26 |
| efried | ack | 13:26 |
| cdent | ah yeah. I'm consistently inconsistent on capitalization because I'm trying to make everyone happy. | 13:29 |
| cdent | i'll make it lower | 13:29 |
| efried | I found the link | 13:29 |
| *** tetsuro has quit IRC | 13:30 | |
| efried | https://governance.openstack.org/tc/reference/service-project-naming.html#project-name-guidelines | 13:30 |
| *** belmoreira has quit IRC | 13:30 | |
| *** belmoreira has joined #openstack-placement | 13:31 | |
| openstackgerrit | Chris Dent proposed openstack/placement master: Add train-prelude release note https://review.opendev.org/684285 | 13:31 |
| efried | personally, I don't see that it would be that hard to define the rule as "capitalize only when you're talking about the project" | 13:32 |
| * cdent aligns | 13:32 | |
| * cdent shrugs | 13:32 | |
| cdent | I kept the title of the link consistent with the cases in the doc | 13:32 |
| *** belmoreira has quit IRC | 13:32 | |
| efried | but then again, even trying to apply that rule to your prelude, I can see where it would be confusing. | 13:32 |
| efried | Yes, a document title should use Title Case | 13:32 |
| efried | English supersedes OpenStack | 13:32 |
| cdent | mEh | 13:33 |
| mriedem | it's a rule i dislike as well, but the docs team says it's the way, e.g. "ironic" specifically drives me nuts | 13:59 |
| mriedem | cdent: question in https://review.opendev.org/#/c/684292/ | 14:05 |
| cdent | mriedem: lookin | 14:06 |
| *** belmoreira has joined #openstack-placement | 14:06 | |
| *** belmoreira has joined #openstack-placement | 14:08 | |
| cdent | mriedem: good spot | 14:08 |
| cdent | I'm unsure how to proceed | 14:10 |
| cdent | i guess I'll fix requirements in master and train? | 14:10 |
| mriedem | cdent: so does it break if you have osc<4? | 14:11 |
| cdent | it does yeah | 14:11 |
| efried | Is it still legal to fix reqs in train? I guess so, that's just a FFE to the reqs team, those are still trickling in. | 14:11 |
| cdent | mriedem: which was unexpected becasuse the docs associated with the endpoint change make it sounds like it was already there | 14:12 |
| mriedem | efried: this is osc-placement | 14:12 |
| cdent | osc-placement train either needs to be pinned to <4 and not have the patch, or pinned to >=4 and have the patch | 14:12 |
| mriedem | ok so this was some dropped support thing in 4.0 huh... | 14:13 |
| cdent | yeah | 14:13 |
| cdent | got me totally off guard | 14:13 |
| cdent | it only showed up because sean's patch to make stable/train gerrit aware failed | 14:14 |
| mriedem | it's a major release 3-4 years in the making so i'm not surprised | 14:14 |
| mriedem | hmm, don't see anything about it in https://docs.openstack.org/releasenotes/python-openstackclient/unreleased.html | 14:14 |
| mriedem | maybe we should talk with dtroyer | 14:14 |
| cdent | i found it somewhere, one mo | 14:14 |
| cdent | https://opendev.org/openstack/python-openstackclient/commit/6fcc2608b17d84cf3699bb4a5bae692404393ca1 | 14:15 |
| cdent | it really is only relevant (in the context of osc-placement) to the tests, because we are using the PlacementFixture and thus the noauth2 middlware | 14:16 |
| cdent | so my inclination would be to choose some way of fixing it and just do so, and not strain ourselves too much | 14:17 |
| * cdent will fix it on master, regardless | 14:17 | |
| mriedem | hmm, yeah so the backward incompatibility doc lists that as #14 https://docs.openstack.org/python-openstackclient/latest/cli/backwards-incompatible.html | 14:17 |
| mriedem | but if there wasn't an option on <3 i'm not sure how it's a valid break | 14:18 |
| mriedem | i'll ping dtroyer in -sdk | 14:18 |
| cdent | one aspect of this is that python-openstackclient only shows up in test-requirements... | 14:20 |
| *** ttsiouts has quit IRC | 14:21 | |
| openstackgerrit | Chris Dent proposed openstack/osc-placement master: Pin python-openstackclient >= 4.0.0 in test-requirements https://review.opendev.org/684352 | 14:21 |
| *** ttsiouts has joined #openstack-placement | 14:22 | |
| *** ttsiouts has quit IRC | 14:22 | |
| *** ttsiouts has joined #openstack-placement | 14:23 | |
| openstackgerrit | Merged openstack/placement master: Deprecate [placement]/policy_file config option https://review.opendev.org/681047 | 14:24 |
| *** belmoreira has quit IRC | 14:50 | |
| *** belmoreira has joined #openstack-placement | 14:51 | |
| mriedem | cdent: question about the badge thing here https://review.opendev.org/#/c/681460/ | 14:55 |
| openstackgerrit | Merged openstack/osc-placement master: Update osc-placement bug link in README https://review.opendev.org/681231 | 14:55 |
| openstackgerrit | Merged openstack/os-resource-classes master: Update bug link in docs to point to storyboard https://review.opendev.org/681464 | 14:56 |
| openstackgerrit | Chris Dent proposed openstack/osc-placement master: Be explicit about auth type in functional tests https://review.opendev.org/684370 | 15:00 |
| openstackgerrit | Merged openstack/os-resource-classes master: Build pdf docs https://review.opendev.org/681463 | 15:02 |
| mriedem | cdent: i'm assuming you tested that manually with both versions of osc? | 15:05 |
| mriedem | efried: gibi: stephenfin: one of you want to get the osc-placement pdf change? https://review.opendev.org/#/c/681460/ | 15:08 |
| gibi | sure | 15:08 |
| mriedem | cdent: do we need to backport that to osc-placement stable/train? ^ | 15:08 |
| mriedem | it's not like we can release another osc-placement at this point anyway, but it could be in the first stable/train minor release i guess.... | 15:09 |
| cdent | mriedem: I did test it manually with both versions, said so in commit message. | 15:10 |
| cdent | are you asking about backporting the pdf build? that seems... excessive | 15:10 |
| mriedem | cdent: you said "This form works in both 3.19.x and 4.0.x." so i was assuming that meant you tested it locally but wasn't sure, i.e. "this should work in both based on code inspection" etc | 15:11 |
| mriedem | so i thought i'd ask | 15:11 |
| mriedem | and yeah, i agree that the pdf build for osc-placement likely doesn't need to be backported | 15:11 |
| cdent | coolio | 15:12 |
| gibi | mriedem, cdent: I tried to generate pdf docs locally with https://review.opendev.org/#/c/681460/ but it failed for me http://paste.openstack.org/show/779194/ | 15:17 |
| gibi | do we forget some dependencies? | 15:17 |
| mriedem | you're missing something that should probably be in bindep | 15:17 |
| mriedem | for latexmk | 15:18 |
| mriedem | i recently ran into this for nova https://review.opendev.org/#/c/683003/ | 15:18 |
| gibi | I dont see latexmk in https://github.com/openstack/requirements/blob/master/bindep.txt | 15:18 |
| mriedem | just building docs, not pdf | 15:18 |
| mriedem | gibi: b/c requirements is things you can get from pypi | 15:18 |
| mriedem | bindep is for native distro packages | 15:18 |
| mriedem | libgcc etc | 15:18 |
| mriedem | gibi: so you're looking for stuff like this https://github.com/openstack/os-brick/commit/132a531e1768dea2db3275da376f163adc8fbf34#diff-03625fa9d8a51df3251e367a19ecfca5 | 15:19 |
| mriedem | latexmk [doc platform:dpkg] | 15:19 |
| mriedem | i think that is something which could be handled in a follow up since i personaly do'nt want to have to validate that entire list of packages :) | 15:20 |
| cdent | do we want doc bindeps in bindeps? seems, here's that word again, excessive | 15:20 |
| cdent | like: if the gate can build a pdf, cool | 15:20 |
| mriedem | i like having everything native i need in bindep for when i'm fialing to build some tox env | 15:20 |
| * cdent shrugs | 15:20 | |
| cdent | well, if we do it, definitely fup | 15:20 |
| mriedem | in nova we've had graphviz forever b/c on new dev vms i always forgot to install it | 15:20 |
| gibi | mriedem: I can install latexmk sure, but then we need to document somewhere that I need to install that | 15:20 |
| mriedem | there are bindep docs somewhere generically for openstack, | 15:21 |
| mriedem | what i'd like to see is whoever is in charge of the pdf effort for train puts the definitive list of bindep packages for building pdf docs in the ML | 15:21 |
| mriedem | since every project seems to be just randomly handling that | 15:21 |
| cdent | it's, unfortunately, at least not in my experience, definitive | 15:22 |
| mriedem | i can start a crank thread on the ML for that | 15:22 |
| cdent | varies from project to project | 15:22 |
| gibi | mriedem: this is the gloval bindep isn't it? https://github.com/openstack/requirements/blob/master/bindep.txt | 15:22 |
| cdent | I suspect, however, that stephenfin has good awareness of them | 15:22 |
| mriedem | gibi: no, that's for installing the requirements repo and running tests | 15:22 |
| gibi | bahh | 15:22 |
| mriedem | well, as far as i know | 15:22 |
| mriedem | if it's the definitive global list then the pdf stuff should be in there | 15:22 |
| mriedem | again, i'll start yelling on the ML | 15:23 |
| mriedem | shaking fist at the sky and such | 15:23 |
| gibi | OK, thanks :D | 15:23 |
| gibi | now installed latexmk and the pdf build needs xelatex :D | 15:23 |
| gibi | this will be fun | 15:23 |
| cdent | gibi: there's an etherpad somewhere that has more info on the bin deps. lemme see if I can find | 15:26 |
| cdent | gibi: line 73 on https://etherpad.openstack.org/p/train-pdf-support-goal | 15:28 |
| gibi | cdent: thanks I managed to build a pdf now | 15:29 |
| mriedem | need another core on this https://review.opendev.org/#/c/684370/ | 15:30 |
| mriedem | so we can backport | 15:30 |
| gibi | cdent, mriedem: pdf gen patch looks good to me but then I suggest to add a bindep.txt to osc-placement in a followup | 15:31 |
| mriedem | i'm fine with that once we have a definitive list from the ML thread | 15:31 |
| gibi | mriedem: sure | 15:31 |
| *** belmoreira has quit IRC | 15:32 | |
| * cdent admires mriedem's optimism | 15:35 | |
| mriedem | optimism is my middle name | 15:35 |
| stephenfin | cdent: reviewed. tl;dr: we don't need to drop those badges. the include directive has a way to define the line that the include starts on | 15:36 |
| cdent | damn | 15:37 |
| cdent | was hoping for a roundabout way to get rid of badges | 15:37 |
| cdent | stephenfin: I'm not really parsing your comment about start-link, can you be more explicit? | 15:38 |
| openstackgerrit | Merged openstack/osc-placement master: Build pdf docs https://review.opendev.org/681460 | 15:41 |
| cdent | stephenfin: if you're motivated to do a fup, that would be awesome | 15:42 |
| openstackgerrit | Merged openstack/osc-placement master: Be explicit about auth type in functional tests https://review.opendev.org/684370 | 15:47 |
| *** ttsiouts has quit IRC | 15:49 | |
| openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: Fixups for pdf docs https://review.opendev.org/684389 | 15:52 |
| openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: docs: Misc cleanups https://review.opendev.org/684390 | 15:52 |
| stephenfin | cdent, gibi: ^ | 15:52 |
| cdent | thanks | 15:55 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement stable/train: Be explicit about auth type in functional tests https://review.opendev.org/684392 | 16:00 |
| openstackgerrit | Matt Riedemann proposed openstack/osc-placement stable/train: Be explicit about auth type in functional tests https://review.opendev.org/684392 | 16:00 |
| mriedem | stephenfin: i'd add a comment about the line 7 magic in https://review.opendev.org/#/c/684389/ | 16:20 |
| openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: Fixups for pdf docs https://review.opendev.org/684389 | 16:27 |
| openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: docs: Misc cleanups https://review.opendev.org/684390 | 16:27 |
| openstackgerrit | Stephen Finucane proposed openstack/osc-placement master: gitignore: Ignore .stestr directory https://review.opendev.org/684396 | 16:27 |
| stephenfin | mriedem: Fair. Done | 16:27 |
| *** e0ne has quit IRC | 16:57 | |
| openstackgerrit | Matt Riedemann proposed openstack/placement master: Add train-prelude release note https://review.opendev.org/684285 | 17:25 |
| cdent | thanks for that ^ mriedem | 17:31 |
| *** e0ne has joined #openstack-placement | 17:47 | |
| *** cdent has quit IRC | 18:08 | |
| *** e0ne has quit IRC | 18:09 | |
| *** belmoreira has joined #openstack-placement | 18:17 | |
| *** e0ne has joined #openstack-placement | 18:32 | |
| *** e0ne has quit IRC | 18:33 | |
| *** mriedem has quit IRC | 18:48 | |
| *** mriedem has joined #openstack-placement | 18:49 | |
| *** e0ne has joined #openstack-placement | 18:54 | |
| *** e0ne has quit IRC | 19:59 | |
| *** belmoreira has quit IRC | 20:27 | |
| *** e0ne has joined #openstack-placement | 20:38 | |
| *** artom has quit IRC | 21:17 | |
| *** artom has joined #openstack-placement | 21:18 | |
| *** tetsuro has joined #openstack-placement | 21:56 | |
| *** tetsuro has quit IRC | 22:00 | |
| *** e0ne has quit IRC | 22:04 | |
| *** tetsuro has joined #openstack-placement | 22:34 | |
| openstackgerrit | Eric Fried proposed openstack/placement master: Add train-prelude release note https://review.opendev.org/684285 | 22:37 |
| *** tetsuro has quit IRC | 22:39 | |
| *** tetsuro has joined #openstack-placement | 23:12 | |
| *** tetsuro has quit IRC | 23:16 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!