*** thorst has joined #openstack-powervm | 00:03 | |
openstackgerrit | Drew Thorstensen proposed openstack/nova-powervm: Update to handle extra devs on recreate https://review.openstack.org/327958 | 00:17 |
---|---|---|
*** apearson has quit IRC | 00:44 | |
*** apearson has joined #openstack-powervm | 00:45 | |
*** smatzek has joined #openstack-powervm | 00:55 | |
*** apearson has quit IRC | 01:46 | |
*** Ashana has joined #openstack-powervm | 02:01 | |
*** Ashana has quit IRC | 02:05 | |
*** smatzek has quit IRC | 02:13 | |
*** mdrabe has joined #openstack-powervm | 02:19 | |
*** Ashana has joined #openstack-powervm | 02:28 | |
*** Ashana has quit IRC | 02:32 | |
*** Ashana has joined #openstack-powervm | 02:34 | |
*** Ashana has quit IRC | 02:38 | |
*** efried has joined #openstack-powervm | 02:40 | |
*** Ashana has joined #openstack-powervm | 02:40 | |
*** Ashana has quit IRC | 02:44 | |
*** Ashana has joined #openstack-powervm | 02:46 | |
openstackgerrit | Drew Thorstensen proposed openstack/nova-powervm: Update to handle extra devs on recreate https://review.openstack.org/327958 | 02:47 |
*** arnoldje has joined #openstack-powervm | 02:47 | |
thorst | efried: Can you check this one? https://review.openstack.org/#/c/327986/ | 02:48 |
efried | thorst, done. | 02:49 |
thorst | we've got one incoming from mdrabe too... | 02:49 |
mdrabe | https://review.openstack.org/#/c/328000/1 | 02:50 |
mdrabe | you can hold off on that for little, still trying to solve the dang ut | 02:50 |
*** Ashana has quit IRC | 02:50 | |
mdrabe | actually dang I think I just got it | 02:50 |
*** Ashana has joined #openstack-powervm | 02:51 | |
*** Ashana has quit IRC | 02:56 | |
*** Ashana has joined #openstack-powervm | 02:57 | |
thorst | efried mdrabe: W+1'ing mine | 02:58 |
efried | mdrabe, I don't think this is the right solution for _wait_for_vioses. | 02:58 |
efried | There's a way to tell @retry what to do when it exhausts retries. | 02:59 |
efried | That would be better. | 02:59 |
mdrabe | like, don't raise a damned exception? | 02:59 |
*** jwcroppe has joined #openstack-powervm | 03:00 | |
thorst | efried: Is there a way to actually do that? | 03:01 |
thorst | I was looking at that earlier and couldn't find a way to get retrying to do that | 03:01 |
*** Ashana has quit IRC | 03:02 | |
mdrabe | efried: yea I don't see one either | 03:02 |
efried | Bah. This may be one of the reasons we keep abandoning 'retrying' and using pypowervm's retry instead. | 03:04 |
thorst | efried: longer term, I just want to rip and replace this method | 03:04 |
thorst | possibly go back to the for-loop madhavi had originally done | 03:04 |
thorst | this logic should be easier to read (and test) | 03:04 |
efried | Wow, yeah, and this does an extra set of gets too. | 03:05 |
efried | Which are expensive enough. | 03:05 |
efried | Okay, do you need me to stick around and review this, or you got it? | 03:05 |
efried | I just got back from class and haven't showered yet. | 03:05 |
efried | Because I love you guys that much. | 03:06 |
openstackgerrit | Matt Rabe proposed openstack/nova-powervm: Add try/except clause around _wait_for_active_vioses https://review.openstack.org/328000 | 03:06 |
openstackgerrit | Merged openstack/nova-powervm: Update to handle extra devs on recreate https://review.openstack.org/327958 | 03:07 |
thorst | lol | 03:07 |
thorst | efried: take a quick peak at that one? | 03:07 |
thorst | I'm doing the same | 03:07 |
thorst | then I'll just get the +2 | 03:08 |
thorst | mdrabe: Need to get rid of the ~ file on there | 03:08 |
mdrabe | oh what the hell is that | 03:08 |
efried | Somebody used vim and did git add -A | 03:08 |
openstackgerrit | Matt Rabe proposed openstack/nova-powervm: Add try/except clause around _wait_for_active_vioses https://review.openstack.org/328000 | 03:09 |
mdrabe | I did a git add . | 03:09 |
thorst | mdrabe: One nit comment | 03:10 |
thorst | on ps 2 | 03:10 |
mdrabe | hit me | 03:10 |
mdrabe | ic | 03:10 |
efried | Ima leave this to y'all. | 03:10 |
efried | It's +1 from me. | 03:10 |
efried | Somewhat reluctantly | 03:10 |
thorst | efried: thx, see ya | 03:12 |
*** Ashana has joined #openstack-powervm | 03:15 | |
thorst | mdrabe: are you doing a ps4 or is that it? | 03:15 |
mdrabe | I'm doing it I'm doing it | 03:15 |
mdrabe | running ut | 03:15 |
openstackgerrit | Matt Rabe proposed openstack/nova-powervm: Add try/except clause around _wait_for_active_vioses https://review.openstack.org/328000 | 03:16 |
mdrabe | thorst: idk if there ever was a for loop, may have been one of the patch sets from https://review.openstack.org/#/c/311745/ though | 03:16 |
thorst | mdrabe: may have just bee in IRC discussion then | 03:19 |
*** Ashana has quit IRC | 03:19 | |
mdrabe | thorst: Can I backport? | 03:22 |
thorst | mdrabe: yeah | 03:23 |
thorst | I'll do the W+1 once they get through test | 03:25 |
*** Ashana has joined #openstack-powervm | 03:34 | |
*** Ashana has quit IRC | 03:38 | |
*** Ashana has joined #openstack-powervm | 03:40 | |
*** Ashana has quit IRC | 03:44 | |
*** Ashana has joined #openstack-powervm | 03:46 | |
*** dwayne__ has joined #openstack-powervm | 03:48 | |
openstackgerrit | Merged openstack/nova-powervm: Add try/except clause around _wait_for_active_vioses https://review.openstack.org/328000 | 03:49 |
*** Ashana has quit IRC | 03:50 | |
*** thorst has quit IRC | 03:51 | |
*** thorst has joined #openstack-powervm | 03:51 | |
*** dwayne_ has quit IRC | 03:51 | |
*** Ashana has joined #openstack-powervm | 03:52 | |
*** dwayne_ has joined #openstack-powervm | 03:52 | |
*** dwayne__ has quit IRC | 03:55 | |
*** Ashana has quit IRC | 03:56 | |
*** thorst has quit IRC | 04:00 | |
*** Ashana has joined #openstack-powervm | 04:35 | |
*** tlian has quit IRC | 04:37 | |
*** Ashana has quit IRC | 04:39 | |
*** Ashana has joined #openstack-powervm | 04:41 | |
*** Ashana has quit IRC | 04:45 | |
*** Ashana has joined #openstack-powervm | 04:46 | |
*** mdrabe has quit IRC | 04:47 | |
*** Ashana has quit IRC | 04:51 | |
*** Ashana has joined #openstack-powervm | 04:52 | |
*** Ashana has quit IRC | 04:57 | |
*** thorst has joined #openstack-powervm | 04:57 | |
*** Ashana has joined #openstack-powervm | 04:58 | |
*** arnoldje has quit IRC | 04:59 | |
*** Ashana has quit IRC | 05:03 | |
*** Ashana has joined #openstack-powervm | 05:04 | |
*** thorst has quit IRC | 05:04 | |
*** Ashana has quit IRC | 05:08 | |
*** Ashana has joined #openstack-powervm | 05:16 | |
*** Ashana has quit IRC | 05:20 | |
*** Ashana has joined #openstack-powervm | 05:23 | |
*** Ashana has quit IRC | 05:28 | |
*** Ashana has joined #openstack-powervm | 05:29 | |
*** Ashana has quit IRC | 05:33 | |
*** Ashana has joined #openstack-powervm | 05:35 | |
*** Ashana has quit IRC | 05:39 | |
*** Ashana has joined #openstack-powervm | 05:47 | |
*** Ashana has quit IRC | 05:51 | |
*** thorst has joined #openstack-powervm | 06:02 | |
*** thorst has quit IRC | 06:10 | |
*** Cartoon_ has joined #openstack-powervm | 06:32 | |
*** openstackgerrit has quit IRC | 06:32 | |
*** openstackgerrit has joined #openstack-powervm | 06:33 | |
*** thorst has joined #openstack-powervm | 07:07 | |
*** thorst has quit IRC | 07:15 | |
*** jwcroppe has quit IRC | 07:18 | |
*** openstackgerrit has quit IRC | 07:33 | |
*** openstackgerrit has joined #openstack-powervm | 07:33 | |
*** k0da has joined #openstack-powervm | 07:36 | |
*** Ashana has joined #openstack-powervm | 08:08 | |
*** Ashana has quit IRC | 08:12 | |
*** thorst has joined #openstack-powervm | 08:13 | |
*** Ashana has joined #openstack-powervm | 08:14 | |
*** jwcroppe has joined #openstack-powervm | 08:19 | |
*** Ashana has quit IRC | 08:19 | |
*** Ashana has joined #openstack-powervm | 08:20 | |
*** thorst has quit IRC | 08:20 | |
*** Ashana has quit IRC | 08:24 | |
*** Ashana has joined #openstack-powervm | 08:26 | |
*** jwcroppe has quit IRC | 08:29 | |
*** Ashana has quit IRC | 08:30 | |
*** Ashana has joined #openstack-powervm | 08:32 | |
*** Ashana has quit IRC | 08:37 | |
*** Ashana has joined #openstack-powervm | 08:38 | |
*** Ashana has quit IRC | 08:42 | |
*** Ashana has joined #openstack-powervm | 08:43 | |
*** Ashana has quit IRC | 08:48 | |
*** thorst has joined #openstack-powervm | 09:18 | |
*** thorst has quit IRC | 09:25 | |
*** thorst has joined #openstack-powervm | 09:37 | |
*** thorst has quit IRC | 09:56 | |
*** thorst has joined #openstack-powervm | 09:57 | |
*** thorst has quit IRC | 10:01 | |
*** jwcroppe has joined #openstack-powervm | 10:26 | |
*** jwcroppe has quit IRC | 10:31 | |
*** smatzek has joined #openstack-powervm | 11:11 | |
*** smatzek has quit IRC | 11:14 | |
*** Ashana has joined #openstack-powervm | 12:41 | |
*** Ashana has quit IRC | 12:43 | |
*** Ashana has joined #openstack-powervm | 12:43 | |
*** tlian has joined #openstack-powervm | 12:48 | |
*** kylek3h has joined #openstack-powervm | 12:50 | |
*** tblakeslee has joined #openstack-powervm | 13:04 | |
*** edmondsw has joined #openstack-powervm | 13:08 | |
*** mdrabe has joined #openstack-powervm | 13:09 | |
*** esberglu has joined #openstack-powervm | 13:20 | |
*** apearson has joined #openstack-powervm | 13:34 | |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: DNM: CI Check https://review.openstack.org/295935 | 13:41 |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: DNM: Test Change Set 2 https://review.openstack.org/300232 | 13:42 |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: DNM1 https://review.openstack.org/300231 | 13:42 |
*** lmtaylor1 has joined #openstack-powervm | 13:49 | |
*** jwcroppe has joined #openstack-powervm | 13:57 | |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: DNM: ci check https://review.openstack.org/328315 | 14:13 |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: DNM: CI Check2 https://review.openstack.org/328317 | 14:17 |
*** arnoldje has joined #openstack-powervm | 14:18 | |
*** tblakeslee has quit IRC | 14:35 | |
*** tblakeslee has joined #openstack-powervm | 14:36 | |
*** apearson has quit IRC | 14:37 | |
*** apearson has joined #openstack-powervm | 14:40 | |
*** mdrabe has quit IRC | 15:00 | |
*** mdrabe has joined #openstack-powervm | 15:13 | |
*** burgerk has joined #openstack-powervm | 15:28 | |
*** Ashana_ has joined #openstack-powervm | 15:28 | |
*** Ashana__ has joined #openstack-powervm | 15:29 | |
*** Ashana has quit IRC | 15:32 | |
*** Ashana_ has quit IRC | 15:32 | |
*** k0da has quit IRC | 15:53 | |
*** Ashana__ has quit IRC | 16:01 | |
*** jwcroppe has quit IRC | 16:11 | |
*** Ashana has joined #openstack-powervm | 16:20 | |
*** Ashana has quit IRC | 16:24 | |
*** Ashana has joined #openstack-powervm | 16:35 | |
*** Ashana has quit IRC | 16:39 | |
*** Ashana has joined #openstack-powervm | 16:41 | |
*** tblakeslee has quit IRC | 16:42 | |
*** tblakeslee has joined #openstack-powervm | 16:44 | |
*** Ashana has quit IRC | 16:45 | |
*** tblakeslee has quit IRC | 16:50 | |
*** Ashana has joined #openstack-powervm | 16:53 | |
*** Ashana has quit IRC | 16:58 | |
*** jwcroppe has joined #openstack-powervm | 17:17 | |
*** Ashana has joined #openstack-powervm | 17:19 | |
*** k0da has joined #openstack-powervm | 17:23 | |
*** Ashana has quit IRC | 17:45 | |
*** Ashana has joined #openstack-powervm | 17:54 | |
*** catintheroof has joined #openstack-powervm | 17:59 | |
*** Ashana has quit IRC | 18:06 | |
*** Ashana has joined #openstack-powervm | 18:07 | |
*** Ashana has quit IRC | 18:10 | |
*** tblakeslee has joined #openstack-powervm | 18:13 | |
*** Ashana has joined #openstack-powervm | 18:13 | |
*** Ashana has quit IRC | 18:13 | |
*** Ashana has joined #openstack-powervm | 18:13 | |
*** adreznec has quit IRC | 18:15 | |
*** adreznec has joined #openstack-powervm | 18:17 | |
*** Ashana has quit IRC | 18:21 | |
*** Ashana has joined #openstack-powervm | 18:23 | |
*** Ashana has quit IRC | 18:23 | |
*** Ashana has joined #openstack-powervm | 18:24 | |
*** Ashana has quit IRC | 18:28 | |
*** Ashana has joined #openstack-powervm | 18:32 | |
*** Ashana has quit IRC | 18:32 | |
*** Ashana has joined #openstack-powervm | 18:32 | |
*** Ashana has quit IRC | 18:33 | |
*** Ashana has joined #openstack-powervm | 18:34 | |
*** Ashana has quit IRC | 18:37 | |
*** Ashana has joined #openstack-powervm | 18:37 | |
*** Ashana has quit IRC | 18:40 | |
*** Ashana has joined #openstack-powervm | 18:43 | |
*** Ashana has quit IRC | 18:45 | |
*** Ashana has joined #openstack-powervm | 18:46 | |
*** Ashana has quit IRC | 18:48 | |
*** Ashana has joined #openstack-powervm | 18:49 | |
*** Ashana has quit IRC | 18:53 | |
*** Ashana has joined #openstack-powervm | 18:53 | |
*** edmondsw has quit IRC | 18:56 | |
*** Ashana has quit IRC | 19:02 | |
*** Ashana has joined #openstack-powervm | 19:05 | |
*** tblakeslee has quit IRC | 19:21 | |
*** tblakeslee has joined #openstack-powervm | 19:28 | |
*** Ashana has quit IRC | 19:39 | |
*** Ashana has joined #openstack-powervm | 19:41 | |
*** tblakeslee has quit IRC | 19:53 | |
*** Ashana has quit IRC | 19:57 | |
*** Ashana has joined #openstack-powervm | 20:02 | |
*** Ashana has quit IRC | 20:04 | |
*** Ashana has joined #openstack-powervm | 20:07 | |
*** tblakeslee has joined #openstack-powervm | 20:18 | |
*** Ashana has quit IRC | 20:21 | |
*** Ashana has joined #openstack-powervm | 20:25 | |
*** tblakeslee has quit IRC | 20:26 | |
*** tblakeslee has joined #openstack-powervm | 20:29 | |
*** Ashana has quit IRC | 20:29 | |
*** lmtaylor1 has quit IRC | 20:39 | |
*** dwayne_ has quit IRC | 20:39 | |
*** edmondsw has joined #openstack-powervm | 21:00 | |
*** apearson has quit IRC | 21:04 | |
*** jwcroppe has quit IRC | 21:08 | |
*** kylek3h has quit IRC | 21:18 | |
*** esberglu has quit IRC | 21:39 | |
*** burgerk has quit IRC | 21:45 | |
*** edmondsw has quit IRC | 21:53 | |
*** tblakeslee has quit IRC | 21:54 | |
*** catintheroof has quit IRC | 22:06 | |
*** mdrabe has quit IRC | 22:23 | |
*** miltonm has quit IRC | 22:33 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!