*** thorst has quit IRC | 00:02 | |
*** Ashana has quit IRC | 00:02 | |
*** Ashana has joined #openstack-powervm | 00:04 | |
*** Ashana has quit IRC | 00:08 | |
*** Ashana has joined #openstack-powervm | 00:10 | |
*** Ashana has quit IRC | 00:14 | |
*** Ashana has joined #openstack-powervm | 00:16 | |
*** Ashana has quit IRC | 00:20 | |
*** Ashana has joined #openstack-powervm | 00:24 | |
*** Ashana has quit IRC | 00:28 | |
*** Ashana has joined #openstack-powervm | 00:30 | |
*** Ashana has quit IRC | 00:34 | |
*** Ashana has joined #openstack-powervm | 00:36 | |
*** Ashana has quit IRC | 00:40 | |
*** Ashana has joined #openstack-powervm | 00:41 | |
*** apearson has quit IRC | 00:44 | |
*** Ashana has quit IRC | 00:46 | |
*** Ashana has joined #openstack-powervm | 00:47 | |
*** Ashana has quit IRC | 00:52 | |
*** Ashana has joined #openstack-powervm | 00:53 | |
*** thorst has joined #openstack-powervm | 00:54 | |
*** thorst has quit IRC | 00:55 | |
*** thorst has joined #openstack-powervm | 00:56 | |
*** Ashana has quit IRC | 00:57 | |
*** Ashana has joined #openstack-powervm | 00:59 | |
*** Ashana has quit IRC | 01:03 | |
*** thorst has quit IRC | 01:04 | |
*** Ashana has joined #openstack-powervm | 01:05 | |
*** Ashana has quit IRC | 01:10 | |
*** Ashana has joined #openstack-powervm | 01:11 | |
*** Ashana has quit IRC | 01:15 | |
*** thorst has joined #openstack-powervm | 01:15 | |
*** Ashana has joined #openstack-powervm | 01:17 | |
*** thorst has quit IRC | 01:18 | |
*** Ashana has quit IRC | 01:21 | |
*** seroyer has joined #openstack-powervm | 01:21 | |
*** Ashana has joined #openstack-powervm | 01:24 | |
*** Ashana has quit IRC | 01:29 | |
*** Ashana has joined #openstack-powervm | 01:33 | |
*** Ashana has quit IRC | 01:38 | |
*** Ashana has joined #openstack-powervm | 01:42 | |
*** Ashana has quit IRC | 01:46 | |
*** Ashana has joined #openstack-powervm | 01:48 | |
*** Ashana has quit IRC | 01:52 | |
*** Ashana has joined #openstack-powervm | 01:53 | |
*** thorst has joined #openstack-powervm | 01:56 | |
*** thorst has quit IRC | 01:57 | |
*** thorst has joined #openstack-powervm | 01:58 | |
*** Ashana has quit IRC | 01:58 | |
*** esberglu has quit IRC | 01:59 | |
*** Ashana has joined #openstack-powervm | 01:59 | |
*** seroyer has quit IRC | 02:01 | |
*** Ashana has quit IRC | 02:04 | |
*** Ashana has joined #openstack-powervm | 02:05 | |
*** thorst has quit IRC | 02:07 | |
*** Ashana has quit IRC | 02:10 | |
*** Ashana has joined #openstack-powervm | 02:11 | |
*** Ashana has quit IRC | 02:15 | |
*** Ashana has joined #openstack-powervm | 02:17 | |
*** Ashana has quit IRC | 02:21 | |
*** Ashana has joined #openstack-powervm | 02:25 | |
*** ManojK has quit IRC | 02:28 | |
*** Ashana has quit IRC | 02:29 | |
*** Ashana has joined #openstack-powervm | 02:31 | |
*** Ashana has quit IRC | 02:35 | |
*** Ashana has joined #openstack-powervm | 02:37 | |
*** Ashana has quit IRC | 02:41 | |
*** Ashana has joined #openstack-powervm | 02:43 | |
*** ManojK has joined #openstack-powervm | 02:44 | |
*** Ashana has quit IRC | 02:47 | |
*** Ashana has joined #openstack-powervm | 02:49 | |
*** Ashana has quit IRC | 02:53 | |
*** Ashana has joined #openstack-powervm | 02:54 | |
*** Ashana has quit IRC | 02:59 | |
*** Ashana has joined #openstack-powervm | 03:00 | |
*** ManojK has quit IRC | 03:04 | |
*** Ashana has quit IRC | 03:05 | |
*** thorst has joined #openstack-powervm | 03:05 | |
*** Ashana has joined #openstack-powervm | 03:06 | |
*** Ashana has quit IRC | 03:10 | |
*** thorst has quit IRC | 03:11 | |
*** Ashana has joined #openstack-powervm | 03:12 | |
*** Ashana has quit IRC | 03:16 | |
*** Ashana has joined #openstack-powervm | 03:18 | |
*** Ashana has quit IRC | 03:23 | |
*** Ashana has joined #openstack-powervm | 03:26 | |
*** Ashana has quit IRC | 03:30 | |
*** Ashana has joined #openstack-powervm | 03:32 | |
*** Ashana has quit IRC | 03:36 | |
*** Ashana has joined #openstack-powervm | 03:38 | |
*** Ashana has quit IRC | 03:42 | |
*** Ashana has joined #openstack-powervm | 03:44 | |
*** Ashana has quit IRC | 03:48 | |
*** Ashana has joined #openstack-powervm | 03:49 | |
*** mdmillerii has quit IRC | 03:52 | |
*** Ashana has quit IRC | 03:54 | |
*** Ashana has joined #openstack-powervm | 03:55 | |
*** Ashana has quit IRC | 04:00 | |
*** Ashana has joined #openstack-powervm | 04:01 | |
*** Ashana has quit IRC | 04:06 | |
*** Ashana has joined #openstack-powervm | 04:07 | |
*** thorst has joined #openstack-powervm | 04:10 | |
*** Ashana has quit IRC | 04:11 | |
*** Ashana has joined #openstack-powervm | 04:13 | |
*** thorst has quit IRC | 04:16 | |
*** Ashana has quit IRC | 04:17 | |
*** ManojK has joined #openstack-powervm | 04:18 | |
*** Ashana has joined #openstack-powervm | 04:19 | |
*** Ashana has quit IRC | 04:23 | |
*** Ashana has joined #openstack-powervm | 04:26 | |
*** ManojK has quit IRC | 04:29 | |
*** Ashana has quit IRC | 04:30 | |
*** Ashana has joined #openstack-powervm | 04:32 | |
*** Ashana has quit IRC | 04:37 | |
*** Ashana has joined #openstack-powervm | 04:38 | |
*** Ashana has quit IRC | 04:42 | |
*** Ashana has joined #openstack-powervm | 04:44 | |
*** Ashana has quit IRC | 04:48 | |
*** Ashana has joined #openstack-powervm | 04:50 | |
*** Ashana has quit IRC | 04:54 | |
*** Ashana has joined #openstack-powervm | 04:56 | |
*** Ashana has quit IRC | 05:00 | |
*** Ashana has joined #openstack-powervm | 05:02 | |
*** Ashana has quit IRC | 05:06 | |
*** Ashana has joined #openstack-powervm | 05:07 | |
*** Ashana has quit IRC | 05:13 | |
*** Ashana has joined #openstack-powervm | 05:13 | |
*** thorst has joined #openstack-powervm | 05:13 | |
*** Ashana has quit IRC | 05:18 | |
*** Ashana has joined #openstack-powervm | 05:19 | |
*** thorst has quit IRC | 05:21 | |
*** Ashana has quit IRC | 05:24 | |
*** Ashana has joined #openstack-powervm | 05:27 | |
*** Ashana has quit IRC | 05:31 | |
*** Ashana has joined #openstack-powervm | 05:33 | |
*** Ashana has quit IRC | 05:37 | |
*** Ashana has joined #openstack-powervm | 05:38 | |
*** Ashana has quit IRC | 05:43 | |
*** Ashana has joined #openstack-powervm | 05:44 | |
*** Ashana has quit IRC | 05:48 | |
*** Ashana has joined #openstack-powervm | 05:50 | |
*** Ashana has quit IRC | 05:55 | |
*** Ashana has joined #openstack-powervm | 05:56 | |
*** Ashana has quit IRC | 06:01 | |
*** Ashana has joined #openstack-powervm | 06:02 | |
*** Ashana has quit IRC | 06:06 | |
*** Ashana has joined #openstack-powervm | 06:08 | |
*** Ashana has quit IRC | 06:12 | |
*** Ashana has joined #openstack-powervm | 06:14 | |
*** Ashana has quit IRC | 06:19 | |
*** thorst has joined #openstack-powervm | 06:19 | |
*** Ashana has joined #openstack-powervm | 06:20 | |
*** Ashana has quit IRC | 06:24 | |
*** thorst has quit IRC | 06:26 | |
*** Ashana has joined #openstack-powervm | 06:27 | |
-openstackstatus- NOTICE: All python 3.5 jobs are failing today, we need to build new xenial images first. | 06:28 | |
*** Ashana has quit IRC | 06:31 | |
*** Ashana has joined #openstack-powervm | 06:33 | |
*** Ashana has quit IRC | 06:38 | |
*** Ashana has joined #openstack-powervm | 06:39 | |
*** Ashana has quit IRC | 06:43 | |
*** Ashana has joined #openstack-powervm | 06:45 | |
*** tlian has quit IRC | 06:45 | |
*** k0da has joined #openstack-powervm | 06:47 | |
*** Ashana has quit IRC | 06:49 | |
*** Ashana has joined #openstack-powervm | 06:50 | |
*** Ashana has quit IRC | 06:55 | |
*** Ashana has joined #openstack-powervm | 06:56 | |
*** Ashana has quit IRC | 07:01 | |
*** Ashana has joined #openstack-powervm | 07:02 | |
*** Ashana has quit IRC | 07:07 | |
*** Ashana has joined #openstack-powervm | 07:08 | |
*** Ashana has quit IRC | 07:12 | |
*** Ashana has joined #openstack-powervm | 07:14 | |
*** Ashana has quit IRC | 07:18 | |
*** Ashana has joined #openstack-powervm | 07:20 | |
*** Ashana has quit IRC | 07:24 | |
*** thorst has joined #openstack-powervm | 07:25 | |
*** Ashana has joined #openstack-powervm | 07:27 | |
*** thorst has quit IRC | 07:31 | |
*** Ashana has quit IRC | 07:32 | |
*** Ashana has joined #openstack-powervm | 07:33 | |
*** Ashana has quit IRC | 07:38 | |
*** Ashana has joined #openstack-powervm | 07:39 | |
*** Ashana has quit IRC | 07:43 | |
*** Ashana has joined #openstack-powervm | 07:45 | |
*** Ashana has quit IRC | 07:50 | |
*** Ashana has joined #openstack-powervm | 07:51 | |
*** Ashana has quit IRC | 07:55 | |
*** Ashana has joined #openstack-powervm | 07:57 | |
*** Ashana has quit IRC | 08:01 | |
*** Ashana has joined #openstack-powervm | 08:03 | |
*** Ashana has quit IRC | 08:07 | |
*** Ashana has joined #openstack-powervm | 08:08 | |
*** Ashana has quit IRC | 08:13 | |
*** Ashana has joined #openstack-powervm | 08:14 | |
*** Ashana has quit IRC | 08:18 | |
*** Ashana has joined #openstack-powervm | 08:20 | |
*** Ashana has quit IRC | 08:25 | |
*** Ashana has joined #openstack-powervm | 08:28 | |
*** thorst has joined #openstack-powervm | 08:29 | |
*** Ashana has quit IRC | 08:32 | |
*** Ashana has joined #openstack-powervm | 08:34 | |
*** thorst has quit IRC | 08:36 | |
*** Ashana has quit IRC | 08:38 | |
*** Ashana has joined #openstack-powervm | 08:39 | |
*** Ashana has quit IRC | 08:44 | |
*** Ashana has joined #openstack-powervm | 08:45 | |
*** Ashana has quit IRC | 08:50 | |
*** Ashana has joined #openstack-powervm | 08:51 | |
*** Ashana has quit IRC | 08:56 | |
*** Ashana has joined #openstack-powervm | 08:57 | |
*** Ashana has quit IRC | 09:01 | |
*** Ashana has joined #openstack-powervm | 09:03 | |
*** jwcroppe has joined #openstack-powervm | 09:04 | |
*** Ashana has quit IRC | 09:07 | |
*** Ashana has joined #openstack-powervm | 09:09 | |
*** Ashana has quit IRC | 09:14 | |
*** Ashana has joined #openstack-powervm | 09:15 | |
*** Ashana has quit IRC | 09:19 | |
*** Ashana has joined #openstack-powervm | 09:21 | |
*** Ashana has quit IRC | 09:25 | |
*** Ashana has joined #openstack-powervm | 09:28 | |
*** Ashana has quit IRC | 09:33 | |
*** Ashana has joined #openstack-powervm | 09:34 | |
*** thorst has joined #openstack-powervm | 09:35 | |
*** Ashana has quit IRC | 09:38 | |
*** Ashana has joined #openstack-powervm | 09:40 | |
*** thorst has quit IRC | 09:42 | |
*** Ashana has quit IRC | 09:44 | |
*** Ashana has joined #openstack-powervm | 09:46 | |
*** Ashana has quit IRC | 09:51 | |
*** Ashana has joined #openstack-powervm | 09:52 | |
*** Ashana has quit IRC | 09:56 | |
*** Ashana has joined #openstack-powervm | 09:58 | |
*** Ashana has quit IRC | 10:02 | |
*** Ashana has joined #openstack-powervm | 10:04 | |
*** Ashana has quit IRC | 10:08 | |
*** Ashana has joined #openstack-powervm | 10:10 | |
*** Ashana has quit IRC | 10:14 | |
*** Ashana has joined #openstack-powervm | 10:15 | |
*** Ashana has quit IRC | 10:20 | |
*** Ashana has joined #openstack-powervm | 10:21 | |
*** Ashana has quit IRC | 10:26 | |
*** Ashana has joined #openstack-powervm | 10:29 | |
*** Ashana has quit IRC | 10:34 | |
*** Ashana has joined #openstack-powervm | 10:35 | |
*** Ashana has quit IRC | 10:40 | |
*** thorst has joined #openstack-powervm | 10:40 | |
*** Ashana has joined #openstack-powervm | 10:41 | |
*** Ashana has quit IRC | 10:46 | |
*** thorst has quit IRC | 10:46 | |
*** seroyer has joined #openstack-powervm | 11:18 | |
*** seroyer has quit IRC | 11:26 | |
*** thorst has joined #openstack-powervm | 11:50 | |
*** thorst_ has joined #openstack-powervm | 11:52 | |
*** thorst__ has joined #openstack-powervm | 11:52 | |
*** thorst has quit IRC | 11:54 | |
*** thorst_ has quit IRC | 11:56 | |
*** thorst__ is now known as thorst | 12:30 | |
*** Ashana has joined #openstack-powervm | 12:53 | |
*** tlian has joined #openstack-powervm | 12:57 | |
*** seroyer has joined #openstack-powervm | 12:58 | |
thorst | Ashana: I put some review comments on your change set. Are you able to test the syntax locally? I know you're still hitting issues running it, but I think that syntax issue will show up pretty quick (cause it will fail to load repo-build) | 13:02 |
---|---|---|
*** mdrabe has joined #openstack-powervm | 13:03 | |
Ashana | I was looking Yea I was starting to look for a plugin for sublime, because at first I tested the syntax with an online tool. | 13:03 |
thorst | Ashana: I think for now, just try to run it on your .230 node and see if it loads as a sniff test | 13:04 |
thorst | at least that is an option | 13:04 |
thorst | the automated tests did run pretty quick. | 13:04 |
Ashana | I had put the code on .230 before and it kept getting errors in the repo-server.yml when I ran repo-install.yml. So it never reached my code changes but I can try it again. | 13:06 |
Ashana | Should I still be running repo-install when Im testing it? | 13:06 |
*** tblakeslee has joined #openstack-powervm | 13:06 | |
thorst | Ashana: yeah...I thought it would fail with syntax errors before it hit that code though | 13:09 |
thorst | because what is there now is a syntax error... | 13:09 |
Ashana | Ahh ok yes it does ok I understand now | 13:10 |
Ashana | Yep its a syntax error | 13:10 |
thorst | seroyer: Did I hear that a lot of MN is without power? | 13:16 |
seroyer | thorst: Maybe? Not here. There were tornados farther west. We just got lots of rain and wind. | 13:17 |
thorst | ahh, I had a meeting rescheduled because its bad up in the twin cities at least. Wasn't sure if it extended down to Roch | 13:17 |
seroyer | I heard there were trees down in the area, but I didn’t see any. | 13:18 |
*** ManojK has joined #openstack-powervm | 13:23 | |
*** esberglu has joined #openstack-powervm | 13:32 | |
*** esberglu has left #openstack-powervm | 13:32 | |
*** kriskend has joined #openstack-powervm | 13:36 | |
*** lmtaylor1 has joined #openstack-powervm | 13:44 | |
*** ManojK has quit IRC | 13:57 | |
*** apearson has joined #openstack-powervm | 13:59 | |
*** ManojK has joined #openstack-powervm | 14:00 | |
Ashana | @adreznec I have started the gerrit review and in the background Drew and I decide to do revert back to an old disk image and start there | 14:01 |
Ashana | Support building copies of CPU architecture specific artifacts on each build | 14:02 |
Ashana | master, which will be synchronized to all slaves regardless of architecture. | 14:02 |
Ashana | @adreznec but in the mean time I was wondering what are you thoughts about the next steps ^^ | 14:02 |
adreznec | Ashana: Oh, you put that up? Didn't see it in my code review queue... | 14:04 |
adreznec | Let me look again quick | 14:04 |
thorst | adreznec: I think we're just wondering how to pursue the next step...which is the synchonization of all slaves | 14:04 |
*** dwayne_ has joined #openstack-powervm | 14:04 | |
adreznec | thorst: Well the synchronization between all repo masters already happens today over rsync | 14:05 |
adreznec | We need to make sure that actually works across archs | 14:05 |
adreznec | And that it happens serially | 14:05 |
adreznec | So we don't get artifact conflicts | 14:05 |
adreznec | For things like noarch packages | 14:06 |
adreznec | Oh, I see why it's not in my review queue, my old account got added to the review | 14:07 |
adreznec | I should talk with the infra guys about deleting that or merging it with my current account | 14:07 |
thorst | adreznec: so the rsync probably syncs all to the same folder? Don't we need to be doing the repo builds in an architecture specific path first? | 14:09 |
adreznec | thorst: Yeah, all the artifacts get rsynced between all repo build servers. I think we need to do the builds serially for each arch, then sync them together serially | 14:10 |
adreznec | and make sure rsync has the flag on to collapse duplicate artifacts | 14:10 |
thorst | adreznec: but am I right that today, the path they go in, isn't arch specific? Does it need to be? | 14:11 |
adreznec | We shouldn't really need any arch specific pathing | 14:11 |
thorst | ahh, nevermind then | 14:11 |
thorst | do the artifacts have the arch in their name? | 14:11 |
adreznec | Since we're going to have to add code to pull the right arch specific artifacts where needed anyway | 14:11 |
*** ManojK has quit IRC | 14:11 | |
adreznec | The venvs do I believe, but not the wheels yet | 14:12 |
adreznec | That needs to be added | 14:12 |
thorst | so is that an appropriate next step then? Add the arch to the wheels (with a DNM tag in the commit message initially)? | 14:12 |
adreznec | Yeah, Ashana could start looking at that | 14:12 |
thorst | now to find where the wheels are built. | 14:17 |
*** mdrabe has quit IRC | 14:20 | |
thorst | Ashana: https://github.com/openstack/openstack-ansible-repo_build/tree/master/tasks | 14:20 |
thorst | you'll need to clone down another repository (openstack-ansible-repo_build) | 14:20 |
thorst | I think it is the repo_build.yml file that you'll need to update there. Something that will build with the appropriate architecture flag | 14:21 |
*** tjakobs has joined #openstack-powervm | 14:22 | |
thorst | Ashana: may just be a second step that renames the output files from the first to the architecture it is running on ( adreznec: keep me honest ) | 14:23 |
adreznec | thorst: Yeah, that would work | 14:25 |
thorst | adreznec: http://lucumr.pocoo.org/2014/1/27/python-on-wheels/ | 14:26 |
adreznec | Unless you can specify fields to append to the name on venv build | 14:26 |
thorst | Should...uhhh...we even care? Shouldn't the libraries that need specific libraries come with the 'is_pure' flag set to false? | 14:26 |
adreznec | thorst: ?? | 14:26 |
adreznec | Don't wheels already have the arch in the name by default? | 14:26 |
thorst | hmmm...I see. Sorry, I'm new to wheels. So really Ashana doesn't have to rename the output files at all... | 14:29 |
thorst | (I'm running wheel stuff manually to play around now) | 14:29 |
adreznec | Not for wheels | 14:29 |
adreznec | But we do for venvs | 14:29 |
adreznec | Not sure if there are any other artifact types I'm not aware of | 14:29 |
adreznec | We probably need to look in a completed repo server container | 14:30 |
adreznec | To verify | 14:30 |
*** mdrabe has joined #openstack-powervm | 14:31 | |
thorst | adreznec: https://github.com/openstack/openstack-ansible-repo_build/blob/master/templates/op-venv-script.sh.j2#L35 | 14:35 |
thorst | is that the place that potentially needs to change? | 14:35 |
*** ManojK has joined #openstack-powervm | 14:35 | |
*** dwayne_ has quit IRC | 14:39 | |
*** dwayne_ has joined #openstack-powervm | 14:41 | |
thorst | Ashana: let me know when I can stop over and we'll chat about the next steps | 16:16 |
*** jwcroppe has quit IRC | 16:23 | |
*** jwcroppe has joined #openstack-powervm | 16:23 | |
*** jwcroppe has quit IRC | 16:28 | |
*** tblakeslee has quit IRC | 16:51 | |
*** ManojK has quit IRC | 17:07 | |
Ashana | Ok great, I have been doing the fresh install steps and will let you know | 17:11 |
*** k0da has quit IRC | 17:37 | |
thorst | burgerk: Can you re-review pypowervm change 3495? | 17:49 |
thorst | I just pushed up something new there and wouldn't mind getting that one out of my hair. | 17:49 |
*** ManojK has joined #openstack-powervm | 17:53 | |
*** k0da has joined #openstack-powervm | 17:54 | |
*** tblakeslee has joined #openstack-powervm | 17:58 | |
burgerk | done | 18:01 |
*** ManojK has quit IRC | 19:07 | |
*** thorst has quit IRC | 19:08 | |
*** esberglu has joined #openstack-powervm | 19:09 | |
*** thorst has joined #openstack-powervm | 19:10 | |
*** ManojK has joined #openstack-powervm | 19:12 | |
*** thorst has quit IRC | 19:14 | |
*** thorst has joined #openstack-powervm | 19:27 | |
mdrabe | thorst: https://bugs.launchpad.net/nova-powervm/+bug/1596797 about this one | 20:12 |
openstack | Launchpad bug 1596797 in nova-powervm "After failure of evacuate operation the VM on the target host is not cleaned up" [Undecided,New] - Assigned to Tyler Blakeslee (tblakes) | 20:12 |
thorst | mdrabe: yep | 20:13 |
mdrabe | So when plug vifs fails on a rebuild the LPAR isn't cleaned up on the destination | 20:13 |
mdrabe | Libvirt driver sort of has the same problem, but not with plug vifs | 20:13 |
thorst | wasn't that the whole 'Create' task needs a roll back...but then you questioned it should be handled in the manager? | 20:13 |
mdrabe | because libvirt plugs vifs before creating the domain (somehow?) https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4859-L4874 | 20:13 |
thorst | mdrabe: its kinda plugs vifs before creating the domain | 20:14 |
thorst | :-) | 20:14 |
mdrabe | Right, there is no rollback for a rebuild failure | 20:14 |
thorst | for some vifs, things need to be done before the domain is created. Like the hybrid veths. | 20:14 |
thorst | I think you're asserting those veth pairs would hang aroud. | 20:14 |
thorst | around. | 20:14 |
mdrabe | My concern is the cleanup of the LPAR / domain | 20:15 |
thorst | well, for PowerVM...really your concern is the clean up of the VM I think | 20:15 |
mdrabe | What's a VM though? | 20:15 |
thorst | removing the scsi connections, cleaning out the trunk adapters, etc... | 20:15 |
thorst | things for a VM that aren't the VM | 20:15 |
thorst | and definitely in the PowerVM Driver case, also the LPAR | 20:16 |
thorst | :-) | 20:16 |
mdrabe | The taskflow stuff cascades the reverts right? | 20:17 |
mdrabe | So the vif plug and storage connections should already have reverts? | 20:17 |
mdrabe | Yea I'm pretty sure those reverts are already there, the issue is just with the LPAR floating around | 20:18 |
mdrabe | Since the Create task doesn't have a revert and the rebuild rollback doesn't do a driver.destroy | 20:18 |
mdrabe | So we actually _can_ just implement revert for the Create task, but only clean anything up if the instance is in a 'rebuilding' state | 20:19 |
*** jwcroppe has joined #openstack-powervm | 20:19 | |
thorst | mdrabe: yeah...for now | 20:19 |
mdrabe | but the libvirt driver will also leave the domain floating around, it's just unlikely since creating the domain is one of the last things that happens | 20:20 |
thorst | yeah... | 20:21 |
thorst | mdrabe: so I guess the question is. Are you still pursuing a manager change? | 20:22 |
mdrabe | thorst: It's complicated. In debuggin the rebuild rollback flow we've found some more holes... | 20:24 |
mdrabe | I'll probably hit up the nova channel and ask them about it, see if they'd want these things fixed | 20:25 |
thorst | mdrabe: what are the other holes? | 20:25 |
openstackgerrit | Drew Thorstensen proposed openstack/nova-powervm: Refactor validate vopt media repo to pypowervm https://review.openstack.org/338536 | 20:25 |
mdrabe | The evacuate API creates a migration 'tombstone', that tombstone doesn't get removed/invalidated as part of rebuild rollback | 20:26 |
thorst | tombstone? | 20:26 |
thorst | that's new to me | 20:26 |
mdrabe | So if my rebuild fails and the source comes back up, the source instance is going to be deleted | 20:26 |
mdrabe | it's just a migration object in the database | 20:26 |
mdrabe | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3370-L3377 | 20:26 |
thorst | interesting. | 20:27 |
mdrabe | ^^ That's it getting created in the evacuate API | 20:27 |
mdrabe | But maybe nova is okay will deleting the VM from the source host even though the rebuild failed | 20:27 |
thorst | well, as long as it doesn't delete the volume | 20:28 |
mdrabe | It shouldn't | 20:28 |
mdrabe | That's another thing though | 20:29 |
mdrabe | thorst: As part of evacuate the source has it's storage connection ripped out, those don't get replugged if the evacuation fails | 20:29 |
thorst | mdrabe: you're asserting that it is to come back up OK on the source though | 20:30 |
thorst | is that true? | 20:30 |
mdrabe | I'm asserting that if we wanted a true rollback we'd undo everything we did | 20:30 |
thorst | I think that's the question to the nova team. | 20:30 |
mdrabe | But evacuate / rebuild rollback is special obviously | 20:31 |
mdrabe | yep | 20:31 |
*** miltonm has joined #openstack-powervm | 20:38 | |
mdrabe | I'm wrong about that tombstone thing actually, the source _won't_ clean up failed evacuations | 20:40 |
openstackgerrit | Drew Thorstensen proposed openstack/nova-powervm: Refactor validate vopt media repo to pypowervm https://review.openstack.org/338536 | 21:13 |
*** lmtaylor1 has quit IRC | 21:38 | |
*** tblakeslee has quit IRC | 21:39 | |
*** esberglu has quit IRC | 21:42 | |
*** apearson has quit IRC | 21:44 | |
*** Ashana has quit IRC | 21:53 | |
openstackgerrit | Drew Thorstensen proposed openstack/nova-powervm: Driver cleanup work https://review.openstack.org/338573 | 21:59 |
*** Ashana has joined #openstack-powervm | 22:00 | |
*** Ashana has quit IRC | 22:05 | |
*** kriskend has quit IRC | 22:05 | |
*** Ashana has joined #openstack-powervm | 22:06 | |
*** k0da has quit IRC | 22:06 | |
*** Ashana has quit IRC | 22:10 | |
*** Ashana has joined #openstack-powervm | 22:11 | |
*** tblakeslee has joined #openstack-powervm | 22:11 | |
*** mdrabe has quit IRC | 22:12 | |
*** Ashana has quit IRC | 22:16 | |
*** Ashana has joined #openstack-powervm | 22:17 | |
*** burgerk has quit IRC | 22:19 | |
*** Ashana has quit IRC | 22:22 | |
*** Ashana has joined #openstack-powervm | 22:23 | |
*** Ashana has quit IRC | 22:28 | |
*** tblakeslee has quit IRC | 22:28 | |
*** Ashana has joined #openstack-powervm | 22:29 | |
*** Ashana has quit IRC | 22:34 | |
*** tjakobs has quit IRC | 22:35 | |
*** Ashana has joined #openstack-powervm | 22:36 | |
*** Ashana has quit IRC | 22:41 | |
*** Ashana has joined #openstack-powervm | 22:42 | |
*** seroyer has quit IRC | 22:42 | |
*** Ashana has quit IRC | 22:46 | |
*** ManojK has quit IRC | 22:47 | |
*** Ashana has joined #openstack-powervm | 22:48 | |
*** Ashana has quit IRC | 22:52 | |
*** Ashana has joined #openstack-powervm | 22:54 | |
*** Ashana has quit IRC | 22:58 | |
*** tlian2 has joined #openstack-powervm | 22:59 | |
*** Ashana has joined #openstack-powervm | 22:59 | |
*** tlian has quit IRC | 23:02 | |
*** Ashana has quit IRC | 23:04 | |
*** Ashana has joined #openstack-powervm | 23:05 | |
*** Ashana has quit IRC | 23:10 | |
*** Ashana has joined #openstack-powervm | 23:11 | |
*** Ashana has quit IRC | 23:15 | |
*** thorst has quit IRC | 23:16 | |
*** thorst has joined #openstack-powervm | 23:16 | |
*** Ashana has joined #openstack-powervm | 23:17 | |
*** Ashana has quit IRC | 23:21 | |
*** Ashana has joined #openstack-powervm | 23:23 | |
*** thorst_ has joined #openstack-powervm | 23:23 | |
*** thorst has quit IRC | 23:25 | |
*** Ashana has quit IRC | 23:27 | |
*** thorst_ has quit IRC | 23:28 | |
*** Ashana has joined #openstack-powervm | 23:29 | |
*** Ashana has quit IRC | 23:33 | |
*** Ashana has joined #openstack-powervm | 23:37 | |
*** Ashana has quit IRC | 23:41 | |
*** Ashana has joined #openstack-powervm | 23:43 | |
*** Ashana has quit IRC | 23:48 | |
*** Ashana has joined #openstack-powervm | 23:49 | |
*** Ashana has quit IRC | 23:53 | |
*** Ashana has joined #openstack-powervm | 23:54 | |
*** Ashana has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!