| *** thorst has joined #openstack-powervm | 00:50 | |
| *** thorst has quit IRC | 00:58 | |
| *** svenkat has quit IRC | 01:00 | |
| *** thorst has joined #openstack-powervm | 01:13 | |
| *** thorst has quit IRC | 01:15 | |
| *** svenkat has joined #openstack-powervm | 01:25 | |
| *** tjakobs has joined #openstack-powervm | 01:38 | |
| *** svenkat has quit IRC | 01:40 | |
| *** apearson has joined #openstack-powervm | 01:51 | |
| *** apearson has quit IRC | 01:54 | |
| *** thorst has joined #openstack-powervm | 02:16 | |
| *** thorst has quit IRC | 02:24 | |
| *** thorst has joined #openstack-powervm | 03:25 | |
| *** thorst has quit IRC | 03:30 | |
| *** thorst has joined #openstack-powervm | 04:26 | |
| *** thorst has quit IRC | 04:35 | |
| *** tjakobs has quit IRC | 04:49 | |
| *** kotra03 has joined #openstack-powervm | 05:13 | |
| *** thorst has joined #openstack-powervm | 05:33 | |
| *** thorst has quit IRC | 05:40 | |
| *** thorst has joined #openstack-powervm | 06:37 | |
| *** thorst has quit IRC | 06:44 | |
| *** thorst has joined #openstack-powervm | 07:43 | |
| *** thorst has quit IRC | 07:50 | |
| *** k0da has joined #openstack-powervm | 08:20 | |
| *** k0da has quit IRC | 08:37 | |
| *** thorst has joined #openstack-powervm | 08:48 | |
| *** thorst has quit IRC | 08:54 | |
| *** k0da has joined #openstack-powervm | 09:44 | |
| *** thorst has joined #openstack-powervm | 09:52 | |
| *** k0da has quit IRC | 09:52 | |
| *** k0da has joined #openstack-powervm | 09:53 | |
| *** thorst has quit IRC | 09:59 | |
| *** thorst has joined #openstack-powervm | 10:50 | |
| *** thorst has quit IRC | 10:55 | |
| *** thorst has joined #openstack-powervm | 10:56 | |
| *** smatzek has joined #openstack-powervm | 11:04 | |
| *** thorst has quit IRC | 11:05 | |
| *** svenkat has joined #openstack-powervm | 11:22 | |
| *** thorst has joined #openstack-powervm | 11:31 | |
| *** Ashana has joined #openstack-powervm | 11:55 | |
| *** k0da has quit IRC | 11:59 | |
| *** edmondsw has joined #openstack-powervm | 11:59 | |
| *** k0da has joined #openstack-powervm | 12:02 | |
| *** madhaviy has joined #openstack-powervm | 12:31 | |
| *** efried has joined #openstack-powervm | 12:42 | |
| *** efried has quit IRC | 12:52 | |
| *** efried has joined #openstack-powervm | 12:52 | |
| *** tblakeslee has joined #openstack-powervm | 12:54 | |
| *** efried1 has joined #openstack-powervm | 13:06 | |
| *** efried has quit IRC | 13:06 | |
| openstackgerrit | Drew Thorstensen proposed openstack/networking-powervm: Support returning non-mgmt LPAR UUIDs https://review.openstack.org/341125 | 13:12 |
|---|---|---|
| thorst | efried1: ^^ I think that addresses most of your concerns (a small tweak to the name). However, one of your comment still holds up (nothing is setting exclude to False). That should come in 344379 - but didn't want to keep esha's bug fix held up for new function | 13:13 |
| efried1 | looking | 13:13 |
| *** mdrabe has joined #openstack-powervm | 13:15 | |
| *** esberglu has joined #openstack-powervm | 13:23 | |
| *** madhaviy has quit IRC | 13:44 | |
| *** madhaviy has joined #openstack-powervm | 13:44 | |
| *** smatzek has quit IRC | 13:47 | |
| *** madhaviy has quit IRC | 13:49 | |
| efried1 | thorst: I'm still not on board. The change from 'include' to 'exclude' is a tiny improvement, but barely significant. 344379 doesn't seem to reference the changed function. There are two calls to this method. Each of those calls should be a single inline list comprehension. If one of them is planning to exclude the management partition, it should have a comment explaining why the management partition isn't wanted - t | 13:53 |
| thorst | efried1: So basically, its the build_prov_requests that needs it | 13:53 |
| thorst | the main thing there is that we need to add all of the CNAs to overall_cnas | 13:53 |
| thorst | but we don't want the mgmt LPAR id in there. | 13:54 |
| thorst | so that will change to exclude_mgmt_partition False, but then will have an additional check that if the LPAR uuid is the mgmt UUID, then add the CNAs to overall_cnas but not to the LPAR UUIDs | 13:54 |
| thorst | I haven't made the change in the subsequent change set yet. | 13:54 |
| thorst | getting through design reviews atm | 13:54 |
| thorst | I'll rebase the other on top of this one though | 13:55 |
| efried1 | No dude, stop. You're not hearing me. | 13:55 |
| efried1 | list_lpar_uuids is 20LOC for what would be a single line of code from the caller. It is not adding any value. | 13:56 |
| thorst | o, just get rid of the method itself? | 13:57 |
| efried1 | Yes. | 13:57 |
| thorst | yeah, meh, was just trying to keep Esha's change in tact somewhat | 13:57 |
| thorst | but I can do that | 13:57 |
| efried1 | BTW, are you saying that _build_system_prov_requests is going to deal with all of the LPARs, but treat the mgmt partition different from the others? | 13:58 |
| thorst | efried1: yeah, it has to :-/ | 13:59 |
| thorst | because the mgmt partition is not an LPAR that OpenStack manages | 13:59 |
| efried1 | Then even more so: | 13:59 |
| efried1 | for lpar in get_partitions(): | 14:00 |
| efried1 | if lpar.is_mgmt_partition: | 14:00 |
| efried1 | # do the mgmt-specific thing with lpar.uuid | 14:00 |
| efried1 | else: | 14:00 |
| efried1 | # do the non-mgmt thing with lpar.uuid | 14:00 |
| thorst | efried1: yep. makes sense. | 14:00 |
| *** catintheroof has joined #openstack-powervm | 14:24 | |
| *** tjakobs has joined #openstack-powervm | 14:26 | |
| *** seroyer has joined #openstack-powervm | 14:43 | |
| *** lmtaylor has joined #openstack-powervm | 14:46 | |
| *** seroyer has quit IRC | 14:58 | |
| *** mdrabe has quit IRC | 15:06 | |
| *** mdrabe has joined #openstack-powervm | 15:11 | |
| openstackgerrit | Sridhar Venkat proposed openstack/nova-powervm: WIP: VIF driver implementation for SR-IOV https://review.openstack.org/343419 | 15:13 |
| *** efried1 has quit IRC | 15:14 | |
| *** k0da has quit IRC | 15:51 | |
| openstackgerrit | Drew Thorstensen proposed openstack/networking-powervm: Support returning non-mgmt LPAR UUIDs https://review.openstack.org/341125 | 15:53 |
| *** Ashana has quit IRC | 15:55 | |
| *** Ashana has joined #openstack-powervm | 16:06 | |
| *** Ashana has quit IRC | 16:10 | |
| *** Ashana has joined #openstack-powervm | 16:12 | |
| *** Ashana has quit IRC | 16:16 | |
| *** Ashana has joined #openstack-powervm | 16:18 | |
| *** seroyer has joined #openstack-powervm | 16:22 | |
| *** Ashana has quit IRC | 16:22 | |
| *** Ashana has joined #openstack-powervm | 16:24 | |
| openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm: [WIP] Add iscsi support https://review.openstack.org/346920 | 16:27 |
| *** Ashana has quit IRC | 16:29 | |
| *** madhaviy has joined #openstack-powervm | 16:29 | |
| *** Ashana has joined #openstack-powervm | 16:30 | |
| *** apearson has joined #openstack-powervm | 16:31 | |
| *** seroyer has quit IRC | 16:31 | |
| *** Ashana has quit IRC | 16:35 | |
| *** Ashana has joined #openstack-powervm | 16:36 | |
| *** Ashana has quit IRC | 16:41 | |
| *** Ashana has joined #openstack-powervm | 16:42 | |
| *** tblakeslee has quit IRC | 16:46 | |
| *** Ashana has quit IRC | 16:47 | |
| *** Ashana has joined #openstack-powervm | 16:48 | |
| *** Ashana has quit IRC | 16:53 | |
| *** Ashana has joined #openstack-powervm | 16:55 | |
| *** Ashana has quit IRC | 16:59 | |
| *** Ashana has joined #openstack-powervm | 17:01 | |
| *** Ashana has quit IRC | 17:05 | |
| *** Ashana has joined #openstack-powervm | 17:06 | |
| *** madhaviy has quit IRC | 17:16 | |
| thorst | adreznec: there? | 17:17 |
| *** kotra03 has quit IRC | 17:21 | |
| adreznec | thorst: Sup | 17:30 |
| thorst | tjakobs adreznec: That iscsi support. We're not supporting iSCSI nova ephemeral disks. That needs to be a volume driver? | 17:30 |
| *** tblakeslee has joined #openstack-powervm | 17:34 | |
| openstackgerrit | Sridhar Venkat proposed openstack/networking-powervm: Checkin blueprint for networking-powervm for SR-IOV VIFs support https://review.openstack.org/322210 | 17:37 |
| adreznec | thorst: Yeah, that's correct. Haven't had a chance to look at tjakobs patch yet | 17:37 |
| adreznec | But we'll need to change it if that's what the WIP is | 17:38 |
| tjakobs | thorst: thanks for the correction, i'll look at changing it | 17:38 |
| thorst | yeah, a few things need to be changed....but wanted to make sure | 17:38 |
| thorst | tjakobs: the first thing is that I think that job should be a task down in pypowervm | 17:38 |
| thorst | I was planning to do that actually, but if you're there...go for it | 17:39 |
| openstackgerrit | Sridhar Venkat proposed openstack/networking-powervm: WIP: Mechanism driver for powervm SR-IOV interface https://review.openstack.org/343423 | 17:39 |
| *** seroyer has joined #openstack-powervm | 17:54 | |
| *** jwcroppe has joined #openstack-powervm | 18:01 | |
| *** seroyer has quit IRC | 18:01 | |
| openstackgerrit | Sridhar Venkat proposed openstack/nova-powervm: Blueprint for nova-powervm SR-IOV VIFs https://review.openstack.org/322203 | 18:05 |
| openstackgerrit | Merged openstack/nova-powervm: Adds supports_device_tagging to capabilities https://review.openstack.org/345021 | 18:09 |
| openstackgerrit | Drew Thorstensen proposed openstack/networking-powervm: WIP: Support VIOS CNAs https://review.openstack.org/344379 | 18:12 |
| *** thorst has quit IRC | 18:23 | |
| *** thorst has joined #openstack-powervm | 18:30 | |
| *** thorst has quit IRC | 18:34 | |
| *** Ashana_ has joined #openstack-powervm | 18:54 | |
| *** Ashana has quit IRC | 18:58 | |
| *** efried has joined #openstack-powervm | 19:09 | |
| *** lmtaylor has left #openstack-powervm | 19:23 | |
| *** jwcroppe has quit IRC | 19:58 | |
| *** jwcroppe has joined #openstack-powervm | 20:00 | |
| *** apearson has quit IRC | 20:00 | |
| *** arnoldje has joined #openstack-powervm | 20:21 | |
| *** thorst has joined #openstack-powervm | 20:32 | |
| *** apearson has joined #openstack-powervm | 20:34 | |
| *** jwcroppe has quit IRC | 20:55 | |
| *** jwcroppe has joined #openstack-powervm | 20:56 | |
| *** Ashana_ has quit IRC | 20:57 | |
| *** Ashana has joined #openstack-powervm | 21:01 | |
| *** Ashana has quit IRC | 21:08 | |
| *** Ashana has joined #openstack-powervm | 21:08 | |
| *** svenkat has quit IRC | 21:14 | |
| *** seroyer has joined #openstack-powervm | 21:16 | |
| thorst | efried: want to give 341125 another go? Gate is a bit hosed up...but I think I've got it refactored the way you were thinking | 21:19 |
| efried | rgr | 21:20 |
| thorst | bonus points if you take a look at 344379 again as well. | 21:20 |
| *** seroyer has quit IRC | 21:28 | |
| *** k0da has joined #openstack-powervm | 21:29 | |
| thorst | adreznec: https://review.openstack.org/#/c/346863/2/tasks/main.yml | 21:33 |
| thorst | what's the > doing in there? | 21:33 |
| efried | thorst, 341125 done. Going for bonus points. | 21:40 |
| thorst | thx dude | 21:40 |
| thorst | how much hate? | 21:40 |
| thorst | like should I go get a beer? | 21:40 |
| efried | thorst, hopefully you'll agree with my comments. | 21:41 |
| thorst | efried: yep, those all seem pretty mechanical at this point. Nothing dramatic | 21:42 |
| *** mdrabe has quit IRC | 21:58 | |
| *** arnoldje has quit IRC | 22:00 | |
| *** esberglu has quit IRC | 22:05 | |
| efried | thorst, 344379 reviewed. | 22:07 |
| thorst | rockin. I think I'll have your changes for the first done in 5 seconds. | 22:14 |
| openstackgerrit | Drew Thorstensen proposed openstack/networking-powervm: Support returning non-mgmt LPAR UUIDs https://review.openstack.org/341125 | 22:14 |
| efried | thorst, that took twenty seconds. Typical developer missed estimation. | 22:16 |
| efried | When I tox nova-powervm against 3460, I get failures in UT because we were patching those symbols. Do we care? | 22:17 |
| *** tblakeslee has quit IRC | 22:17 | |
| efried | 3640, that is. | 22:17 |
| *** tjakobs has quit IRC | 22:18 | |
| thorst | let me look | 22:31 |
| thorst | o yeah...I would prefer not to break tox. But if we agree that is the right path, then we'd just port the nova-powervm change back to say mitaka. | 22:31 |
| thorst | although, I suspect we will want to patch that way | 22:31 |
| thorst | it is just clearer to a user | 22:31 |
| thorst | rather than having to patch some hidden method. | 22:32 |
| *** esberglu has joined #openstack-powervm | 22:41 | |
| openstackgerrit | Drew Thorstensen proposed openstack/networking-powervm: WIP: Support VIOS CNAs https://review.openstack.org/344379 | 22:42 |
| *** thorst has quit IRC | 22:43 | |
| *** thorst has joined #openstack-powervm | 22:43 | |
| *** jwcroppe has quit IRC | 22:47 | |
| *** thorst has quit IRC | 22:52 | |
| *** Ashana has quit IRC | 22:53 | |
| *** Ashana has joined #openstack-powervm | 22:54 | |
| *** Ashana has quit IRC | 22:58 | |
| *** Ashana has joined #openstack-powervm | 23:00 | |
| *** efried has quit IRC | 23:03 | |
| *** Ashana has quit IRC | 23:04 | |
| *** k0da has quit IRC | 23:10 | |
| *** Ashana has joined #openstack-powervm | 23:12 | |
| *** Ashana has quit IRC | 23:16 | |
| *** Ashana has joined #openstack-powervm | 23:17 | |
| *** Ashana has quit IRC | 23:22 | |
| *** Ashana has joined #openstack-powervm | 23:23 | |
| *** thorst has joined #openstack-powervm | 23:26 | |
| *** Ashana has quit IRC | 23:28 | |
| *** Ashana has joined #openstack-powervm | 23:29 | |
| *** Ashana has quit IRC | 23:33 | |
| *** Ashana has joined #openstack-powervm | 23:35 | |
| *** Ashana has quit IRC | 23:39 | |
| *** Ashana has joined #openstack-powervm | 23:41 | |
| *** arnoldje has joined #openstack-powervm | 23:45 | |
| *** Ashana has quit IRC | 23:45 | |
| *** Ashana has joined #openstack-powervm | 23:47 | |
| *** apearson has quit IRC | 23:47 | |
| *** Ashana has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!