| *** kylek3h has joined #openstack-powervm | 00:02 | |
| *** apearson has joined #openstack-powervm | 00:39 | |
| *** jwcroppe has joined #openstack-powervm | 00:46 | |
| *** seroyer has joined #openstack-powervm | 00:50 | |
| *** jwcroppe has quit IRC | 00:51 | |
| *** seroyer has quit IRC | 00:52 | |
| *** tjakobs has joined #openstack-powervm | 00:54 | |
| *** tjakobs has quit IRC | 00:59 | |
| openstackgerrit | Drew Thorstensen proposed openstack/nova-powervm: WIP: Pre-allocate trunk adapter on target host https://review.openstack.org/350231 | 01:02 |
|---|---|---|
| *** thorst has quit IRC | 01:02 | |
| *** thorst has joined #openstack-powervm | 01:03 | |
| *** edmondsw has quit IRC | 01:04 | |
| *** thorst has quit IRC | 01:12 | |
| *** kriskend_ has quit IRC | 01:13 | |
| *** kriskend has quit IRC | 01:14 | |
| *** kylek3h has quit IRC | 01:42 | |
| *** tjakobs has joined #openstack-powervm | 01:48 | |
| *** tjakobs has quit IRC | 01:53 | |
| *** esberglu has joined #openstack-powervm | 02:07 | |
| *** smatzek has joined #openstack-powervm | 02:12 | |
| *** smatzek has quit IRC | 02:35 | |
| *** jwcroppe has joined #openstack-powervm | 02:48 | |
| *** esberglu has quit IRC | 02:52 | |
| *** jwcroppe has quit IRC | 02:53 | |
| *** apearson has quit IRC | 03:17 | |
| *** tjakobs has joined #openstack-powervm | 03:51 | |
| *** jwcroppe has joined #openstack-powervm | 04:33 | |
| *** jwcroppe has quit IRC | 04:33 | |
| *** jwcroppe has joined #openstack-powervm | 04:33 | |
| *** kotra03 has joined #openstack-powervm | 04:51 | |
| *** kotra03 has quit IRC | 05:32 | |
| *** jwcroppe has quit IRC | 05:42 | |
| *** jwcroppe has joined #openstack-powervm | 05:42 | |
| *** jwcroppe has quit IRC | 05:47 | |
| *** arunman has joined #openstack-powervm | 06:00 | |
| *** kotra03 has joined #openstack-powervm | 06:13 | |
| *** kotra03 has quit IRC | 06:18 | |
| *** jwcroppe has joined #openstack-powervm | 06:43 | |
| *** jwcroppe has quit IRC | 06:48 | |
| *** kairo has joined #openstack-powervm | 07:21 | |
| *** kairo has quit IRC | 07:22 | |
| *** kairo has joined #openstack-powervm | 07:22 | |
| *** kotra03 has joined #openstack-powervm | 07:28 | |
| *** jwcroppe has joined #openstack-powervm | 07:44 | |
| *** jwcroppe has quit IRC | 07:49 | |
| *** k0da has joined #openstack-powervm | 07:58 | |
| *** kotra03 has quit IRC | 08:16 | |
| *** kotra03 has joined #openstack-powervm | 08:22 | |
| *** jwcroppe has joined #openstack-powervm | 08:45 | |
| *** jwcroppe has quit IRC | 08:49 | |
| *** jwcroppe has joined #openstack-powervm | 09:46 | |
| *** jwcroppe has quit IRC | 09:50 | |
| *** kotra03 has quit IRC | 10:08 | |
| *** kotra03_ has joined #openstack-powervm | 10:12 | |
| *** kotra03_ is now known as kotra03 | 10:13 | |
| *** jwcroppe has joined #openstack-powervm | 10:47 | |
| openstackgerrit | Arun Mani proposed openstack/nova-powervm: Deploy of a VM occasionally fails due to invalid keystone token https://review.openstack.org/351270 | 10:47 |
| *** smatzek has joined #openstack-powervm | 10:51 | |
| *** jwcroppe has quit IRC | 10:52 | |
| *** tjakobs has quit IRC | 11:10 | |
| *** jwcroppe has joined #openstack-powervm | 11:47 | |
| *** jwcroppe has quit IRC | 11:52 | |
| *** thorst_ has joined #openstack-powervm | 11:54 | |
| arunman | thorst_: https://review.openstack.org/351270, fixed your comments and updated patchset. Please check | 11:59 |
| thorst_ | arunman: in the comments you say that you updated the test to make sure its been called exactly once with the exception | 12:01 |
| thorst_ | but I don't actually see that. | 12:01 |
| thorst_ | arunman: also, can you verify that it has been live tested? | 12:03 |
| arunman | My change is like this, the first time around it gets called with the failure result object. Then goes for a retry.. this time around I use the valid result object with 'success' set to true and succeeds | 12:03 |
| thorst_ | I was expecting to see something like 'call_count' or 'assert_called_once_with' | 12:04 |
| arunman | this ensures it's retried once after a failure during the first time | 12:04 |
| arunman | I did try with assert_called_once_with, but its actually called more than once for a retry and hence went with this implementation | 12:04 |
| thorst_ | could you do call_count == 2? | 12:04 |
| thorst_ | self.assertEqual(mock_run.call_count, 2) | 12:05 |
| thorst_ | that just makes sure both calls get consumed. | 12:05 |
| thorst_ | both side effects that is | 12:05 |
| arunman | yeah.. I guess I did check that. But, what I noticed was it gets called a couple of times in the beginning of test_underscore_store, before it hits this place and the total count here happens to be 4 | 12:10 |
| thorst_ | need to do a reset_mock() before your second pass. | 12:10 |
| thorst_ | mock_run.reset_mock() | 12:11 |
| thorst_ | and if its hitting it more times...then I question if the code is doing what we expect. | 12:11 |
| arunman | it's the actual tests that's doing this before... one for a success case, one for a unsuccessful upload, and two times with my changes | 12:13 |
| thorst_ | then the reset_mock will reset that call count | 12:13 |
| arunman | yep.. added that. Uploading it for review | 12:13 |
| thorst_ | thx | 12:15 |
| thorst_ | I'll give +1 for now and then once it gets past CI we'll get it +2'd | 12:15 |
| thorst_ | since I know you need this in mitaka | 12:15 |
| thorst_ | go to the review, hit the 'cherry-pick' button | 12:16 |
| thorst_ | and type in stable/mitaka | 12:16 |
| thorst_ | then add efried and myself as reviewers | 12:16 |
| openstackgerrit | Arun Mani proposed openstack/nova-powervm: Deploy of a VM occasionally fails due to invalid keystone token https://review.openstack.org/351270 | 12:18 |
| arunman | Sure thing.. I've updated the UT as well | 12:18 |
| *** k0da has quit IRC | 12:26 | |
| *** k0da has joined #openstack-powervm | 12:30 | |
| arunman | added this to 'cherry-pick' in stable/mitaka | 12:30 |
| *** mdrabe has joined #openstack-powervm | 12:30 | |
| *** burgerk has joined #openstack-powervm | 12:32 | |
| thorst_ | arunman: thx for making those changes. Hoping this all gets through CI and we can merge this in today | 12:33 |
| openstackgerrit | Ravi Kumar Kota proposed openstack/nova-powervm: WIP: PowerVM: Implement get_instance_diagnostics https://review.openstack.org/350525 | 12:34 |
| thorst_ | kotra03: I think you're ready to remove the 'WIP' from that commit message? | 12:34 |
| kotra03 | thorst_, I will remove that after live testing | 12:35 |
| thorst_ | ahh, still waiting on that | 12:35 |
| thorst_ | got it | 12:35 |
| arunman | thorst_: thnx to you too for your time and review on this | 12:36 |
| thorst_ | :-) No problem. More changes to nova-powervm will only make it better | 12:36 |
| thorst_ | lets do all the changes we can there and in pypowervm | 12:36 |
| *** arunman has quit IRC | 12:45 | |
| *** catintheroof has joined #openstack-powervm | 12:46 | |
| *** kylek3h has joined #openstack-powervm | 12:55 | |
| *** kylek3h has quit IRC | 12:58 | |
| *** apearson has joined #openstack-powervm | 12:59 | |
| *** jwcroppe has joined #openstack-powervm | 13:00 | |
| *** tblakes has joined #openstack-powervm | 13:02 | |
| *** kylek3h has joined #openstack-powervm | 13:14 | |
| *** kylek3h has quit IRC | 13:14 | |
| *** kylek3h has joined #openstack-powervm | 13:15 | |
| *** edmondsw has joined #openstack-powervm | 13:19 | |
| *** esberglu has joined #openstack-powervm | 13:23 | |
| *** seroyer has joined #openstack-powervm | 13:25 | |
| *** dwayne has joined #openstack-powervm | 13:28 | |
| *** thorst_ has quit IRC | 13:31 | |
| *** seroyer has quit IRC | 13:38 | |
| *** kotra03 has quit IRC | 13:41 | |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova-powervm: Added revert to delete LPAR from destination host on failed rebuild https://review.openstack.org/350773 | 13:45 |
| *** kriskend_ has joined #openstack-powervm | 13:53 | |
| *** kriskend has joined #openstack-powervm | 13:53 | |
| *** jwcroppe_ has joined #openstack-powervm | 13:53 | |
| *** jwcroppe has quit IRC | 13:55 | |
| *** lmtaylor1 has joined #openstack-powervm | 14:01 | |
| *** tblakes has quit IRC | 14:07 | |
| *** burgerk has quit IRC | 14:10 | |
| *** smatzek has quit IRC | 14:13 | |
| *** tblakes has joined #openstack-powervm | 14:15 | |
| *** jwcroppe_ has quit IRC | 14:20 | |
| *** jwcroppe has joined #openstack-powervm | 14:21 | |
| *** thorst_ has joined #openstack-powervm | 14:26 | |
| *** seroyer has joined #openstack-powervm | 14:26 | |
| *** arunman has joined #openstack-powervm | 14:28 | |
| *** arunman has quit IRC | 14:35 | |
| *** smatzek has joined #openstack-powervm | 14:36 | |
| *** thorst_ has quit IRC | 14:38 | |
| *** catintheroof has quit IRC | 14:47 | |
| *** burgerk has joined #openstack-powervm | 14:48 | |
| *** catintheroof has joined #openstack-powervm | 14:48 | |
| *** k0da has quit IRC | 14:52 | |
| *** catintheroof has quit IRC | 14:53 | |
| *** svenkat has joined #openstack-powervm | 15:00 | |
| efried | svenkat: https://review.openstack.org/#/c/343423/14/networking_powervm/plugins/ml2/drivers/mech_pvm_sriov.py@51 | 15:00 |
| efried | Where did the 'agent' arg come from? | 15:00 |
| svenkat | let me look | 15:01 |
| svenkat | there was a try_to_bind method that invoked _get_vif_details, that had agent in it… now i dont see the try_to_bind… method in mechanism driver | 15:02 |
| svenkat | look at patchset 11 | 15:02 |
| *** kotra03 has joined #openstack-powervm | 15:03 | |
| efried | I understand how it's being used by the mech driver. (That call is now in mech_pvm_base.py) But _get_vif_details is called by base neutron code, neh? | 15:04 |
| efried | It looks like in PS8, you added the 'agent' param to _get_vif_details. | 15:04 |
| efried | I know *why* you did it. It makes sense. We want to be able to convey information from the agent through to the nova side. | 15:04 |
| *** thorst_ has joined #openstack-powervm | 15:04 | |
| svenkat | where is get_vif_details is called now? | 15:05 |
| svenkat | wherever it is called, it should have agent | 15:05 |
| efried | neutron/plugins/ml2/driver_context.py:100: self._original_vif_details = self._plugin._get_vif_details(binding) | 15:05 |
| efried | neutron/plugins/ml2/driver_context.py:230: return self._plugin._get_vif_details(self._binding) | 15:05 |
| efried | neutron/plugins/ml2/plugin.py:538: port[portbindings.VIF_DETAILS] = self._get_vif_details(binding) | 15:05 |
| efried | neutron/plugins/ml2/plugin.py:540: def _get_vif_details(self, binding): | 15:05 |
| efried | neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py:152: self._get_vif_details(segment), | 15:05 |
| efried | neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py:191: def _get_vif_details(self, segment): | 15:05 |
| efried | The places *we're* calling it - we can control. The places *neutron* calls it - we can't. | 15:06 |
| svenkat | previously we had our own try_to_bind_segment_for_agent, can we continue to overwrite it | 15:07 |
| efried | Yes, we still do - that's in mech_pvm_base now. | 15:07 |
| efried | But the question is: is it okay for us to funnel information like phys port mappings through *sometimes* but not all the time? | 15:08 |
| svenkat | i think we should overwrite try_to_bind_segment_for_agent and name _get_vif_details to something else and invoke it. | 15:12 |
| *** thorst_ has quit IRC | 15:12 | |
| svenkat | i am looking at older patchsets when we did not have _get_vif_details | 15:12 |
| svenkat | but with _get_vif_details(segement, agent), and invoked by overwritten try_to_bind_segment_for_agent, anything is getting broken? or is it just an observation? | 15:14 |
| efried | I don't know. | 15:15 |
| efried | Oh, you're asking whether it's okay to leave the _get_vif_details signature changed? | 15:15 |
| svenkat | yes | 15:15 |
| efried | I seriously doubt it. But I don't know how to get to the code paths that would cause it to break. | 15:15 |
| svenkat | why not put try_to_bind_segment_for_agent back? that invokes local _get_vif_details | 15:16 |
| *** thorst_ has joined #openstack-powervm | 15:16 | |
| *** arunman has joined #openstack-powervm | 15:18 | |
| svenkat | or rename _get_vif_details as something else and invoke it in overwritten try_to_bind_segement_for_agent method | 15:19 |
| efried | svenkat, try_to_bind_segment_for_agent is still there - it's just in the base class, mech_pvm_base. That way we can use it for both drivers, since thorst_ was setting that up anyway. | 15:20 |
| efried | So yes, I can change the code in try_to_bind_segment_for_agent to set the extra stuff (phys port locs, redundancy level) in the vif details. | 15:20 |
| svenkat | sicne we need data from agent configuration to vif, we need to overwrite it for our own sriov mechnaism driver… | 15:20 |
| efried | And leave the signature of _get_vif_details alone. | 15:21 |
| svenkat | ok… good idea. we can do all in try_to_bind_segment_for_agent without invokig _get_vif_details | 15:21 |
| efried | But that means _get_vif_details will *not* be populating those extra pieces of information (phys port locs, redundancy level) whenever it's called from these nebulous, mysterious places within neutron itself. | 15:21 |
| *** thorst_ has quit IRC | 15:21 | |
| efried | and I don't know if that's okay. | 15:22 |
| efried | I guess... we try it. | 15:22 |
| svenkat | sure. | 15:22 |
| efried | Meanwhile, I can't stack. On your system or mine. I am cursed. | 15:23 |
| svenkat | on controller side? | 15:25 |
| *** catintheroof has joined #openstack-powervm | 15:25 | |
| svenkat | 9.47.83.108 should be fine.. are you using that one? this jupiter instance got renewed for another month | 15:26 |
| *** apearson has quit IRC | 15:26 | |
| efried | I tried to hook up to it yesterday and couldn't ssh/telnet. | 15:28 |
| efried | So I tried making .149 an all-in-one. | 15:28 |
| efried | Fail. | 15:28 |
| svenkat | let me ssh into .108 | 15:28 |
| *** thorst_ has joined #openstack-powervm | 15:29 | |
| svenkat | i can ssh into 9.47.83.108 stack / svenkat123 | 15:29 |
| *** apearson has joined #openstack-powervm | 15:30 | |
| *** thorst_ has quit IRC | 15:31 | |
| *** tjakobs has joined #openstack-powervm | 15:41 | |
| openstackgerrit | Eric Fried proposed openstack/nova-powervm: WIP: VIF driver implementation for SR-IOV https://review.openstack.org/343419 | 15:48 |
| *** thorst_ has joined #openstack-powervm | 15:53 | |
| *** apearson has quit IRC | 15:57 | |
| *** apearson has joined #openstack-powervm | 15:59 | |
| *** thorst_ has quit IRC | 16:00 | |
| *** antonym has joined #openstack-powervm | 16:29 | |
| *** kairo has quit IRC | 16:53 | |
| *** dwayne has quit IRC | 17:05 | |
| *** arunman has quit IRC | 17:07 | |
| *** dwayne has joined #openstack-powervm | 17:18 | |
| *** arunman has joined #openstack-powervm | 17:19 | |
| *** apearson has quit IRC | 17:40 | |
| *** arunman has quit IRC | 17:42 | |
| *** arunman has joined #openstack-powervm | 17:44 | |
| *** thorst_ has joined #openstack-powervm | 18:05 | |
| *** arunman has quit IRC | 18:21 | |
| *** kotra03 has quit IRC | 18:22 | |
| *** thorst_ has quit IRC | 18:41 | |
| tblakes | Does anyone know the comment you need to post to rerun Jenkins in Gerrit? | 18:43 |
| adreznec | recheck | 18:56 |
| adreznec | tblakes: ^^ | 18:56 |
| tblakes | adreznec: Thanks! | 18:56 |
| *** catintheroof has quit IRC | 19:12 | |
| *** thorst_ has joined #openstack-powervm | 19:21 | |
| *** thorst_ has quit IRC | 19:26 | |
| tblakes | I submitted a review at https://review.openstack.org/#/c/350773/ and Jenkins still hasn't completed it's tests. I let it run for 2 hours the first time, and it's run for 30 minutes this time without returning anything. Is there anything I should do to check it's status? | 19:35 |
| mdrabe | tblakes: Sometimes it just takes a while | 19:50 |
| mdrabe | Can always run the tests locally as well | 19:50 |
| tblakes | How do I run them locally? | 19:51 |
| *** kylek3h has quit IRC | 19:53 | |
| *** apearson has joined #openstack-powervm | 19:54 | |
| *** thorst_ has joined #openstack-powervm | 20:08 | |
| *** apearson has quit IRC | 20:09 | |
| *** apearson has joined #openstack-powervm | 20:10 | |
| *** thorst_ has quit IRC | 20:12 | |
| mdrabe | tblakes: tox -e py27 | 20:13 |
| mdrabe | that'll run all the py27 tests | 20:13 |
| mdrabe | tox -e pep8 #will run all the pep8 checks | 20:14 |
| tblakes | Oh I already did that. I thought there were more tests that were run | 20:14 |
| tblakes | Thanks | 20:14 |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova-powervm: Added revert to delete LPAR from destination host on failed rebuild https://review.openstack.org/350773 | 20:21 |
| *** apearson has quit IRC | 20:29 | |
| *** apearson has joined #openstack-powervm | 20:29 | |
| *** thorst_ has joined #openstack-powervm | 20:40 | |
| *** smatzek has quit IRC | 20:48 | |
| *** apearson has quit IRC | 20:50 | |
| *** thorst_ has quit IRC | 20:53 | |
| *** svenkat has quit IRC | 21:11 | |
| *** lmtaylor1 has left #openstack-powervm | 21:29 | |
| *** tblakes has quit IRC | 21:41 | |
| *** chmod6661rg has quit IRC | 21:50 | |
| *** chmod666org has joined #openstack-powervm | 21:51 | |
| *** apearson has joined #openstack-powervm | 21:54 | |
| *** esberglu has quit IRC | 21:55 | |
| *** burgerk has quit IRC | 22:01 | |
| *** seroyer has quit IRC | 22:02 | |
| *** tjakobs has quit IRC | 22:08 | |
| *** apearson has quit IRC | 22:14 | |
| *** kriskend_ has quit IRC | 22:15 | |
| *** kriskend has quit IRC | 22:15 | |
| *** efried has quit IRC | 22:18 | |
| *** mdrabe has quit IRC | 22:23 | |
| *** edmondsw has quit IRC | 22:36 | |
| *** apearson has joined #openstack-powervm | 22:39 | |
| *** tblakes has joined #openstack-powervm | 22:53 | |
| *** apearson has quit IRC | 22:54 | |
| *** apearson has joined #openstack-powervm | 23:04 | |
| *** dwayne has quit IRC | 23:20 | |
| openstackgerrit | Henry Gessau proposed openstack/networking-powervm: Enable DeprecationWarning in test environments https://review.openstack.org/353164 | 23:35 |
| *** apearson has quit IRC | 23:39 | |
| *** dwayne has joined #openstack-powervm | 23:42 | |
| *** dwayne has quit IRC | 23:52 | |
| *** esberglu has joined #openstack-powervm | 23:56 | |
| *** esberglu has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!