*** gianpero has quit IRC | 00:03 | |
*** kylek3h has joined #openstack-powervm | 00:14 | |
*** edmondsw has joined #openstack-powervm | 01:13 | |
*** edmondsw has quit IRC | 01:17 | |
*** thorst_ has joined #openstack-powervm | 01:37 | |
*** thorst_ has quit IRC | 01:39 | |
*** thorst_ has joined #openstack-powervm | 01:40 | |
*** thorst_ has quit IRC | 01:48 | |
*** edmondsw has joined #openstack-powervm | 01:49 | |
*** edmondsw has quit IRC | 01:54 | |
*** seroyer has quit IRC | 02:18 | |
*** edmondsw has joined #openstack-powervm | 02:26 | |
*** edmondsw has quit IRC | 02:30 | |
*** thorst_ has joined #openstack-powervm | 02:32 | |
*** thorst_ has quit IRC | 02:34 | |
*** thorst_ has joined #openstack-powervm | 02:35 | |
*** thorst_ has quit IRC | 02:43 | |
*** edmondsw has joined #openstack-powervm | 03:02 | |
*** edmondsw has quit IRC | 03:07 | |
*** thorst_ has joined #openstack-powervm | 03:37 | |
*** thorst_ has quit IRC | 03:37 | |
*** thorst_ has joined #openstack-powervm | 03:38 | |
*** thorst_ has quit IRC | 03:47 | |
*** jwcroppe has joined #openstack-powervm | 03:51 | |
*** thorst_ has joined #openstack-powervm | 04:44 | |
*** thorst_ has quit IRC | 04:52 | |
*** edmondsw has joined #openstack-powervm | 06:19 | |
*** tlian has quit IRC | 06:20 | |
*** edmondsw has quit IRC | 06:23 | |
*** thorst_ has joined #openstack-powervm | 06:54 | |
*** thorst_ has quit IRC | 07:01 | |
*** edmondsw has joined #openstack-powervm | 07:16 | |
*** edmondsw has quit IRC | 07:20 | |
*** edmondsw has joined #openstack-powervm | 07:52 | |
*** edmondsw has quit IRC | 07:57 | |
*** thorst_ has joined #openstack-powervm | 07:59 | |
*** thorst_ has quit IRC | 08:06 | |
*** k0da has joined #openstack-powervm | 08:27 | |
*** edmondsw has joined #openstack-powervm | 08:29 | |
*** edmondsw has quit IRC | 08:33 | |
*** thorst_ has joined #openstack-powervm | 09:05 | |
*** thorst_ has quit IRC | 09:11 | |
*** edmondsw has joined #openstack-powervm | 09:41 | |
*** edmondsw has quit IRC | 09:46 | |
*** thorst_ has joined #openstack-powervm | 10:09 | |
*** thorst_ has quit IRC | 10:17 | |
*** thorst_ has joined #openstack-powervm | 11:15 | |
*** thorst_ has quit IRC | 11:22 | |
*** k0da has quit IRC | 12:07 | |
*** k0da has joined #openstack-powervm | 12:11 | |
*** thorst_ has joined #openstack-powervm | 12:18 | |
*** thorst_ has quit IRC | 12:26 | |
*** gianpero has joined #openstack-powervm | 12:34 | |
*** gianpero has quit IRC | 12:40 | |
*** seroyer has joined #openstack-powervm | 12:41 | |
*** thorst_ has joined #openstack-powervm | 12:43 | |
*** seroyer has quit IRC | 12:48 | |
*** gianpero has joined #openstack-powervm | 13:00 | |
*** svenkat has joined #openstack-powervm | 13:22 | |
*** openstackgerrit has joined #openstack-powervm | 13:37 | |
openstackgerrit | Drew Thorstensen (thorst) proposed openstack/nova-powervm: Add delay queue for events https://review.openstack.org/391164 | 13:37 |
---|---|---|
*** tlian has joined #openstack-powervm | 14:04 | |
*** gianpero has quit IRC | 14:17 | |
*** tblakes has joined #openstack-powervm | 14:18 | |
*** apearson has joined #openstack-powervm | 14:26 | |
*** mdrabe has joined #openstack-powervm | 14:28 | |
*** tjakobs has joined #openstack-powervm | 14:44 | |
*** edmondsw has joined #openstack-powervm | 14:47 | |
*** edmondsw_ has joined #openstack-powervm | 14:49 | |
*** edmondsw_ has quit IRC | 14:50 | |
thorst_ | efried: OMG OMG OMG - https://review.openstack.org/#/c/391284/ | 14:53 |
adreznec | Hack removal time! | 14:53 |
thorst_ | its a christmas miracle | 14:53 |
efried | looking... | 14:53 |
thorst_ | also, I've got the deadlock fix | 14:53 |
thorst_ | I'm fixing a few things in it, but we solved the mystery deadlock | 14:54 |
efried | oo, tell me | 14:54 |
thorst_ | apparently REST now creates the file pipe when we create the vio_file | 14:54 |
adreznec | Please elaborate thorst_, this sounds fun | 14:54 |
thorst_ | but it doesn't start reading the file until we run the upload to it | 14:55 |
thorst_ | we started writing to the file quick. Glance fast failed. We wrote EOF | 14:55 |
thorst_ | then...at a later point in time, REST started reading the file | 14:55 |
efried | ...before the upload thread had hit. | 14:55 |
adreznec | Awesome | 14:55 |
efried | Noyce. | 14:55 |
adreznec | That's a fun timing issue | 14:55 |
thorst_ | so, I've got it | 14:55 |
efried | So how are you planning to solve? | 14:55 |
efried | signal between the two threads? | 14:55 |
thorst_ | pass the upload_f into the _ensure_pipe_close | 14:56 |
thorst_ | and if not done, write the close again...wait .5 seconds...rinse repeat | 14:56 |
efried | uh | 14:56 |
adreznec | If at first you don't succeed, try again, and again, and again | 14:56 |
thorst_ | cause we have no signal to know when they start the read | 14:56 |
thorst_ | it isn't when our thread starts...its some point in time later. | 14:56 |
efried | Yeah, that'll work. A bit... weird feeling, but seems solid. | 14:56 |
thorst_ | reality is its like .1 - 2 seconds | 14:56 |
thorst_ | anyway, getting that out now. | 14:57 |
thorst_ | fixing UT | 14:57 |
thorst_ | etc... | 14:57 |
adreznec | Right | 14:57 |
efried | The more traditional way would be to use a semaphore to get the two threads to talk to each other. | 14:57 |
efried | But that's another variable. This is clever. I like it. | 14:57 |
thorst_ | you'd like doctor who | 14:57 |
thorst_ | its all about cleverness | 14:57 |
thorst_ | at least season 2 to like 5 | 14:57 |
*** tblakes has quit IRC | 14:57 | |
efried | Does the upload thread finish right away, or does it wait til the writes are done? | 14:58 |
* adreznec uses sonic screwdriver on glance upload code | 14:58 | |
efried | I.e. does the _ensure_pipe_close need to check whether the thread has finished, or whether it has started? | 14:58 |
efried | Cause if the latter, it doesn't necessarily close the window. | 14:58 |
*** esberglu has joined #openstack-powervm | 15:03 | |
*** tblakes has joined #openstack-powervm | 15:28 | |
*** openstackgerrit has quit IRC | 15:33 | |
*** seroyer has joined #openstack-powervm | 15:42 | |
thorst_ | efried: sorry, was otp | 15:45 |
thorst_ | upload thread finished when the REST API returns | 15:45 |
thorst_ | it needs to check that its 'done' | 15:45 |
thorst_ | (and has started) | 15:45 |
adreznec | efried: thorst_ who's going to handle cleanup of the OOT driver now that https://review.openstack.org/#/c/391284/ has merged? efried? | 15:49 |
thorst_ | adreznec maybe? | 15:49 |
thorst_ | I mean, he who smelt it... | 15:49 |
*** edmondsw has quit IRC | 15:49 | |
adreznec | lol | 15:50 |
*** edmondsw has joined #openstack-powervm | 15:50 | |
*** seroyer has quit IRC | 15:51 | |
*** edmondsw has quit IRC | 15:54 | |
*** edmondsw has joined #openstack-powervm | 15:55 | |
*** mdrabe has quit IRC | 16:20 | |
*** mdrabe has joined #openstack-powervm | 16:28 | |
*** k0da has quit IRC | 16:32 | |
*** gianpero has joined #openstack-powervm | 17:43 | |
esberglu | thorst_: adreznec: Some of the nova runs are failing to start n-cpu with this error | 17:47 |
esberglu | AttributeError: type object 'Architecture' has no attribute 'PPC64' | 17:47 |
esberglu | Which is from this change | 17:47 |
esberglu | https://review.openstack.org/#/c/403934 | 17:48 |
esberglu | https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L127 | 17:50 |
esberglu | That's how you would access that right? Am I missing something obvious? | 17:50 |
*** tjakobs has quit IRC | 18:04 | |
thorst_ | esberglu: That is how it appears to be accessed elsewhere | 18:14 |
thorst_ | are the reviews that it is running against removing that field? | 18:14 |
esberglu | Nope | 18:17 |
esberglu | For example | 18:17 |
esberglu | https://review.openstack.org/#/c/400785/ | 18:17 |
esberglu | It doesn't need a rebase and it didn't change that at all | 18:18 |
thorst_ | esberglu: where's the failure? | 18:24 |
esberglu | http://184.172.12.213/95/401395/8/silent/nova-pvm-dsvm-tempest-full/ff45546/logs/ | 18:25 |
esberglu | n-cpu.log | 18:25 |
thorst_ | does this happen on every nova patch? | 18:26 |
esberglu | Pretty much | 18:27 |
esberglu | One run didn't hit it | 18:27 |
thorst_ | hmmm | 18:28 |
thorst_ | adreznec: I think this may be more up your alley. Looks to be something with regard to how we patch in | 18:28 |
thorst_ | or efried but he's on vacation | 18:28 |
esberglu | Is he out the rest of the month? | 18:29 |
thorst_ | pretty much | 18:29 |
esberglu | thorst_: WTF the other projects are hitting it now too... | 18:36 |
esberglu | But fields.py hasn't changed in 7 days | 18:36 |
thorst_ | esberglu: something else must've | 18:36 |
thorst_ | so what just merged into nova. | 18:36 |
esberglu | Ahh. I think I found it. I think the error message is giving the wrong information. | 18:40 |
esberglu | The error is coming from this line | 18:40 |
esberglu | (fields.Architecture.PPC64, hv_type.PHYP, vm_mode.HVM) | 18:41 |
esberglu | And they changed where hv_type and vm_mode are located | 18:41 |
esberglu | Idk why the error message thinks that its a problem with fields.Architecture.PPC64 though | 18:41 |
esberglu | Change incoming | 18:41 |
thorst_ | :-) yay for CI | 18:42 |
*** tjakobs has joined #openstack-powervm | 18:44 | |
*** openstackgerrit has joined #openstack-powervm | 18:59 | |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: Update hv_type and vm_mode to new location https://review.openstack.org/406304 | 18:59 |
thorst_ | :-D | 18:59 |
* thorst_ is happy for CI | 18:59 | |
*** thorst_ has quit IRC | 19:40 | |
*** esberglu has quit IRC | 20:01 | |
*** esberglu has joined #openstack-powervm | 20:01 | |
*** esberglu_ has joined #openstack-powervm | 20:05 | |
*** esberglu has quit IRC | 20:06 | |
*** esberglu has joined #openstack-powervm | 20:07 | |
*** esberglu_ has quit IRC | 20:09 | |
*** esberglu_ has joined #openstack-powervm | 20:09 | |
*** esberglu has quit IRC | 20:11 | |
*** thorst_ has joined #openstack-powervm | 20:14 | |
*** edmondsw has quit IRC | 20:28 | |
*** k0da has joined #openstack-powervm | 20:40 | |
thorst_ | esberglu_: I W+1'd the change | 20:46 |
thorst_ | our CI votes for nova-powervm, right? | 20:47 |
openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm: Retry up to 3 times on disk create https://review.openstack.org/406355 | 20:53 |
openstackgerrit | Merged openstack/nova-powervm: Update hv_type and vm_mode to new location https://review.openstack.org/406304 | 20:53 |
esberglu_ | thorst: Yeah otherwise it would show (non-voting) next to it in gerrit | 20:53 |
thorst_ | awesome | 20:54 |
*** esberglu_ has quit IRC | 20:54 | |
*** esberglu has joined #openstack-powervm | 20:54 | |
*** esberglu_ has joined #openstack-powervm | 20:56 | |
*** devlaps has quit IRC | 20:57 | |
*** esbergl__ has joined #openstack-powervm | 20:58 | |
*** esberglu has quit IRC | 20:59 | |
*** esberglu has joined #openstack-powervm | 21:00 | |
*** esberglu_ has quit IRC | 21:00 | |
*** esbergl__ has quit IRC | 21:02 | |
*** thorst_ has quit IRC | 21:18 | |
*** thorst_ has joined #openstack-powervm | 21:18 | |
*** thorst_ has quit IRC | 21:27 | |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: DNM: ci check https://review.openstack.org/328315 | 21:27 |
openstackgerrit | Eric Berglund proposed openstack/nova-powervm: DNM: CI Check2 https://review.openstack.org/328317 | 21:28 |
*** gianpero has quit IRC | 21:30 | |
*** esberglu has quit IRC | 21:48 | |
*** esberglu has joined #openstack-powervm | 21:49 | |
*** thorst_ has joined #openstack-powervm | 21:51 | |
*** esberglu has quit IRC | 21:53 | |
*** svenkat has quit IRC | 22:05 | |
*** thorst_ has quit IRC | 22:13 | |
*** thorst_ has joined #openstack-powervm | 22:14 | |
*** thorst_ has quit IRC | 22:19 | |
openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm: Retry up to 3 times on disk create https://review.openstack.org/406355 | 22:21 |
*** tjakobs has quit IRC | 22:33 | |
*** tblakes has quit IRC | 22:44 | |
*** mdrabe has quit IRC | 22:57 | |
*** k0da has quit IRC | 23:23 | |
*** thorst_ has joined #openstack-powervm | 23:31 | |
*** thorst_ has quit IRC | 23:33 | |
*** thorst_ has joined #openstack-powervm | 23:34 | |
*** thorst_ has quit IRC | 23:38 | |
*** thorst_ has joined #openstack-powervm | 23:39 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!