*** thorst_ has joined #openstack-powervm | 00:00 | |
*** thorst_ has quit IRC | 00:04 | |
*** BorD_ has quit IRC | 00:08 | |
*** thorst_ has joined #openstack-powervm | 00:13 | |
*** thorst_ has quit IRC | 00:13 | |
*** Jay2 has quit IRC | 00:21 | |
*** Jay2 has joined #openstack-powervm | 00:22 | |
*** Jay2 has quit IRC | 00:26 | |
*** BorD_ has joined #openstack-powervm | 00:38 | |
*** Jay2 has joined #openstack-powervm | 00:57 | |
*** Jay3 has joined #openstack-powervm | 01:42 | |
*** Jay2 has quit IRC | 01:43 | |
*** thorst_ has joined #openstack-powervm | 01:44 | |
*** thorst_ has quit IRC | 01:49 | |
*** thorst_ has joined #openstack-powervm | 02:09 | |
*** thorst_ has quit IRC | 02:12 | |
*** thorst_ has joined #openstack-powervm | 02:57 | |
*** thorst_ has quit IRC | 02:57 | |
*** thorst_ has joined #openstack-powervm | 03:07 | |
*** thorst_ has quit IRC | 03:07 | |
*** Jay2 has joined #openstack-powervm | 03:48 | |
*** Jay3 has quit IRC | 03:49 | |
*** Jay2 has quit IRC | 03:52 | |
*** Jay2 has joined #openstack-powervm | 03:53 | |
*** Jay3 has joined #openstack-powervm | 03:59 | |
*** Jay2 has quit IRC | 04:00 | |
*** dwayne has quit IRC | 04:15 | |
*** thorst_ has joined #openstack-powervm | 05:49 | |
*** Jay2 has joined #openstack-powervm | 05:50 | |
*** Jay3 has quit IRC | 05:52 | |
*** thorst_ has quit IRC | 05:55 | |
*** tjakobs has joined #openstack-powervm | 06:41 | |
*** thorst_ has joined #openstack-powervm | 07:51 | |
*** thorst_ has quit IRC | 07:56 | |
*** tjakobs has quit IRC | 08:21 | |
*** Jay3 has joined #openstack-powervm | 08:21 | |
*** Jay2 has quit IRC | 08:23 | |
*** k0da has joined #openstack-powervm | 08:29 | |
*** Jay1 has joined #openstack-powervm | 09:50 | |
*** Jay3 has quit IRC | 09:51 | |
*** thorst_ has joined #openstack-powervm | 09:52 | |
*** thorst_ has quit IRC | 09:57 | |
*** Jay2 has joined #openstack-powervm | 11:08 | |
*** Jay1 has quit IRC | 11:11 | |
*** Jay2 has quit IRC | 11:31 | |
*** Jay1 has joined #openstack-powervm | 11:31 | |
*** Jay1 has quit IRC | 11:35 | |
*** thorst_ has joined #openstack-powervm | 11:53 | |
*** thorst_ has quit IRC | 11:57 | |
*** thorst_ has joined #openstack-powervm | 12:41 | |
*** edmondsw has joined #openstack-powervm | 13:07 | |
efried | thorst_ What's new? | 13:15 |
---|---|---|
thorst_ | ?? | 13:15 |
efried | Ima be trucking along on the OVS and SSP change sets, just wanted to make sure there wasn't something else that needed more urgent attention. | 13:19 |
thorst_ | nothing that i know of. I'm getting the system test team going now, and they're going to try an 'in tree' devstack just to get familiar with how to set up a devstack with pending patch sets. | 13:20 |
efried | dig. Are they on IRC? (Loaded question) | 13:23 |
thorst_ | they should be. nilesh is one. Haven't seen jay on yet | 13:23 |
thorst_ | but that's how communication is to be handled... | 13:23 |
*** tblakes has joined #openstack-powervm | 13:31 | |
*** mdrabe has joined #openstack-powervm | 13:36 | |
*** tlian has joined #openstack-powervm | 13:52 | |
*** nbante has joined #openstack-powervm | 13:57 | |
*** kjw3 has quit IRC | 14:04 | |
*** nbante has quit IRC | 14:37 | |
*** kriskend has joined #openstack-powervm | 14:53 | |
*** dwayne has joined #openstack-powervm | 14:54 | |
*** burgerk has joined #openstack-powervm | 15:07 | |
*** apearson has joined #openstack-powervm | 15:27 | |
*** tjakobs has joined #openstack-powervm | 15:46 | |
efried | thorst_ There was one question I had on the ovs-vif patch | 16:02 |
thorst_ | ? in comments or here? | 16:02 |
efried | Well, either would do. https://review.openstack.org/#/c/422512/7/nova/conf/powervm.py@130 | 16:03 |
efried | The question is whether we really need to introduce these conf options at all. | 16:03 |
efried | I get the sense there's a desire to be conservative with the number of conf options we propose. If that's not a thing, I won't worry about it. | 16:03 |
thorst_ | maybe not for pvm_vswitch_for_novalink_io | 16:03 |
thorst_ | but definitely for use_rmc_mgmt_vif | 16:03 |
thorst_ | we want that there for sure | 16:04 |
thorst_ | we turn that off in our CI actually | 16:04 |
thorst_ | it was leading to slow activation times when we were deploying real VMs (can't remember why off hand) | 16:04 |
thorst_ | bbiab | 16:04 |
thorst_ | ahh, no it was undercloud we had it turned off | 16:11 |
thorst_ | I think it made that weird pypowervm patch we have work better | 16:12 |
*** esberglu has joined #openstack-powervm | 16:14 | |
*** k0da has quit IRC | 16:23 | |
*** apearson has quit IRC | 16:31 | |
*** apearson has joined #openstack-powervm | 16:33 | |
*** nbante has joined #openstack-powervm | 16:52 | |
*** apearson has quit IRC | 17:09 | |
*** apearson has joined #openstack-powervm | 17:09 | |
*** apearson has quit IRC | 17:21 | |
*** apearson has joined #openstack-powervm | 17:50 | |
*** nbante has quit IRC | 18:07 | |
*** k0da has joined #openstack-powervm | 19:04 | |
*** burgerk has quit IRC | 19:30 | |
*** burgerk has joined #openstack-powervm | 19:32 | |
*** kriskend has quit IRC | 21:25 | |
*** kriskend has joined #openstack-powervm | 21:26 | |
efried | thorst_ There's a bit of incongruity in the vif unplugging stack. The low-level methods (the vif driver-specific ones that do the real work) return stuff; but the module-level method doesn't kick them back up the stack; and the consuming Tasks don't use 'em. | 21:30 |
efried | I'm okay with that last thing, but it seems to me like the module-level unplug method should return whatever the low-level methods return. | 21:30 |
efried | Or we should rip the return values out of the low-level methods. | 21:30 |
efried | Thoughts? | 21:30 |
efried | (vif.py btw) | 21:31 |
thorst_ | yeah, I don't think it should return up the stuff | 21:32 |
thorst_ | because depending on what you plug/unplug that stuff is wildly different | 21:33 |
thorst_ | vNIC vs. VF vs. VEA | 21:33 |
efried | Okay, I'll rip the return values out of the low-level methods. | 21:36 |
thorst_ | well, we did use them to do slot store stuff | 21:36 |
thorst_ | right/ | 21:36 |
thorst_ | but the issue in tree is we're not doing any slot store initially? | 21:36 |
efried | Even OOT, the slot storing is done locally, and the module-level unplug isn't returning the value. | 21:37 |
thorst_ | hmmm | 21:37 |
thorst_ | I think it could be removed off hand | 21:37 |
efried | Okay, I'll make sure, and rip it. | 21:37 |
efried | One other thing. | 21:37 |
efried | PvmLioVifDriver.plug is doing 'ip link set up' | 21:38 |
thorst_ | yeah | 21:38 |
efried | And then PvmOvsVifDriver.plug is doing it again. | 21:38 |
efried | Is that on purpose? | 21:38 |
thorst_ | yeah | 21:38 |
efried | Both are doing get_trunk_dev_name too. Is that related? | 21:38 |
thorst_ | when you DLPAR in an adapter on the NovaLink it is not in the up state automatically | 21:38 |
thorst_ | yeah, same deal...just was harder to refactor out (looked grosser) than to leave the duplication in | 21:39 |
thorst_ | it was a diminishing return, also in readability I think | 21:39 |
efried | Soooo, harmless to do it twice? | 21:39 |
thorst_ | (if I remember right) | 21:39 |
thorst_ | o yeah, harmless | 21:39 |
thorst_ | I guess if we're doing it twice, we could remove the second call of link up | 21:39 |
efried | Does the trunk_dev_name change? | 21:39 |
thorst_ | nope | 21:39 |
efried | ...within one instance of a vif driver class? | 21:40 |
thorst_ | within one instance of a vif | 21:40 |
efried | Okay, so no good making the trunk_dev_name an instance var so we don't have to re-grab it. | 21:40 |
thorst_ | well, I think it is within an instance of the driver as written today | 21:41 |
thorst_ | but meh...its simple string replacement | 21:41 |
thorst_ | your call | 21:41 |
efried | oh, yeah, I thought it was a REST calll. | 21:42 |
thorst_ | nope, input into a rest call | 21:43 |
efried | thorst_ does it matter if I get_trunk_dev_name before or after the crt_p2p_cna call? | 21:44 |
efried | Doesn't look like it. | 21:44 |
thorst_ | its input into crt_p2p_cna | 21:44 |
thorst_ | so get it before that. | 21:44 |
efried | But no need to re-get it after. | 21:44 |
efried | So yeah, those two lines appear redundant to me. | 21:44 |
thorst_ | nah, you're just telling the REST API, here is what to set the device name when you create it. | 21:44 |
*** apearson has quit IRC | 22:06 | |
*** kriskend has quit IRC | 22:13 | |
*** kriskend has joined #openstack-powervm | 22:17 | |
openstackgerrit | Eric Fried proposed openstack/nova-powervm: In-tree backports (2) https://review.openstack.org/426956 | 22:21 |
*** tblakes has quit IRC | 22:24 | |
*** apearson has joined #openstack-powervm | 22:29 | |
*** apearson has quit IRC | 22:31 | |
*** edmondsw has quit IRC | 22:34 | |
*** thorst_ has quit IRC | 22:36 | |
*** apearson has joined #openstack-powervm | 22:44 | |
*** kriskend has quit IRC | 22:58 | |
openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm: Add support for File I/O Driver https://review.openstack.org/426964 | 23:06 |
*** thorst_ has joined #openstack-powervm | 23:06 | |
*** tjakobs has quit IRC | 23:10 | |
*** thorst_ has quit IRC | 23:10 | |
*** mdrabe has quit IRC | 23:11 | |
*** apearson has quit IRC | 23:18 | |
*** k0da has quit IRC | 23:35 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!