| *** edmondsw has quit IRC | 00:02 | |
| *** svenkat has quit IRC | 01:13 | |
| *** edmondsw has joined #openstack-powervm | 03:33 | |
| *** edmondsw has quit IRC | 03:37 | |
| *** jwcroppe has quit IRC | 06:32 | |
| *** jwcroppe has joined #openstack-powervm | 06:47 | |
| *** edmondsw has joined #openstack-powervm | 07:09 | |
| *** edmondsw has quit IRC | 07:14 | |
| *** chas has joined #openstack-powervm | 07:41 | |
| *** wagnqwsh has joined #openstack-powervm | 07:43 | |
| *** wagnqwsh has left #openstack-powervm | 07:44 | |
| *** openstackgerrit has quit IRC | 08:33 | |
| *** chas has quit IRC | 08:44 | |
| *** edmondsw has joined #openstack-powervm | 08:57 | |
| *** edmondsw has quit IRC | 09:02 | |
| *** chas has joined #openstack-powervm | 09:44 | |
| *** chas has quit IRC | 09:49 | |
| *** edmondsw has joined #openstack-powervm | 10:46 | |
| *** edmondsw has quit IRC | 10:50 | |
| *** smatzek has joined #openstack-powervm | 10:58 | |
| *** k0da has joined #openstack-powervm | 11:14 | |
| *** k0da has quit IRC | 11:37 | |
| *** k0da has joined #openstack-powervm | 11:37 | |
| *** thorst has joined #openstack-powervm | 11:45 | |
| *** edmondsw_ has joined #openstack-powervm | 12:29 | |
| *** efried has joined #openstack-powervm | 12:33 | |
| thorst | so what'd I miss? | 12:41 |
|---|---|---|
| efried | For my part, I've spent the whole time rebasing the pile of in-tree changes. | 12:48 |
| thorst | efried: https://review.openstack.org/#/c/438119/3..11/nova/virt/powervm/driver.py | 12:48 |
| thorst | how did you get rid of the capabilities? | 12:48 |
| efried | mriedem said since they were the same as the superclass, I should just omit them. | 12:48 |
| thorst | ahh, fair | 12:48 |
| thorst | you have some SR-IOV things in there that isn't needed yet...could shave 20 loc if desired. | 12:49 |
| efried | Yeah, I noticed that. | 12:49 |
| efried | mriedem already questioned the amount of churn | 12:50 |
| efried | Even though it's been all rebases and similar (like bumping pypowervm req) | 12:50 |
| thorst | yeah, that's fair. I had too :-) | 12:51 |
| thorst | it feels like a lot, but it really isn't too much | 12:51 |
| efried | Yeah | 12:51 |
| thorst | its just that the channel gets flooded every time you do a mass rebase... | 12:51 |
| efried | if you look at 6..11, which is the changes since he reviewed last. | 12:52 |
| efried | It's flake8-import-order and reqs | 12:52 |
| thorst | we're still using task flow in future patches, right? | 12:53 |
| thorst | (going through things slowly...) | 12:53 |
| efried | thorst Yeah, #3 introduces TaskFlow. | 12:56 |
| efried | harlowja (owner of TaskFlow) took an interest in that stuff, btw. | 12:56 |
| efried | We've had a couple of interesting conversations. | 12:56 |
| efried | He actively solicited input on things that would make TaskFlow easier to use. | 12:56 |
| thorst | efried: awesome...I was once questioned where all our exception handling code was | 12:56 |
| thorst | and its all contained within task flow...so... | 12:57 |
| efried | Yuh | 12:57 |
| efried | You may remember this conversation, but mriedem actually asked me about it. | 12:58 |
| efried | It was like, "Oh, interesting, you're using TaskFlow, whyzat?" | 12:58 |
| efried | And I was like, "I thought that's the way we do it" | 12:58 |
| efried | And then I looked in the nova code - and nobody else is doing it. | 12:58 |
| efried | He said there was a time they were looking at it, but they kinda punted cause it was too complicated. | 12:59 |
| thorst | yeah, it was right before I left | 12:59 |
| thorst | taskflow rox | 12:59 |
| efried | The one suggestion I did bring up with harlowja - after I wound up rewriting a lot of the UT around our TaskFlow - was that UT on it is tough. Suggested stock fixtures in the taskflow lib, which he thought was a good idea. So we may see that in the future. | 13:01 |
| thorst | neat! | 13:02 |
| efried | Yeah, that would help a lot. | 13:02 |
| efried | Course, then I'd have to rewrite all the UT again... | 13:02 |
| thorst | https://review.openstack.org/#/c/427380/18/nova/virt/powervm/driver.py - line 234...I don't compute that statement | 13:02 |
| efried | May be a holdover from when we were returning true/false from these guys. | 13:06 |
| efried | But yeah, in reboot context, doesn't make amount of sense. | 13:06 |
| efried | Because we're not skipping the reboot if the instance is already up. | 13:06 |
| efried | That comment would have made more sense in power_on. | 13:07 |
| thorst | I did -1 that change set. I think a test case is missing. | 13:13 |
| efried | ack | 13:14 |
| thorst | efried: the other thing that would be nice to add to task flow is basically what we have here: https://review.openstack.org/#/c/438729/11/nova/virt/powervm/tasks/base.py | 13:16 |
| thorst | I've used that in other code as well, but basically a way to say how long each task took via the logs | 13:16 |
| efried | Did I not do that? | 13:16 |
| efried | Oh, to add to TaskFlow. | 13:17 |
| efried | Yeah, cool. | 13:17 |
| thorst | so I'm through the first couple. Do we need adreznec to do a pass as well? | 13:28 |
| thorst | to get them into the core reviewer column? | 13:28 |
| adreznec | Uh oh, did we rebase again over the weekend | 13:28 |
| efried | adreznec Friday morning, I think. | 13:29 |
| thorst | I think if we move 3-4 more change sets to the core reviewer backlog that will help get the first few reviewed. | 13:30 |
| adreznec | Ah, must have been after I did my sweep over coffee | 13:30 |
| adreznec | FYI thorst efried it looks like the Nova spec review sprint is next week Tuesday | 13:33 |
| adreznec | So I'll probably set up our bp review for sometime after that in the week | 13:33 |
| efried | Does that happen in IRC? | 13:33 |
| adreznec | I believe so | 13:33 |
| thorst | do we need efried to participate from a powervm perspective in nova as well? | 13:33 |
| thorst | I understand we have to do separately ourselves for OOT, but for IT, do we want to have someone looking through? | 13:34 |
| adreznec | Possibly | 13:34 |
| adreznec | It'll probably be an all day sort of thing in the nova channel | 13:34 |
| adreznec | That's how it's been in the past anyway | 13:34 |
| *** jwcroppe has quit IRC | 13:44 | |
| *** esberglu has joined #openstack-powervm | 13:57 | |
| *** esberglu_ has joined #openstack-powervm | 14:00 | |
| *** esberglu has quit IRC | 14:02 | |
| *** jwcroppe has joined #openstack-powervm | 14:06 | |
| *** burgerk has joined #openstack-powervm | 14:11 | |
| *** dwayne_ has joined #openstack-powervm | 14:24 | |
| *** tjakobs has joined #openstack-powervm | 14:26 | |
| *** apearson has joined #openstack-powervm | 14:35 | |
| efried | FYI, I have another doc appt this morning. Should be back noonish (CT). | 14:55 |
| *** waler has quit IRC | 15:18 | |
| *** apearson has quit IRC | 15:34 | |
| *** apearson has joined #openstack-powervm | 15:37 | |
| *** chas has joined #openstack-powervm | 15:38 | |
| *** chas_ has joined #openstack-powervm | 15:40 | |
| thorst | esberglu_: quick q...CI going OK? | 15:40 |
| esberglu_ | Yeah. Battling off problems as they were coming in last couple of weeks. But passing 90%ish over the weekend | 15:41 |
| thorst | and the last 10% are environmental or just bugs? | 15:42 |
| *** chas has quit IRC | 15:42 | |
| *** chas_ has quit IRC | 15:44 | |
| esberglu_ | We are getting the occasional "No valid host was found" error. And then some 500 internal server errors. | 15:44 |
| thorst | :-/ boo, but ok | 15:44 |
| esberglu_ | Every time I start to look into them something else has been coming in and breaking CI | 15:44 |
| thorst | lol | 15:44 |
| esberglu_ | So I haven't found the root issue yet for either of them | 15:45 |
| thorst | CI is tough... :-/ | 15:45 |
| thorst | ok | 15:45 |
| esberglu_ | On the list for today provided everything goes well | 15:45 |
| *** chas has joined #openstack-powervm | 15:46 | |
| *** k0da has quit IRC | 15:51 | |
| *** apearson has quit IRC | 16:40 | |
| *** apearson has joined #openstack-powervm | 16:43 | |
| efried | thorst Addressed comments in power_on/off, rebased up to cfg_drv. Please continue +1ing. | 18:05 |
| thorst | k | 18:05 |
| *** jwcroppe has quit IRC | 18:10 | |
| *** jwcroppe has joined #openstack-powervm | 18:16 | |
| *** k0da has joined #openstack-powervm | 18:36 | |
| *** chas has quit IRC | 18:39 | |
| *** smatzek has quit IRC | 19:10 | |
| *** jayasankar_ has joined #openstack-powervm | 19:54 | |
| jayasankar_ | adreznec: apearson: what is the plan for 2Q from Devstack ? to complete all operations with IT and OOT ? | 19:56 |
| adreznec | jayasankar_: From what perspective? In terms of what you should be testing? | 20:02 |
| jayasankar_ | Yeah.. scope of testing.. | 20:02 |
| adreznec | jayasankar_: Yeah, I think we'll want to test both IT and OOT with the 1.0.0.6 dev version of things. Ideally expanding beyond things that are tested in the CI environment | 20:04 |
| adreznec | So non-SSP storage backends, etc | 20:04 |
| adreznec | thorst: I think it'd be great to test things like migration, resize (to new host), etc | 20:04 |
| adreznec | But not sure we have hardware for that | 20:05 |
| thorst | adreznec: we're testing LPM, but I've just asked that it be done in one env. | 20:06 |
| thorst | either OSA or Devstack | 20:06 |
| thorst | with the OOT but using the LIO stack | 20:06 |
| adreznec | thorst: Ok | 20:09 |
| adreznec | That seems reasonable | 20:09 |
| adreznec | Devstack is probably more flexible... but I don't have a preference on which one we should do | 20:10 |
| thorst | but I think the next devstack thing will maybe be to test with Nova Ephemeral on the LIO stack. | 20:10 |
| thorst | the stuff tjakobs was driving in? | 20:10 |
| adreznec | Uh | 20:10 |
| adreznec | Eventually | 20:11 |
| jayasankar_ | as OSA + ISCSI + OOT is planned already.. with Devstack as Drew mentioned earlier can I say we have to cover SVC + FC ? | 20:11 |
| adreznec | We hit some snags in the design there | 20:11 |
| adreznec | So that's on hold until the REST work gets figured out | 20:11 |
| thorst | jayasankar_: yeah, I think SVC + FC via NPIV would be a great test. | 20:11 |
| thorst | we need a proper regression on that | 20:11 |
| jayasankar_ | thorst: That is yet to be implemented or already in place ? | 20:12 |
| jayasankar_ | with OOT | 20:14 |
| *** apearson has quit IRC | 20:15 | |
| thorst | jayasankar_: its there now | 20:16 |
| *** jwcroppe has quit IRC | 20:16 | |
| thorst | just read the devref for info on how to set it up | 20:16 |
| *** jwcroppe has joined #openstack-powervm | 20:16 | |
| jayasankar_ | thorst: ah okay.. but we will get separate host or I have to move to OOT now on the current host ? | 20:18 |
| *** jwcroppe_ has joined #openstack-powervm | 20:18 | |
| thorst | jayasankar_: need to move it...no new tests going on the current one anyway and I'm assuming its documented on how you set it up :-) | 20:19 |
| *** jwcroppe has quit IRC | 20:21 | |
| jayasankar_ | pls slack me if any one has any reference links on the same. Also will move to typical Neo with two VIOS tomorrow and configure it. | 20:22 |
| jayasankar_ | efried: You are not debugging any thing on my host neo34 ? Can I reconfigure my neo to OOT ? | 20:23 |
| *** apearson has joined #openstack-powervm | 20:25 | |
| *** apearson has quit IRC | 20:40 | |
| *** apearson has joined #openstack-powervm | 20:46 | |
| *** jayasankar_ has quit IRC | 20:50 | |
| *** burgerk_ has joined #openstack-powervm | 20:58 | |
| *** burgerk has quit IRC | 21:01 | |
| *** edmondsw_ has quit IRC | 21:03 | |
| *** burgerk_ has quit IRC | 21:03 | |
| *** edmondsw_ has joined #openstack-powervm | 21:05 | |
| *** edmondsw_ has quit IRC | 21:09 | |
| *** smatzek has joined #openstack-powervm | 21:17 | |
| *** jwcroppe_ has quit IRC | 21:20 | |
| *** jwcroppe has joined #openstack-powervm | 21:28 | |
| *** smatzek has quit IRC | 21:33 | |
| *** jwcroppe has quit IRC | 21:45 | |
| *** apearson has quit IRC | 21:45 | |
| *** apearson has joined #openstack-powervm | 21:48 | |
| *** esberglu_ has quit IRC | 21:51 | |
| *** apearson has quit IRC | 21:52 | |
| *** jwcroppe has joined #openstack-powervm | 21:57 | |
| *** apearson has joined #openstack-powervm | 21:58 | |
| *** dwayne_ has quit IRC | 21:58 | |
| *** thorst has quit IRC | 22:02 | |
| *** thorst has joined #openstack-powervm | 22:03 | |
| *** esberglu has joined #openstack-powervm | 22:05 | |
| *** thorst has quit IRC | 22:07 | |
| *** esberglu has quit IRC | 22:09 | |
| *** apearson has quit IRC | 22:25 | |
| *** tjakobs has quit IRC | 22:35 | |
| *** edmondsw has joined #openstack-powervm | 22:47 | |
| *** thorst has joined #openstack-powervm | 22:50 | |
| *** edmondsw has quit IRC | 22:52 | |
| *** thorst has quit IRC | 22:53 | |
| *** k0da has quit IRC | 23:05 | |
| *** jwcroppe has quit IRC | 23:22 | |
| *** thorst has joined #openstack-powervm | 23:24 | |
| *** jwcroppe has joined #openstack-powervm | 23:35 | |
| *** thorst has quit IRC | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!