*** chas has joined #openstack-powervm | 00:22 | |
*** edmondsw has joined #openstack-powervm | 00:23 | |
*** chas has quit IRC | 00:27 | |
*** edmondsw has quit IRC | 00:28 | |
*** thorst has joined #openstack-powervm | 00:37 | |
*** thorst has quit IRC | 00:42 | |
*** chas has joined #openstack-powervm | 00:43 | |
*** chas has quit IRC | 00:47 | |
*** chas has joined #openstack-powervm | 01:04 | |
*** chas has quit IRC | 01:08 | |
*** thorst has joined #openstack-powervm | 01:13 | |
*** chas has joined #openstack-powervm | 01:25 | |
*** thorst has quit IRC | 01:25 | |
*** chas has quit IRC | 01:29 | |
*** thorst has joined #openstack-powervm | 01:33 | |
*** thorst has quit IRC | 01:36 | |
*** chas has joined #openstack-powervm | 01:45 | |
*** chas has quit IRC | 01:50 | |
*** kjw3 has joined #openstack-powervm | 02:04 | |
*** chas has joined #openstack-powervm | 02:06 | |
*** thorst has joined #openstack-powervm | 02:07 | |
*** chas has quit IRC | 02:11 | |
*** thorst has quit IRC | 02:23 | |
*** chas has joined #openstack-powervm | 02:27 | |
*** chas has quit IRC | 02:32 | |
*** chas has joined #openstack-powervm | 02:48 | |
*** chas has quit IRC | 02:53 | |
*** thorst has joined #openstack-powervm | 02:54 | |
*** thorst has quit IRC | 02:54 | |
*** jay1_ has joined #openstack-powervm | 02:58 | |
*** chas has joined #openstack-powervm | 03:09 | |
*** jay1_ has quit IRC | 03:12 | |
*** chas has quit IRC | 03:14 | |
*** thorst has joined #openstack-powervm | 03:26 | |
*** k0da has quit IRC | 03:34 | |
*** thorst has quit IRC | 03:44 | |
*** chas has joined #openstack-powervm | 03:50 | |
*** chas has quit IRC | 03:56 | |
*** edmondsw has joined #openstack-powervm | 04:00 | |
*** edmondsw has quit IRC | 04:04 | |
*** shyama has joined #openstack-powervm | 04:07 | |
*** chas has joined #openstack-powervm | 04:12 | |
*** chas has quit IRC | 04:16 | |
*** chas has joined #openstack-powervm | 04:33 | |
*** chas has quit IRC | 04:37 | |
*** thorst has joined #openstack-powervm | 04:41 | |
*** thorst has quit IRC | 04:46 | |
*** chas has joined #openstack-powervm | 04:54 | |
*** chas has quit IRC | 04:58 | |
*** chas has joined #openstack-powervm | 05:35 | |
*** chas has quit IRC | 05:40 | |
*** thorst has joined #openstack-powervm | 05:42 | |
*** thorst has quit IRC | 05:46 | |
*** chas has joined #openstack-powervm | 05:56 | |
*** edmondsw has joined #openstack-powervm | 06:00 | |
*** chas has quit IRC | 06:01 | |
*** edmondsw has quit IRC | 06:05 | |
*** jay1_ has joined #openstack-powervm | 06:06 | |
*** chas has joined #openstack-powervm | 06:17 | |
*** chas has quit IRC | 06:21 | |
*** chas has joined #openstack-powervm | 06:38 | |
*** chas has quit IRC | 06:42 | |
*** chas has joined #openstack-powervm | 07:25 | |
*** chas has quit IRC | 07:26 | |
*** chas has joined #openstack-powervm | 07:26 | |
*** thorst has joined #openstack-powervm | 07:44 | |
*** thorst has quit IRC | 08:03 | |
*** k0da has joined #openstack-powervm | 08:30 | |
*** thorst has joined #openstack-powervm | 10:00 | |
*** thorst has quit IRC | 10:04 | |
*** k0da has quit IRC | 10:30 | |
*** thorst has joined #openstack-powervm | 11:01 | |
*** thorst has quit IRC | 11:06 | |
openstackgerrit | Arun Mani proposed openstack/nova-powervm master: Deploy of VM occasionally fails with OSError https://review.openstack.org/457707 | 11:06 |
---|---|---|
*** shyama has quit IRC | 11:07 | |
*** smatzek has joined #openstack-powervm | 11:23 | |
*** smatzek has quit IRC | 11:25 | |
*** smatzek has joined #openstack-powervm | 11:25 | |
*** thorst has joined #openstack-powervm | 11:26 | |
*** shyama has joined #openstack-powervm | 11:27 | |
*** chas_ has joined #openstack-powervm | 11:31 | |
*** openstackgerrit has quit IRC | 11:32 | |
*** chas has quit IRC | 11:35 | |
*** a1fisher has quit IRC | 12:11 | |
*** edmondsw has joined #openstack-powervm | 12:12 | |
*** jay1_ has quit IRC | 12:18 | |
*** mdrabe has joined #openstack-powervm | 12:34 | |
efried | adreznec yt? | 12:35 |
efried | or thorst ? | 12:36 |
thorst | what's up | 12:41 |
efried | I've never been clear on exactly how requirements are really supposed to work. | 12:41 |
efried | https://review.openstack.org/#/c/458259/ | 12:41 |
efried | Like, when it's called for and/or acceptable to bump g-r vs. u-c. | 12:41 |
thorst | adreznec is the better one | 12:42 |
thorst | or edmondsw maybe....but I think adreznec knows that best | 12:42 |
efried | I don't feel like it would actually *hurt* us to stay at 1.1.1 for the time being. | 12:42 |
efried | 1.1.2 doesn't have any actual function or bugfix material that we need. | 12:42 |
efried | So we could probably wait until 1.1.3 to actually bump. | 12:42 |
efried | But we don't really want to miss it in pike, and have to keep patching local2remote for another release worth. | 12:43 |
efried | That said, the current CI setup is pretty unobtrusive. | 12:43 |
efried | And we don't need to keep the old local2remote patch around. | 12:43 |
efried | So maybe we don't care at all. | 12:43 |
thorst | well, I think we can bump upper-requirements | 13:01 |
thorst | that's kinda the reason for that | 13:01 |
thorst | we don't necessarily keep those two in sync all the time... | 13:01 |
thorst | then that would allow CI to bump up | 13:01 |
thorst | at least for master | 13:02 |
*** apearson has joined #openstack-powervm | 13:05 | |
edmondsw | efried I agree with thorst... sounds like you'd want to bump u-c but not g-r | 13:12 |
efried | thorst edmondsw Okay, done. | 13:12 |
efried | Thanks guys. | 13:12 |
adreznec | efried: thorst Sorry, just got in. Yep, agreed on the u-c only bump for now since you're really trying to move up the upper bound of allowed releases and not remove the older releases from support | 13:19 |
*** apearson has quit IRC | 13:30 | |
*** apearson has joined #openstack-powervm | 13:32 | |
*** k0da has joined #openstack-powervm | 13:36 | |
*** kjw3 has quit IRC | 13:38 | |
*** smatzek has quit IRC | 13:39 | |
*** dwayne has joined #openstack-powervm | 13:49 | |
*** smatzek has joined #openstack-powervm | 13:59 | |
*** esberglu has joined #openstack-powervm | 14:05 | |
*** tjakobs has joined #openstack-powervm | 14:22 | |
thorst | efried: dang dude...nice | 14:24 |
efried | :) | 14:24 |
*** a1fisher has joined #openstack-powervm | 14:30 | |
*** kjw3 has joined #openstack-powervm | 14:33 | |
efried | thorst adreznec esberglu edmondsw - spawn/delete #1 got sdague +W! | 14:36 |
thorst | woo | 14:36 |
thorst | amazing! | 14:36 |
edmondsw | :) | 14:36 |
thorst | and fast... | 14:36 |
esberglu | Nice! | 14:37 |
edmondsw | awesome | 14:37 |
adreznec | Wait no, I changed my mind, I don't to have the driver in tree anymore! | 14:37 |
adreznec | :P | 14:37 |
edmondsw | someone shoot adreznec | 14:37 |
efried | They will physically kill you at the summit. | 14:37 |
adreznec | lol probably | 14:37 |
adreznec | upgraded to definitely if mikal is there | 14:38 |
edmondsw | efried you saw my comments in https://review.openstack.org/#/c/458259/ | 14:43 |
efried | edmondsw Yuh, was just about to fix. Good call. | 14:43 |
edmondsw | cool | 14:43 |
edmondsw | I didn't look at why jenkins failed | 14:44 |
efried | edmondsw Done. I'll take a quick look at the failure, but it's not likely ours. | 14:45 |
edmondsw | +1 | 14:46 |
efried | edmondsw yeah, a timeout in a test. | 14:46 |
efried | edmondsw I believe addressed by https://review.openstack.org/458161 | 14:47 |
*** dwayne has quit IRC | 14:47 | |
efried | which is now merged. | 14:48 |
edmondsw | cool | 14:54 |
*** chas_ has quit IRC | 15:04 | |
*** chas has joined #openstack-powervm | 15:04 | |
*** chas has quit IRC | 15:09 | |
thorst | efried: I -1'd 457707 | 15:32 |
efried | thorst ack | 15:34 |
*** chas has joined #openstack-powervm | 15:55 | |
*** chas has quit IRC | 15:59 | |
*** mdrabe has quit IRC | 16:00 | |
*** mdrabe has joined #openstack-powervm | 16:07 | |
*** dwayne has joined #openstack-powervm | 16:12 | |
*** apearson has quit IRC | 16:25 | |
*** apearson has joined #openstack-powervm | 16:25 | |
edmondsw | efried took me too long to go through https://review.openstack.org/#/c/438598/12 so you'll see my comments there instead of your newer patch set | 16:42 |
edmondsw | some of them you've probably addressed, but I doubt all | 16:42 |
efried | edmondsw ack | 16:42 |
*** esberglu has quit IRC | 16:55 | |
*** esberglu has joined #openstack-powervm | 17:34 | |
*** shyama has quit IRC | 17:53 | |
*** shyama has joined #openstack-powervm | 17:54 | |
thorst | efried: I think tomorrow or so we should work with Jay to get devstack stood up with the storwise cinder driver...do some iscsi testing there | 18:22 |
thorst | since nbante's test isn't going super hot...and we need to validate LPM with iSCSI | 18:22 |
*** chas has joined #openstack-powervm | 18:25 | |
*** nbante has joined #openstack-powervm | 18:26 | |
nbante | I am trying to rerun playbook to configure external stoarge but setup-hosts.yml is failing with some setuptools dependecy issue. | 18:29 |
nbante | I am getting below error when I manually tried | 18:29 |
nbante | python /opt/get-pip.py --isolated setuptools==34.2.0 | 18:29 |
*** chas has quit IRC | 18:30 | |
nbante | Requirement already up-to-date: setuptools==34.2.0 in /usr/local/lib/python2.7/dist-packages | 18:30 |
nbante | Requirement already up-to-date: pip in /usr/local/lib/python2.7/dist-packages | 18:30 |
nbante | Requirement already up-to-date: packaging>=16.8 in /usr/local/lib/python2.7/dist-packages (from setuptools==34.2.0) | 18:30 |
nbante | Collecting appdirs>=1.4.0 (from setuptools==34.2.0) | 18:30 |
nbante | Using cached appdirs-1.4.3-py2.py3-none-any.whl | 18:30 |
nbante | Requirement already up-to-date: six>=1.6.0 in /usr/lib/python2.7/dist-packages (from setuptools==34.2.0) | 18:30 |
nbante | Collecting pyparsing (from packaging>=16.8->setuptools==34.2.0) | 18:30 |
nbante | Using cached pyparsing-2.2.0-py2.py3-none-any.whl | 18:30 |
nbante | Installing collected packages: appdirs, pyparsing | 18:30 |
nbante | Found existing installation: appdirs 1.4.0 | 18:30 |
nbante | Uninstalling appdirs-1.4.0: | 18:30 |
nbante | Successfully uninstalled appdirs-1.4.0 | 18:30 |
nbante | Rolling back uninstall of appdirs | 18:30 |
nbante | Exception: | 18:30 |
nbante | any clue to fix this issue | 18:31 |
edmondsw | nbante I'm not sure you pasted enough there... what was the actual error? | 18:39 |
esberglu | efried: Looks like the --keep-redundant-commits isn't working properly. All of the in-tree patches are failing to apply PS1 since it merged | 18:43 |
esberglu | I can remove PS1 from the patch list | 18:43 |
efried | Well wtf | 18:44 |
esberglu | But that means any patches being tested that haven't rebased to that point will fail | 18:44 |
esberglu | But it's weird because it would have been seeing it as a redundant commit before it merged right? | 18:44 |
efried | esberglu Pretty sure gerrit automatically rebases if a dependency has merged. | 18:44 |
efried | Maybe that's the problem. Hold on, thinking... | 18:45 |
esberglu | No I'm saying just random nova patches | 18:45 |
efried | Oh, probably so. | 18:45 |
esberglu | But nbd if we post some failures from that | 18:45 |
esberglu | At least in my opinion | 18:46 |
efried | esberglu What currently-whitelisted tests rely on changes >1 | 18:46 |
efried | Sayin, can we just remove everything from the patch list? | 18:46 |
efried | Mebbe bust the whitelist back down to just change-1 status. | 18:46 |
efried | Now that things are moving. | 18:46 |
efried | And lockstep it up as we merge more changes. | 18:46 |
esberglu | efried: There are a few tests that rely on later changes | 18:48 |
esberglu | https://github.com/powervm/powervm-ci/commit/69cb39bc790d886f74c75e239fa19a8fa84454f1 | 18:48 |
efried | mm | 18:48 |
esberglu | Keeping the whitelist in sync with the IT driver is gonna be a headache | 18:49 |
esberglu | Starting to think a blacklist might be better | 18:49 |
esberglu | We can use the OOT blacklist as a starting point | 18:50 |
*** jpasqualetto has quit IRC | 18:50 | |
esberglu | And any further tests that we disable we can leave a comment about why | 18:50 |
esberglu | So we should be able to enable certain tests as functionality comes in | 18:50 |
nbante | edmondsw I am getting below exception | 18:51 |
nbante | Exception: | 18:51 |
nbante | Traceback (most recent call last): | 18:51 |
nbante | File "/tmp/tmpMcX3v4/pip.zip/pip/basecommand.py", line 215, in main | 18:51 |
nbante | status = self.run(options, args) | 18:51 |
nbante | File "/tmp/tmpMcX3v4/pip.zip/pip/commands/install.py", line 342, in run | 18:51 |
*** nbante has quit IRC | 18:51 | |
*** nbante has joined #openstack-powervm | 18:51 | |
*** newbie|3 has joined #openstack-powervm | 18:51 | |
edmondsw | nbante you'd better put that in http://paste.openstack.org/ or something | 18:53 |
newbie|3 | sure | 18:53 |
edmondsw | efried esberglu I was wondering if this would happen... I think you have to mark the commits as dependent on another commit, not as redundant | 18:54 |
efried | esberglu edmondsw Also why I was a bit concerned with cherry-picking each individually, rather than review -d of the top one and rebase onto HEAD | 18:55 |
edmondsw | efried esberglu I thought there was an easier way, but here's at least one way: https://ask.openstack.org/en/question/31633/gerrit-best-way-to-make-a-series-of-dependent-commits/ | 18:57 |
efried | Right, that's the way I always do it when I'm working on a series. | 18:58 |
*** newbie|3 has quit IRC | 18:59 | |
*** nbante has quit IRC | 18:59 | |
*** nbante has joined #openstack-powervm | 19:00 | |
edmondsw | efried esberglu https://docs.openstack.org/infra/manual/developers.html#adding-a-dependency | 19:01 |
efried | edmondsw Yup, almost exactly the way I do it. Except I use rebase instead of review -x | 19:02 |
*** chas has joined #openstack-powervm | 19:02 | |
efried | Possible review -x is nicer because maybe it automatically skips redundant intervening rebase steps. | 19:03 |
esberglu | We could probably use -d | 19:03 |
nbante | I pulled latest ansible code and now dependency error gone. Facing another issue, trying to debug. | 19:04 |
esberglu | Just would need to reorder so that it happens before we pull in the actual patch being tested I think | 19:04 |
*** chas has quit IRC | 19:06 | |
*** jpasqualetto has joined #openstack-powervm | 19:07 | |
esberglu | efried: Removing the first patch from the list on production for now so that we can get our other IT patches passing | 19:09 |
efried | esberglu k | 19:09 |
esberglu | Reworking the patching logic as well | 19:09 |
*** shyama has quit IRC | 19:10 | |
*** nbante has quit IRC | 19:10 | |
efried | thorst Thoughts on edmondsw's suggestion of using save_and_reraise_exception all over the place? | 19:24 |
thorst | efried: where was that? And it seems reasonable...I just want to make sure we flush it all back to OOT | 19:25 |
edmondsw | efried thorst this explains why: https://github.com/openstack/oslo.utils/blob/master/oslo_utils/excutils.py#L146 | 19:25 |
efried | thorst https://review.openstack.org/#/c/438598/12 | 19:25 |
efried | Just seems like unnecessary code/logic if we're doing something really simple in the except clause. Like, are we really worried that LOG.* will muck with the exception context? | 19:27 |
edmondsw | efried it's not that... some other greenthread could | 19:27 |
thorst | if it is a pattern that everyone else follows, then I'm good with it | 19:27 |
efried | edmondsw *Any* greenthread switch?? No way. | 19:28 |
efried | That'd have to be a python bug. | 19:28 |
edmondsw | thorst efried I grepped and see 168 other places in nova using this | 19:28 |
edmondsw | so yes, it's a pattern | 19:28 |
efried | Well, I grepped (stand by, will count) places that don't. | 19:29 |
edmondsw | :) | 19:29 |
efried | 56 | 19:29 |
edmondsw | you can ask in the nova channel... I'd guess that's 56 bugs, but maybe they will tell you it's not necessary in some cases | 19:29 |
efried | So it's like, one of those herringbone patterns where one color is used more than the other. | 19:30 |
efried | I don't object to changing 'em all, necessarily, just seems overly paranoid in most cases. | 19:30 |
edmondsw | ask mriedem | 19:30 |
edmondsw | I'm good with whatever he says | 19:30 |
efried | Will do. He and sdague didn't call it out in their reviews, but easy enough to miss I suppose. | 19:31 |
edmondsw | efried yeah, I figured they just overlooked it | 19:32 |
*** chas has joined #openstack-powervm | 19:38 | |
*** jpasqualetto has quit IRC | 19:42 | |
*** chas has quit IRC | 19:43 | |
*** apearson has quit IRC | 19:50 | |
edmondsw | efried so, from sdague's last comment, i would say save_and_reraise_exception isn't required to merge this, but if you have to spin a new patchset it should use it | 19:50 |
efried | edmondsw Yeah, I'll put it in. Just seems more complicated than it's worth for these little cases. | 19:51 |
edmondsw | I hear you about base python bug... I think it'd be more an eventlet issue, but that's probably what you meant | 19:51 |
efried | Yeah, I suppose eventlet would be to blame in that case. | 19:51 |
efried | It wouldn't be terribly hard to test. | 19:52 |
edmondsw | if you have the time :) | 19:52 |
efried | Make an except clause that deliberately switches greenthreads and raises some exception. | 19:52 |
efried | Time... and motivation. | 19:53 |
edmondsw | lol | 19:53 |
efried | I probably don't care enough to prioritize that. | 19:53 |
edmondsw | yeah | 19:53 |
efried | I'd be more swayed by the possibility of LOG.* doing something freaky. | 19:53 |
efried | shrug | 19:53 |
*** jpasqualetto has joined #openstack-powervm | 19:54 | |
efried | edmondsw "it would be nice if there was a specific childclass of HttpError for 404s, and you could just expect that and not have to do this kind of check and reraise all over the place." | 19:56 |
edmondsw | efried yeah, if you had that the save_and_reraise thing would be a non-issue | 19:56 |
efried | This is a good idea. We'd have to put it in pypowervm and only use it in nova once it's landed in a version we can require. | 19:56 |
efried | You feel like proposing the pypowervm change for it? | 19:57 |
edmondsw | efried yeah, I thought of that... that's the rub | 19:57 |
edmondsw | efried I'm tied up at the moment with higher priorities | 19:57 |
efried | edmondsw We're pretty likely to need another requirements bump before RC1, so it's not out of the realm of possibility. | 19:57 |
edmondsw | efried is there a todo list we could throw that on? | 19:57 |
efried | But will need to be done in a later change set. | 19:57 |
efried | edmondsw Launchpad bug. | 19:58 |
edmondsw | efried sure, I can open a bug | 19:58 |
efried | Cool man. https://launchpad.net/pypowervm | 19:58 |
*** apearson has joined #openstack-powervm | 20:02 | |
edmondsw | efried https://bugs.launchpad.net/pypowervm/+bug/1685016 | 20:03 |
openstack | Launchpad bug 1685016 in pypowervm "HttpError is not granular enough" [Undecided,New] | 20:03 |
efried | edmondsw Thanks. | 20:03 |
*** smatzek has quit IRC | 20:09 | |
*** apearson has quit IRC | 20:14 | |
*** chas has joined #openstack-powervm | 20:14 | |
*** chas has quit IRC | 20:18 | |
edmondsw | efried LOG.exception("PowerVM error during destroy.", instance=instance) ... what is the instance=instance for? | 20:29 |
efried | edmondsw So glad you asked. | 20:29 |
efried | The logger nova uses knows to look for an 'instance' kwarg and if found, includes the instance UUID in the log message template. | 20:30 |
efried | Makes debugging way easier. | 20:30 |
efried | Works for any LOG.* in nova. | 20:30 |
edmondsw | cool | 20:31 |
efried | edmondsw Aaargh, lost an edit in an aborted rebase. Didn't change spelling of goofy consts in vm.py | 20:32 |
edmondsw | efried and didn't add that 2nd blank line after imports | 20:32 |
efried | edmondsw That one too. | 20:33 |
efried | I started addressing the comments on the wrong change set. | 20:33 |
edmondsw | ok, I'll stop looking and let you fix | 20:33 |
efried | Tried to stash and restore, but got a conflict that was gonna be more trouble than worth to resolve, so started over. | 20:33 |
efried | But missed those. | 20:33 |
efried | Stand by for fix. | 20:33 |
efried | edmondsw K, done. | 20:34 |
edmondsw | efried why are you setting both id and _uuid to the same thing, rather than one being instance.uuid and one being the output from get_pvm_uuid? | 20:44 |
edmondsw | intentional? | 20:44 |
efried | edmondsw Probably not. Looking... | 20:44 |
efried | edmondsw Probably a bug from OOT too, in fact. | 20:45 |
edmondsw | added review comment as a question | 20:45 |
edmondsw | I've gotta run | 20:46 |
efried | I don't see the id field being used anywhere, but you're right, it's probably intended to be the instance ID. | 20:47 |
*** edmondsw has quit IRC | 20:51 | |
*** edmondsw has joined #openstack-powervm | 20:51 | |
*** edmondsw has quit IRC | 20:56 | |
*** thorst has quit IRC | 21:11 | |
*** edmondsw has joined #openstack-powervm | 21:20 | |
*** edmondsw has quit IRC | 21:25 | |
*** chas has joined #openstack-powervm | 21:26 | |
*** apearson has joined #openstack-powervm | 21:30 | |
*** chas has quit IRC | 21:31 | |
*** esberglu has quit IRC | 21:46 | |
*** esberglu has joined #openstack-powervm | 21:46 | |
*** jpasqualetto has quit IRC | 21:47 | |
*** esberglu has quit IRC | 21:51 | |
*** dwayne has quit IRC | 21:55 | |
*** chas has joined #openstack-powervm | 22:02 | |
*** jpasqualetto has joined #openstack-powervm | 22:04 | |
*** thorst has joined #openstack-powervm | 22:06 | |
*** mdrabe has quit IRC | 22:06 | |
*** thorst has quit IRC | 22:07 | |
*** chas has quit IRC | 22:07 | |
*** apearson has quit IRC | 22:08 | |
*** k0da has quit IRC | 22:22 | |
*** chas has joined #openstack-powervm | 22:38 | |
*** thorst has joined #openstack-powervm | 22:39 | |
*** chas has quit IRC | 22:43 | |
*** tjakobs has quit IRC | 22:54 | |
*** thorst has quit IRC | 22:56 | |
*** kjw3 has quit IRC | 23:00 | |
*** chas has joined #openstack-powervm | 23:14 | |
*** chas has quit IRC | 23:19 | |
*** chas has joined #openstack-powervm | 23:50 | |
*** thorst has joined #openstack-powervm | 23:53 | |
*** chas has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!