*** thorst has quit IRC | 00:47 | |
*** esberglu has quit IRC | 01:12 | |
*** jwcroppe has joined #openstack-powervm | 02:11 | |
*** thorst has joined #openstack-powervm | 04:38 | |
*** thorst has quit IRC | 04:46 | |
*** BorD__ has quit IRC | 05:00 | |
*** tjakobs has joined #openstack-powervm | 05:13 | |
*** thorst has joined #openstack-powervm | 06:01 | |
*** thorst has quit IRC | 06:05 | |
*** tjakobs has quit IRC | 06:26 | |
openstackgerrit | Vu Cong Tuan proposed openstack/ceilometer-powervm master: Fix html_last_updated_fmt for Python3 https://review.openstack.org/474861 | 06:47 |
---|---|---|
*** thorst has joined #openstack-powervm | 08:02 | |
*** thorst has quit IRC | 08:06 | |
*** k0da has joined #openstack-powervm | 09:10 | |
*** thorst has joined #openstack-powervm | 10:03 | |
*** thorst has quit IRC | 10:07 | |
*** thorst has joined #openstack-powervm | 10:55 | |
*** thorst has quit IRC | 10:58 | |
*** thorst has joined #openstack-powervm | 10:58 | |
*** thorst has quit IRC | 11:02 | |
*** smatzek has joined #openstack-powervm | 11:51 | |
*** edmondsw has joined #openstack-powervm | 12:01 | |
*** BorD_ has joined #openstack-powervm | 12:01 | |
*** thorst has joined #openstack-powervm | 12:21 | |
*** kylek3h has joined #openstack-powervm | 12:52 | |
*** dwayne has joined #openstack-powervm | 12:59 | |
efried | edmondsw Can I get a fresh look at 5453? | 13:02 |
edmondsw | efried sure, one sec | 13:02 |
efried | No real hurry, just been out there a couple days. | 13:03 |
*** jpasqualetto has joined #openstack-powervm | 13:05 | |
*** jwcroppe has quit IRC | 13:07 | |
*** jwcroppe has joined #openstack-powervm | 13:08 | |
*** esberglu has joined #openstack-powervm | 13:08 | |
*** jwcroppe has quit IRC | 13:12 | |
efried | esberglu http://184.172.12.213/65/468565/2/check/nova-powervm-out-of-tree-pvm/9c673b5/ looks like it failed two tests; but the results & logs aren't there. | 13:26 |
*** tjakobs has joined #openstack-powervm | 13:26 | |
esberglu | efried: Yeah I saw that. It says logs/ doesn't exist | 13:26 |
esberglu | We define the logs path only as logs/*.gz in the jenkins job config | 13:26 |
esberglu | I tried changing it to the full path to see if that's what is needed | 13:26 |
efried | Other weird CI failures abound since last night. I'll leave you to it. | 13:27 |
*** jwcroppe has joined #openstack-powervm | 13:28 | |
*** mdrabe has joined #openstack-powervm | 13:29 | |
*** dwayne has quit IRC | 13:31 | |
esberglu | efried: See 5469 for a couple quick fixes | 13:39 |
esberglu | I also put up a patch that should allow us to patch to any openstack repo 5468 | 13:40 |
esberglu | Gonna try that out once I get the log publishing fixed | 13:40 |
*** jwcroppe has quit IRC | 13:55 | |
*** jwcroppe has joined #openstack-powervm | 13:55 | |
efried | esberglu Regarding 5469, edmondsw had some questions as to whether this test was really supposed to be related to security_compliance | 13:59 |
*** jwcroppe has quit IRC | 14:00 | |
efried | esberglu But if so, I would like to get that tempest bug opened and include the bug number in these comments and commit msg. | 14:01 |
efried | esberglu See eavesdrop from last night: http://eavesdrop.openstack.org/irclogs/%23openstack-powervm/%23openstack-powervm.2017-06-15.log.html#t2017-06-15T21:48:29 | 14:02 |
esberglu | efried: Yeah that's on my list of things to explore today. My thinking was that since right now it says it's disabled we should at least actually have it disabled | 14:02 |
efried | Well, it's already disabled. | 14:02 |
efried | Oh, does having the name instead of the UUID not actually work anymore? | 14:02 |
esberglu | efried: I'm pretty sure we need id now | 14:03 |
efried | okay. | 14:03 |
edmondsw | esberglu then I think that proves we didn't need to disable this, doesn't it? | 14:03 |
efried | Hah, it would if you could point to a passing run since last night. Can you? | 14:04 |
edmondsw | lol... no | 14:04 |
edmondsw | efried well actually... | 14:04 |
*** jwcroppe has joined #openstack-powervm | 14:04 | |
esberglu | Well they are all gonna fail because that test is failing | 14:04 |
efried | Right, that's my point. | 14:05 |
esberglu | efried: That and 1 other. But idk what the other one is since we can't look at the logs... So that's step 1 | 14:06 |
edmondsw | efried I thought I'd seen a run pass, but I can't find it | 14:06 |
esberglu | edmondsw: Yeah I think a newton CI check passed | 14:06 |
efried | Objection, your honor: hearsay. | 14:06 |
edmondsw | lol | 14:06 |
esberglu | Because failing to delete a network in newton must return something different and doesn't kill the whole run | 14:07 |
*** tjakobs has quit IRC | 14:08 | |
esberglu | efried: Not sure where we landed on 5469. Do we want to leave that test disabled until I have a chance to take a further look? | 14:14 |
esberglu | I don't have enough information to open a bug at this point | 14:14 |
efried | esberglu Okay, go for it. | 14:15 |
edmondsw | esberglu yeah, leave it skipped for now, but once we get the CI passing let's come back to that | 14:21 |
esberglu | edmondsw: Yep | 14:21 |
openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: Remove volume_group_vios_name https://review.openstack.org/468565 | 14:22 |
edmondsw | efried are you saying there ^ that nova will raise an exception if a conf setting isn't defined in code? I don't think that can be right... it should just get ignored | 14:24 |
efried | edmondsw I may be thinking of referring to a conf option that isn't defined. | 14:25 |
efried | Easy enough to try... | 14:25 |
edmondsw | efried yeah, that would raise | 14:25 |
efried | edmondsw Yuh, mahbad. | 14:28 |
edmondsw | np | 14:29 |
efried | Seems slightly dangerous - a one-character typo in a conf option will get you silently using the default, which may take a long time to notice depending on what option we're talking about. | 14:30 |
efried | edmondsw Having gotten no bites on https://review.openstack.org/#/c/472794/ perhaps you should send something out to the ML. | 14:36 |
efried | For something like this, I think describing the problem in words will get you more attention than "yet another review someone's asking me to look at' | 14:37 |
efried | s/'$/"/ | 14:37 |
edmondsw | efried sure | 14:44 |
edmondsw | esberglu should 5468 be split into a change that adds the new capability vs. a change that remove the old -n? | 14:49 |
edmondsw | esberglu then you could add the new capability, remove -n in neo-os-ci, remove the -n support | 14:50 |
edmondsw | as 3 separate patches in that order | 14:50 |
esberglu | edmondsw: Yeah good idea | 14:50 |
*** dwayne has joined #openstack-powervm | 14:55 | |
esberglu | efried: edmondsw: No luck specifying the full /opt/stack/logs/ path | 14:57 |
*** tjakobs has joined #openstack-powervm | 15:03 | |
edmondsw | esberglu are the logs just not there? | 15:10 |
esberglu | edmondsw: I ran a manual run up through the journalctl output | 15:11 |
esberglu | The logs are in /opt/stack/logs/ and all get zipped. You can see it happen in console.html as well | 15:11 |
edmondsw | strange | 15:11 |
esberglu | I think it has to do with the jenkins "workspace" | 15:11 |
esberglu | Not sure what changed though. Our config didn't | 15:12 |
*** mdrabe has quit IRC | 15:18 | |
edmondsw | efried should I wait for the CI to pass before +W on https://review.openstack.org/#/c/474861/ ? | 15:21 |
*** mdrabe has joined #openstack-powervm | 15:30 | |
efried | edmondsw I'm not sure we're allowed to merge *-powervm without our CI passing. | 15:42 |
efried | In any case, it's bad form. So yeah, let's hold off. | 15:42 |
efried | esberglu Sounds like it could be a permissions thing. | 15:42 |
esberglu | efried: edmondsw: Patching logic is tested and working | 16:03 |
efried | esberglu Okay, I have a couple of nits on there, could be done in a followon. | 16:05 |
esberglu | efried: Nah I can do them. No real hurry to get this in, we aren't patching anything right now anyways | 16:05 |
efried | okay. | 16:05 |
*** k0da has quit IRC | 16:06 | |
efried | esberglu Comments up in PS5 | 16:07 |
esberglu | efried: Okay. Will address them later. Back to jenkins | 16:07 |
esberglu | efried: After this I just need to add support to patch devstack and we can live patch essentially everything | 16:09 |
esberglu | Also gonna move the list of pypowervm patches external | 16:09 |
esberglu | efried: Okay so logs/*.gz is what we want for the source (actually we could probably be more descriptive) | 16:12 |
esberglu | This is using antglob syntax so that should match /opt/stack/logs/*.gz | 16:12 |
esberglu | Just have to find out why it can't find the logs directory | 16:13 |
esberglu | logs/*.gz matches with any number of directories in front of logs | 16:14 |
esberglu | I might try outputting journalctl to logs instead of /opt/stack/logs/ while I try to find out why it can't see /opt/stack/logs | 16:16 |
esberglu | That should also match the regex, but maybe jenkins has access there | 16:16 |
esberglu | efried: How do you look at how rst renders in gerrit? Or is that only for openstack gerrit | 16:20 |
edmondsw | esberglu if you modify 5468 to make "openstack/" be part of the repo names, you could then use repo names like 'openstack-dev/devstack' and share the same patching logic, no? | 16:23 |
edmondsw | efried are you going to rebase https://review.openstack.org/#/c/471146/ ? | 16:25 |
esberglu | edmondsw: Sure could | 16:25 |
efried | edmondsw I *think* you can say tox -e docs and it'll build the docs/build dir, whose contents you can then open up in a browser. | 16:28 |
*** dwayne has quit IRC | 16:28 | |
edmondsw | esberglu I think that was for you | 16:28 |
efried | oh, yeah, sorry. | 16:28 |
efried | edmondsw Yes, I'll rebase it this afternoon. | 16:28 |
edmondsw | coo | 16:28 |
esberglu | efried: thx | 16:28 |
esberglu | I'm going to try to add a devstack silent job to our CI | 16:29 |
esberglu | Which should help us identify when it's devstack breaking us vs. something else | 16:29 |
esberglu | efried: edmondsw: One more fix. 5470 | 16:58 |
esberglu | Missed a line in the in-tree local.conf | 16:58 |
edmondsw | esberglu remove the leading / | 17:00 |
esberglu | edmondsw: Done | 17:01 |
edmondsw | I thought you'd already fixed that in the OOT one, but it looks like it also has a leading / | 17:02 |
edmondsw | fix it as well? | 17:02 |
edmondsw | or am I missing something? esberglu | 17:02 |
esberglu | edmondsw: I must not have pushed properly. Because I know I went and fixed that. And was pretty sure that I had that line in the it conf | 17:04 |
esberglu | edmondsw: Done | 17:05 |
edmondsw | esberglu +2 | 17:06 |
esberglu | edmondsw: Okay everything should be passing now minus 1 unidentified test for master OOT and log publishing | 17:07 |
*** dwayne has joined #openstack-powervm | 17:16 | |
*** kylek3h has quit IRC | 17:19 | |
*** esberglu has quit IRC | 17:21 | |
*** esberglu has joined #openstack-powervm | 17:22 | |
*** esberglu has quit IRC | 17:26 | |
*** esberglu has joined #openstack-powervm | 17:34 | |
*** esberglu has quit IRC | 17:39 | |
*** tjakobs has quit IRC | 17:41 | |
*** esberglu has joined #openstack-powervm | 17:47 | |
*** esberglu has quit IRC | 18:19 | |
*** esberglu has joined #openstack-powervm | 18:19 | |
edmondsw | efried your comment in https://review.openstack.org/#/c/471773/ about not needing to rebuild the adapter doesn't really help us unless I put back the _initialized var you had me remove | 18:20 |
edmondsw | that what you want? | 18:20 |
*** burgerk has joined #openstack-powervm | 18:22 | |
edmondsw | I don't think it would really help, though | 18:22 |
edmondsw | I mean, I don't think it would simplify any logic | 18:23 |
*** tjakobs has joined #openstack-powervm | 18:31 | |
efried | edmondsw Why wouldn't `adapter is None` equate to `not _initialized`? | 19:18 |
efried | And the logic in question would be a big try: block which starts with `if adapter is None: create Adapter` | 19:20 |
edmondsw | efried I don't understand why you ask... I already made exactly that change | 19:21 |
*** smatzek has quit IRC | 19:21 | |
edmondsw | your first statement anyway... the second doesn't work | 19:21 |
efried | Okay, let's do it like this: I'm gonna write it up pseudocode style and then we can walk through it and you can tell me why it doesn't work. | 19:23 |
efried | Assuming me writing it up doesn't make that clear to me :) | 19:23 |
edmondsw | good luck :) | 19:23 |
efried | edmondsw It's the stuff like _built_adapter and _initialized_at_entry that makes me go ooky | 19:25 |
efried | Pretty sure the not-needing-to-build-the-adapter-more-than-once thing allows us to get rid of _built_adapter, anyway. | 19:26 |
edmondsw | why? | 19:26 |
edmondsw | I don't see how | 19:26 |
efried | Okay, okay, let me play with it. | 19:26 |
efried | You may very well be right. | 19:26 |
efried | But I'll go down fighting. | 19:26 |
edmondsw | :) | 19:26 |
edmondsw | wouldn't have it any other way | 19:26 |
efried | edmondsw So actually, I'm having a new thought here that I wouldn't mind brainstorming a bit. | 19:28 |
efried | We want to do two completely different things that potentially disable/enable the compute host. | 19:29 |
efried | One is initial setup, which includes adapter creation, vios check, scrub, disk driver. | 19:29 |
efried | The other is refreshing the host_wrapper. | 19:29 |
efried | So I wouldn't mind being able to say... | 19:30 |
efried | with update_compute_host_status(...): | 19:30 |
efried | self.host_wrapper = System.get()[0] | 19:31 |
efried | kind of thing | 19:31 |
edmondsw | efried I think you lost me at "The other is..." | 19:32 |
edmondsw | you seem to be implying we only do adapter creation, vios check, scrub, and disk driver in init_host... and we can't do that | 19:32 |
efried | Initial setup we have to do once. Though arguably we want to do the VIOS check any time we come back to life, but let's put that aside for the moment. | 19:32 |
edmondsw | even adapter creation cannot only be done once | 19:33 |
edmondsw | it has to be done until it succeeds once, which isn't the same thing | 19:33 |
efried | We only need to do it once successfully - yeah. | 19:33 |
efried | okay, so let me play with *that* a bit. Though it won't wind up bearing a lot of resemblance to what you've done. | 19:34 |
*** thorst has quit IRC | 19:37 | |
*** thorst has joined #openstack-powervm | 19:39 | |
*** thorst has quit IRC | 19:44 | |
*** smatzek has joined #openstack-powervm | 19:44 | |
*** burgerk has quit IRC | 19:48 | |
*** thorst has joined #openstack-powervm | 19:59 | |
esberglu | thorst: efried: edmondsw: So I'm still trying to figure this log publishing out. We are using this weird snapshot of an scp plugin | 20:30 |
esberglu | I looked at it a while back with adreznec and we had no idea where it actually came from or why it worked and the official scp plugin did not | 20:31 |
esberglu | I'm nearly certain that it is that coming back to bite us | 20:31 |
esberglu | I'm working on getting the latest scp plugin working | 20:31 |
*** thorst has quit IRC | 20:33 | |
edmondsw | esberglu weird... good luck | 20:34 |
esberglu | edmondsw: Also I think another piece of the intree local.conf got left behind on that bad gerrit commit | 20:34 |
edmondsw | patch? | 20:35 |
edmondsw | I mean, do you have a patch number for me to check? | 20:35 |
esberglu | About to push it up | 20:37 |
esberglu | 5472 | 20:38 |
esberglu | edmondsw: ^ | 20:38 |
edmondsw | esberglu should we move the Q_PLUGIN_CONF_FILE line to be with that, since I think they're highly related | 20:40 |
esberglu | edmondsw: I was going to go through and comment/organize all of the local.conf files | 20:41 |
esberglu | edmondsw: I can though quick | 20:41 |
edmondsw | sounds good | 20:41 |
*** smatzek has quit IRC | 20:42 | |
esberglu | edmondsw: Done | 20:42 |
edmondsw | esberglu +2 | 20:44 |
esberglu | edmondsw: thx | 20:44 |
edmondsw | esberglu I'm headed out... have a good weekend! | 20:44 |
esberglu | edmondsw: Same to you | 20:44 |
*** k0da has joined #openstack-powervm | 20:51 | |
*** edmondsw has quit IRC | 20:54 | |
*** jpasqualetto has quit IRC | 20:55 | |
*** esberglu has quit IRC | 21:00 | |
*** mdrabe has quit IRC | 21:35 | |
*** tjakobs has quit IRC | 21:53 | |
*** dwayne has quit IRC | 21:55 | |
*** thorst has joined #openstack-powervm | 21:59 | |
*** thorst has quit IRC | 22:04 | |
*** k0da has quit IRC | 22:05 | |
*** thorst has joined #openstack-powervm | 22:20 | |
*** jwcroppe has quit IRC | 22:20 | |
*** thorst has quit IRC | 22:20 | |
*** dwayne has joined #openstack-powervm | 22:40 | |
*** jwcroppe has joined #openstack-powervm | 22:54 | |
*** thorst has joined #openstack-powervm | 23:51 | |
*** thorst has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!