| *** thorst has joined #openstack-powervm | 00:02 | |
| *** thorst has quit IRC | 00:08 | |
| *** k0da has joined #openstack-powervm | 00:14 | |
| *** k0da has quit IRC | 00:28 | |
| *** thorst has joined #openstack-powervm | 00:36 | |
| *** thorst has quit IRC | 00:36 | |
| *** thorst has joined #openstack-powervm | 01:52 | |
| *** thorst has quit IRC | 01:56 | |
| *** svenkat has joined #openstack-powervm | 02:04 | |
| *** svenkat has quit IRC | 03:15 | |
| *** k0da has joined #openstack-powervm | 03:26 | |
| *** k0da has quit IRC | 03:33 | |
| *** burgerk has joined #openstack-powervm | 03:33 | |
| *** thorst has joined #openstack-powervm | 03:53 | |
| *** thorst has quit IRC | 03:57 | |
| *** burgerk has quit IRC | 04:36 | |
| *** thorst has joined #openstack-powervm | 05:54 | |
| *** thorst has quit IRC | 05:59 | |
| *** k0da has joined #openstack-powervm | 06:56 | |
| *** k0da has quit IRC | 07:08 | |
| *** YuYangWang has joined #openstack-powervm | 07:42 | |
| *** YuYangWang has quit IRC | 07:47 | |
| *** thorst has joined #openstack-powervm | 07:54 | |
| *** thorst has quit IRC | 08:00 | |
| *** k0da has joined #openstack-powervm | 08:26 | |
| *** thorst has joined #openstack-powervm | 09:23 | |
| *** thorst has quit IRC | 09:28 | |
| *** YuYangWang has joined #openstack-powervm | 09:45 | |
| *** openstackgerrit has joined #openstack-powervm | 10:21 | |
| openstackgerrit | Arundhati Surpur proposed openstack/networking-powervm master: Removes unnecessary utf-8 encoding https://review.openstack.org/482086 | 10:21 |
|---|---|---|
| *** edmondsw has joined #openstack-powervm | 11:25 | |
| *** edmondsw has quit IRC | 11:25 | |
| *** edmondsw has joined #openstack-powervm | 11:25 | |
| *** jwcroppe_ has quit IRC | 11:28 | |
| *** jwcroppe has joined #openstack-powervm | 11:29 | |
| *** thorst has joined #openstack-powervm | 11:53 | |
| *** smatzek has joined #openstack-powervm | 12:03 | |
| openstackgerrit | Arundhati Surpur proposed openstack/networking-powervm master: Removes unnecessary utf-8 encoding https://review.openstack.org/482086 | 12:06 |
| *** svenkat has joined #openstack-powervm | 12:14 | |
| *** svenkat has quit IRC | 12:21 | |
| *** fried_rice is now known as efried | 12:27 | |
| *** svenkat has joined #openstack-powervm | 12:29 | |
| *** mdrabe has joined #openstack-powervm | 12:29 | |
| thorst | efried: I think I'm going to have to make a relatively large change for vif plugging :-( | 12:34 |
| edmondsw | thorst why's that? | 12:54 |
| thorst | as we're adding OVS to the REST API, we're hitting some interesting issues. | 12:54 |
| thorst | I think they're right...but they're...interesting. | 12:54 |
| thorst | I'm working through it now, *may* find a way to just do it all in REST. | 12:55 |
| efried | thorst We knew the changes were going to be substantial. | 13:06 |
| efried | But it sounds like maybe you're going in a different direction than expected? | 13:06 |
| efried | thorst Let's talk it through. | 13:06 |
| thorst | efried: I need to talk to nvcastet a bit more | 13:08 |
| efried | thorst Yeah, what I fear is nvcastet making decisions that are suboptimal from a REST API perspective. | 13:08 |
| *** esberglu has joined #openstack-powervm | 13:09 | |
| thorst | efried: I'm not sure about that TBH | 13:16 |
| thorst | I think REST is pretty OK | 13:16 |
| thorst | its the backend...but let me think through once I'm out of meetings | 13:16 |
| *** burgerk has joined #openstack-powervm | 13:51 | |
| *** jwcroppe has quit IRC | 13:59 | |
| *** esberglu has quit IRC | 14:02 | |
| *** esberglu has joined #openstack-powervm | 14:02 | |
| *** kriskend has joined #openstack-powervm | 14:12 | |
| *** jwcroppe has joined #openstack-powervm | 14:15 | |
| *** k0da has quit IRC | 15:15 | |
| *** jwcroppe has quit IRC | 16:39 | |
| *** jwcroppe has joined #openstack-powervm | 16:47 | |
| *** jwcroppe has quit IRC | 16:49 | |
| esberglu | efried: edmondsw: See changes 5548 and 5549 to knock out a huge chunk of the skip list (156 lines) | 17:42 |
| esberglu | 5548 is good to go | 17:42 |
| efried | ack | 17:42 |
| esberglu | I want to run 5549 through again to make sure I didn't remove or leave any tests errantly | 17:42 |
| edmondsw | ack | 17:42 |
| edmondsw | esberglu how did you determine which extensions to list in 5548? | 17:45 |
| *** kriskend has quit IRC | 18:00 | |
| *** kriskend has joined #openstack-powervm | 18:05 | |
| *** kylek3h has joined #openstack-powervm | 18:11 | |
| *** kriskend_ has joined #openstack-powervm | 18:19 | |
| *** kriskend has quit IRC | 18:19 | |
| esberglu | edmondsw: There is an openstack command for listing extensions | 18:55 |
| esberglu | openstack extension list | 18:55 |
| esberglu | Then you can add --network | 18:55 |
| esberglu | To list only the network extensions | 18:55 |
| edmondsw | esberglu check the comments I added in 5548 | 18:55 |
| esberglu | edmondsw: Yep just looked at them | 18:55 |
| edmondsw | esberglu what do you think of that blacklist idea? seems safer | 18:56 |
| edmondsw | would involve that cli you just mentioned | 18:56 |
| esberglu | edmondsw: Would be easier with a whitelist | 18:56 |
| esberglu | Then I can just filter the output of that command | 18:56 |
| edmondsw | I think the whitelist leaves us open to not testing things we should be testing if/when something gets added | 18:57 |
| esberglu | The whitelist would get generated each run | 18:57 |
| edmondsw | esberglu maybe I'm not following you | 18:57 |
| edmondsw | generated how? | 18:57 |
| esberglu | After you stack, you can run that command to list all of the enabled api extensions | 18:58 |
| edmondsw | the conf setting is a whitelist... so yes, you'd generate a whitelist each run... but how? I'm suggesting we generate it from running openstack extension list --network and then removing anything from a blacklist that we hardcode | 18:58 |
| esberglu | So if any new features are added it would have to be a change at the devstack local.conf level | 18:58 |
| esberglu | I think openstack cli has ways to only output what you want | 18:59 |
| esberglu | So I would only have it output the enabled extensions | 18:59 |
| esberglu | by name | 18:59 |
| esberglu | And then concatenate with commas and set it in tempest.conf | 18:59 |
| edmondsw | "if any new features are added it would have to be a change at the devstack local.conf level" doesn't seem like it would necessarily be true | 19:00 |
| esberglu | Well if we needed a change it would be. If a new extension is added that we don't want, we would have to disable it in the local.conf before stacking | 19:00 |
| edmondsw | we don't have anything in local.conf to do with most of the things in that list you've proposed | 19:00 |
| esberglu | And if a new extension is added that we do want, it will get picked up when stacking, then it will be present when generating the whitelist | 19:01 |
| edmondsw | what's the diff between all and the list you've proposed in 5548? what are we actually disabling there? | 19:01 |
| edmondsw | and you're saying everythig in that diff is explicitly disabled in our local.conf? | 19:02 |
| esberglu | The extensions are enabled or disabled when stacking based on all sorts of things IIRC. Some have specific settings, some are side effects of other settings | 19:03 |
| edmondsw | esberglu right, that's what I was afraid of | 19:04 |
| edmondsw | so something new could get enabled based on some side effect or something, without us needing to do anything in local.conf | 19:04 |
| edmondsw | but we wouldn't be testing it in our CI like we should be | 19:04 |
| *** k0da has joined #openstack-powervm | 19:05 | |
| edmondsw | also it will be more readable to see what we want to disable than what we want to enable, right? | 19:06 |
| edmondsw | efried you're welcome to chime in here at any point :) | 19:06 |
| efried | Reading backscroll... | 19:06 |
| esberglu | I think you're worrying to much about the list. This is just a short term solution so that I can start getting rid of tests in the skip list. This is all going away as soon as the devstack generated tempest.conf is up | 19:06 |
| esberglu | We would just be subject to devstack defaults for enabled/disabled extensions. If it is enabled by default and introduced it either works or breaks us which is what we want either way | 19:06 |
| esberglu | If it is disabled by default we would never know the difference | 19:07 |
| esberglu | And as far as readability | 19:07 |
| esberglu | We aren't listing the extensions anywhere | 19:07 |
| esberglu | Just going through the output of a command | 19:07 |
| edmondsw | esberglu you're listing them with 5548 | 19:07 |
| esberglu | edmondsw: Yeah I thought we had already determined that we were changing that | 19:08 |
| esberglu | I thought we were arguing white vs blacklist | 19:08 |
| edmondsw | but you're right about this probably being me overthinking things if this is all temporary | 19:08 |
| edmondsw | assuming it really is temporary | 19:08 |
| esberglu | How long "temporary" is depends on how many external changes are needed | 19:09 |
| esberglu | Here's the flow I want to happen | 19:09 |
| edmondsw | yeah | 19:09 |
| esberglu | 1) Get devstack to generate a tempest.conf that matches our current tempest.conf | 19:09 |
| esberglu | 1a) With the exception being anything that is in our current tempest.conf that shouldn't be | 19:10 |
| edmondsw | so you'll change 5548 to use the output of `openstack extension list --network`? | 19:10 |
| esberglu | Yeah | 19:10 |
| edmondsw | ok, I'm cool with that | 19:10 |
| esberglu | 2) While that is going on, start working through the skip lists | 19:10 |
| esberglu | and see what else we can get rid of/identify any bugs | 19:10 |
| efried | ...and exclude anything in a blacklist of network extensions, said blacklist maintained... where? how? | 19:11 |
| esberglu | efried: That's why I wanted a whitelist. The blacklist just adds one more piece to the puzzle | 19:11 |
| edmondsw | efried in some CI code | 19:11 |
| efried | esberglu I don't see how. | 19:12 |
| efried | Either we're hardcoding the whitelist, or we're hardcoding the blacklist. | 19:12 |
| esberglu | openstack extension list --network | 19:12 |
| edmondsw | efried but I think esberglu has sold me on just calling that CLI he mentioned, once I realized that CLI lists everything that is enabled in devstack | 19:12 |
| esberglu | It lists all of the enabled extensions after stacking | 19:12 |
| esberglu | It's how I generated the list in 5548 | 19:13 |
| esberglu | I'm just gonna do it each run now instead | 19:13 |
| edmondsw | +1 | 19:13 |
| efried | Oh, sure, perfect. | 19:13 |
| efried | I thought we were going to have to hardcode something one way or the other. | 19:13 |
| esberglu | Nope | 19:13 |
| edmondsw | efried I did to, but nope... so I think we all agree now :) | 19:14 |
| esberglu | :) | 19:14 |
| efried | yuh | 19:14 |
| *** k0da has quit IRC | 19:36 | |
| *** jay1_ has joined #openstack-powervm | 19:52 | |
| *** edmondsw_ has joined #openstack-powervm | 19:53 | |
| *** edmondsw has quit IRC | 19:56 | |
| *** edmondsw has joined #openstack-powervm | 19:57 | |
| *** edmondsw_ has quit IRC | 19:59 | |
| *** jay1_ has quit IRC | 20:05 | |
| *** k0da has joined #openstack-powervm | 20:12 | |
| esberglu | efried: Okay I'm at the point where I have a comma separated list of extensions and want to set api_extensions in tempest.conf | 20:17 |
| esberglu | Problem is that there are multiple api_extensions (for each service) | 20:18 |
| esberglu | Know a good way to find the correct api_extensions line to replace? | 20:18 |
| efried | slack me an example of the output | 20:18 |
| esberglu | I need to get the api_extensions line in the [network-features-enabled] section | 20:19 |
| efried | esberglu And you want to do this from bash (as opposed to python)? | 20:19 |
| esberglu | efried: I was going to try it in bash unless it's way more difficult that way | 20:20 |
| esberglu | For now I could just put a placeholder in our tempest.conf | 20:20 |
| esberglu | On that line | 20:20 |
| esberglu | But I'm trying to improve my bash so I wanted something better | 20:22 |
| efried | esberglu See os_ci_tempest.sh:set_conf_option | 20:23 |
| esberglu | efried: Oh I forgot that was in there. Thanks | 20:23 |
| efried | esberglu Yahyoubetcha. | 20:23 |
| *** thorst has quit IRC | 20:42 | |
| *** thorst has joined #openstack-powervm | 20:45 | |
| *** thorst has quit IRC | 20:49 | |
| *** svenkat has quit IRC | 20:54 | |
| *** thorst has joined #openstack-powervm | 21:00 | |
| *** smatzek has quit IRC | 21:09 | |
| efried | esberglu You can also look up `iniset` in the devstack libs. | 21:30 |
| efried | esberglu Actually, devstack/inc/ini-config is full of useful config-related functions :) | 21:32 |
| esberglu | efried: Cool I'll take a look tomorrow. Was having too much fun nuking the skip list today. Just knocked out another 80 lines | 21:42 |
| *** esberglu has quit IRC | 21:49 | |
| *** svenkat has joined #openstack-powervm | 21:52 | |
| *** kriskend_ has quit IRC | 21:54 | |
| *** kylek3h has quit IRC | 22:00 | |
| *** thorst has quit IRC | 22:02 | |
| *** burgerk has quit IRC | 22:11 | |
| *** k0da has quit IRC | 22:31 | |
| *** svenkat has quit IRC | 22:56 | |
| *** thorst has joined #openstack-powervm | 23:17 | |
| *** thorst has quit IRC | 23:21 | |
| efried | edmondsw Are you interested in being added to all of my ksa changes? | 23:28 |
| edmondsw | sure | 23:29 |
| efried | edmondsw https://review.openstack.org/#/q/owner:self+project:openstack/keystoneauth+status:open | 23:29 |
| edmondsw | efried will try to look tomorrow | 23:30 |
| efried | whoops | 23:30 |
| edmondsw | I can replace self with efried :) | 23:30 |
| efried | I'll just walk 'em and add you. | 23:30 |
| efried | There's not that many. | 23:30 |
| edmondsw | my +1 will help you with the keystone guys | 23:30 |
| edmondsw | they know me pretty well at this point :) | 23:30 |
| edmondsw | unlike nova... | 23:31 |
| efried | edmondsw Done. | 23:31 |
| efried | They're getting to know me :) | 23:31 |
| efried | But definitely appreciate your reviews. | 23:31 |
| *** edmondsw has quit IRC | 23:40 | |
| *** thorst has joined #openstack-powervm | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!