| *** thorst has joined #openstack-powervm | 00:02 | |
| *** thorst has quit IRC | 00:07 | |
| *** svenkat has joined #openstack-powervm | 01:31 | |
| *** jwcroppe has joined #openstack-powervm | 01:54 | |
| *** svenkat has quit IRC | 02:02 | |
| *** thorst has joined #openstack-powervm | 02:08 | |
| *** thorst has quit IRC | 02:13 | |
| *** apearson has joined #openstack-powervm | 02:37 | |
| *** esberglu has joined #openstack-powervm | 03:00 | |
| *** esberglu has quit IRC | 03:00 | |
| *** chhavi has joined #openstack-powervm | 03:02 | |
| *** apearson has quit IRC | 03:52 | |
| *** esberglu has joined #openstack-powervm | 03:53 | |
| *** esberglu has quit IRC | 03:58 | |
| *** apearson has joined #openstack-powervm | 04:28 | |
| *** apearson has quit IRC | 04:47 | |
| *** apearson has joined #openstack-powervm | 04:49 | |
| *** apearson has quit IRC | 05:13 | |
| *** thorst has joined #openstack-powervm | 05:57 | |
| *** thorst has quit IRC | 06:03 | |
| *** esberglu has joined #openstack-powervm | 06:37 | |
| *** esberglu has quit IRC | 06:38 | |
| *** esberglu has joined #openstack-powervm | 06:38 | |
| *** esberglu has quit IRC | 06:38 | |
| *** thorst has joined #openstack-powervm | 07:59 | |
| *** thorst has quit IRC | 08:03 | |
| *** edmondsw has joined #openstack-powervm | 09:16 | |
| *** edmondsw has quit IRC | 09:20 | |
| *** thorst has joined #openstack-powervm | 10:00 | |
| *** thorst has quit IRC | 10:04 | |
| *** esberglu has joined #openstack-powervm | 10:16 | |
| *** esberglu has quit IRC | 10:16 | |
| *** thorst has joined #openstack-powervm | 11:01 | |
| *** thorst has quit IRC | 11:05 | |
| *** esberglu has joined #openstack-powervm | 11:10 | |
| *** esberglu has quit IRC | 11:14 | |
| *** thorst has joined #openstack-powervm | 11:17 | |
| *** smatzek has joined #openstack-powervm | 11:24 | |
| *** svenkat has joined #openstack-powervm | 11:43 | |
| *** svenkat has quit IRC | 11:47 | |
| *** svenkat has joined #openstack-powervm | 11:48 | |
| *** thorst has quit IRC | 12:06 | |
| *** thorst has joined #openstack-powervm | 12:11 | |
| *** jwcroppe has quit IRC | 12:53 | |
| *** apearson has joined #openstack-powervm | 13:01 | |
| *** kylek3h has joined #openstack-powervm | 13:07 | |
| *** jwcroppe has joined #openstack-powervm | 13:26 | |
| *** esberglu has joined #openstack-powervm | 13:28 | |
| *** thorst has quit IRC | 13:33 | |
| *** smatzek has quit IRC | 13:44 | |
| *** smatzek has joined #openstack-powervm | 14:06 | |
| *** thorst has joined #openstack-powervm | 14:29 | |
| *** apearson has quit IRC | 14:58 | |
| *** efried is now known as efried_bbiab | 15:00 | |
| *** apearson has joined #openstack-powervm | 15:02 | |
| *** apearson_ has joined #openstack-powervm | 15:34 | |
| *** jwcroppe has quit IRC | 15:36 | |
| *** apearson has quit IRC | 15:36 | |
| *** efried_bbiab is now known as efried | 15:38 | |
| *** thorst has quit IRC | 15:45 | |
| *** thorst has joined #openstack-powervm | 15:46 | |
| *** apearson_ has quit IRC | 15:49 | |
| *** apearson_ has joined #openstack-powervm | 15:49 | |
| *** thorst has quit IRC | 15:50 | |
| *** apearson_ has quit IRC | 15:58 | |
| *** apearson has joined #openstack-powervm | 16:00 | |
| *** jwcroppe has joined #openstack-powervm | 16:02 | |
| *** apearson has quit IRC | 16:03 | |
| *** jwcroppe_ has joined #openstack-powervm | 16:09 | |
| *** jwcroppe has quit IRC | 16:13 | |
| *** jwcroppe_ has quit IRC | 16:16 | |
| *** apearson has joined #openstack-powervm | 16:24 | |
| *** jwcroppe has joined #openstack-powervm | 16:27 | |
| *** jwcroppe_ has joined #openstack-powervm | 16:34 | |
| *** jwcroppe has quit IRC | 16:37 | |
| *** thorst has joined #openstack-powervm | 16:46 | |
| esberglu | efried: 5548 (generating networking api_extensions) is ready for review | 17:19 |
|---|---|---|
| esberglu | I tested that full commit chain just now and everything looked good | 17:19 |
| *** jwcroppe has joined #openstack-powervm | 17:20 | |
| *** jwcroppe_ has quit IRC | 17:22 | |
| esberglu | efried: Nvm I messed up the push. Hold on until I fix it | 17:29 |
| *** miltonm has quit IRC | 17:35 | |
| *** jwcroppe_ has joined #openstack-powervm | 17:51 | |
| *** jwcroppe has quit IRC | 17:52 | |
| efried | esberglu Ready now? | 17:52 |
| esberglu | efried: Yep | 17:52 |
| efried | esberglu Not loving your regex logic. | 17:57 |
| efried | It'll probably work forever, but I can break it. | 17:57 |
| esberglu | efried: What's your issue with it | 17:57 |
| esberglu | I was trying to search from the section being edited up to the next "[" | 17:58 |
| esberglu | Rather than searching the whole file for it | 17:58 |
| efried | First thing: You haven't assured yourself that the var exists in the section you're mucking with. | 17:58 |
| esberglu | Yeah, if it doesn't exist it gets added by the else of that block | 17:59 |
| efried | Nono, I mean if it exists in the file, but it does *not* exist in the section you're targeting, it won't get added. The sed command will no-op. | 17:59 |
| esberglu | efried: We could only search the section in question instead of the whole file | 18:00 |
| efried | That could be stated as a limitation - the LIMITATIONS comments needs updating anyway. | 18:00 |
| efried | Next, your range gizmo should be using the section_regex. Otherwise you run the risk of spanning too much of the file. | 18:02 |
| efried | And your substitution should be using the var regex too. | 18:02 |
| efried | Next, if the section in question is the last section in the file, your range gizmo won't work (because no subsequent opening square bracket) | 18:04 |
| efried | I'm thinking perhaps we need to crib some of devstacks config file libs. | 18:04 |
| efried | esberglu Ugh, the devstack ini stuff also has the bug of not working if the section is the last one in the file. | 18:12 |
| efried | Maybe. I wonder if it goes to EOF if the second half of the range doesn't match.... | 18:12 |
| esberglu | efried: I think I read that somewhere when I was messing with this yesterday | 18:12 |
| esberglu | Let me see if I can find it | 18:13 |
| efried | esberglu Nah, I just confirmed it. | 18:13 |
| efried | It does indeed go to EOF. | 18:13 |
| esberglu | Ah cool. So I'll just update to use the var_regex and section_regex. And add the new limitation and update the rest. | 18:14 |
| esberglu | Sound good? Remember this is only in play during the transitionary period while getting devstack generated tempest.conf working | 18:15 |
| efried | esberglu Do we have access to devstack at the point where this runs? | 18:18 |
| esberglu | What do you mean by that? | 18:18 |
| efried | esberglu Have we cloned devstack? | 18:19 |
| esberglu | Yeah. This is post stack | 18:19 |
| efried | Yeah, I guess we must've | 18:19 |
| efried | Okay. So why don't we just get rid of set_conf_option entirely, source devstack/inc/ini-config, and use iniset throughout? | 18:20 |
| esberglu | efried: Sure | 18:20 |
| efried | That'll make me a lot more confident that it works. | 18:21 |
| esberglu | efried: Sure. There's only one other place that uses set_conf_option in os_ci_tempest.sh anyways | 18:22 |
| efried | That's slightly depressing. | 18:23 |
| esberglu | efried: Actually using iniset is going to be fantastic. Because then I can set any tempest.conf settings that don't have corresponding devstack settings there | 18:25 |
| esberglu | While we wait for the fixes in devstack to get through | 18:25 |
| esberglu | Much smoother transition | 18:25 |
| *** miltonm has joined #openstack-powervm | 18:42 | |
| *** thorst has quit IRC | 18:44 | |
| *** chhavi has quit IRC | 19:38 | |
| *** apearson has quit IRC | 20:00 | |
| *** apearson has joined #openstack-powervm | 20:02 | |
| *** smatzek has quit IRC | 20:21 | |
| *** esberglu has quit IRC | 21:12 | |
| *** smatzek has joined #openstack-powervm | 21:15 | |
| *** smatzek has quit IRC | 21:20 | |
| *** kylek3h has quit IRC | 21:20 | |
| *** apearson has quit IRC | 21:21 | |
| *** svenkat has quit IRC | 21:21 | |
| *** esberglu has joined #openstack-powervm | 21:26 | |
| *** apearson has joined #openstack-powervm | 21:28 | |
| *** apearson has quit IRC | 21:41 | |
| *** thorst has joined #openstack-powervm | 21:42 | |
| *** thorst has quit IRC | 21:48 | |
| *** apearson has joined #openstack-powervm | 21:54 | |
| *** apearson has quit IRC | 22:37 | |
| *** jwcroppe_ has quit IRC | 23:09 | |
| *** jwcroppe has joined #openstack-powervm | 23:09 | |
| *** jwcroppe has quit IRC | 23:13 | |
| *** jwcroppe has joined #openstack-powervm | 23:44 | |
| *** thorst has joined #openstack-powervm | 23:48 | |
| *** thorst has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!