| *** edmondsw has joined #openstack-powervm | 00:02 | |
| *** thorst has joined #openstack-powervm | 00:03 | |
| *** edmondsw has quit IRC | 00:06 | |
| *** thorst has quit IRC | 00:07 | |
| *** thorst has joined #openstack-powervm | 00:07 | |
| *** thorst has quit IRC | 00:08 | |
| *** edmondsw has joined #openstack-powervm | 00:33 | |
| *** edmondsw has quit IRC | 00:56 | |
| *** thorst has joined #openstack-powervm | 01:11 | |
| *** thorst has quit IRC | 01:11 | |
| *** fried_rice is now known as efried | 01:32 | |
| *** edmondsw has joined #openstack-powervm | 01:55 | |
| *** edmondsw has quit IRC | 01:59 | |
| *** thorst has joined #openstack-powervm | 03:02 | |
| *** thorst has quit IRC | 03:08 | |
| *** edmondsw has joined #openstack-powervm | 03:43 | |
| *** edmondsw has quit IRC | 03:47 | |
| *** edmondsw has joined #openstack-powervm | 05:31 | |
| *** edmondsw has quit IRC | 05:36 | |
| *** edmondsw has joined #openstack-powervm | 07:19 | |
| *** edmondsw has quit IRC | 07:24 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:37 | |
| *** AlexeyAbashkin has quit IRC | 08:12 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 08:12 | |
| *** edmondsw has joined #openstack-powervm | 09:08 | |
| *** edmondsw has quit IRC | 09:12 | |
| *** thorst has joined #openstack-powervm | 11:59 | |
| *** thorst_ has joined #openstack-powervm | 12:00 | |
| *** thorst_ has quit IRC | 12:01 | |
| *** thorst has quit IRC | 12:04 | |
| *** thorst has joined #openstack-powervm | 12:04 | |
| *** edmondsw has joined #openstack-powervm | 12:21 | |
| *** edmondsw has quit IRC | 12:21 | |
| *** edmondsw has joined #openstack-powervm | 12:22 | |
| *** kylek3h has joined #openstack-powervm | 13:35 | |
| *** esberglu has joined #openstack-powervm | 13:58 | |
| *** k0da has joined #openstack-powervm | 14:49 | |
| esberglu | efried: https://review.openstack.org/#/c/409404/35/nova/virt/powervm/media.py | 14:54 |
|---|---|---|
| esberglu | Can you weigh in on edmondsw's comment about get_vm_id vs. get_pvm_uuid here? (L183) | 14:54 |
| esberglu | https://github.com/powervm/pypowervm/blob/develop/pypowervm/tasks/scsi_mapper.py#L450 | 14:55 |
| efried | esberglu Will do. | 14:56 |
| esberglu | ^ sounds like it accepts either from that parameter in pypowervm | 14:56 |
| edmondsw | efried it's probably fine based on the comment in pypowervm, but appreciate you double checking | 14:58 |
| *** tjakobs has joined #openstack-powervm | 15:14 | |
| *** k0da has quit IRC | 15:16 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: DNM: ci check https://review.openstack.org/328315 | 15:16 |
| efried | esberglu edmondsw commented; it's fine. | 15:19 |
| edmondsw | cool, t | 15:19 |
| edmondsw | tx | 15:19 |
| efried | is_uuid, client_id = uuid.id_or_uuid(client_lpar_id) | 15:19 |
| esberglu | tx | 15:19 |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova-powervm master: Raise catachable error when VNC terminal fails to open. https://review.openstack.org/513833 | 15:20 |
| *** AlexeyAbashkin has quit IRC | 15:37 | |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova-powervm master: Raise catachable error when VNC terminal fails to open. https://review.openstack.org/513833 | 16:17 |
| *** AlexeyAbashkin has joined #openstack-powervm | 17:13 | |
| *** AlexeyAbashkin has quit IRC | 17:17 | |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: update translations https://review.openstack.org/514399 | 17:37 |
| openstackgerrit | Matthew Edmonds proposed openstack/networking-powervm master: update translations https://review.openstack.org/514403 | 17:45 |
| openstackgerrit | Matthew Edmonds proposed openstack/ceilometer-powervm master: update translations https://review.openstack.org/514405 | 17:52 |
| *** kylek3h has quit IRC | 17:56 | |
| *** kylek3h has joined #openstack-powervm | 17:56 | |
| efried | edmondsw Translations suck. I am certain I have spent more time looking at these messages than all customers from those locales combined. | 18:05 |
| edmondsw | efried yep | 18:37 |
| edmondsw | once we merge in master, we'll have to backport to pike | 18:37 |
| edmondsw | bugs me that we still have all those files for logs | 18:38 |
| efried | edmondsw We shouldn't. We should delete them. Is there some reason we're keeping them? | 19:05 |
| edmondsw | efried I'll throw up a separate patch to remove them. I'm just not sure how to make sure it doesn't break something | 19:05 |
| efried | edmondsw What would it break? | 19:06 |
| edmondsw | efried that's the question | 19:06 |
| efried | If a translation can't be found, it uses the English, end of story. | 19:06 |
| efried | edmondsw Don't we have some kind of TVT anyway? | 19:06 |
| efried | edmondsw btw, you saw my patch to rip out those orphaned info log translations, yah? | 19:07 |
| edmondsw | efried already +2'd | 19:07 |
| efried | Cool, I should look before I ask :) | 19:07 |
| edmondsw | np :) | 19:07 |
| edmondsw | tx for that | 19:08 |
| edmondsw | efried and your comments... I'm leery of some of them, but I'll give it a shot | 19:08 |
| efried | edmondsw Happy to explain if you like. | 19:08 |
| edmondsw | have been burned in the past when I tried to edit translated files and file encodings got messed up | 19:08 |
| efried | mm, I can see that. Maybe leave the Japanese one alone, then. The others ought to be fine. | 19:09 |
| edmondsw | I don't question your comments, just whether I can safely edit the files | 19:09 |
| efried | edmondsw Dig. | 19:09 |
| edmondsw | efried why would japanese be the only one that's special? | 19:09 |
| efried | edmondsw TBH, it's pretty unimportant to me whether those changes get made. Some of them (like missing spaces from one line to the next) are clearly wrong. But like I said, nobody looks at these messages anyway. | 19:09 |
| edmondsw | that was my thought :) | 19:10 |
| efried | edmondsw Because that one would be using unicode. The Western ones are going to be using ascii or something similar enough as makes no difference. | 19:10 |
| edmondsw | well, there's simplified chinese, traditional chinese, korean... | 19:11 |
| edmondsw | I'd rather just leave them if ok with you | 19:11 |
| edmondsw | efried ^ | 19:12 |
| edmondsw | not our job to correct the translator's mistakes | 19:12 |
| efried | edmondsw But I didn't suggest any edits to those | 19:12 |
| efried | oh, I guess some spacing. | 19:13 |
| efried | and that one %s<korean stuff> that seemed wrong. | 19:13 |
| efried | edmondsw sfine, at least I'm on record noting the mistakes. | 19:15 |
| edmondsw | :) tx | 19:15 |
| efried | Though I really do feel we should be deleting those log-related ones. | 19:15 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: remove log translation files https://review.openstack.org/514437 | 19:21 |
| openstackgerrit | Matthew Edmonds proposed openstack/networking-powervm master: remove log translation files https://review.openstack.org/514439 | 19:31 |
| openstackgerrit | Matthew Edmonds proposed openstack/ceilometer-powervm master: remove log translations https://review.openstack.org/514441 | 19:38 |
| openstackgerrit | Matthew Edmonds proposed openstack/ceilometer-powervm master: remove log translations https://review.openstack.org/514441 | 19:40 |
| edmondsw | efried ^ | 19:41 |
| efried | edmondsw ack | 19:42 |
| *** AlexeyAbashkin has joined #openstack-powervm | 19:58 | |
| *** AlexeyAbashkin has quit IRC | 20:02 | |
| *** thorst has quit IRC | 21:02 | |
| *** edmondsw has quit IRC | 21:20 | |
| *** thorst has joined #openstack-powervm | 21:27 | |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova-powervm master: Raise catachable error when VNC terminal fails to open. https://review.openstack.org/513833 | 21:27 |
| *** thorst has quit IRC | 21:31 | |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova-powervm master: Raise catachable error when VNC terminal fails to open. https://review.openstack.org/513833 | 21:40 |
| *** esberglu has quit IRC | 21:49 | |
| *** esberglu has joined #openstack-powervm | 21:49 | |
| *** esberglu_ has joined #openstack-powervm | 21:51 | |
| *** esberglu has quit IRC | 21:54 | |
| *** esberglu_ has quit IRC | 21:56 | |
| *** esberglu has joined #openstack-powervm | 22:01 | |
| openstackgerrit | Tyler Blakeslee proposed openstack/nova-powervm master: Raise catachable error when VNC terminal fails to open. https://review.openstack.org/513833 | 22:06 |
| *** esberglu has quit IRC | 22:25 | |
| *** thorst has joined #openstack-powervm | 22:46 | |
| *** edmondsw has joined #openstack-powervm | 22:48 | |
| *** thorst has quit IRC | 22:51 | |
| *** edmondsw has quit IRC | 22:52 | |
| *** tjakobs has quit IRC | 23:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!