| *** chhavi has joined #openstack-powervm | 00:14 | |
| *** tjakobs has quit IRC | 00:18 | |
| *** chhavi has quit IRC | 00:18 | |
| *** k0da has quit IRC | 00:34 | |
| *** esberglu has joined #openstack-powervm | 01:20 | |
| *** esberglu has quit IRC | 01:20 | |
| *** esberglu has joined #openstack-powervm | 01:30 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Move host cpu stats to pypowervm https://review.openstack.org/512864 | 01:41 |
|---|---|---|
| *** esberglu has quit IRC | 01:46 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 01:51 | |
| *** AlexeyAbashkin has quit IRC | 01:55 | |
| *** zerick has quit IRC | 02:26 | |
| *** zerick has joined #openstack-powervm | 02:27 | |
| *** zerick has quit IRC | 02:43 | |
| *** zerick has joined #openstack-powervm | 02:43 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 02:51 | |
| *** AlexeyAbashkin has quit IRC | 02:55 | |
| *** thorst has joined #openstack-powervm | 03:35 | |
| *** thorst has quit IRC | 03:41 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 03:51 | |
| *** AlexeyAbashkin has quit IRC | 03:55 | |
| *** chhavi has joined #openstack-powervm | 05:29 | |
| *** thorst has joined #openstack-powervm | 05:37 | |
| *** thorst has quit IRC | 05:41 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 06:03 | |
| *** AlexeyAbashkin has quit IRC | 06:19 | |
| *** k0da has joined #openstack-powervm | 07:49 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 08:03 | |
| *** AlexeyAbashkin has quit IRC | 09:02 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 09:06 | |
| *** AlexeyAbashkin has quit IRC | 09:37 | |
| *** thorst has joined #openstack-powervm | 09:39 | |
| *** thorst has quit IRC | 09:43 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 09:46 | |
| *** AlexeyAbashkin has quit IRC | 09:53 | |
| *** k0da has quit IRC | 10:22 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 11:07 | |
| *** edmondsw has joined #openstack-powervm | 11:50 | |
| *** chhavi has quit IRC | 11:58 | |
| openstackgerrit | Matthew Edmonds proposed openstack/ceilometer-powervm master: update translations https://review.openstack.org/514405 | 12:00 |
| *** thorst has joined #openstack-powervm | 12:01 | |
| openstackgerrit | Eric Fried proposed openstack/ceilometer-powervm master: update translations https://review.openstack.org/514405 | 12:04 |
| efried | edmondsw In case you hadn't noticed, I'm taking on the burden of risk of editing those translation files when I find something that's clearly wrong. | 12:04 |
| edmondsw | efried yep, I saw that... tx | 12:04 |
| edmondsw | I wouldn't ask you to do that, but I won't object, either... I was tempted to do it myself | 12:05 |
| efried | Otherwise there seems no point in bothering with a "review" of translation patches. | 12:06 |
| efried | edmondsw Have there been zero changes to translated messages since we cut pike? | 12:41 |
| efried | I.e. are these backports legit? | 12:41 |
| efried | Or possibly more to the point: at what stage did we send stuff off for translation? Maybe the master ones were bogus. | 12:41 |
| edmondsw | efried my understanding is that the files that were sent off for translation were pulled from pike | 12:41 |
| efried | edmondsw Okay, so if we've updated anything in master since then, it would be out of sync there. But I guess them's the breaks anyway. | 12:42 |
| edmondsw | efried yeah... using pike translations in master is better than using ocata translations in master :) | 12:42 |
| efried | right | 12:42 |
| *** miltonm has joined #openstack-powervm | 12:49 | |
| *** chhavi has joined #openstack-powervm | 12:53 | |
| *** k0da has joined #openstack-powervm | 13:30 | |
| *** esberglu has joined #openstack-powervm | 14:07 | |
| openstackgerrit | Merged openstack/ceilometer-powervm master: update translations https://review.openstack.org/514405 | 14:36 |
| edmondsw | efried what do you think of the comment I just added on 6049? | 14:44 |
| efried | ... | 14:44 |
| *** burgerk has joined #openstack-powervm | 14:51 | |
| efried | edmondsw Replied. esberglu opinion? | 14:52 |
| edmondsw | guess it could be a dict instead of a class | 14:54 |
| edmondsw | that simplifies it somewhat | 14:54 |
| edmondsw | efried ^ | 14:54 |
| efried | edmondsw Meh, could be. That kinda gets back to being pretty close to making it nova-specific. | 14:55 |
| efried | edmondsw Makes it weirder if we're converting from one dict format to another. | 14:56 |
| edmondsw | efried not really... dict doesn't have to align with nova's dict keys | 14:56 |
| edmondsw | eh | 14:56 |
| efried | I know | 14:56 |
| edmondsw | I don't mind converting from one dict format to another any more than converting from a class to a dict | 14:57 |
| edmondsw | conversion has to happen either way | 14:57 |
| efried | shrug | 14:57 |
| edmondsw | more to the point is what's best for pypowervm | 14:57 |
| esberglu | efried: edmondsw: Catching up | 15:01 |
| efried | see also slack | 15:02 |
| esberglu | I like the dict better than another class I think, I'll see where we land in slack | 15:11 |
| *** tjakobs has joined #openstack-powervm | 15:24 | |
| *** AlexeyAbashkin has quit IRC | 15:29 | |
| esberglu | edmondsw: I'm not clear on why we need the extra class at all, perhaps I'm missing something | 15:38 |
| esberglu | Won't this new get_latest method still essentially be a shim for _refresh_if_needed? | 15:38 |
| edmondsw | esberglu sort of | 15:39 |
| edmondsw | one way or the other, the caller needs to do something that will trigger a refresh | 15:39 |
| edmondsw | get_latest makes more sense from a client perspective... they're not worrying about caching, they're just saying "I want the latest" | 15:40 |
| edmondsw | whereas _refresh_if_needed implies that the caller knows there's caching and a refresh may or may not be needed | 15:40 |
| esberglu | Yeah I get that from a naming standpoint. But why can't we just call it get_latest, make it a shim for _refresh_if_needed, and keep the total cycles count where they are? | 15:41 |
| edmondsw | because "get_latest" needs to return something | 15:41 |
| edmondsw | if you don't have a new class, what would it return? | 15:41 |
| efried | It's a usage model thing. I get what edmondsw is saying. It makes sense. The refresh would ideally happen automagically when you access the properties. Then we could get around all of this crapola. | 15:43 |
| efried | Just looked at _refresh_if_needed, and it's actually really cheap when you don't need to refresh. It just compares the current time to the last-updated datestamp. | 15:43 |
| efried | So we could make each of the public instance attrs a @property that does _refresh_if_needed. Bam, one class, and one less consumer call. | 15:44 |
| efried | (not cpu_freq - that should still get set once in init and stay an instance attr since it's static (for now)) | 15:45 |
| efried | esberglu edmondsw Thoughts? ^ | 15:45 |
| edmondsw | efried we could... but cheap or not I don't love calling that 4 times (today... could grow) when once should be enough | 15:47 |
| esberglu | edmondsw: Why does get_latest() need to return anything? | 15:47 |
| edmondsw | esberglu semantics... a "get" needs to return something | 15:48 |
| esberglu | edmondsw: gather_latest() ;) | 15:51 |
| esberglu | I guess this just seems like adding extra complexity to me | 15:51 |
| efried | Personally I don't think it's awful to call refresh() on a thing called "Cache" before you access its data. | 15:51 |
| edmondsw | efried esberglu ok, nevermind... just add a refresh method | 16:12 |
| efried | esberglu But rename the thing to ...Cache | 16:12 |
| esberglu | efried: edmondsw: Sounds good | 16:13 |
| *** kjw3 has joined #openstack-powervm | 16:23 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 16:53 | |
| *** AlexeyAbashkin has quit IRC | 16:57 | |
| openstackgerrit | Eric Berglund proposed openstack/nova-powervm master: Get host-level cpu metrics from pypowervm metric cache https://review.openstack.org/512864 | 17:12 |
| *** AlexeyAbashkin has joined #openstack-powervm | 17:48 | |
| *** AlexeyAbashkin has quit IRC | 17:52 | |
| efried | esberglu Minor tweaks on the pypowervm side | 18:23 |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:30 | |
| *** AlexeyAbashkin has quit IRC | 18:34 | |
| *** chhavi has quit IRC | 18:37 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:47 | |
| mdrabe | esberglu: CI alright? Can I recheck https://review.openstack.org/#/c/514858/? | 18:50 |
| esberglu | mdrabe: Yeah recheck | 18:51 |
| mdrabe | thnx | 18:51 |
| *** AlexeyAbashkin has quit IRC | 18:52 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 20:31 | |
| *** burgerk has quit IRC | 20:34 | |
| *** AlexeyAbashkin has quit IRC | 20:35 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 20:47 | |
| *** thorst has quit IRC | 20:50 | |
| *** AlexeyAbashkin has quit IRC | 20:52 | |
| *** thorst has joined #openstack-powervm | 22:00 | |
| *** thorst has quit IRC | 22:06 | |
| openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm master: ISCSI volume attachment fixes https://review.openstack.org/467599 | 22:07 |
| *** esberglu has quit IRC | 22:07 | |
| *** k0da has quit IRC | 22:08 | |
| *** k0da has joined #openstack-powervm | 22:15 | |
| *** tjakobs has quit IRC | 22:41 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 22:46 | |
| *** AlexeyAbashkin has quit IRC | 22:50 | |
| *** k0da has quit IRC | 23:05 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 23:07 | |
| *** AlexeyAbashkin has quit IRC | 23:11 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 23:27 | |
| *** thorst has joined #openstack-powervm | 23:29 | |
| *** AlexeyAbashkin has quit IRC | 23:32 | |
| *** thorst has quit IRC | 23:43 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!