Monday, 2017-11-13

*** edmondsw has joined #openstack-powervm00:17
*** edmondsw has quit IRC00:25
*** adreznec has joined #openstack-powervm05:21
*** edmondsw has joined #openstack-powervm05:41
*** edmondsw has quit IRC05:45
*** AlexeyAbashkin has joined #openstack-powervm07:45
*** chas_ has joined #openstack-powervm07:56
*** AlexeyAbashkin has quit IRC10:08
openstackgerritOpenStack Proposal Bot proposed openstack/ceilometer-powervm master: Updated from global requirements  https://review.openstack.org/51929610:17
openstackgerritOpenStack Proposal Bot proposed openstack/networking-powervm master: Updated from global requirements  https://review.openstack.org/51912110:22
openstackgerritOpenStack Proposal Bot proposed openstack/nova-powervm master: Updated from global requirements  https://review.openstack.org/51912910:24
*** AlexeyAbashkin has joined #openstack-powervm11:23
openstackgerritEric Fried proposed openstack/nova-powervm master: Get host-level cpu metrics from pypowervm metric cache  https://review.openstack.org/51286412:13
openstackgerritMerged openstack/ceilometer-powervm master: Updated from global requirements  https://review.openstack.org/51929612:22
openstackgerritMerged openstack/nova-powervm master: Updated from global requirements  https://review.openstack.org/51912912:27
openstackgerritMerged openstack/networking-powervm master: Updated from global requirements  https://review.openstack.org/51912112:58
*** edmondsw has joined #openstack-powervm13:19
*** edmondsw has quit IRC13:20
*** edmondsw has joined #openstack-powervm13:20
openstackgerritSridhar Venkat proposed openstack/nova-powervm master: Tap devices are removed when host is rebooted  https://review.openstack.org/51903013:36
efriededmondsw you there?13:43
edmondswefried yes... looking at ^ now13:43
efriedThanks, read my mind :)13:43
edmondswis there a fix proposed for pypowervm?13:43
edmondswefried ^13:45
edmondswcomment says "This will be removed in future when pypowervm is fixed"13:46
efriededmondsw Yes, it's merged.  Lemme get you the commit...13:46
efriededmondsw 613113:46
edmondswefried so shouldn't we use that in nova-powervm master, and only use this hack in stable branches?13:47
efriededmondsw Long term, yes (maybe).  But we needed this fix ASAP.13:47
efriedWe have to get the pypowervm fix into a release and through g-r, which seems to be taking a while lately.13:47
*** edmondsw_ has joined #openstack-powervm13:53
efriededmondsw We're also in negotiations to get 1.1.10 into stable u-c (but not g-r).  Weighing the relative merits of that.13:53
*** edmondsw has quit IRC13:53
edmondsw_efried negotiations with whom?13:53
*** edmondsw_ is now known as edmondsw13:54
efriededmondsw #openstack-requirements folks.13:54
edmondswwhat is driving the request?13:54
edmondswwe haven't even released 1.1.10 yet have we?13:54
efriedNo.  This bug is driving the request.13:55
edmondswor did we just do that to pick this up?13:55
efriedWe haven't done anything yet.13:56
efriedJust svenkat's emergency-fix-with-horrid-monkeypatching over the weekend.13:56
efriededmondsw Oh, yeah, cause there's also 6138 that's needed for this.13:57
*** svenkat has joined #openstack-powervm14:02
* efried waves to svenkat 14:05
svenkatHello!14:06
efriededmondsw Are you still reviewing the patch?14:07
edmondswefried yes... and making a ton of comments14:07
svenkatwhich issue is being discussed here?14:07
edmondsw51903014:07
svenkatohok.14:08
efriededmondsw Okay; but be aware that this is a deliberate hack for the sake of expediency.14:08
edmondswefried yeah, I get that... the comments are wonky, though. I assume we can afford an hour to let svenkat get off the phone and fix them14:08
edmondswefried as is I'm struggling to figure this out14:09
efriededmondsw When you're done redlining that guy, wanna push https://review.openstack.org/#/c/512864/ ?14:12
svenkatI am off.. let me look at your comments14:15
svenkati do not see any new comments in https://review.openstack.org/#/c/519030/414:16
edmondswefried done14:16
edmondswsvenkat haven't saved yet14:16
svenkatok.. will wait14:17
edmondswI'll walk over, easier to discuss that way14:17
svenkatsure14:17
efriededmondsw svenkat But I'd still like to see the executive summary in the review when you're done.14:18
*** edmondsw has quit IRC14:20
*** edmondsw has joined #openstack-powervm14:20
*** edmondsw has quit IRC14:21
*** edmondsw has joined #openstack-powervm14:21
openstackgerritMerged openstack/nova-powervm master: Get host-level cpu metrics from pypowervm metric cache  https://review.openstack.org/51286414:28
edmondswefried yep, one sec and I'll save these comments, which will give you that. Then I'll throw up a new ps that addresses them14:44
efriededmondsw Roger that.14:44
edmondswefried one of the comments was a TODO to add caching... but this code is only hit when the agent has just restarted, so any cache would always be empty, no?14:55
efriededmondsw It's hit once per vif, though.  We could certainly cache the VIOS wrapper(s), and perhaps the CNA lists too.14:56
edmondswk that makes more sense14:56
efriedThe latter would help if >1 vif per VM.14:56
*** miltonm has joined #openstack-powervm15:00
*** tjakobs has joined #openstack-powervm15:01
*** esberglu has joined #openstack-powervm15:07
openstackgerritMatthew Edmonds proposed openstack/nova-powervm master: Tap devices are removed when host is rebooted  https://review.openstack.org/51903015:44
edmondswefried ^15:45
efriededmondsw +2.  Assuming we don't get thorst to look, I'll +W it when svenkat +1s.15:48
edmondswefried well let's at least sort out this slack conversation first15:50
svenkatI added my +115:51
edmondswefried svenkat ok, I think we're good here... I'll +2/+W15:56
openstackgerritEric Berglund proposed openstack/nova-powervm master: Replace TestCase with NoDBTestCase  https://review.openstack.org/51837816:08
openstackgerritMatthew Edmonds proposed openstack/nova-powervm master: Tap devices are removed when host is rebooted  https://review.openstack.org/51903016:16
openstackgerritMerged openstack/nova-powervm master: Tap devices are removed when host is rebooted  https://review.openstack.org/51903016:35
*** AlexeyAbashkin has quit IRC18:18
*** chas_ has quit IRC18:28
*** chas_ has joined #openstack-powervm18:28
*** chas_ has quit IRC18:32
edmondswefried what do you think of my comment on 6107?18:56
*** chas_ has joined #openstack-powervm19:30
*** AlexeyAbashkin has joined #openstack-powervm19:37
*** AlexeyAbashkin has quit IRC19:41
*** chas_ has quit IRC19:47
*** chas_ has joined #openstack-powervm19:47
*** esberglu has quit IRC19:50
*** esberglu has joined #openstack-powervm19:50
*** chas_ has quit IRC19:51
*** AlexeyAbashkin has joined #openstack-powervm19:59
*** AlexeyAbashkin has quit IRC20:06
*** AlexeyAbashkin has joined #openstack-powervm20:06
efriededmondsw I suggested the same at some point.  Must not have been in a code comment, but - great minds, and all that.20:18
edmondswefried alright, I'm fine with making it a future change if you are20:20
efriedYuh.  Want to do a full sweep of pypowervm and get rid of all references to sys as parent.  Then we can do the same in all community code.20:21
efriedesberglu ^20:21
esbergluefried: ack. Is there something similar to the etherpads for pypowervm that I'm not aware of?20:23
efriedWe had a temporary internal etherpad at some point, but we had knocked it all out.20:24
efriedAt this point we can track it via the LP bug.  Sec...20:24
efriedesberglu https://bugs.launchpad.net/pypowervm/+bug/163766820:24
openstackLaunchpad bug 1637668 in pypowervm "Get rid of need for host uuid" [Wishlist,Confirmed] - Assigned to Eric Fried (efried)20:24
esbergluCool tx20:25
*** Alexey_Abashkin has joined #openstack-powervm20:27
efriedesberglu I made notes and assigned to you.20:27
esbergluok20:27
*** Alexey_Abashkin1 has joined #openstack-powervm20:28
*** AlexeyAbashkin has quit IRC20:30
*** Alexey_Abashkin1 is now known as AlexeyAbashkin20:30
*** Alexey_Abashkin has quit IRC20:31
efriedesberglu Has 6107 been through a community CI run yet?20:50
efriedJust with base code to ensure it's backward compatible for now.  Then we can rip the host_uuid out of the community code subsequently.20:51
esbergluefried: Nope will do20:51
efriedthx20:51
*** AlexeyAbashkin has quit IRC20:53
*** AlexeyAbashkin has joined #openstack-powervm21:32
*** AlexeyAbashkin has quit IRC21:36
*** chas_ has joined #openstack-powervm21:37
*** svenkat has quit IRC21:56
*** AlexeyAbashkin has joined #openstack-powervm22:26
*** AlexeyAbashkin has quit IRC22:31
edmondswesberglu are you going to propose something similar to https://review.openstack.org/#/c/518378 for the IT driver?22:33
edmondswthere are 3 places we are using TestCase instead of NoDBTestCase in the IT driver22:34
esbergluedmondsw: Yeah I have it on my personal TODO list, I'll add to the etherpad too22:34
edmondswtx22:34
*** esberglu_ has joined #openstack-powervm22:35
*** esberglu has quit IRC22:39
openstackgerritMerged openstack/nova-powervm master: Replace TestCase with NoDBTestCase  https://review.openstack.org/51837822:42
*** esberglu_ has quit IRC22:43
*** esberglu has joined #openstack-powervm22:44
*** esberglu has quit IRC22:48
*** esberglu has joined #openstack-powervm22:57
*** tjakobs has quit IRC23:10
*** esberglu has quit IRC23:15
*** chas_ has quit IRC23:20
*** chas_ has joined #openstack-powervm23:21
*** chas_ has quit IRC23:25
*** chas_ has joined #openstack-powervm23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!