*** svenkat has joined #openstack-powervm | 00:30 | |
*** gman-tx has joined #openstack-powervm | 00:30 | |
*** esberglu has joined #openstack-powervm | 01:02 | |
*** svenkat has quit IRC | 01:05 | |
*** esberglu has quit IRC | 01:07 | |
*** gman-tx has quit IRC | 01:54 | |
*** gman-tx has joined #openstack-powervm | 01:58 | |
*** gman-tx has quit IRC | 02:45 | |
*** esberglu has joined #openstack-powervm | 02:51 | |
*** esberglu has quit IRC | 02:52 | |
*** esberglu has joined #openstack-powervm | 02:52 | |
*** esberglu has quit IRC | 02:57 | |
*** csky has joined #openstack-powervm | 02:58 | |
*** csky has quit IRC | 03:03 | |
*** csky has joined #openstack-powervm | 03:03 | |
*** csky has quit IRC | 04:00 | |
*** chhavi has joined #openstack-powervm | 04:18 | |
*** chhavi__ has joined #openstack-powervm | 04:18 | |
*** esberglu has joined #openstack-powervm | 05:33 | |
*** esberglu has quit IRC | 05:38 | |
*** AlexeyAbashkin has joined #openstack-powervm | 06:07 | |
*** AlexeyAbashkin has quit IRC | 06:11 | |
*** AlexeyAbashkin has joined #openstack-powervm | 06:12 | |
*** chhavi__ has quit IRC | 06:19 | |
*** AlexeyAbashkin has quit IRC | 06:26 | |
*** esberglu has joined #openstack-powervm | 07:23 | |
*** esberglu has quit IRC | 07:28 | |
*** AlexeyAbashkin has joined #openstack-powervm | 08:32 | |
*** AlexeyAbashkin has quit IRC | 08:38 | |
*** AlexeyAbashkin has joined #openstack-powervm | 08:44 | |
*** AlexeyAbashkin has quit IRC | 08:49 | |
*** adi_____ has quit IRC | 09:01 | |
*** adi_____ has joined #openstack-powervm | 09:02 | |
*** esberglu has joined #openstack-powervm | 09:11 | |
*** esberglu has quit IRC | 09:12 | |
*** esberglu has joined #openstack-powervm | 09:12 | |
*** esberglu has quit IRC | 09:12 | |
*** esberglu has joined #openstack-powervm | 09:13 | |
*** AlexeyAbashkin has joined #openstack-powervm | 09:14 | |
*** esberglu has quit IRC | 09:17 | |
*** esberglu has joined #openstack-powervm | 11:00 | |
*** esberglu has quit IRC | 11:04 | |
*** AlexeyAbashkin has quit IRC | 11:58 | |
*** efried_cya_wed is now known as efried | 12:46 | |
*** AlexeyAbashkin has joined #openstack-powervm | 12:46 | |
*** svenkat has joined #openstack-powervm | 13:05 | |
*** svenkat_ has joined #openstack-powervm | 13:09 | |
*** svenkat has quit IRC | 13:10 | |
*** svenkat_ is now known as svenkat | 13:10 | |
*** apearson has joined #openstack-powervm | 13:34 | |
*** gman-tx has joined #openstack-powervm | 13:42 | |
*** esberglu has joined #openstack-powervm | 13:44 | |
*** esberglu has quit IRC | 13:48 | |
*** esberglu has joined #openstack-powervm | 14:27 | |
*** csky_ has joined #openstack-powervm | 14:36 | |
*** esberglu has quit IRC | 14:44 | |
*** esberglu has joined #openstack-powervm | 14:59 | |
efried | esberglu Which volume driver are you porting first? | 15:38 |
---|---|---|
esberglu | efried: vscsi | 15:38 |
esberglu | efried: Did you see the convo yesterday about that at all? | 15:39 |
efried | yes | 15:39 |
efried | esberglu Is VscsiVolumeAdapter used directly? Or just as ABC for PV and ISCSI? | 15:40 |
esberglu | PVVscsiFCVolumeAdapter | 15:41 |
esberglu | efried: https://review.openstack.org/#/c/526094/ | 15:41 |
esberglu | Started there | 15:42 |
esberglu | But that is VERY wip | 15:42 |
efried | Okay, so you're porting PVVscsiFCVolumeAdapter? | 15:44 |
esberglu | Yeah | 15:44 |
efried | So a couple of things here. | 15:44 |
efried | First, why did you happen to choose this one? | 15:44 |
esberglu | efried: Thought that's what we decided on earlier this cycle no? | 15:45 |
efried | I don't remember. I'm fine with it, just curious. | 15:46 |
efried | What else did we decide on, in terms of volume adapters? | 15:46 |
efried | Is this for Q? | 15:46 |
efried | And is it the only one we're doing for Q? | 15:46 |
esberglu | efried: yes and yes | 15:46 |
efried | k | 15:47 |
efried | So | 15:47 |
efried | IMO, we *should* collapse completely to propose to in-tree. | 15:47 |
efried | Same as we did for the networking stuff. | 15:47 |
esberglu | efried: Just for LOC and reviewer ease? | 15:48 |
efried | I could be convinced that we could collapse to *one* base class and one derived class. | 15:48 |
efried | But even there, I think it'd be better to collapse completely. | 15:48 |
efried | Here's why: | 15:49 |
efried | If it was just a case of the base class providing abstract methods and some default impls, we could make a case to reviewers, maybe. | 15:49 |
efried | But here we've got these weird indirection things, where do_this calls the subclass _do_this -- which is going to seem really weird without knowing the whole picture. | 15:50 |
efried | In general, it's against the philosophy we're using (call it "agile" or "the OpenStack way" or whatever) to propose code in anticipation of something that doesn't exist yet. We're supposed to be thinking of each patch as if it's the last one. | 15:50 |
efried | There are exceptions - but even there, such patches are typically proposed in series, all together. Which is not going to be the case here, since this is the only one for Q. | 15:51 |
efried | The other thing, about refactoring the way we do this stuff OOT: | 15:52 |
efried | I'd be on board with that. | 15:52 |
efried | The way these classes are set up right now is kind of more Java-esque, where there's strict typing and stuff. | 15:52 |
efried | I would be in favor of a looser duck-typed setup, where we don't strictly have to have X defined in the base class to use X in a subclass. | 15:53 |
efried | But I would kinda have to see what that looks like tbh. | 15:53 |
esberglu | efried: I can start thinking about it as I work through IT | 15:56 |
efried | ight. Does what I said above make sense? edmondsw may want to argue the other side again tomorrow. | 15:56 |
esberglu | efried: Yeah it makes sense. And I suspect the nova guys would say the same and that's who ultimately need on board | 15:57 |
efried | just so | 15:57 |
esberglu | You're in tomorrow right? | 15:57 |
esberglu | Otherwise I can argue your side to edmondsw | 15:58 |
efried | esberglu Yes, I'm here tomorrow and first half of Friday (like 6-11 or so) | 16:04 |
esberglu | Then out through the month? | 16:05 |
*** gman-tx has quit IRC | 16:09 | |
efried | esberglu Yes. | 16:28 |
*** gman-tx has joined #openstack-powervm | 16:43 | |
*** AlexeyAbashkin has quit IRC | 16:54 | |
*** chhavi has quit IRC | 17:56 | |
*** apearson has quit IRC | 18:01 | |
*** apearson has joined #openstack-powervm | 18:01 | |
*** apearson has quit IRC | 18:02 | |
*** apearson has joined #openstack-powervm | 18:02 | |
*** apearson has quit IRC | 18:03 | |
*** apearson has joined #openstack-powervm | 18:03 | |
*** apearson has quit IRC | 18:03 | |
*** apearson has joined #openstack-powervm | 18:04 | |
*** apearson has quit IRC | 18:04 | |
*** apearson has joined #openstack-powervm | 18:04 | |
*** apearson has quit IRC | 18:05 | |
*** apearson has joined #openstack-powervm | 18:05 | |
*** apearson has quit IRC | 18:06 | |
*** apearson has joined #openstack-powervm | 18:06 | |
*** apearson has quit IRC | 18:06 | |
*** apearson has joined #openstack-powervm | 18:07 | |
*** apearson has quit IRC | 18:08 | |
*** apearson has joined #openstack-powervm | 18:08 | |
*** apearson has quit IRC | 18:09 | |
*** apearson has joined #openstack-powervm | 18:09 | |
*** apearson has quit IRC | 18:09 | |
*** apearson has joined #openstack-powervm | 18:10 | |
*** apearson has quit IRC | 18:10 | |
*** apearson has joined #openstack-powervm | 18:10 | |
*** apearson has quit IRC | 18:11 | |
*** apearson has joined #openstack-powervm | 18:11 | |
*** apearson has quit IRC | 18:12 | |
*** apearson has joined #openstack-powervm | 18:12 | |
*** apearson has quit IRC | 18:13 | |
*** apearson has joined #openstack-powervm | 18:13 | |
*** apearson has quit IRC | 18:13 | |
*** apearson has joined #openstack-powervm | 18:14 | |
*** apearson has quit IRC | 18:14 | |
*** apearson has joined #openstack-powervm | 18:14 | |
*** apearson has quit IRC | 18:15 | |
*** apearson has joined #openstack-powervm | 18:15 | |
*** apearson has quit IRC | 18:16 | |
esberglu | efried: Just got an IT cloud stood up with SEA, can spawn and ssh into instances so it's a promising start | 18:29 |
*** gman-tx has quit IRC | 18:31 | |
*** esberglu has quit IRC | 18:56 | |
*** apearson has joined #openstack-powervm | 19:15 | |
*** esberglu has joined #openstack-powervm | 19:24 | |
efried | esberglu Great news! | 19:31 |
*** gman-tx has joined #openstack-powervm | 19:49 | |
*** gman-tx has quit IRC | 20:03 | |
*** AlexeyAbashkin has joined #openstack-powervm | 21:38 | |
*** apearson has quit IRC | 21:38 | |
*** svenkat has quit IRC | 21:55 | |
*** apearson has joined #openstack-powervm | 22:01 | |
*** AlexeyAbashkin has quit IRC | 22:43 | |
*** apearson has quit IRC | 23:16 | |
*** openstack has joined #openstack-powervm | 23:29 | |
*** ChanServ sets mode: +o openstack | 23:29 | |
*** edmondsw has joined #openstack-powervm | 23:42 | |
*** chhavi has joined #openstack-powervm | 23:52 | |
*** esberglu has quit IRC | 23:57 | |
*** chhavi has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!