*** edmondsw has joined #openstack-powervm | 02:45 | |
*** edmondsw has quit IRC | 03:03 | |
*** edmondsw has joined #openstack-powervm | 03:05 | |
*** edmondsw has quit IRC | 03:06 | |
*** edmondsw has joined #openstack-powervm | 04:35 | |
*** edmondsw has quit IRC | 04:40 | |
*** edmondsw has joined #openstack-powervm | 06:23 | |
*** edmondsw has quit IRC | 06:28 | |
*** edmondsw has joined #openstack-powervm | 08:12 | |
*** edmondsw has quit IRC | 08:16 | |
*** edmondsw has joined #openstack-powervm | 10:00 | |
*** edmondsw has quit IRC | 10:04 | |
*** edmondsw has joined #openstack-powervm | 12:19 | |
*** edmondsw has quit IRC | 12:20 | |
*** chhavi has joined #openstack-powervm | 12:56 | |
*** chhavi has quit IRC | 13:01 | |
*** chhavi has joined #openstack-powervm | 13:02 | |
*** edmondsw has joined #openstack-powervm | 13:39 | |
*** edmondsw has quit IRC | 13:44 | |
*** efried has joined #openstack-powervm | 13:46 | |
*** edmondsw has joined #openstack-powervm | 14:14 | |
*** esberglu has joined #openstack-powervm | 14:37 | |
*** mdrabe_ is now known as mdrabe | 14:38 | |
esberglu | efried: edmondsw: You guys in today? | 14:53 |
---|---|---|
efried | esberglu I'm here. | 14:53 |
esberglu | efried: I've got a few changes out preparing for IT SEA CI | 14:54 |
efried | Yup, on my radar. | 14:54 |
efried | Clearing out some of the email backlog first. | 14:54 |
esberglu | efried: Cool. The local.conf cleanup and change from whitelist to blacklist are ready | 14:55 |
esberglu | We need a new pypowervm to be cut before we can merge the actual SEA IT CI change | 14:55 |
esberglu | I don't think there's anything we are waiting to get in before we do so? | 14:56 |
*** chhavi has quit IRC | 14:57 | |
*** chhavi has joined #openstack-powervm | 14:58 | |
*** efried has quit IRC | 15:02 | |
edmondsw | esberglu I'm here as well | 15:10 |
*** efried has joined #openstack-powervm | 15:13 | |
esberglu | edmondsw: efried: OVS IT is working as expected for spawns and deletes. I'm still working on getting a full tempest run passing on that | 15:18 |
esberglu | But networking specific tempest tests are looking good | 15:18 |
esberglu | It just ran out of ips last try, so I'm adding more and will let you guys know how that looks | 15:19 |
edmondsw | sounds good, thanks | 15:19 |
edmondsw | esberglu I've got a couple things I have to knock out and then I'll try to catch up with your change proposals | 15:20 |
esberglu | edmondsw: thx | 15:21 |
catmando | hey chaps | 17:17 |
catmando | just noticed the activity; don't know if you're able to see my questions above | 17:18 |
catmando | don't want to repaste if you can | 17:18 |
*** csky has joined #openstack-powervm | 17:33 | |
efried | catmando I don't have 'em; please re-paste. | 17:40 |
catmando | i think i found a bug in powervc 1.4 | 17:42 |
catmando | but i don't know if it's really a bug or just missing documentation | 17:42 |
catmando | i cannot create a server using the POST to nova's /servers unless i use an imageRef | 17:42 |
catmando | but https://developer.openstack.org/api-ref/compute/ states that imageref is optional if i set block_device_mapping_v2 | 17:42 |
catmando | any attempt to not use an imageref fails at line 981 in powervc-nova/compute/manager.py | 17:42 |
catmando | commenting out that block just leads to more failures later on | 17:42 |
catmando | the error that eventually bubbles through to powervc is "failed prepping block device" | 17:42 |
catmando | this is a real issue for us as powervc's naming scheme when it comes to creating instances from images makes management very difficult (especially on the Brocade switches) | 17:42 |
catmando | we were hoping to resolve this by doing our own flash copies (backups) on the SVC and then creating an instance from that nicely named copy | 17:42 |
catmando | there also seems to be some custom undocumented method for marking volumes as bootable | 17:42 |
catmando | specifically, marking a volume as bootable in cinder does nothing, it has to be marked as "is_boot_volume" in the volume_metadata table | 17:42 |
efried | edmondsw mdrabe ^^ Your wheelhouse. (Or maybe gfm needs to brought in?) | 17:44 |
edmondsw | reading back | 17:44 |
edmondsw | yeah, let me try to pull in gfm | 17:46 |
catmando | for the time being I have worked around this by changing the configs and some places where the instance and volume templates are hardcoded | 17:47 |
edmondsw | csky are you around? | 17:48 |
*** chhavi has quit IRC | 17:51 | |
mdrabe | catmando: Are you wanting the PowerVC instance name, hypervisor LPAR name, and zone name on the fabric to all be similar? | 17:53 |
catmando | mdrabe: yes, and without cutting off the instance name / adding UUIDS | 17:54 |
catmando | it makes reading zones on the SAN switches very painful and we have a pattern in place for naming | 17:54 |
catmando | it also makes looking at the HMC painful | 17:54 |
catmando | as I say, my workaround does work, but the above feels like a bug | 17:55 |
mdrabe | Yea you can change the name templates in conf to make it more eyeball friendly, I would just proceed with caution | 17:55 |
catmando | there's no reason for the block_device_mapping_v2 to fail with that error. i can clearly see that the code ALWAYS expectes an imageRef, which in that case is wrong | 17:56 |
mdrabe | I believe the reason we don't mention those conf options at all is because we want to avoid naming collisions | 17:56 |
catmando | mdrabe you can, but there are also hardcoded lines | 17:56 |
catmando | the conf files won't allow you to drop all the UUIDs | 17:56 |
catmando | I can provide a patch set | 17:56 |
catmando | (but it feels like an edge case) | 17:57 |
catmando | as i say, my concern is regarding the imageRef and the bootable flag | 17:57 |
mdrabe | Are you looking at nova? | 17:57 |
catmando | nova and cinder | 17:57 |
catmando | in fact, nova is actually setting a portion of the volume name that cinder then picks up and modifies further | 17:58 |
mdrabe | Can you link the line #s from github? | 17:58 |
mdrabe | er this is pvc specific isn't it | 17:59 |
catmando | I can, but have left the office now. Will leave it here | 17:59 |
catmando | Yes, it is | 17:59 |
mdrabe | What Python module is it? I can find it from there | 17:59 |
catmando | Powervc-nova/compute/something | 18:00 |
catmando | Have a search for .37s | 18:00 |
catmando | It's the string format that's hard coded in there somewhere | 18:01 |
catmando | I forget where exactly | 18:01 |
catmando | The patches are small, maybe 4 or 5 lines in total | 18:01 |
mdrabe | Hmm not finding ".37s" | 18:03 |
edmondsw | mdrabe powervc_cinder/db/sqlalchemy/models.py | 18:05 |
mdrabe | ah thnx | 18:05 |
mdrabe | catmando are you using the pvc_volume_name_template option in cinder conf? | 18:07 |
catmando | Yes, I did try | 18:08 |
catmando | There are a number of places where uuids are appended | 18:08 |
mdrabe | Lookin through it | 18:11 |
*** csky has quit IRC | 18:31 | |
mdrabe | catmando: From what I can tell each volume driver defines it's own naming conventions based on the limitations of the storage provider. | 18:44 |
mdrabe | The pvc_volume_name_template conf option looks like it's used only for existing volumes though | 18:45 |
mdrabe | The community cinder conf option volume_name_template is used for setting the volume name out on the storage provider | 18:46 |
edmondsw | mdrabe I think his primary question is why the code is expecting imageRef when he specified block_device_mapping_v2 | 19:01 |
edmondsw | put another why... why isn't boot-from-volume (in the nova sense) working? | 19:03 |
edmondsw | I suspect that's a limitation more than a bug, but I don't know if it's something we can address | 19:05 |
edmondsw | so if we can find another solution to his case where he doesn't need to use boot-from-volume, great | 19:05 |
mdrabe | Yea I'm pretty sure pvc has to boot from an image | 19:05 |
edmondsw | yeah, I just don't know the ins and outs well enough to know if that was more of a test statement and a couple code tweaks or an intentional "that's not gonna work" thing | 19:06 |
mdrabe | Yea me neither | 19:07 |
edmondsw | catmando ^ | 19:08 |
edmondsw | None of the folks I've looked for that should be able to give a more complete answer seem to be around today | 19:08 |
*** zerick has joined #openstack-powervm | 19:22 | |
catmando | @edmondsw: no worries, maybe something will crop up over the next couple of days | 19:33 |
esberglu | efried: edmondsw: Got a working tempest run for OVS IT | 20:10 |
esberglu | I started with the OOT SEA skip list, so there are probably some more tests I can enable | 20:10 |
efried | Noyce | 20:11 |
esberglu | But I'm satisfied with the results for now. Just need your reviews and then we can bug the cores | 20:11 |
edmondsw | esberglu excellent | 20:23 |
efried | esberglu So right now your powervm-ci patch is setting us up for SEA - is the plan to switch that over to OVS at some point soon? | 20:27 |
efried | Oh, I had forgotten where we were with in-tree patches. Looks like OVS isn't even proposed yet. So this is The Right Thing for now. | 20:29 |
esberglu | efried: I thought that the plan was to support SEA IT CI for queens? Then do further work to get both SEA and OVS CI pipelines next release | 20:30 |
efried | yeah yeah, that sounds right. | 20:30 |
efried | oh, I wasn't seeing the ovs patch because it's still under wangqwsh's name. | 20:31 |
edmondsw | efried I was just about to ask what you meant there :) | 20:31 |
edmondsw | about not being proposed | 20:31 |
efried | Well, so that brings up the question: why does it need to be patched in for the CI? | 20:31 |
edmondsw | esberglu have you looked at why the IT CI run failed for the OVS change? Does that need to be rechecked again? | 20:31 |
efried | Okay, so yeah, I'm confused. | 20:32 |
esberglu | edmondsw: We need a new pypowervm release for that | 20:32 |
edmondsw | why? | 20:32 |
efried | If we're not putting OVS in tree right now, it shouldn't be in the series ahead of SEA. | 20:32 |
esberglu | efried: We are putting OVS in tree. Just not CI | 20:32 |
efried | oy vay. Okay. | 20:33 |
efried | If only there was a regular meeting for us to sync up on this stuff. | 20:33 |
edmondsw | because we were testing SEA in the OOT CI, and not OVS, so this was easier | 20:33 |
efried | But if you've got OVS working now... | 20:33 |
edmondsw | efried if only we weren't all hazy after our time off :) | 20:33 |
edmondsw | we had OVS working OOT for a long time, but we weren't testing it in CI | 20:33 |
esberglu | edmondsw: OVS is working for a IT stack. But nothing has been done for an OVS CI pipeline yet | 20:34 |
edmondsw | agreed that we need to look at that... but nova didn't seem to care when we talked about this at the PTG | 20:34 |
edmondsw | esberglu right, I'm trying to explain why we're not doing OVS in CI yet | 20:35 |
edmondsw | it's on the TODO list, though, right? | 20:35 |
esberglu | edmondsw: Yeah, just not something we were targeting for queens | 20:35 |
edmondsw | right | 20:35 |
efried | So when you say, "Got a working tempest run for OVS IT" -- that's not the same as having OVS CI? | 20:35 |
edmondsw | correct | 20:35 |
edmondsw | he was doing some manual testing | 20:36 |
efried | I guess it's the first & hardest part; then we need to do all the crazy yaml stuff to make it actually occur in the CI? | 20:36 |
esberglu | efried: Exactly | 20:36 |
efried | Okay, I'm on board now. | 20:36 |
esberglu | https://review.openstack.org/#/c/503061/5/specs/queens/approved/powervm-nova-it-compute-driver.rst | 20:36 |
esberglu | ^ per the comment on L168 we weren't aiming for OVS CI this release | 20:36 |
edmondsw | esberglu have you looked at why the IT CI run failed for the OVS change? Does that need to be rechecked? | 20:37 |
efried | esberglu Remind me how we patch in change sets in the CI. Does including a change set number also pull in its dependencies? | 20:37 |
esberglu | efried: Right now we list each change individually. The dependencies are not pulled in | 20:38 |
esberglu | edmondsw: We need a new pypowervm cut | 20:38 |
esberglu | https://github.com/powervm/pypowervm/commit/651a01b6 | 20:38 |
esberglu | ^ we need that change | 20:38 |
edmondsw | so when you asked about cutting pypowervm this morning and said it was needed for the SEA IT CI change... it's really for this as well? | 20:40 |
esberglu | edmondsw: Yeah both need it | 20:40 |
edmondsw | was this done because of an earlier comment? | 20:41 |
esberglu | edmondsw: We're trying to remove host_uuid from pypowervm. This was added as part of that effort | 20:48 |
esberglu | Some of the rest calls still need a parent_uuid so we cache the sys_uuid to use for that | 20:48 |
edmondsw | yeah, I see that... and I guess it makes sense to do that from the get go instead of switching it IT later | 20:48 |
esberglu | yeah | 20:50 |
edmondsw | efried do we need to include _cleanup_orphan_adapters in the OVS/SEA patches? | 21:33 |
edmondsw | mdrabe any thoughts on that? | 21:36 |
esberglu | edmondsw: iirc that's only needed for migration | 21:53 |
efried | edmondsw Sorry, context? | 21:57 |
edmondsw | OOT powervm/driver.py's method | 21:58 |
efried | No, orphan adapters should only apply to vscsi/fc | 21:58 |
edmondsw | oh, I thought that was networks... guess I didn't look closely enough | 21:58 |
efried | So OOT yes. IT not until https://review.openstack.org/#/c/526094/ | 21:58 |
edmondsw | don't we have some cleanup related to networks as well somewhere? | 21:59 |
efried | And it does apply to migration most of the time, but that's not the only way you can end up with an orphan. | 21:59 |
efried | Um, I don't think so. | 21:59 |
edmondsw | k | 22:01 |
edmondsw | esberglu there's a hack at the top of vif.py in the OVS patch because we need a newer version of pypowervm... If we need that anyway for the CI now, we should go ahead and address that | 22:02 |
edmondsw | efried do you want to get 6121 in before we rel pypowervm or it doesn't matter? | 22:03 |
edmondsw | I'll admit I haven't looked at it yet | 22:03 |
edmondsw | since vacay anyway | 22:04 |
efried | edmondsw It's not critical. We had a customer issue around that. I don't remember whether they confirmed that wasn't their problem, or just haven't gotten back to me yet, but either way it's clearly not urgent. | 22:05 |
edmondsw | efried anything else you're aware of needing to get in before release? | 22:06 |
efried | no | 22:07 |
efried | Nothing else is close to ready. | 22:07 |
edmondsw | esberglu couple quick things to address on the OVS patch, but nearly there... comments added | 22:28 |
esberglu | edmondsw: ack | 22:39 |
edmondsw | esberglu also just left a question in the SEA patch that may affect OVS patch | 22:40 |
edmondsw | efried I left you a couple comments on 6121 | 23:18 |
edmondsw | gotta run now | 23:18 |
efried | edmondsw Ack, thx | 23:18 |
*** edmondsw has quit IRC | 23:19 | |
*** edmondsw has joined #openstack-powervm | 23:19 | |
*** edmondsw has quit IRC | 23:24 | |
*** openstackgerrit has joined #openstack-powervm | 23:33 | |
openstackgerrit | Taylor Jakobson proposed openstack/nova-powervm master: Refactor volume drivers https://review.openstack.org/530816 | 23:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!