| *** edmondsw has joined #openstack-powervm | 00:36 | |
| *** esberglu has quit IRC | 00:37 | |
| *** openstackgerrit has joined #openstack-powervm | 02:07 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer-powervm master: Updated from global requirements https://review.openstack.org/531957 | 02:07 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/networking-powervm master: Updated from global requirements https://review.openstack.org/531966 | 02:19 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova-powervm master: Updated from global requirements https://review.openstack.org/531968 | 02:23 |
| *** edmondsw has quit IRC | 02:30 | |
| *** adreznec has quit IRC | 03:07 | |
| *** adreznec has joined #openstack-powervm | 03:08 | |
| *** adreznec has quit IRC | 03:16 | |
| *** adreznec has joined #openstack-powervm | 03:21 | |
| *** esberglu has joined #openstack-powervm | 04:16 | |
| *** esberglu has quit IRC | 04:17 | |
| *** chhavi has joined #openstack-powervm | 04:37 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 07:56 | |
| *** chhavi__ has joined #openstack-powervm | 08:29 | |
| *** chhavi has quit IRC | 08:29 | |
| *** chhavi__ has quit IRC | 09:48 | |
| *** chhavi__ has joined #openstack-powervm | 09:49 | |
| *** chhavi__ has quit IRC | 10:57 | |
| *** AlexeyAbashkin has quit IRC | 11:02 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 11:02 | |
| *** apearson__ has quit IRC | 13:11 | |
| *** edmondsw has joined #openstack-powervm | 13:21 | |
| openstackgerrit | Merged openstack/ceilometer-powervm master: Updated from global requirements https://review.openstack.org/531957 | 13:40 |
| openstackgerrit | Merged openstack/networking-powervm master: Updated from global requirements https://review.openstack.org/531966 | 13:44 |
| *** esberglu has joined #openstack-powervm | 13:48 | |
| *** apearson__ has joined #openstack-powervm | 13:49 | |
| *** AlexeyAbashkin has quit IRC | 13:52 | |
| openstackgerrit | Merged openstack/nova-powervm master: Updated from global requirements https://review.openstack.org/531968 | 13:52 |
| *** gman-tx has joined #openstack-powervm | 13:57 | |
| *** chhavi__ has joined #openstack-powervm | 13:58 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 14:00 | |
| esberglu | #startmeeting powervm_driver_meeting | 14:00 |
| openstack | Meeting started Tue Jan 9 14:00:24 2018 UTC and is due to finish in 60 minutes. The chair is esberglu. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: powervm_driver_meeting)" | 14:00 | |
| openstack | The meeting name has been set to 'powervm_driver_meeting' | 14:00 |
| efried | \o | 14:00 |
| edmondsw | o/ | 14:01 |
| esberglu | #topic In-tree Driver | 14:02 |
| *** openstack changes topic to "In-tree Driver (Meeting topic: powervm_driver_meeting)" | 14:02 | |
| esberglu | The pypowervm uc change merged yesterday | 14:02 |
| esberglu | OVS has passed CI and is ready for reviews | 14:02 |
| edmondsw | awesome | 14:03 |
| esberglu | I ran SEA CI IT manually and it looked good and merged last night | 14:03 |
| edmondsw | I pinged mriedem and sdague to start reviewing yesterday afternoon | 14:03 |
| efried | I merged the *-powervm requirements bumps this morning. | 14:03 |
| esberglu | However it's broken on the actual SEA patch, but works for everything else | 14:03 |
| edmondsw | do we know why? | 14:04 |
| esberglu | When it tries to apply the OVS & SEA patches onto the SEA patch it gets a merge failure | 14:04 |
| esberglu | We hit this last release and I thought we fixed it | 14:04 |
| edmondsw | did we only fix it OOT? | 14:04 |
| esberglu | But we've changed a few things with how we set up the repos since then | 14:04 |
| esberglu | No this would probably hit that as well, just not a very common case | 14:05 |
| esberglu | That's first on my list today | 14:05 |
| edmondsw | yep | 14:05 |
| edmondsw | I will let mriedem and sdague know the OVS is fully ready, SEA we're still working a CI issue | 14:06 |
| esberglu | edmondsw: Cool tx | 14:06 |
| esberglu | The vSCSI patch is looking good functionally. I need to clean up the comment throughout a couple of the files that are outdated, missing params, returns, etc. | 14:06 |
| esberglu | The UT is passing tox locally, but some of the tests are failing the gerrit tox | 14:07 |
| efried | Have you -r'd locally? | 14:07 |
| esberglu | efried: Not recently, but I have at some point since they started failing upstream | 14:09 |
| esberglu | https://review.openstack.org/#/c/526094/15/nova/tests/unit/virt/powervm/volume/test_vscsi.py | 14:09 |
| esberglu | It's various tests in this file, not the same ones every time | 14:09 |
| efried | hm, that doesn't bode well. | 14:09 |
| esberglu | I think that they may just be taking too long? | 14:10 |
| esberglu | http://logs.openstack.org/94/526094/15/check/openstack-tox-py27/c736859/job-output.txt.gz#_2018-01-08_21_19_34_770605 | 14:10 |
| esberglu | These tests call the top level attach/detach_volume methods and test the entire flows in each test | 14:11 |
| edmondsw | does sound like a potential timeout issue | 14:13 |
| esberglu | Which is not how most of the other UT for the IT work has been done, that was mostly smaller sets of code in each UT | 14:13 |
| edmondsw | yeah, UT should be smaller | 14:13 |
| esberglu | I based them off of the OOT tests, I've been trying to keep them as in sync as I can | 14:13 |
| esberglu | Think it's worth reworking? | 14:13 |
| edmondsw | we might have to | 14:13 |
| esberglu | If that is indeed the issue | 14:13 |
| edmondsw | you could try bumping the timeouts first and see if that resolves them | 14:14 |
| edmondsw | to confirm the issue is what we think it is | 14:14 |
| esberglu | I can't bump the timeouts, they're passing locally and I can't control the upstream zuul | 14:14 |
| edmondsw | oh I meant locally | 14:15 |
| esberglu | It's just one file, it shouldn't be that much work to break the UT into smaller sections | 14:15 |
| edmondsw | k, let's start there | 14:16 |
| efried | or reduce the timeouts locally and see if the same kind of errors pop up. | 14:17 |
| esberglu | Sure I can try that | 14:17 |
| esberglu | That's all I had for IT, any other thoughts from you guys? | 14:17 |
| edmondsw | efried will you be able to review the SEA and OVS patches today? | 14:17 |
| efried | Just finished the OVS patch. | 14:18 |
| edmondsw | sweet | 14:18 |
| efried | Will look at the SEA patch. | 14:18 |
| efried | Been ignoring vSCSI because WIP and Zuul -1 | 14:18 |
| edmondsw | yep | 14:18 |
| edmondsw | esberglu let us know when we should start looking at vSCSI, or if there are parts of it we should start looking at, like the non-test bits? | 14:19 |
| esberglu | I would appreciate reviews for vSCSI sooner rather than later | 14:19 |
| esberglu | The UT is ready for review except for test_vscsi.py | 14:20 |
| edmondsw | ok, I'll review that today | 14:20 |
| esberglu | tx | 14:21 |
| esberglu | #topic Out-of-tree Driver | 14:22 |
| *** openstack changes topic to "Out-of-tree Driver (Meeting topic: powervm_driver_meeting)" | 14:22 | |
| efried | I merged the *-powervm requirements bumps this morning. | 14:22 |
| esberglu | The only thing I had OOT was the SaveBDM stuff from yesterday | 14:23 |
| edmondsw | that was OOT? | 14:24 |
| edmondsw | I thought that was part of the IT vSCSI work | 14:24 |
| esberglu | Well I'm assuming the same errors I was hitting IT will hit OOT, but don't have an OOT stack right now to confirm | 14:24 |
| edmondsw | oh, sure | 14:24 |
| esberglu | The plan from yesterday was to confirm that it hits OOT as well, and remove if it's not needed there either | 14:25 |
| esberglu | I'm not sure if it's needed for live migration or something | 14:26 |
| edmondsw | yep, absolutely | 14:26 |
| edmondsw | all changes that we've made in the IT patches should be worked back to OOT | 14:26 |
| edmondsw | for OVS and SEA as well as vSCSI | 14:26 |
| esberglu | Yep | 14:27 |
| edmondsw | I'll fix the tests for that bdm cleanup patch I threw up yesterday... should have that up again in a few min | 14:27 |
| edmondsw | I'm not thinking of anything else OOT of the top of my head | 14:28 |
| esberglu | I'll put together a list on the etherpad | 14:28 |
| esberglu | #topic Device Passthrough | 14:29 |
| *** openstack changes topic to "Device Passthrough (Meeting topic: powervm_driver_meeting)" | 14:29 | |
| esberglu | efried: Anything to discuss here? | 14:30 |
| efried | I can summarize the current status of the work in nova if you like, but in general we've just got quite a lot of work to squeeze in before feature freeze. I'm heads down on that. | 14:31 |
| * efried apparently has multiple heads | 14:32 | |
| *** tjakobs has joined #openstack-powervm | 14:32 | |
| edmondsw | just don't start talking to yourself :) | 14:32 |
| edmondsw | we can probably skip the summary and give you time to do the work for today | 14:33 |
| efried | Whereas I wouldn't object to reviews from you guys, that's not strictly necessary; and there's really nothing else y'all can do to help without significant ramp-up. | 14:33 |
| edmondsw | esberglu there was also a summary on the ML a couple days ago | 14:33 |
| edmondsw | yep | 14:33 |
| efried | Though edmondsw and charles may want to review the report client stuff out of interest since you're going to be working up similar code for pvc | 14:33 |
| edmondsw | efried link? | 14:33 |
| efried | Series starting at https://review.openstack.org/#/c/521685/ | 14:34 |
| edmondsw | tx | 14:34 |
| efried | Goal this week will be to clear some of those WIPs at the top | 14:35 |
| efried | (and get those bottom ones merged - that's on cores now) | 14:35 |
| efried | looks like the bottom two are in the gate, cool. | 14:36 |
| efried | Nothing else from me. | 14:36 |
| efried | [looks like the bottom two are in the gate, cool.] <== so edmondsw don't -1 them! | 14:36 |
| edmondsw | lol... sure | 14:36 |
| esberglu | Alright sounds like we can move on | 14:37 |
| esberglu | #topic PowerVM CI | 14:37 |
| *** openstack changes topic to "PowerVM CI (Meeting topic: powervm_driver_meeting)" | 14:37 | |
| esberglu | Not much to talk about here other than the issue already mentioned | 14:38 |
| edmondsw | ping me when you figure that one out? | 14:38 |
| esberglu | edmondsw: ok | 14:38 |
| edmondsw | I don't have anything else | 14:39 |
| esberglu | After feature freeze I'd like to be heads down on CI for a bit | 14:39 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-powervm master: cleanup private bdm methods https://review.openstack.org/531874 | 14:39 |
| esberglu | I want to upgrade the undercloud to pike, update all of the management services | 14:39 |
| esberglu | And have a ton of other small changes/cleanup to do | 14:40 |
| edmondsw | ok, tx for the heads up... I think we can afford that after ff | 14:40 |
| *** gman-tx has quit IRC | 14:41 | |
| esberglu | Oh and get depends-on working | 14:41 |
| efried | meh, low priority | 14:41 |
| esberglu | #topic Open Discussion | 14:41 |
| *** openstack changes topic to "Open Discussion (Meeting topic: powervm_driver_meeting)" | 14:41 | |
| esberglu | Nothing else from me | 14:42 |
| edmondsw | same | 14:42 |
| esberglu | #endmeeting | 14:44 |
| *** openstack changes topic to "This channel is for PowerVM-related development and discussion. For general OpenStack support, please use #openstack." | 14:44 | |
| openstack | Meeting ended Tue Jan 9 14:44:19 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:44 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-01-09-14.00.html | 14:44 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-01-09-14.00.txt | 14:44 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/powervm_driver_meeting/2018/powervm_driver_meeting.2018-01-09-14.00.log.html | 14:44 |
| *** gman-tx has joined #openstack-powervm | 15:10 | |
| esberglu | edmondsw: efried: I see what the problem is with the patching, not sure the best way to fix it | 15:33 |
| esberglu | Right now we merge the change being tested into whichever branch is being tested | 15:33 |
| esberglu | https://github.com/powervm/powervm-ci/blob/master/devstack/prep_devstack.sh#L135 | 15:34 |
| esberglu | Then when we try to apply the patches found in patching.conf, we search the git log for the commit and skip it if it is found | 15:34 |
| esberglu | https://github.com/powervm/powervm-ci/blob/master/devstack/prep_devstack.sh#L139-L163 | 15:34 |
| esberglu | The problem is that when we merge the initial change into master, the commit number from the changes being tested aren't in the git log | 15:34 |
| esberglu | only a commit number from the merge of those changes into the branch | 15:34 |
| esberglu | So you have whatever the last commit number is on master, and then a commit number for the merge | 15:34 |
| esberglu | We weren't hitting this last release because we weren't merging the changes into the branch | 15:35 |
| esberglu | Just checking out whatever change we were testing | 15:36 |
| esberglu | https://github.com/powervm/powervm-ci/commit/c9d2a8b | 15:36 |
| edmondsw | esberglu are you saying the same thing is being patched twice? | 15:36 |
| esberglu | So the commit chain (in this case OVS, then SEA) would be found in the git log and each patch would be skipped | 15:36 |
| edmondsw | once as the commit we're trying to test, and again because it's one of the reviews in our patch list? | 15:36 |
| esberglu | edmondsw: Yes | 15:37 |
| edmondsw | esberglu so can't you then simply add a check to our patch list processing to ignore a patch listed there if it's the one we're trying to test? | 15:37 |
| efried | you wouldn't know | 15:40 |
| esberglu | edmondsw: That would work if it's a single commit. But not for commit chains. For example if we're testing SEA we don't want to apply the OVS patch | 15:40 |
| esberglu | That's why we were checking the git log | 15:40 |
| efried | At some point we were doing it by changenumber,patchnumber, weren't we? | 15:40 |
| edmondsw | yeah | 15:40 |
| edmondsw | that "yeah" was to esberglu | 15:41 |
| efried | though I guess that doesn't help either. | 15:41 |
| efried | I would say we could do the check-if-in-the-chain based on the Change-Id | 15:41 |
| efried | But then we wouldn't be sure to get the correct commit level. | 15:41 |
| efried | (to be clear, if we had the right change at the wrong level, we should fail - resolving that automatically is a challenge that *might* be solvable, but not worth it.) | 15:42 |
| esberglu | Could we merge the other way? Merge master into the change being tested instead of the change being tested into master? | 15:43 |
| esberglu | That might retain the commit numbers in the git log | 15:43 |
| edmondsw | I don't think that would work | 15:43 |
| efried | ya know, the git log *does* have all the commit hashes, if you look at it as a tree. Not sure how to automate that, but it ought to be possible. | 15:44 |
| efried | esberglu Do you have a repo downloaded somewhere that's in this condition? (Merge commits but not original commits) | 15:44 |
| esberglu | efried: One sec, I can get one back into that state | 15:45 |
| efried | esberglu I think if you add --all to your git log command, you'll pick up the missing commits. | 15:46 |
| esberglu | efried: Cool thanks that works! | 15:54 |
| efried | noyce | 15:54 |
| esberglu | I can't believe this was working at all tbh | 15:56 |
| esberglu | https://github.com/powervm/powervm-ci/blob/master/devstack/prep_devstack.sh#L154 | 15:56 |
| esberglu | That {{ nova_chain_base_commit }} is a remnant from when this was in the ansible playbooks | 15:56 |
| esberglu | It must just not be ignoring it I guess | 15:57 |
| esberglu | efried: Do you remember why we had the { nova_chain_base_commit }}..HEAD in that git log command? It just limits how far back the git log goes? | 16:04 |
| efried | Yeah. What would the alternative be? | 16:05 |
| esberglu | efried: Do we actually need that? Just trying to decide if I should replace it somehow or rip it out | 16:05 |
| esberglu | I don't really want to be constantly updating the base commit there | 16:06 |
| efried | Well, if you don't do that, you'll get the entire git history from the beginning of time. I doubt you want that. | 16:06 |
| efried | No, we should be figuring that out dynamically. | 16:06 |
| efried | It should be e.g. origin/master | 16:06 |
| efried | mdrabe edmondsw esberglu Take a look at mdbooth's latest post to openstack-dev ML (block device features). We should see if we can make use of that. | 16:10 |
| edmondsw | efried ack | 16:11 |
| esberglu | efried: Wouldn't that also go back to the beginning of time? | 16:12 |
| efried | esberglu origin/master..HEAD will get you only the commits between origin/master and HEAD, inclusive. | 16:13 |
| *** tjakobs has quit IRC | 16:13 | |
| efried | uhm | 16:13 |
| efried | Hm, the --all seems to blow it up. | 16:14 |
| efried | Well, I can seem to use .. and --graph together to get the right set of commits. But then you'd have to parse out the ascii art, which is doable but sucky. | 16:16 |
| efried | There must be a way. RingTFM... | 16:16 |
| efried | esberglu try --no-merges | 16:20 |
| efried | (instead of --all) | 16:22 |
| esberglu | efried: Worked | 16:22 |
| esberglu | efried: Oh cool that only prints the two commits in the chain | 16:24 |
| esberglu | ovs and sea I mean | 16:25 |
| efried | nice | 16:26 |
| esberglu | efried: Thanks for the help. Change is up 6237 | 16:27 |
| efried | ack | 16:28 |
| esberglu | I'll do a full run through of the script quick on both SEA and OVS changes | 16:28 |
| efried | ++ | 16:31 |
| esberglu | edmondsw: efried: One more quick change to that patch | 16:36 |
| efried | esberglu What does that do? | 16:36 |
| esberglu | efried: Prevents a text editor from opening when doing the pull | 16:36 |
| efried | why would that happen? If the pull creates a merge commit? | 16:37 |
| efried | ...which I guess maybe it sometimes would, which is why you were having this problem with merge commits in the first place? | 16:37 |
| openstackgerrit | Merged openstack/nova-powervm master: cleanup private bdm methods https://review.openstack.org/531874 | 16:38 |
| esberglu | efried: Yeah | 16:38 |
| efried | +2 | 16:38 |
| efried | esberglu Questions for ya in -nova | 16:43 |
| efried | edmondsw maybe you know the answer offhand | 16:45 |
| *** AlexeyAbashkin has quit IRC | 17:02 | |
| *** chhavi__ has quit IRC | 17:14 | |
| edmondsw | esberglu I added some comments on vSCSI | 17:34 |
| edmondsw | still need to look at vscsi.py and the tests, but I have to run | 17:35 |
| edmondsw | will be offline this afternoon | 17:35 |
| esberglu | edmondsw: Okay tx. Will take a look after lunch | 17:36 |
| *** edmondsw has quit IRC | 17:58 | |
| *** edmondsw has joined #openstack-powervm | 18:01 | |
| *** edmondsw has quit IRC | 18:06 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 18:26 | |
| *** AlexeyAbashkin has quit IRC | 18:30 | |
| *** esberglu has quit IRC | 18:31 | |
| *** esberglu has joined #openstack-powervm | 18:31 | |
| *** apearson__ has quit IRC | 18:57 | |
| *** apearson__ has joined #openstack-powervm | 19:02 | |
| *** apearson__ has quit IRC | 19:28 | |
| *** apearson__ has joined #openstack-powervm | 20:22 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 22:00 | |
| *** AlexeyAbashkin has quit IRC | 22:05 | |
| *** gman-tx has quit IRC | 22:16 | |
| *** zerick_ has quit IRC | 22:33 | |
| *** zerick has joined #openstack-powervm | 22:34 | |
| *** zerick has quit IRC | 22:49 | |
| *** apearson__ has quit IRC | 22:59 | |
| *** chhavi__ has joined #openstack-powervm | 23:11 | |
| *** chhavi__ has quit IRC | 23:15 | |
| *** AlexeyAbashkin has joined #openstack-powervm | 23:22 | |
| *** AlexeyAbashkin has quit IRC | 23:27 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!